[JBoss JIRA] (JBIDE-14778) 'Generate deployment method' uses wrong location for option 'add empty beans.xml' when war type is selected
by Snjezana Peco (JIRA)
[ https://issues.jboss.org/browse/JBIDE-14778?page=com.atlassian.jira.plugi... ]
Snjezana Peco commented on JBIDE-14778:
---------------------------------------
The PR has been appliad to the master.
I have also added the following code:
{code}
archive.addAsManifestResource(EmptyAsset.INSTANCE, "beans.xml")
{code}
for the ResourceAdapterArchive (RAR) archive (JBIDE-14779)
Max,
please reopen the jira if you want to apply the PR to the jbosstools_4.1.x branch.
> 'Generate deployment method' uses wrong location for option 'add empty beans.xml' when war type is selected
> -----------------------------------------------------------------------------------------------------------
>
> Key: JBIDE-14778
> URL: https://issues.jboss.org/browse/JBIDE-14778
> Project: Tools (JBoss Tools)
> Issue Type: Sub-task
> Components: testing-tools
> Reporter: Aslak Knutsen
> Assignee: Snjezana Peco
> Fix For: 4.2.0.Alpha1
>
>
> Given:
> Generate Deployment Method Dialog
> When:
> * Archive type: WebArchive
> * Add an empty beans.xml file: true
> Then:
> Generated ShrinkWrap deployment should have a EmptyAsset.INSTANCE to beans.xml mapping added in the correct location.
> *Expected*
> When WebArchive:
> {code}
> archive.addAsWebInfResource(EmptyAsset.INSTNACE, "beans.xml")
> {code}
> When JavaArchive:
> {code}
> archive.addAsManifestResource(EmptyAsset.INSTNACE, "beans.xml")
> {code}
> When Enterprise Archive:
> Field _Add an empty beans.xml file_ should be disabled. No CDI on EAR level in spec.
> Actual result:
> Both JavaArchive, WebArchive, EnterpriseArchive use ManifestResource location
> {code}
> .addAsManifestResource(EmptyAsset.INSTANCE, "beans.xml");
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 7 months
[JBoss JIRA] (JBIDE-14778) 'Generate deployment method' uses wrong location for option 'add empty beans.xml' when war type is selected
by Snjezana Peco (JIRA)
[ https://issues.jboss.org/browse/JBIDE-14778?page=com.atlassian.jira.plugi... ]
Snjezana Peco updated JBIDE-14778:
----------------------------------
Fix Version/s: 4.2.0.Alpha1
(was: 4.1.x)
(was: 4.2.x)
> 'Generate deployment method' uses wrong location for option 'add empty beans.xml' when war type is selected
> -----------------------------------------------------------------------------------------------------------
>
> Key: JBIDE-14778
> URL: https://issues.jboss.org/browse/JBIDE-14778
> Project: Tools (JBoss Tools)
> Issue Type: Sub-task
> Components: testing-tools
> Reporter: Aslak Knutsen
> Assignee: Snjezana Peco
> Fix For: 4.2.0.Alpha1
>
>
> Given:
> Generate Deployment Method Dialog
> When:
> * Archive type: WebArchive
> * Add an empty beans.xml file: true
> Then:
> Generated ShrinkWrap deployment should have a EmptyAsset.INSTANCE to beans.xml mapping added in the correct location.
> *Expected*
> When WebArchive:
> {code}
> archive.addAsWebInfResource(EmptyAsset.INSTNACE, "beans.xml")
> {code}
> When JavaArchive:
> {code}
> archive.addAsManifestResource(EmptyAsset.INSTNACE, "beans.xml")
> {code}
> When Enterprise Archive:
> Field _Add an empty beans.xml file_ should be disabled. No CDI on EAR level in spec.
> Actual result:
> Both JavaArchive, WebArchive, EnterpriseArchive use ManifestResource location
> {code}
> .addAsManifestResource(EmptyAsset.INSTANCE, "beans.xml");
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 7 months
[JBoss JIRA] (JBIDE-14530) Support 'Arquillian Cruiser' in standard 'Outline' view
by Snjezana Peco (JIRA)
[ https://issues.jboss.org/browse/JBIDE-14530?page=com.atlassian.jira.plugi... ]
Snjezana Peco commented on JBIDE-14530:
---------------------------------------
I suppose you mean the Java Outline view, i.e. "the normal 'Outline' view" when opening an Arqullian JUnit class in the Java Editor.
As I can see, we can't contribute any content to the outline view of an editor.
Max, Aslak,
If you mean this is an important feature, we could create a separate editor for Arquillian JUnit classes. The editor would extend the Java Editor (or CompilationUnitEditor) and implement its own outline page.
WDYT?
> Support 'Arquillian Cruiser' in standard 'Outline' view
> -------------------------------------------------------
>
> Key: JBIDE-14530
> URL: https://issues.jboss.org/browse/JBIDE-14530
> Project: Tools (JBoss Tools)
> Issue Type: Sub-task
> Components: testing-tools
> Reporter: Aslak Knutsen
> Assignee: Snjezana Peco
> Fix For: 4.1.x
>
>
> Would it be possible to extend the normal 'Outline' view to specially handle 'Deployment methods' and add the option to continue drilling down into the content of the defined archive?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 7 months
[JBoss JIRA] (JBIDE-15392) Add api in server needed for source lookup
by Snjezana Peco (JIRA)
[ https://issues.jboss.org/browse/JBIDE-15392?page=com.atlassian.jira.plugi... ]
Snjezana Peco commented on JBIDE-15392:
---------------------------------------
The classpath containers don't include all jars from a server. The source lookup plugin requires all jars.
> Add api in server needed for source lookup
> ------------------------------------------
>
> Key: JBIDE-15392
> URL: https://issues.jboss.org/browse/JBIDE-15392
> Project: Tools (JBoss Tools)
> Issue Type: Feature Request
> Components: maven, server
> Reporter: Max Rydahl Andersen
> Assignee: Snjezana Peco
>
> As uncovered in https://github.com/jbosstools/jbosstools-central/pull/128/files#L5L120 we got a problem with source lookup code always having to play catchup with server changes.
> We need to define a stable api that can be used here.
> lets outline what api is actually needed and then subjiras for the specifics.
> For me it looks like server lookup needs a few things:
> 0. know exact version of server
> 1. know the file structure of a certain server
> 2. get dir or directories that contain jar that is the "runtime"
> My guess is that #2 might just be sufficient for source code lookup.
> Any comments ?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 7 months
[JBoss JIRA] (JBIDE-15392) Add api in server needed for source lookup
by Rob Stryker (JIRA)
[ https://issues.jboss.org/browse/JBIDE-15392?page=com.atlassian.jira.plugi... ]
Rob Stryker commented on JBIDE-15392:
-------------------------------------
My only concern here is what exactly defines "directories that contain jars that are the runtime". This will need to be spec'd out. It's also possible it is not the same for all consumers.
If Snjezana did just copy the code from the classpaths plugin (as.classpaths.core) which does something very similar, I do wonder why she didn't just use that classpath container to begin with.
What are the differences exactly between the classpath containers in as.classpath.core and the one Snjezana is trying to make here?
> Add api in server needed for source lookup
> ------------------------------------------
>
> Key: JBIDE-15392
> URL: https://issues.jboss.org/browse/JBIDE-15392
> Project: Tools (JBoss Tools)
> Issue Type: Feature Request
> Components: maven, server
> Reporter: Max Rydahl Andersen
> Assignee: Snjezana Peco
>
> As uncovered in https://github.com/jbosstools/jbosstools-central/pull/128/files#L5L120 we got a problem with source lookup code always having to play catchup with server changes.
> We need to define a stable api that can be used here.
> lets outline what api is actually needed and then subjiras for the specifics.
> For me it looks like server lookup needs a few things:
> 0. know exact version of server
> 1. know the file structure of a certain server
> 2. get dir or directories that contain jar that is the "runtime"
> My guess is that #2 might just be sufficient for source code lookup.
> Any comments ?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 7 months
[JBoss JIRA] (JBIDE-15392) Add api in server needed for source lookup
by Max Rydahl Andersen (JIRA)
Max Rydahl Andersen created JBIDE-15392:
-------------------------------------------
Summary: Add api in server needed for source lookup
Key: JBIDE-15392
URL: https://issues.jboss.org/browse/JBIDE-15392
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: maven, server
Reporter: Max Rydahl Andersen
Assignee: Snjezana Peco
As uncovered in https://github.com/jbosstools/jbosstools-central/pull/128/files#L5L120 we got a problem with source lookup code always having to play catchup with server changes.
We need to define a stable api that can be used here.
lets outline what api is actually needed and then subjiras for the specifics.
For me it looks like server lookup needs a few things:
0. know exact version of server
1. know the file structure of a certain server
2. get dir or directories that contain jar that is the "runtime"
My guess is that #2 might just be sufficient for source code lookup.
Any comments ?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 7 months
[JBoss JIRA] (JBIDE-15391) Investigate having ports UI add relevant command line args to server startup
by Rob Stryker (JIRA)
Rob Stryker created JBIDE-15391:
-----------------------------------
Summary: Investigate having ports UI add relevant command line args to server startup
Key: JBIDE-15391
URL: https://issues.jboss.org/browse/JBIDE-15391
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: server
Affects Versions: 4.2.0.Alpha1
Reporter: Rob Stryker
Assignee: Rob Stryker
Fix For: 4.2.0.Alpha1
Subject seems pretty complete; forum post contains more information. Investigate how feasible it is for the editor sections to add relevant command line arguments to override standalone.xml's defaults.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 7 months