[JBoss JIRA] (JBDS-2923) Verify whether JBDS really needs PDE
by Alexey Kazakov (JIRA)
[ https://issues.jboss.org/browse/JBDS-2923?page=com.atlassian.jira.plugin.... ]
Alexey Kazakov edited comment on JBDS-2923 at 2/20/14 8:08 PM:
---------------------------------------------------------------
The following plugins depend on *pde.core*:
- org.hibernate.eclipse.mapper _(no compilation error if I remove this dependency)_
- org.jboss.ide.eclipse.archives.webtools _(no compilation error if I remove this dependency)_
- org.jboss.ide.eclipse.as.core _(no compilation error if I remove this dependency)_
*pde.ua.ui*:
- org.jboss.tools.project.examples.cheatsheet
*pde.ui*:
- org.jboss.tools.common.model.ui
- org.jboss.tools.common.text.ext
- org.jboss.tools.jsf.ui _(no compilation error if I remove this dependency)_
- org.jboss.tools.seam.ui.pages
was (Author: akazakov):
The following plugins depend on *pde.core*:
- org.hibernate.eclipse.mapper
- org.jboss.ide.eclipse.archives.webtools
- org.jboss.ide.eclipse.as.core
*pde.ua.ui*:
- org.jboss.tools.project.examples.cheatsheet
*pde.ui*:
- org.jboss.tools.common.model.ui
- org.jboss.tools.common.text.ext
- org.jboss.tools.jsf.ui
- org.jboss.tools.seam.ui.pages
> Verify whether JBDS really needs PDE
> ------------------------------------
>
> Key: JBDS-2923
> URL: https://issues.jboss.org/browse/JBDS-2923
> Project: Developer Studio (JBoss Developer Studio)
> Issue Type: Task
> Security Level: Public(Everyone can see)
> Components: build
> Reporter: Mickael Istria
> Assignee: Alexey Kazakov
> Fix For: 8.0.0.Beta1
>
>
> It looks like by default, JBDS embeds PDE and its UI contributions, which are totally off-topic.
> We should consider removing PDE. For this we need to check what depends on it first.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 2 months
[JBoss JIRA] (JBDS-2923) Verify whether JBDS really needs PDE
by Alexey Kazakov (JIRA)
[ https://issues.jboss.org/browse/JBDS-2923?page=com.atlassian.jira.plugin.... ]
Alexey Kazakov commented on JBDS-2923:
--------------------------------------
It seems that we can remove pde from *org.hibernate.eclipse.mapper*, *org.jboss.tools.jsf.ui*, *org.jboss.ide.eclipse.archives.webtools*, *org.jboss.ide.eclipse.as.core*.
It's not so easy to get rid of pde.ua.ui and pde.ui in the rest of plugins.
> Verify whether JBDS really needs PDE
> ------------------------------------
>
> Key: JBDS-2923
> URL: https://issues.jboss.org/browse/JBDS-2923
> Project: Developer Studio (JBoss Developer Studio)
> Issue Type: Task
> Security Level: Public(Everyone can see)
> Components: build
> Reporter: Mickael Istria
> Assignee: Alexey Kazakov
> Fix For: 8.0.0.Beta1
>
>
> It looks like by default, JBDS embeds PDE and its UI contributions, which are totally off-topic.
> We should consider removing PDE. For this we need to check what depends on it first.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 2 months
[JBoss JIRA] (JBDS-2923) Verify whether JBDS really needs PDE
by Alexey Kazakov (JIRA)
[ https://issues.jboss.org/browse/JBDS-2923?page=com.atlassian.jira.plugin.... ]
Alexey Kazakov edited comment on JBDS-2923 at 2/20/14 7:45 PM:
---------------------------------------------------------------
The following plugins depend on *pde.core*:
- org.hibernate.eclipse.mapper
- org.jboss.ide.eclipse.archives.webtools
- org.jboss.ide.eclipse.as.core
*pde.ua.ui*:
- org.jboss.tools.project.examples.cheatsheet
*pde.ui*:
- org.jboss.tools.common.model.ui
- org.jboss.tools.common.text.ext
- org.jboss.tools.jsf.ui
- org.jboss.tools.seam.ui.pages
was (Author: akazakov):
The following plugins depend on PDE:
- org.hibernate.eclipse.mapper
- org.jboss.ide.eclipse.archives.webtools
- org.jboss.ide.eclipse.as.core
- org.jboss.tools.project.examples.cheatsheet
- org.jboss.tools.common.model.ui
- org.jboss.tools.common.text.ext
- org.jboss.tools.jsf.ui
- org.jboss.tools.seam.ui.pages
And these test plugins:
- org.jboss.tools.cdi.ui.test
- org.jboss.tools.common.el.core.test
- org.jboss.tools.common.model.test
- org.jboss.tools.common.model.ui.test
- org.jboss.tools.common.text.ext.test
- org.jboss.tools.common.validation.test
- org.jboss.tools.common.verification.ui.test
- org.jboss.tools.jsf.test
- org.jboss.tools.jsf.text.ext.test
- org.jboss.tools.jsf.ui.test
- org.jboss.tools.jsf.verification.test
- org.jboss.tools.jsf.vpe.ajax4jsf.test
- org.jboss.tools.jsf.vpe.facelets.test
- org.jboss.tools.jsf.vpe.jbpm.test
- org.jboss.tools.jsf.vpe.jsf.test
- org.jboss.tools.jsf.vpe.jstl.test
- org.jboss.tools.jsf.vpe.myfaces.test
- org.jboss.tools.jsf.vpe.richfaces.test
- org.jboss.tools.jsf.vpe.seam.test
- org.jboss.tools.jst.web.kb.test
- org.jboss.tools.jst.web.test
- org.jboss.tools.jst.web.ui.test
- org.jboss.tools.runtime.seam.detector.test
- org.jboss.tools.seam.core.test
- org.jboss.tools.seam.pages.xml.test
- org.jboss.tools.seam212GA.core.test
- org.jboss.tools.seam212GA.ui.test
- org.jboss.tools.seam221GA.core.test
- org.jboss.tools.seam221GA.ui.test
- org.jboss.tools.seam230.core.test
- org.jboss.tools.seam230.ui.test
- org.jboss.tools.ws.core.test
- org.jboss.tools.ws.creation.core.test
> Verify whether JBDS really needs PDE
> ------------------------------------
>
> Key: JBDS-2923
> URL: https://issues.jboss.org/browse/JBDS-2923
> Project: Developer Studio (JBoss Developer Studio)
> Issue Type: Task
> Security Level: Public(Everyone can see)
> Components: build
> Reporter: Mickael Istria
> Assignee: Alexey Kazakov
> Fix For: 8.0.0.Beta1
>
>
> It looks like by default, JBDS embeds PDE and its UI contributions, which are totally off-topic.
> We should consider removing PDE. For this we need to check what depends on it first.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 2 months
[JBoss JIRA] (JBDS-2923) Verify whether JBDS really needs PDE
by Alexey Kazakov (JIRA)
[ https://issues.jboss.org/browse/JBDS-2923?page=com.atlassian.jira.plugin.... ]
Alexey Kazakov commented on JBDS-2923:
--------------------------------------
The following plugins depend on PDE:
- org.hibernate.eclipse.mapper
- org.jboss.ide.eclipse.archives.webtools
- org.jboss.ide.eclipse.as.core
- org.jboss.tools.project.examples.cheatsheet
- org.jboss.tools.common.model.ui
- org.jboss.tools.common.text.ext
- org.jboss.tools.jsf.ui
- org.jboss.tools.seam.ui.pages
And these test plugins:
- org.jboss.tools.cdi.ui.test
- org.jboss.tools.common.el.core.test
- org.jboss.tools.common.model.test
- org.jboss.tools.common.model.ui.test
- org.jboss.tools.common.text.ext.test
- org.jboss.tools.common.validation.test
- org.jboss.tools.common.verification.ui.test
- org.jboss.tools.jsf.test
- org.jboss.tools.jsf.text.ext.test
- org.jboss.tools.jsf.ui.test
- org.jboss.tools.jsf.verification.test
- org.jboss.tools.jsf.vpe.ajax4jsf.test
- org.jboss.tools.jsf.vpe.facelets.test
- org.jboss.tools.jsf.vpe.jbpm.test
- org.jboss.tools.jsf.vpe.jsf.test
- org.jboss.tools.jsf.vpe.jstl.test
- org.jboss.tools.jsf.vpe.myfaces.test
- org.jboss.tools.jsf.vpe.richfaces.test
- org.jboss.tools.jsf.vpe.seam.test
- org.jboss.tools.jst.web.kb.test
- org.jboss.tools.jst.web.test
- org.jboss.tools.jst.web.ui.test
- org.jboss.tools.runtime.seam.detector.test
- org.jboss.tools.seam.core.test
- org.jboss.tools.seam.pages.xml.test
- org.jboss.tools.seam212GA.core.test
- org.jboss.tools.seam212GA.ui.test
- org.jboss.tools.seam221GA.core.test
- org.jboss.tools.seam221GA.ui.test
- org.jboss.tools.seam230.core.test
- org.jboss.tools.seam230.ui.test
- org.jboss.tools.ws.core.test
- org.jboss.tools.ws.creation.core.test
> Verify whether JBDS really needs PDE
> ------------------------------------
>
> Key: JBDS-2923
> URL: https://issues.jboss.org/browse/JBDS-2923
> Project: Developer Studio (JBoss Developer Studio)
> Issue Type: Task
> Security Level: Public(Everyone can see)
> Components: build
> Reporter: Mickael Istria
> Assignee: Alexey Kazakov
> Fix For: 8.0.0.Beta1
>
>
> It looks like by default, JBDS embeds PDE and its UI contributions, which are totally off-topic.
> We should consider removing PDE. For this we need to check what depends on it first.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 2 months
[JBoss JIRA] (JBIDE-15256) Include tycho-source-feature-plugin and tycho-p2-plugin into parent/pom.xml/build/pluginManagement
by Denis Golovin (JIRA)
[ https://issues.jboss.org/browse/JBIDE-15256?page=com.atlassian.jira.plugi... ]
Denis Golovin resolved JBIDE-15256.
-----------------------------------
Resolution: Done
all PR's pushed to master branches
> Include tycho-source-feature-plugin and tycho-p2-plugin into parent/pom.xml/build/pluginManagement
> --------------------------------------------------------------------------------------------------
>
> Key: JBIDE-15256
> URL: https://issues.jboss.org/browse/JBIDE-15256
> Project: Tools (JBoss Tools)
> Issue Type: Enhancement
> Components: build
> Affects Versions: 4.2.0.Alpha1
> Reporter: Denis Golovin
> Assignee: Denis Golovin
> Fix For: 4.2.0.Beta1
>
>
> Currently every feature's pom.xml includes the same code, which is code-duplication issue.
> {code}
> <plugin>
> <groupId>org.eclipse.tycho.extras</groupId>
> <artifactId>tycho-source-feature-plugin</artifactId>
> <version>${tychoExtrasVersion}</version>
> <executions>
> <execution>
> <id>source-feature</id>
> <phase>package</phase>
> <goals>
> <goal>source-feature</goal>
> </goals>
> </execution>
> </executions>
> </plugin>
> <plugin>
> <groupId>org.eclipse.tycho</groupId>
> <artifactId>tycho-p2-plugin</artifactId>
> <version>${tychoVersion}</version>
> <executions>
> <execution>
> <id>attached-p2-metadata</id>
> <phase>package</phase>
> <goals>
> <goal>p2-metadata</goal>
> </goals>
> </execution>
> </executions>
> </plugin>{code}
> It should be included into pluginManagement section of parent/pom.xml instead and that would reduce code duplication to
> {code}<plugin>
> <groupId>org.eclipse.tycho.extras</groupId>
> <artifactId>tycho-source-feature-plugin</artifactId>
> </plugin>
> <plugin>
> <groupId>org.eclipse.tycho</groupId>
> <artifactId>tycho-p2-plugin</artifactId>
> </plugin>{code}
> in every feture's pom.xml file.
> More over code above could be moved to to features/pom.xml as
> {code}<build>
> <plugins>
> <plugin>
> <groupId>org.eclipse.tycho.extras</groupId>
> <artifactId>tycho-source-feature-plugin</artifactId>
> </plugin>
> <plugin>
> <groupId>org.eclipse.tycho</groupId>
> <artifactId>tycho-p2-plugin</artifactId>
> </plugin>
> </plugins>
> </build>{code}
> that would let keep pom.xml for every feature even cleaner.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 2 months
[JBoss JIRA] (JBIDE-15256) Include tycho-source-feature-plugin and tycho-p2-plugin into parent/pom.xml/build/pluginManagement
by Denis Golovin (JIRA)
[ https://issues.jboss.org/browse/JBIDE-15256?page=com.atlassian.jira.plugi... ]
Denis Golovin updated JBIDE-15256:
----------------------------------
Git Pull Request: https://github.com/jbosstools/jbosstools-build/pull/107, https://github.com/jbosstools/jbosstools-aerogear/pull/27, https://github.com/jbosstools/jbosstools-arquillian/pull/57, https://github.com/jbosstools/jbosstools-central/pull/214, https://github.com/jbosstools/jbosstools-birt/pull/19, https://github.com/jbosstools/jbosstools-forge/pull/71, https://github.com/jbosstools/jbosstools-freemarker/pull/15, https://github.com/jbosstools/jbosstools-hibernate/pull/37, https://github.com/jbosstools/jbosstools-javaee/pull/201, https://github.com/jbosstools/jbosstools-jst/pull/272, https://github.com/jbosstools/jbosstools-livereload/pull/75, https://github.com/jbosstools/jbosstools-openshift/pull/363, https://github.com/jbosstools/jbosstools-portlet/pull/27, https://github.com/jbosstools/jbosstools-vpe/pull/218, https://github.com/jbosstools/jbosstools-webservices/pull/119 (was: https://github.com/jbosstools/jbosstools-build/pull/107, https://github.com/jbosstools/jbosstools-base/pull/170)
> Include tycho-source-feature-plugin and tycho-p2-plugin into parent/pom.xml/build/pluginManagement
> --------------------------------------------------------------------------------------------------
>
> Key: JBIDE-15256
> URL: https://issues.jboss.org/browse/JBIDE-15256
> Project: Tools (JBoss Tools)
> Issue Type: Enhancement
> Components: build
> Affects Versions: 4.2.0.Alpha1
> Reporter: Denis Golovin
> Assignee: Denis Golovin
> Fix For: 4.2.0.Beta1
>
>
> Currently every feature's pom.xml includes the same code, which is code-duplication issue.
> {code}
> <plugin>
> <groupId>org.eclipse.tycho.extras</groupId>
> <artifactId>tycho-source-feature-plugin</artifactId>
> <version>${tychoExtrasVersion}</version>
> <executions>
> <execution>
> <id>source-feature</id>
> <phase>package</phase>
> <goals>
> <goal>source-feature</goal>
> </goals>
> </execution>
> </executions>
> </plugin>
> <plugin>
> <groupId>org.eclipse.tycho</groupId>
> <artifactId>tycho-p2-plugin</artifactId>
> <version>${tychoVersion}</version>
> <executions>
> <execution>
> <id>attached-p2-metadata</id>
> <phase>package</phase>
> <goals>
> <goal>p2-metadata</goal>
> </goals>
> </execution>
> </executions>
> </plugin>{code}
> It should be included into pluginManagement section of parent/pom.xml instead and that would reduce code duplication to
> {code}<plugin>
> <groupId>org.eclipse.tycho.extras</groupId>
> <artifactId>tycho-source-feature-plugin</artifactId>
> </plugin>
> <plugin>
> <groupId>org.eclipse.tycho</groupId>
> <artifactId>tycho-p2-plugin</artifactId>
> </plugin>{code}
> in every feture's pom.xml file.
> More over code above could be moved to to features/pom.xml as
> {code}<build>
> <plugins>
> <plugin>
> <groupId>org.eclipse.tycho.extras</groupId>
> <artifactId>tycho-source-feature-plugin</artifactId>
> </plugin>
> <plugin>
> <groupId>org.eclipse.tycho</groupId>
> <artifactId>tycho-p2-plugin</artifactId>
> </plugin>
> </plugins>
> </build>{code}
> that would let keep pom.xml for every feature even cleaner.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 2 months
[JBoss JIRA] (JBIDE-16633) The quick fix for unknown attributes is not available if "Ignore specified attribute names" validation preference is unchecked
by Alexey Kazakov (JIRA)
[ https://issues.jboss.org/browse/JBIDE-16633?page=com.atlassian.jira.plugi... ]
Alexey Kazakov updated JBIDE-16633:
-----------------------------------
Fix Version/s: 4.2.0.Beta1
> The quick fix for unknown attributes is not available if "Ignore specified attribute names" validation preference is unchecked
> ------------------------------------------------------------------------------------------------------------------------------
>
> Key: JBIDE-16633
> URL: https://issues.jboss.org/browse/JBIDE-16633
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: jsp/jsf/xml/html source editing, upstream
> Affects Versions: 4.1.2.CR1
> Reporter: Victor Rubezhny
> Assignee: Victor Rubezhny
> Fix For: 4.1.2.CR1, 4.2.0.Beta1
>
>
> 1. Create a project
> 2. Create the following html file:
> {code}
> <!doctype html>
> <html ng-app>
> </html>
> {code}
> 3. Open the file with JBoss Tools HTML Editor
> 4. Assert: There is a problem "Undefined attribute name" for ng-app
> 5. Assert: Move the mouse over the problem and you see two quick fixes:
> - Ignore ng-app attribute
> - Ignore all ng-* attributes
> 6. Go to Preference->Web->Validation->
> 7. Check "Ignore specified attribute names"
> 8. Add "ng-app,ng-*" pattern
> 9. Uncheck "Ignore specified attribute names". Click OK.
> 10. Assert: There is still a problem "Undefined attribute name" for ng-app
> 11. Failure: Move the mouse over the problem but there are not quick fixes any more.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 2 months
[JBoss JIRA] (JBIDE-16633) The quick fix for unknown attributes is not available if "Ignore specified attribute names" validation preference is unchecked
by Alexey Kazakov (JIRA)
[ https://issues.jboss.org/browse/JBIDE-16633?page=com.atlassian.jira.plugi... ]
Alexey Kazakov updated JBIDE-16633:
-----------------------------------
Fix Version/s: (was: 4.2.0.Beta1)
> The quick fix for unknown attributes is not available if "Ignore specified attribute names" validation preference is unchecked
> ------------------------------------------------------------------------------------------------------------------------------
>
> Key: JBIDE-16633
> URL: https://issues.jboss.org/browse/JBIDE-16633
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: jsp/jsf/xml/html source editing, upstream
> Affects Versions: 4.1.2.CR1
> Reporter: Victor Rubezhny
> Assignee: Victor Rubezhny
> Fix For: 4.1.2.CR1
>
>
> 1. Create a project
> 2. Create the following html file:
> {code}
> <!doctype html>
> <html ng-app>
> </html>
> {code}
> 3. Open the file with JBoss Tools HTML Editor
> 4. Assert: There is a problem "Undefined attribute name" for ng-app
> 5. Assert: Move the mouse over the problem and you see two quick fixes:
> - Ignore ng-app attribute
> - Ignore all ng-* attributes
> 6. Go to Preference->Web->Validation->
> 7. Check "Ignore specified attribute names"
> 8. Add "ng-app,ng-*" pattern
> 9. Uncheck "Ignore specified attribute names". Click OK.
> 10. Assert: There is still a problem "Undefined attribute name" for ng-app
> 11. Failure: Move the mouse over the problem but there are not quick fixes any more.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 2 months