[JBoss JIRA] (JBIDE-15256) Include tycho-source-feature-plugin and tycho-p2-plugin into parent/pom.xml/build/pluginManagement
by Denis Golovin (JIRA)
[ https://issues.jboss.org/browse/JBIDE-15256?page=com.atlassian.jira.plugi... ]
Denis Golovin commented on JBIDE-15256:
---------------------------------------
PR for base pushed to master
> Include tycho-source-feature-plugin and tycho-p2-plugin into parent/pom.xml/build/pluginManagement
> --------------------------------------------------------------------------------------------------
>
> Key: JBIDE-15256
> URL: https://issues.jboss.org/browse/JBIDE-15256
> Project: Tools (JBoss Tools)
> Issue Type: Enhancement
> Components: build
> Affects Versions: 4.2.0.Alpha1
> Reporter: Denis Golovin
> Assignee: Denis Golovin
> Fix For: 4.2.0.Beta1
>
>
> Currently every feature's pom.xml includes the same code, which is code-duplication issue.
> {code}
> <plugin>
> <groupId>org.eclipse.tycho.extras</groupId>
> <artifactId>tycho-source-feature-plugin</artifactId>
> <version>${tychoExtrasVersion}</version>
> <executions>
> <execution>
> <id>source-feature</id>
> <phase>package</phase>
> <goals>
> <goal>source-feature</goal>
> </goals>
> </execution>
> </executions>
> </plugin>
> <plugin>
> <groupId>org.eclipse.tycho</groupId>
> <artifactId>tycho-p2-plugin</artifactId>
> <version>${tychoVersion}</version>
> <executions>
> <execution>
> <id>attached-p2-metadata</id>
> <phase>package</phase>
> <goals>
> <goal>p2-metadata</goal>
> </goals>
> </execution>
> </executions>
> </plugin>{code}
> It should be included into pluginManagement section of parent/pom.xml instead and that would reduce code duplication to
> {code}<plugin>
> <groupId>org.eclipse.tycho.extras</groupId>
> <artifactId>tycho-source-feature-plugin</artifactId>
> </plugin>
> <plugin>
> <groupId>org.eclipse.tycho</groupId>
> <artifactId>tycho-p2-plugin</artifactId>
> </plugin>{code}
> in every feture's pom.xml file.
> More over code above could be moved to to features/pom.xml as
> {code}<build>
> <plugins>
> <plugin>
> <groupId>org.eclipse.tycho.extras</groupId>
> <artifactId>tycho-source-feature-plugin</artifactId>
> </plugin>
> <plugin>
> <groupId>org.eclipse.tycho</groupId>
> <artifactId>tycho-p2-plugin</artifactId>
> </plugin>
> </plugins>
> </build>{code}
> that would let keep pom.xml for every feature even cleaner.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 2 months
[JBoss JIRA] (JBIDE-16621) The quick fix for unknown attributes is not available if "Ignore specified attribute names" validation preference is unchecked
by Victor Rubezhny (JIRA)
[ https://issues.jboss.org/browse/JBIDE-16621?page=com.atlassian.jira.plugi... ]
Victor Rubezhny edited comment on JBIDE-16621 at 2/20/14 1:32 PM:
------------------------------------------------------------------
Currently we have 2 BugZIllas regarding these quickfixes. One of them is marked as 'regression'. I did reported (actually just told on them) on the last WTP Development Status Meeting. Will do the same today, probably.
Not sure if we should mark both issues as a hot. They aren't blockers (at least the one related to this certain issue) from WTP's point of view.
But I'll be glad to here & see '+1' votes from anyone on these issues. Sometimes it's good to push on WTP guys.
The mentioned issues are:
* [Bug #427565 - QuickFix for HTML5 attribute validator annotations is shown for non-HTML5 documents|https://bugs.eclipse.org/bugs/show_bug.cgi?id=427565]
* [Bug #428013 - \[regression\] Web->HTML Files->Validation preference page doesn't saves the new severity values|https://bugs.eclipse.org/bugs/show_bug.cgi?id=428013]
See:
* [WTP Development Status Meeting 2014-02-20|https://wiki.eclipse.org/WTP_2014-02-20#Any_others.3F]
* [WTP Development Status Meeting 2014-02-13|https://wiki.eclipse.org/WTP_2014-02-13#Any_others.3F]
was (Author: vrubezhny):
Currently we have 2 BugZIllas regarding these quickfixes. One of them is marked as 'regression'. I did reported (actually just told on them) on the last WTP Development Status Meeting. Will do the same today, probably.
Not sure if we should mark both issues as a hot. They aren't blockers (at least the one related to this certain issue) from WTP's point of view.
But I'll be glad to here & see '+1' votes from anyone on these issues. Sometimes it's good to push on WTP guys.
The mentioned issues are:
* [Bug #427565 - QuickFix for HTML5 attribute validator annotations is shown for non-HTML5 documents|https://bugs.eclipse.org/bugs/show_bug.cgi?id=427565]
* [Bug #428013 - \[regression\] Web->HTML Files->Validation preference page doesn't saves the new severity values|https://bugs.eclipse.org/bugs/show_bug.cgi?id=428013]
> The quick fix for unknown attributes is not available if "Ignore specified attribute names" validation preference is unchecked
> ------------------------------------------------------------------------------------------------------------------------------
>
> Key: JBIDE-16621
> URL: https://issues.jboss.org/browse/JBIDE-16621
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: jsp/jsf/xml/html source editing, upstream
> Affects Versions: 4.2.0.Beta1
> Reporter: Alexey Kazakov
> Assignee: Victor Rubezhny
> Fix For: 4.2.0.Beta1
>
>
> 1. Create a project
> 2. Create the following html file:
> {code}
> <!doctype html>
> <html ng-app>
> </html>
> {code}
> 3. Open the file with JBoss Tools HTML Editor
> 4. Assert: There is a problem "Undefined attribute name" for ng-app
> 5. Assert: Move the mouse over the problem and you see two quick fixes:
> - Ignore ng-app attribute
> - Ignore all ng-* attributes
> 6. Go to Preference->Web->Validation->
> 7. Check "Ignore specified attribute names"
> 8. Add "ng-app,ng-*" pattern
> 9. Uncheck "Ignore specified attribute names". Click OK.
> 10. Assert: There is still a problem "Undefined attribute name" for ng-app
> 11. Failure: Move the mouse over the problem but there are not quick fixes any more.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 2 months
[JBoss JIRA] (JBIDE-16621) The quick fix for unknown attributes is not available if "Ignore specified attribute names" validation preference is unchecked
by Victor Rubezhny (JIRA)
[ https://issues.jboss.org/browse/JBIDE-16621?page=com.atlassian.jira.plugi... ]
Victor Rubezhny commented on JBIDE-16621:
-----------------------------------------
[~akazakov] Should I fix the same issue for 4.1.2?
> The quick fix for unknown attributes is not available if "Ignore specified attribute names" validation preference is unchecked
> ------------------------------------------------------------------------------------------------------------------------------
>
> Key: JBIDE-16621
> URL: https://issues.jboss.org/browse/JBIDE-16621
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: jsp/jsf/xml/html source editing, upstream
> Affects Versions: 4.2.0.Beta1
> Reporter: Alexey Kazakov
> Assignee: Victor Rubezhny
> Fix For: 4.2.0.Beta1
>
>
> 1. Create a project
> 2. Create the following html file:
> {code}
> <!doctype html>
> <html ng-app>
> </html>
> {code}
> 3. Open the file with JBoss Tools HTML Editor
> 4. Assert: There is a problem "Undefined attribute name" for ng-app
> 5. Assert: Move the mouse over the problem and you see two quick fixes:
> - Ignore ng-app attribute
> - Ignore all ng-* attributes
> 6. Go to Preference->Web->Validation->
> 7. Check "Ignore specified attribute names"
> 8. Add "ng-app,ng-*" pattern
> 9. Uncheck "Ignore specified attribute names". Click OK.
> 10. Assert: There is still a problem "Undefined attribute name" for ng-app
> 11. Failure: Move the mouse over the problem but there are not quick fixes any more.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 2 months
[JBoss JIRA] (JBIDE-9631) VPE Context menu for editing actions Cut and Paste have wrong shortcuts on Mac Os
by Konstantin Marmalyukov (JIRA)
[ https://issues.jboss.org/browse/JBIDE-9631?page=com.atlassian.jira.plugin... ]
Konstantin Marmalyukov resolved JBIDE-9631.
-------------------------------------------
Fix Version/s: 4.2.0.Alpha2
(was: LATER)
Resolution: Done
resolved since upstream issue is resolved
> VPE Context menu for editing actions Cut and Paste have wrong shortcuts on Mac Os
> ---------------------------------------------------------------------------------
>
> Key: JBIDE-9631
> URL: https://issues.jboss.org/browse/JBIDE-9631
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: upstream, visual-page-editor-core
> Affects Versions: 3.3.0.M3
> Environment: Mac Os 10.6
> Reporter: Vlado Pakan
> Assignee: Konstantin Marmalyukov
> Fix For: 4.2.0.Alpha2
>
> Attachments: menubarmenu.png, sourcepanemenu.png, visualpanemenu.png, wtpContextMenuFromSource.png, wtpContextMenuFromVisual.png, wtpEditMenu.png
>
>
> VPE Context menus "Cut" and "Paste" have wrong shortcut Ctrl-X and Ctrl-V instead of Command+X and Command+V on Mac Os. This error is in both context menus either for source pane and for visual pane. Menus are correctly labeled in Menu Bar "Edit" menu.
> See attached screenshots.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 2 months
[JBoss JIRA] (JBIDE-16621) The quick fix for unknown attributes is not available if "Ignore specified attribute names" validation preference is unchecked
by Victor Rubezhny (JIRA)
[ https://issues.jboss.org/browse/JBIDE-16621?page=com.atlassian.jira.plugi... ]
Victor Rubezhny commented on JBIDE-16621:
-----------------------------------------
Currently we have 2 BugZIllas regarding these quickfixes. One of them is marked as 'regression'. I did reported (actually just told on them) on the last WTP Development Status Meeting. Will do the same today, probably.
Not sure if we should mark both issues as a hot. They aren't blockers (at least the one related to this certain issue) from WTP's point of view.
But I'll be glad to here & see '+1' votes from anyone on these issues. Sometimes it's good to push on WTP guys.
The mentioned issues are:
* [Bug #427565 - QuickFix for HTML5 attribute validator annotations is shown for non-HTML5 documents|https://bugs.eclipse.org/bugs/show_bug.cgi?id=427565]
* [Bug #428013 - \[regression\] Web->HTML Files->Validation preference page doesn't saves the new severity values|https://bugs.eclipse.org/bugs/show_bug.cgi?id=428013]
> The quick fix for unknown attributes is not available if "Ignore specified attribute names" validation preference is unchecked
> ------------------------------------------------------------------------------------------------------------------------------
>
> Key: JBIDE-16621
> URL: https://issues.jboss.org/browse/JBIDE-16621
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: jsp/jsf/xml/html source editing, upstream
> Affects Versions: 4.2.0.Beta1
> Reporter: Alexey Kazakov
> Assignee: Victor Rubezhny
> Fix For: 4.2.0.Beta1
>
>
> 1. Create a project
> 2. Create the following html file:
> {code}
> <!doctype html>
> <html ng-app>
> </html>
> {code}
> 3. Open the file with JBoss Tools HTML Editor
> 4. Assert: There is a problem "Undefined attribute name" for ng-app
> 5. Assert: Move the mouse over the problem and you see two quick fixes:
> - Ignore ng-app attribute
> - Ignore all ng-* attributes
> 6. Go to Preference->Web->Validation->
> 7. Check "Ignore specified attribute names"
> 8. Add "ng-app,ng-*" pattern
> 9. Uncheck "Ignore specified attribute names". Click OK.
> 10. Assert: There is still a problem "Undefined attribute name" for ng-app
> 11. Failure: Move the mouse over the problem but there are not quick fixes any more.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 2 months
[JBoss JIRA] (JBIDE-16621) The quick fix for unknown attributes is not available if "Ignore specified attribute names" validation preference is unchecked
by Denis Golovin (JIRA)
[ https://issues.jboss.org/browse/JBIDE-16621?page=com.atlassian.jira.plugi... ]
Denis Golovin commented on JBIDE-16621:
---------------------------------------
Should we mark this bugzilla issue as hot? It seems to be usual to have unknown attributes in html5 documents.
> The quick fix for unknown attributes is not available if "Ignore specified attribute names" validation preference is unchecked
> ------------------------------------------------------------------------------------------------------------------------------
>
> Key: JBIDE-16621
> URL: https://issues.jboss.org/browse/JBIDE-16621
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: jsp/jsf/xml/html source editing, upstream
> Affects Versions: 4.2.0.Beta1
> Reporter: Alexey Kazakov
> Assignee: Victor Rubezhny
> Fix For: 4.2.0.Beta1
>
>
> 1. Create a project
> 2. Create the following html file:
> {code}
> <!doctype html>
> <html ng-app>
> </html>
> {code}
> 3. Open the file with JBoss Tools HTML Editor
> 4. Assert: There is a problem "Undefined attribute name" for ng-app
> 5. Assert: Move the mouse over the problem and you see two quick fixes:
> - Ignore ng-app attribute
> - Ignore all ng-* attributes
> 6. Go to Preference->Web->Validation->
> 7. Check "Ignore specified attribute names"
> 8. Add "ng-app,ng-*" pattern
> 9. Uncheck "Ignore specified attribute names". Click OK.
> 10. Assert: There is still a problem "Undefined attribute name" for ng-app
> 11. Failure: Move the mouse over the problem but there are not quick fixes any more.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 2 months
[JBoss JIRA] (JBIDE-16621) The quick fix for unknown attributes is not available if "Ignore specified attribute names" validation preference is unchecked
by Denis Golovin (JIRA)
[ https://issues.jboss.org/browse/JBIDE-16621?page=com.atlassian.jira.plugi... ]
Denis Golovin edited comment on JBIDE-16621 at 2/20/14 1:03 PM:
----------------------------------------------------------------
Should we mark this bugzilla issue as hot and try to include it in next M build?
was (Author: dgolovin):
Should we mark this bugzilla issue as hot? It seems to be usual to have unknown attributes in html5 documents.
> The quick fix for unknown attributes is not available if "Ignore specified attribute names" validation preference is unchecked
> ------------------------------------------------------------------------------------------------------------------------------
>
> Key: JBIDE-16621
> URL: https://issues.jboss.org/browse/JBIDE-16621
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: jsp/jsf/xml/html source editing, upstream
> Affects Versions: 4.2.0.Beta1
> Reporter: Alexey Kazakov
> Assignee: Victor Rubezhny
> Fix For: 4.2.0.Beta1
>
>
> 1. Create a project
> 2. Create the following html file:
> {code}
> <!doctype html>
> <html ng-app>
> </html>
> {code}
> 3. Open the file with JBoss Tools HTML Editor
> 4. Assert: There is a problem "Undefined attribute name" for ng-app
> 5. Assert: Move the mouse over the problem and you see two quick fixes:
> - Ignore ng-app attribute
> - Ignore all ng-* attributes
> 6. Go to Preference->Web->Validation->
> 7. Check "Ignore specified attribute names"
> 8. Add "ng-app,ng-*" pattern
> 9. Uncheck "Ignore specified attribute names". Click OK.
> 10. Assert: There is still a problem "Undefined attribute name" for ng-app
> 11. Failure: Move the mouse over the problem but there are not quick fixes any more.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 2 months
[JBoss JIRA] (JBIDE-9494) VPE has wrong transformation for HTML codes to display special characters in page
by Konstantin Marmalyukov (JIRA)
[ https://issues.jboss.org/browse/JBIDE-9494?page=com.atlassian.jira.plugin... ]
Konstantin Marmalyukov resolved JBIDE-9494.
-------------------------------------------
Fix Version/s: 4.2.0.Beta1
(was: LATER)
Resolution: Done
resolved because upstream issue is fixed
> VPE has wrong transformation for HTML codes to display special characters in page
> ---------------------------------------------------------------------------------
>
> Key: JBIDE-9494
> URL: https://issues.jboss.org/browse/JBIDE-9494
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: upstream, visual-page-editor-core
> Affects Versions: 3.3.0.M3
> Reporter: Vitali Yemialyanchyk
> Assignee: Konstantin Marmalyukov
> Fix For: 4.2.0.Beta1
>
> Attachments: cannot-reproduce-screenshot.png, quote.tagx
>
>
> take a look at screenshot-1 below
> !https://issues.jboss.org/secure/attachment/12345926/screenshot-1.jpg!
> take a look at string:
> {noformat}
> & & ' ' ' ' '"
> {noformat}
> Add a space character after '&' and remove it.
> Than take a look how vpe render this string:
> {noformat}
> & & ' ' ' ' '
> {noformat}
> i.e. in some case vpe displays &#039; instead of expected '
> *Related bugzilla bug:* https://bugs.eclipse.org/bugs/show_bug.cgi?id=357677
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 2 months