[JBoss JIRA] (JBIDE-18010) For JBIDE 4.2.0.CR1: Ensure copyrights and provider names are correct in all plugins and features
by Nick Boldt (JIRA)
[ https://issues.jboss.org/browse/JBIDE-18010?page=com.atlassian.jira.plugi... ]
Nick Boldt commented on JBIDE-18010:
------------------------------------
An idea from [~rob.stryker], for being explicit w/ our contributor attribution in files:
{code}
/*******************************************************************************
* Copyright (c) 2008-2009 Red Hat, Inc.
* Distributed under license by Red Hat, Inc. All rights reserved.
* This program is made available under the terms of the
* Eclipse Public License v1.0 which accompanies this distribution,
* and is available at http://www.eclipse.org/legal/epl-v10.html
*
* Contributors:
* Rob Stryker - Initial Implementation
* Rob Stryker - JBIDE-3156, JBDS-485, JBIDE-3638 and others
* Snjezana Peco - JBIDE-3572
*
*
******************************************************************************/
{code}
> For JBIDE 4.2.0.CR1: Ensure copyrights and provider names are correct in all plugins and features
> -------------------------------------------------------------------------------------------------
>
> Key: JBIDE-18010
> URL: https://issues.jboss.org/browse/JBIDE-18010
> Project: Tools (JBoss Tools)
> Issue Type: Task
> Components: build
> Reporter: Nick Boldt
> Assignee: Max Rydahl Andersen
> Priority: Blocker
> Labels: task
> Fix For: 4.2.0.CR1
>
>
> For JBIDE 4.2.0.CR1: Please perform the following *2* tasks:
> 1. Verify that all your plugin and feature copyright dates end in 2014, and that the copyright holder is *{color:red}Red Hat, Inc.{color}* or a variation similar to the examples below.
> Be sure to also include *translated* files, where they exist.
> *java files*
> {code:title=*.java}
> Copyright (c) 2010-2014 Red Hat, Inc. and others.
> {code}
> *html files*
> {code:title=about.html}
> © 2014 Red Hat, Inc. All rights reserved
> {code}
> *properties files*
> {code:title=about.properties}
> Copyright (c) Red Hat, Inc., contributors and others 2004 - 2014. All rights reserved
> {code}
> {code:title=about_fr.properties}
> Copyright (c) Red Hat, Inc., contributors and others 2004 - 2014. Tous droits r\u00E9serv\u00E9s.
> {code}
> {code:title=feature.properties}
> Copyright (c) 2010-2014 Red Hat, Inc. and others.
> {code}
> {code:title=Messages.properties}
> # Copyright (c) 2014 Red Hat, Inc. and others.
> {code}
> *xsd files*
> {code:title=jboss-as-naming_1_3.xsd}
> Copyright 2014, Red Hat, Inc., and individual contributors
> {code}
> 2. Verify that all your plugin and feature provider names are *{color:red}JBoss by Red Hat{color}*.
> Be sure to also include *translated* files, where they exist.
> *This step is particularly important for new plugins and features that have been added recently.*
> Depending on how your plugin is configured you should see something like this in your *plugin.properties* files:
> {code}BundleName = JMX Resources Bundle
> BundleProvider = JBoss by Red Hat{code}
> or
> {code}Bundle-Name.0 = JBossTools Archives Core Plugin
> Bundle-Vendor.0 = JBoss by Red Hat{code}
> Then in your MANIFEST.MF files, you will reference these variables like this.
> *Bundle-Localization* is required or your plugin won't see the values in your *plugin.properties* file!
> {code}Bundle-Localization: plugin
> Bundle-Name: %BundleName
> Bundle-Vendor: %BundleProvider{code}
> or
> {code}Bundle-Localization: plugin
> Bundle-Name: %Bundle-Name.0
> Bundle-Vendor: %Bundle-Vendor.0{code}
> For features, check that your *feature.properties* file contains good values too:
> {code}featureName=JMX Console
> featureProvider=JBoss by Red Hat{code}
> or
> {code}featureName=JBoss Archives Tools
> providerName=JBoss by Red Hat{code}
> Then in your feature.xml files, you will reference these variables like this:
> {code}<feature label="%featureName" provider-name="%featureProvider" ...>{code}
> or
> {code}<feature label="%featureName" provider-name="%providerName" ...>{code}
> 3. If you would like QE to review your changes, please *Resolve* this JIRA when done.
> 4. If you do not require QE to review your changes, please *Close* this JIRA when done.
> 5. If you have any questions, please contact [~nickboldt].
> [Search for all task JIRA|https://issues.jboss.org/issues/?jql=%28%28project+in+%28JBDS%29+and...]
> See also: JBDS-3114
--
This message was sent by Atlassian JIRA
(v6.2.6#6264)
11 years, 10 months
[JBoss JIRA] (JBIDE-18053) Add Powermock to the target platform
by Mickael Istria (JIRA)
[ https://issues.jboss.org/browse/JBIDE-18053?page=com.atlassian.jira.plugi... ]
Mickael Istria edited comment on JBIDE-18053 at 8/20/14 12:45 PM:
------------------------------------------------------------------
* Since the version of Mockito on Locus doesn't set version on packages, and Powermock uses versions in its import-packages. It's not possible to use Mockito from Locus.
* Since Powermock depends on org.mockito.internal.verification and Orbit doesn't export this package, it's not possible to use Mockito from Orbit.
So only Mockito from Powermock works.
was (Author: mickael_istria):
Since the version of Mockito on Locus doesn't set version on packages, and Powermock uses versions in its import-packages. It's not possible to use Mockito from Locus.
However, Mockito from Powermock repo or Orbit are compatible.
> Add Powermock to the target platform
> ------------------------------------
>
> Key: JBIDE-18053
> URL: https://issues.jboss.org/browse/JBIDE-18053
> Project: Tools (JBoss Tools)
> Issue Type: Feature Request
> Components: build
> Affects Versions: 4.2.x
> Reporter: Jeff Cantrill
> Assignee: Nick Boldt
> Fix For: 4.2.0.CR1
>
>
> *Reason:* To improving testing by allowing the stubbing of scenerios like "new File(path).exists()" which require bytecode modifications in order to accomplish. Example of intended use: https://gist.github.com/jcantrill/fd83c27d3fc542742ec7
> *License and owner:* Apache 2.0 / https://github.com/jayway
> *Original p2 repo:* http://powermock-osgi.googlecode.com/svn/updateSite/1.5.4.1/
> *JBoss mirror:* http://download.jboss.org/jbosstools/updates/requirements/powermock/1.5.4.1/
> *Sources:* https://code.google.com/p/powermock-osgi/ , http://powermock-osgi.googlecode.com/svn/trunk/
> *Affected projects:* OpenShift tests
> *Include in JBDS:* No
> *Type of dependency:* testing
> *List of bundles added/removed:*
> {code}
> + <unit id="org.powermock.mockito-junit.feature.feature.group" version="1.5.4.1"/>
> + <unit id="org.objenesis" version="2.1.0"/>
> + <unit id="javassist" version="3.18.1.GA"/>
> {code}
> *p2diff report:*
> {code}
> mistria@mistria--rh:~/git/jbosstools-target-platforms/jbosstools/multiple$ ~/git/p2diff/org.eclipse.equinox.p2.example.p2diff.packaging/target/products/org.eclipse.equinox.p2.example.p2diff.product/linux/gtk/x86_64/p2diff http://download.jboss.org/jbosstools/targetplatforms/jbosstoolstarget/4.4... file:$(pwd)/target/jbosstools-multiple.target.repo/
> > org.mockito.mockito-core [1.9.5]
> > javassist [3.18.1.GA]
> > org.powermock.powermock-api-support [1.5.4]
> > org.powermock.powermock-reflect [1.5.4]
> > org.powermock.mockito-junit.feature.feature.jar [1.5.4.1]
> > org.junit [4.11.0]
> > org.powermock.powermock-api-mockito [1.5.4]
> > org.powermock.powermock-module-junit4-common [1.5.4]
> > org.powermock.powermock-module-junit3 [1.5.4]
> > org.powermock.powermock-module-junit4 [1.5.4]
> > org.powermock.powermock-core [1.5.4]
> > org.hamcrest.hamcrest-core [1.3.0]
> > org.powermock.mockito-junit.feature.feature.group [1.5.4.1]
> > org.powermock.powermock-classloading-base [1.5.4]
> > org.powermock.powermock-module-junit4-legacy [1.5.4]
> > org.objenesis [2.1.0]
> === Summary ===
> file:/home/mistria/git/jbosstools-target-platforms/jbosstools/multiple/target/jbosstools-multiple.target.repo/ contains 16 unique IUs
> {code}
--
This message was sent by Atlassian JIRA
(v6.2.6#6264)
11 years, 10 months
[JBoss JIRA] (JBIDE-18108) Set version on exported packages
by Mickael Istria (JIRA)
Mickael Istria created JBIDE-18108:
--------------------------------------
Summary: Set version on exported packages
Key: JBIDE-18108
URL: https://issues.jboss.org/browse/JBIDE-18108
Project: Tools (JBoss Tools)
Issue Type: Enhancement
Components: locus
Affects Versions: 1.1.0-LOCUS
Reporter: Mickael Istria
Locus bundles don't specify version for their exports, so they cannot be consumed by other bundles that use Import-Package with a version.
--
This message was sent by Atlassian JIRA
(v6.2.6#6264)
11 years, 10 months
[JBoss JIRA] (JBIDE-18053) Add Powermock to the target platform
by Mickael Istria (JIRA)
[ https://issues.jboss.org/browse/JBIDE-18053?page=com.atlassian.jira.plugi... ]
Mickael Istria commented on JBIDE-18053:
----------------------------------------
Since the version of Mockito on Locus doesn't set version on packages, and Powermock uses versions in its import-packages. It's not possible to use Mockito from Locus.
However, Mockito from Powermock repo or Orbit are compatible.
> Add Powermock to the target platform
> ------------------------------------
>
> Key: JBIDE-18053
> URL: https://issues.jboss.org/browse/JBIDE-18053
> Project: Tools (JBoss Tools)
> Issue Type: Feature Request
> Components: build
> Affects Versions: 4.2.x
> Reporter: Jeff Cantrill
> Assignee: Nick Boldt
> Fix For: 4.2.0.CR1
>
>
> *Reason:* To improving testing by allowing the stubbing of scenerios like "new File(path).exists()" which require bytecode modifications in order to accomplish. Example of intended use: https://gist.github.com/jcantrill/fd83c27d3fc542742ec7
> *License and owner:* Apache 2.0 / https://github.com/jayway
> *Original p2 repo:* http://powermock-osgi.googlecode.com/svn/updateSite/1.5.4.1/
> *JBoss mirror:* http://download.jboss.org/jbosstools/updates/requirements/powermock/1.5.4.1/
> *Sources:* https://code.google.com/p/powermock-osgi/ , http://powermock-osgi.googlecode.com/svn/trunk/
> *Affected projects:* OpenShift tests
> *Include in JBDS:* No
> *Type of dependency:* testing
> *List of bundles added/removed:*
> {code}
> + <unit id="org.powermock.mockito-junit.feature.feature.group" version="1.5.4.1"/>
> + <unit id="org.objenesis" version="2.1.0"/>
> + <unit id="javassist" version="3.18.1.GA"/>
> {code}
> *p2diff report:*
> {code}
> mistria@mistria--rh:~/git/jbosstools-target-platforms/jbosstools/multiple$ ~/git/p2diff/org.eclipse.equinox.p2.example.p2diff.packaging/target/products/org.eclipse.equinox.p2.example.p2diff.product/linux/gtk/x86_64/p2diff http://download.jboss.org/jbosstools/targetplatforms/jbosstoolstarget/4.4... file:$(pwd)/target/jbosstools-multiple.target.repo/
> > org.mockito.mockito-core [1.9.5]
> > javassist [3.18.1.GA]
> > org.powermock.powermock-api-support [1.5.4]
> > org.powermock.powermock-reflect [1.5.4]
> > org.powermock.mockito-junit.feature.feature.jar [1.5.4.1]
> > org.junit [4.11.0]
> > org.powermock.powermock-api-mockito [1.5.4]
> > org.powermock.powermock-module-junit4-common [1.5.4]
> > org.powermock.powermock-module-junit3 [1.5.4]
> > org.powermock.powermock-module-junit4 [1.5.4]
> > org.powermock.powermock-core [1.5.4]
> > org.hamcrest.hamcrest-core [1.3.0]
> > org.powermock.mockito-junit.feature.feature.group [1.5.4.1]
> > org.powermock.powermock-classloading-base [1.5.4]
> > org.powermock.powermock-module-junit4-legacy [1.5.4]
> > org.objenesis [2.1.0]
> === Summary ===
> file:/home/mistria/git/jbosstools-target-platforms/jbosstools/multiple/target/jbosstools-multiple.target.repo/ contains 16 unique IUs
> {code}
--
This message was sent by Atlassian JIRA
(v6.2.6#6264)
11 years, 10 months
[JBoss JIRA] (JBIDE-18039) Support DeltaSpike's PartialBean dynamically implemented interfaces and Data repositories
by Max Rydahl Andersen (JIRA)
[ https://issues.jboss.org/browse/JBIDE-18039?page=com.atlassian.jira.plugi... ]
Max Rydahl Andersen closed JBIDE-18039.
---------------------------------------
Resolution: Cannot Reproduce Bug
okey - then I'm going to close this as non-reproducible but do please reopen/create new one and link to this if you do find a way to reproduce.
Thanks!
> Support DeltaSpike's PartialBean dynamically implemented interfaces and Data repositories
> -----------------------------------------------------------------------------------------
>
> Key: JBIDE-18039
> URL: https://issues.jboss.org/browse/JBIDE-18039
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: cdi-extensions
> Environment: JBDS 8.0.0.Beta3
> Reporter: Ron Šmeral
> Assignee: Viacheslav Kabanovich
> Fix For: 4.2.0.CR1
>
>
> JBDS currently shows _No bean is eligible for injection to the injection point_ for injection points which are implemented using DeltaSpike's PartialBean extension. This also affects DeltaSpike's Data module, which is based on PartialBean.
> The injection point:
> {code:java|title=QueryServiceTest.java}
> @Inject
> private PersonQueryService personQueryService;
> {code}
> The injected interface:
> {code:java|title=PersonQueryService.java}
> @RequestScoped
> @QueryServiceBinding
> public interface PersonQueryService {
> ...
> {code}
> A partial bean binding annotation:
> {code:java|title=QueryServiceBinding.java}
> @PartialBeanBinding
> @Target(TYPE)
> @Retention(RUNTIME)
> public @interface QueryServiceBinding {
> }
> {code}
> The handler:
> {code:java|title=QueryServicePartialBean.java}
> @RequestScoped
> @QueryServiceBinding
> public class QueryServicePartialBean implements InvocationHandler {
> public Object invoke(Object proxy, Method method, Object[] args) throws Throwable {
> ...
> {code}
> There's no implementing class directly in the project, and that's what JBDS is complaining about. The interface is implemented dynamically, using an extension which looks for:
> * interfaces and abstract classes annotated with a partial bean binding
> * invocation handlers which handle calls to methods of those interfaces
> and then adds beans for those interfaces in the ABD phase.
> The same goes for DS Data module's {{@Repository}} ( = a partial bean binding) beans.
> JBDS should not show the no-bean-eligible warning for dynamically implemented interfaces or for DS Data repositories and should instead point to the invocation handler associated with those interfaces through the partial bean binding.
--
This message was sent by Atlassian JIRA
(v6.2.6#6264)
11 years, 10 months