[JBoss JIRA] (JBIDE-18808) JAX-RS Resource wizard: Resource methods are created even though there is no Target entity specified anymore
by Marián Labuda (JIRA)
[ https://issues.jboss.org/browse/JBIDE-18808?page=com.atlassian.jira.plugi... ]
Marián Labuda closed JBIDE-18808.
---------------------------------
Verified in JBDS 9.0.0.Alpha1 build ID 11.
> JAX-RS Resource wizard: Resource methods are created even though there is no Target entity specified anymore
> ------------------------------------------------------------------------------------------------------------
>
> Key: JBIDE-18808
> URL: https://issues.jboss.org/browse/JBIDE-18808
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: webservices
> Affects Versions: 4.2.0.CR1
> Reporter: Xavier Coulon
> Assignee: Xavier Coulon
> Labels: jax-rs
> Fix For: 4.3.0.Alpha1
>
>
> If I start typing name of Target entity in the JAX-RS Resource wizard, then checkboxes for creating resource methods (findById, listAll...) are allowed to be changed (checked/unchecked). But after completely removing of Target entity (leaving the field blank) the checkboxes are stilled in state checked/unchecked as they were changed while having filled Entity, but this changes are propagated next. That cause generating resource class with those methods even though there was no Entity specified and it leaves blank space in those generated methods causing syntax error.
--
This message was sent by Atlassian JIRA
(v6.3.11#6341)
11 years, 2 months
[JBoss JIRA] (JBIDE-18188) HTML5 Palette: filter to show only palette groups for which libraries are defined on the page
by Vlado Pakan (JIRA)
[ https://issues.jboss.org/browse/JBIDE-18188?page=com.atlassian.jira.plugi... ]
Vlado Pakan closed JBIDE-18188.
-------------------------------
Verified with JBDS 9.0.0.Alpha1-v20150216-1042-B11
> HTML5 Palette: filter to show only palette groups for which libraries are defined on the page
> ---------------------------------------------------------------------------------------------
>
> Key: JBIDE-18188
> URL: https://issues.jboss.org/browse/JBIDE-18188
> Project: Tools (JBoss Tools)
> Issue Type: Feature Request
> Components: jsp/jsf/xml/html source editing
> Affects Versions: 4.3.x
> Reporter: Daniel Azarov
> Assignee: Daniel Azarov
> Labels: new_and_noteworthy
> Fix For: 4.3.0.Alpha1
>
> Attachments: Filter1.png, Filter2.png
>
>
> *Test case 1:*
> 1. Open empty html file in Visual Page Editor and make sure button "Show only palette groups for which libraries are defined on the page" is not selected
> {code}
> {code}
> ASSERT:
> Follow palette groups visible on HTML 5 Palette:
> 1. Ionic 1.0
> 2. jQuery Mobile 1.4
> 3. HTML 5.0
> 2. Press the button "Show only palette groups for which libraries are defined on the page"
> ASSERT:
> No Palette groups are visible in HTML 5 Palette
> *Test case 2:*
> 1. Open follow html file in Visual Page Editor and make sure button "Show only palette groups for which libraries are defined on the page" is not selected
> {code:html}
> <!DOCTYPE html>
> <html>
> <head>
> <meta name="viewport" content="width=device-width, initial-scale=1">
> <link rel="stylesheet" href="http://code.ionicframework.com/1.0.0-beta.13/css/ionic.css" />
> <script src="http://code.ionicframework.com/1.0.0-beta.13/js/ionic.bundle.js"></script>
> <meta charset="UTF-8">
> <title>Insert title here</title>
> </head>
> <body>
> </body>
> </html>
> {code}
> ASSERT:
> Follow palette groups visible on HTML 5 Palette:
> 1. Ionic 1.0
> 2. jQuery Mobile 1.4
> 3. HTML 5.0
> 2. Press the button "Show only palette groups for which libraries are defined on the page"
> ASSERT:
> Follow palette groups visible on HTML 5 Palette:
> 1. Ionic 1.0
> 2. HTML 5.0
> *Test case 3:*
> 1. Open follow html file in Visual Page Editor and make sure button "Show only palette groups for which libraries are defined on the page" is not selected
> {code:html}
> <!DOCTYPE html>
> <html>
> <head>
> <meta name="viewport" content="width=device-width, initial-scale=1">
> <link rel="stylesheet" href="http://code.jquery.com/mobile/1.4.4/jquery.mobile-1.4.4.min.css" />
> <script src="http://code.jquery.com/jquery-2.0.3.min.js"></script>
> <script src="http://code.jquery.com/mobile/1.4.4/jquery.mobile-1.4.4.min.js"></script>
> <meta charset="UTF-8">
> <title>Insert title here</title>
> </head>
> <body>
> </body>
> </html>
> {code}
> ASSERT:
> Follow palette groups visible on HTML 5 Palette:
> 1. Ionic 1.0
> 2. jQuery Mobile 1.4
> 3. HTML 5.0
> 2. Press the button "Show only palette groups for which libraries are defined on the page"
> ASSERT:
> Follow palette groups visible on HTML 5 Palette:
> 1. jQuery Mobile 1.4
> 2. HTML 5.0
--
This message was sent by Atlassian JIRA
(v6.3.11#6341)
11 years, 2 months
[JBoss JIRA] (JBIDE-18188) HTML5 Palette: filter to show only palette groups for which libraries are defined on the page
by Vlado Pakan (JIRA)
[ https://issues.jboss.org/browse/JBIDE-18188?page=com.atlassian.jira.plugi... ]
Vlado Pakan commented on JBIDE-18188:
-------------------------------------
Test Case 1 was working it means I have seen Ionic palette. It disappeared after button "Show only palette groups for which libraries are defined on the page" was checked during Test Case 2.
Feature is added so I'm closing this Jira and creating new bug here JBIDE-19338
> HTML5 Palette: filter to show only palette groups for which libraries are defined on the page
> ---------------------------------------------------------------------------------------------
>
> Key: JBIDE-18188
> URL: https://issues.jboss.org/browse/JBIDE-18188
> Project: Tools (JBoss Tools)
> Issue Type: Feature Request
> Components: jsp/jsf/xml/html source editing
> Affects Versions: 4.3.x
> Reporter: Daniel Azarov
> Assignee: Daniel Azarov
> Labels: new_and_noteworthy
> Fix For: 4.3.0.Alpha1
>
> Attachments: Filter1.png, Filter2.png
>
>
> *Test case 1:*
> 1. Open empty html file in Visual Page Editor and make sure button "Show only palette groups for which libraries are defined on the page" is not selected
> {code}
> {code}
> ASSERT:
> Follow palette groups visible on HTML 5 Palette:
> 1. Ionic 1.0
> 2. jQuery Mobile 1.4
> 3. HTML 5.0
> 2. Press the button "Show only palette groups for which libraries are defined on the page"
> ASSERT:
> No Palette groups are visible in HTML 5 Palette
> *Test case 2:*
> 1. Open follow html file in Visual Page Editor and make sure button "Show only palette groups for which libraries are defined on the page" is not selected
> {code:html}
> <!DOCTYPE html>
> <html>
> <head>
> <meta name="viewport" content="width=device-width, initial-scale=1">
> <link rel="stylesheet" href="http://code.ionicframework.com/1.0.0-beta.13/css/ionic.css" />
> <script src="http://code.ionicframework.com/1.0.0-beta.13/js/ionic.bundle.js"></script>
> <meta charset="UTF-8">
> <title>Insert title here</title>
> </head>
> <body>
> </body>
> </html>
> {code}
> ASSERT:
> Follow palette groups visible on HTML 5 Palette:
> 1. Ionic 1.0
> 2. jQuery Mobile 1.4
> 3. HTML 5.0
> 2. Press the button "Show only palette groups for which libraries are defined on the page"
> ASSERT:
> Follow palette groups visible on HTML 5 Palette:
> 1. Ionic 1.0
> 2. HTML 5.0
> *Test case 3:*
> 1. Open follow html file in Visual Page Editor and make sure button "Show only palette groups for which libraries are defined on the page" is not selected
> {code:html}
> <!DOCTYPE html>
> <html>
> <head>
> <meta name="viewport" content="width=device-width, initial-scale=1">
> <link rel="stylesheet" href="http://code.jquery.com/mobile/1.4.4/jquery.mobile-1.4.4.min.css" />
> <script src="http://code.jquery.com/jquery-2.0.3.min.js"></script>
> <script src="http://code.jquery.com/mobile/1.4.4/jquery.mobile-1.4.4.min.js"></script>
> <meta charset="UTF-8">
> <title>Insert title here</title>
> </head>
> <body>
> </body>
> </html>
> {code}
> ASSERT:
> Follow palette groups visible on HTML 5 Palette:
> 1. Ionic 1.0
> 2. jQuery Mobile 1.4
> 3. HTML 5.0
> 2. Press the button "Show only palette groups for which libraries are defined on the page"
> ASSERT:
> Follow palette groups visible on HTML 5 Palette:
> 1. jQuery Mobile 1.4
> 2. HTML 5.0
--
This message was sent by Atlassian JIRA
(v6.3.11#6341)
11 years, 2 months
[JBoss JIRA] (JBIDE-18823) Invalid generated code in JAX-RS Endpoint
by Marián Labuda (JIRA)
[ https://issues.jboss.org/browse/JBIDE-18823?page=com.atlassian.jira.plugi... ]
Marián Labuda closed JBIDE-18823.
---------------------------------
Verified in JBDS 9.0.0.Alpha1 build ID 11.
> Invalid generated code in JAX-RS Endpoint
> -----------------------------------------
>
> Key: JBIDE-18823
> URL: https://issues.jboss.org/browse/JBIDE-18823
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: webservices
> Affects Versions: 4.2.0.Final
> Reporter: Xavier Coulon
> Assignee: Xavier Coulon
> Labels: jax-rs
> Fix For: 4.3.0.Alpha1
>
>
> The generated code in the 'create' method contains something like this:
> {code}
> return Response.created(
> UriBuilder.fromResource(Session.class)
> .path(String.valueOf(session.getId())).build()).build();
> {code}
> but the {{Session.class}} should be {{SessionEndpoint.class}} since it must be the resource class annotated with {{@Path}}
> Also, after discussion with [~maxandersen], here the plan to fix this issue:
> - if the {{create}} method generation is selected and the target entity is selected and contains a 'getId()' method, then generate the following method body:
> {code}
> //TODO: process the given pojo
> // here we use Pojo#getId(), assuming it provides the end-user with the identifier to retrieve the created Pojo resource
> Response.created(UriBuilder.fromResource(PojoEndpoint.class).path(String.valueOf(pojo.getId())).build())
> .build();
> {code}
> - if the {{create}} method generation is selected and the target entity is selected and *does not contain* a 'getId()' method, then generate the following method body:
> {code}
> //TODO: process the given pojo
> // you may want to do something like this
> // return Response.created(UriBuilder.fromResource(PojoEndpoint.class).path(String.valueOf(pojo.getId())).build();
> // assuming that Pojo#getId() or a similar method would provide the end-user with the identifier to retrieve the created Pojo resource
> Response.created(null).build();
> {code}
> If no target entity is provided, there is no way to generate the method skeletons.
> The goal if this change is to make sure we generate code that compiles (that was not the case if the target entity class did not have a {{getId()}} method) and that returns a sensitive Response object (hence, we don't return {{null}}).
--
This message was sent by Atlassian JIRA
(v6.3.11#6341)
11 years, 2 months
[JBoss JIRA] (JBIDE-19337) Generated JAX-RS endpoint hint in create method inline comment contains invalid code template
by Marián Labuda (JIRA)
[ https://issues.jboss.org/browse/JBIDE-19337?page=com.atlassian.jira.plugi... ]
Marián Labuda updated JBIDE-19337:
----------------------------------
Description:
In JBIDE-18823 we implemented to generate create() method body in relation to (non)existing getId method in POJO class. If there is no such method, generated codes looks like this:
{code}
//TODO: process the given pojo
//you may want to use the following return statement, assuming that Pojo#getId() or a similar method
//would provide the identifier to retrieve the created Pojo resource:
//return Response.created(UriBuilder.fromResource(PojoEndpoint.class).path(String.valueOf(pojo.getId())).build();
{code}
but the code in last inline comment should looks like this
{code}
Response.created(UriBuilder.fromResource(PojoEndpoint.class).path(String.valueOf(pojo.getId())).build()).build();
{code}
was:
In JBIDE-18823 we implemented to generate create() method body in relation to (non)existing getId method in POJO class. If there is no such method, generated codes looks like this:
{code}
//TODO: process the given pojo
//you may want to use the following return statement, assuming that Pojo#getId() or a similar method
//would provide the identifier to retrieve the created Pojo resource:
//return Response.created(UriBuilder.fromResource(Pojo2Endpoint.class).path(String.valueOf(pojo2.getId())).build();
{code}
but the code in last inline comment should looks like this
{code}
Response.created(UriBuilder.fromResource(Pojo2Endpoint.class).path(String.valueOf(pojo2.getId())).build()).build();
{code}
> Generated JAX-RS endpoint hint in create method inline comment contains invalid code template
> ---------------------------------------------------------------------------------------------
>
> Key: JBIDE-19337
> URL: https://issues.jboss.org/browse/JBIDE-19337
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: webservices
> Affects Versions: 4.3.0.Alpha1
> Reporter: Marián Labuda
> Priority: Minor
> Labels: jax-rs
>
> In JBIDE-18823 we implemented to generate create() method body in relation to (non)existing getId method in POJO class. If there is no such method, generated codes looks like this:
> {code}
> //TODO: process the given pojo
> //you may want to use the following return statement, assuming that Pojo#getId() or a similar method
> //would provide the identifier to retrieve the created Pojo resource:
> //return Response.created(UriBuilder.fromResource(PojoEndpoint.class).path(String.valueOf(pojo.getId())).build();
> {code}
> but the code in last inline comment should looks like this
> {code}
> Response.created(UriBuilder.fromResource(PojoEndpoint.class).path(String.valueOf(pojo.getId())).build()).build();
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.11#6341)
11 years, 2 months
[JBoss JIRA] (JBIDE-19337) Generated JAX-RS endpoint hint in create method inline comment contains invalid code template
by Marián Labuda (JIRA)
[ https://issues.jboss.org/browse/JBIDE-19337?page=com.atlassian.jira.plugi... ]
Marián Labuda updated JBIDE-19337:
----------------------------------
Labels: jax-rs (was: )
> Generated JAX-RS endpoint hint in create method inline comment contains invalid code template
> ---------------------------------------------------------------------------------------------
>
> Key: JBIDE-19337
> URL: https://issues.jboss.org/browse/JBIDE-19337
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: webservices
> Affects Versions: 4.3.0.Alpha1
> Reporter: Marián Labuda
> Priority: Minor
> Labels: jax-rs
>
> In JBIDE-18823 we implemented to generate create() method body in relation to (non)existing getId method in POJO class. If there is no such method, generated codes looks like this:
> {code}
> //TODO: process the given pojo
> //you may want to use the following return statement, assuming that Pojo#getId() or a similar method
> //would provide the identifier to retrieve the created Pojo resource:
> //return Response.created(UriBuilder.fromResource(PojoEndpoint.class).path(String.valueOf(pojo.getId())).build();
> {code}
> but the code in last inline comment should looks like this
> {code}
> Response.created(UriBuilder.fromResource(PojoEndpoint.class).path(String.valueOf(pojo.getId())).build()).build();
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.11#6341)
11 years, 2 months
[JBoss JIRA] (JBIDE-19338) Ionic palette items disappears when "Show only palette groups for which libraries are defined on the page" filter is applied
by Vlado Pakan (JIRA)
Vlado Pakan created JBIDE-19338:
-----------------------------------
Summary: Ionic palette items disappears when "Show only palette groups for which libraries are defined on the page" filter is applied
Key: JBIDE-19338
URL: https://issues.jboss.org/browse/JBIDE-19338
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: jsp/jsf/xml/html source editing
Affects Versions: 4.3.0.Alpha1
Environment: MS Windows 7 JBDS 9.0.0.Alpha1-v20150216-1042-B11
Reporter: Vlado Pakan
1. Open empty html file in Visual Page Editor and make sure button "Show only palette groups for which libraries are defined on the page" is not selected
ASSERT: Following palette groups visible on HTML 5 Palette:
1. Ionic 1.0
2. jQuery Mobile 1.4
3. HTML 5.0
2. Check the button "Show only palette groups for which libraries are defined on the page"
ASSERT: No Palette groups are visible in HTML 5 Palette
3. Open following html file in Visual Page Editor and make sure button "Show only palette groups for which libraries are defined on the page" is not selected
{code:html}
<!DOCTYPE html>
<html>
<head>
<meta name="viewport" content="width=device-width, initial-scale=1">
<link rel="stylesheet" href="http://code.ionicframework.com/1.0.0-beta.13/css/ionic.css" />
<script src="http://code.ionicframework.com/1.0.0-beta.13/js/ionic.bundle.js"></script>
<meta charset="UTF-8">
<title>Insert title here</title>
</head>
<body>
</body>
</html>
{code}
ASSERT: Following palette groups visible on HTML 5 Palette:
1. Ionic 1.0
2. jQuery Mobile 1.4
3. HTML 5.0
4. Check the button "Show only palette groups for which libraries are defined on the page"
ERROR: Ionic palette is not displayed
5. Uncheck the button "Show only palette groups for which libraries are defined on the page"
ERROR: Ionic palette is not displayed
--
This message was sent by Atlassian JIRA
(v6.3.11#6341)
11 years, 2 months