[JBoss JIRA] (JBIDE-21302) Removing user from credentials framework while not authenticated to secure storage should not work
by Rob Stryker (JIRA)
[ https://issues.jboss.org/browse/JBIDE-21302?page=com.atlassian.jira.plugi... ]
Rob Stryker commented on JBIDE-21302:
-------------------------------------
[~scabanovich] Good catch!
Add API method If method need not be implemented by Client Binary compatible (0)
That's a great solution! Let's do it!
> Removing user from credentials framework while not authenticated to secure storage should not work
> --------------------------------------------------------------------------------------------------
>
> Key: JBIDE-21302
> URL: https://issues.jboss.org/browse/JBIDE-21302
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: common/jst/core
> Affects Versions: 4.3.1.Beta1
> Environment: JBDS 9.0.0.Beta1-v20151210-1836-B183
> Reporter: Radim Hopp
> Assignee: Rob Stryker
> Fix For: 4.3.1.CR1, 4.4.0.Alpha1
>
>
> Removing credentials (which are stored in secure storage) using
> CredentialPreferencePage without being authenticated to secure storage (see steps to reproduce on how to do that) seems to delete the credentials, but after eclipse restart, the credentials are still there. I would prefer message saying something like "Unable to delete credentials stored in secure storage without atuhenticating to secure storage".
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
10 years, 1 month
[JBoss JIRA] (JBDS-3557) JBDS Installer should be EPL licensed
by Alexey Kazakov (JIRA)
[ https://issues.jboss.org/browse/JBDS-3557?page=com.atlassian.jira.plugin.... ]
Alexey Kazakov updated JBDS-3557:
---------------------------------
Fix Version/s: 9.1.0.CR1
10.0.0.Alpha1
> JBDS Installer should be EPL licensed
> -------------------------------------
>
> Key: JBDS-3557
> URL: https://issues.jboss.org/browse/JBDS-3557
> Project: Developer Studio (JBoss Developer Studio)
> Issue Type: Enhancement
> Components: installer, legal
> Reporter: Ken Finnigan
> Assignee: Nick Boldt
> Fix For: 9.1.0.CR1, 10.0.0.Alpha1
>
>
> For the Developer Platform to be able to bundle JBDS, it needs to be licensed as ASLv2 or EPL and not GPL
> Sources code in repository ether has Apache Licence or no license.
> IzPack distribution jar's and licenses:
> 1. kunstoff Look and Feel is under LGPL http://kunstoff.incors.com/archive/licence.php3
> 2. Birosoft Liquid Look and Feel
> The source code (except the files or methods mentioned below) of the look and feel is released under the LGPL (GNU Lesser General Public License),
> which you can view on http://www.gnu.org/copyleft/lesser.html.
> Some methods are marked as SUN proprietary, the LGPL does not apply for those methods.
> 3. JGoodies Karsten Lentzsch - BSD open source license http://www.jgoodies.com/downloads/libraries/
> 4. Metouia Look And Feel: a free pluggable look and feel for java - LGPLv2.1 http://grepcode.com/file/repo1.maven.org/maven2/net.sf.squirrel-sql.third...
> 5. Nimbus Look And Feel
> This library is free software; you can redistribute it and/or
> * modify it under the terms of the GNU Lesser General Public
> * License as published by the Free Software Foundation; either
> * version 2.1 of the License, or (at your option) any later version.
> 6. Substance Java Look and Feel (bundles several components with licenses listed below)
> 6.1 Copyright (c) 2005-2007, Kirill Grouchnikov and contributors
> All rights reserved.
> Redistribution and use in source and binary forms, with or without
> modification, are permitted provided that the following conditions are met:
> * Redistributions of source code must retain the above copyright
> notice, this list of conditions and the following disclaimer.
> * Redistributions in binary form must reproduce the above copyright
> notice, this list of conditions and the following disclaimer in the
> documentation and/or other materials provided with the distribution.
> * Neither the name of the Kirill Grouchnikov and contributors nor
> the names of its contributors may be used to endorse or promote products
> derived from this software without specific prior written permission.
> 6.2 Source code, documentation and binaries of the Quaqua Look and
> Feel (also called "this software") are subject to the GNU Lesser
> General Public License (LGPL).
> 6.3. MOZILLA PUBLIC LICENSE Version 1.1
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
10 years, 1 month
[JBoss JIRA] (JBIDE-21302) Removing user from credentials framework while not authenticated to secure storage should not work
by Viacheslav Kabanovich (JIRA)
[ https://issues.jboss.org/browse/JBIDE-21302?page=com.atlassian.jira.plugi... ]
Viacheslav Kabanovich edited comment on JBIDE-21302 at 2/16/16 10:09 AM:
-------------------------------------------------------------------------
We can add new method - boolean save() - and mark the old one - void saveModel() - as deprecated. That will not break API compatibility.
Implementation of old saveModel() will just call save() without using its return. All clients you mention will continue using this old method. Removing user will use new method.
Since interface name ICredentialsModel has 'Model' in it, I think it may be ok to have method save() without 'Model' - and Javadoc may explain exactly what it saves. [~rob.stryker], may I do that change to the pull request?
was (Author: scabanovich):
We can add new method - boolean save() - and mark the old one - void saveModel() - as deprecated. That will not break compatibility.
Implementation of old saveModel() will just call save() without using its return. All clients you mention will continue using this old method. Removing user will use new method.
Since interface name ICredentialsModel has 'Model' in it, I think it may be ok to have method save() without 'Model' - and Javadoc may explain exactly what it saves. [~rob.stryker], may I do that change to the pull request?
> Removing user from credentials framework while not authenticated to secure storage should not work
> --------------------------------------------------------------------------------------------------
>
> Key: JBIDE-21302
> URL: https://issues.jboss.org/browse/JBIDE-21302
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: common/jst/core
> Affects Versions: 4.3.1.Beta1
> Environment: JBDS 9.0.0.Beta1-v20151210-1836-B183
> Reporter: Radim Hopp
> Assignee: Rob Stryker
> Fix For: 4.3.1.CR1, 4.4.0.Alpha1
>
>
> Removing credentials (which are stored in secure storage) using
> CredentialPreferencePage without being authenticated to secure storage (see steps to reproduce on how to do that) seems to delete the credentials, but after eclipse restart, the credentials are still there. I would prefer message saying something like "Unable to delete credentials stored in secure storage without atuhenticating to secure storage".
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
10 years, 1 month
[JBoss JIRA] (JBIDE-21302) Removing user from credentials framework while not authenticated to secure storage should not work
by Viacheslav Kabanovich (JIRA)
[ https://issues.jboss.org/browse/JBIDE-21302?page=com.atlassian.jira.plugi... ]
Viacheslav Kabanovich commented on JBIDE-21302:
-----------------------------------------------
We can add new method - boolean save() - and mark the old one - void saveModel() - as deprecated. That will not break compatibility.
Implementation of old saveModel() will just call save() without using its return. All clients you mention will continue using this old method. Removing user will use new method.
Since interface name ICredentialsModel has 'Model' in it, I think it may be ok to have method save() without 'Model' - and Javadoc may explain exactly what it saves. [~rob.stryker], may I do that change to the pull request?
> Removing user from credentials framework while not authenticated to secure storage should not work
> --------------------------------------------------------------------------------------------------
>
> Key: JBIDE-21302
> URL: https://issues.jboss.org/browse/JBIDE-21302
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: common/jst/core
> Affects Versions: 4.3.1.Beta1
> Environment: JBDS 9.0.0.Beta1-v20151210-1836-B183
> Reporter: Radim Hopp
> Assignee: Rob Stryker
> Fix For: 4.3.1.CR1, 4.4.0.Alpha1
>
>
> Removing credentials (which are stored in secure storage) using
> CredentialPreferencePage without being authenticated to secure storage (see steps to reproduce on how to do that) seems to delete the credentials, but after eclipse restart, the credentials are still there. I would prefer message saying something like "Unable to delete credentials stored in secure storage without atuhenticating to secure storage".
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
10 years, 1 month
[JBoss JIRA] (JBIDE-21681) Truncated lines seen on openshift login page
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-21681?page=com.atlassian.jira.plugi... ]
Andre Dietisheim commented on JBIDE-21681:
------------------------------------------
[~xiazhao2015] thanks for the clarification. I believe that this is a platform/upstream problem that we cant easily tackle on our side. Since this isnt critical I'll postpone investigations to 4.4.x
> Truncated lines seen on openshift login page
> --------------------------------------------
>
> Key: JBIDE-21681
> URL: https://issues.jboss.org/browse/JBIDE-21681
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Affects Versions: 4.3.1.Beta2
> Environment: OpenShift 3 Tools: 3.1.0.CR1-v20160212-1935-B177
> OS: Fedora 17 & 22
> Reporter: Xia Zhao
> Priority: Minor
> Labels: login_wizard, openshift_v3
> Fix For: 4.4.x
>
> Attachments: Screenshot from 2016-02-15 10-21-30.png
>
>
> On the latest openshift login wizard inside JBT, the checkbox in the last line about whether you want to save credential is truncated. Please refer to the attached screenshot.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
10 years, 1 month
[JBoss JIRA] (JBIDE-21681) Truncated lines seen on openshift login page
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-21681?page=com.atlassian.jira.plugi... ]
Andre Dietisheim updated JBIDE-21681:
-------------------------------------
Fix Version/s: 4.4.x
> Truncated lines seen on openshift login page
> --------------------------------------------
>
> Key: JBIDE-21681
> URL: https://issues.jboss.org/browse/JBIDE-21681
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Affects Versions: 4.3.1.Beta2
> Environment: OpenShift 3 Tools: 3.1.0.CR1-v20160212-1935-B177
> OS: Fedora 17 & 22
> Reporter: Xia Zhao
> Priority: Minor
> Labels: login_wizard, openshift_v3
> Fix For: 4.4.x
>
> Attachments: Screenshot from 2016-02-15 10-21-30.png
>
>
> On the latest openshift login wizard inside JBT, the checkbox in the last line about whether you want to save credential is truncated. Please refer to the attached screenshot.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
10 years, 1 month
[JBoss JIRA] (JBIDE-21302) Removing user from credentials framework while not authenticated to secure storage should not work
by Rob Stryker (JIRA)
[ https://issues.jboss.org/browse/JBIDE-21302?page=com.atlassian.jira.plugi... ]
Rob Stryker commented on JBIDE-21302:
-------------------------------------
[~scabanovich] I like the solution, but unfortunately it breaks API compatibility. See https://wiki.eclipse.org/Evolving_Java-based_APIs_2
Changing the return type of a method, especially an interface method with consumers, will break API compatibility, even when the existing return type was void.
In order to avoid this, we'd need to know that every consumer *using* the API will be rebuilt. As of right now, known consumers are download runtimes, and CDK. If we can guarantee that users who somehow get a new foundation will also get a new CDK and a new download runtimes, then the patch *could* be accepted for maintenance. Otherwise, it will have to be master only.
> Removing user from credentials framework while not authenticated to secure storage should not work
> --------------------------------------------------------------------------------------------------
>
> Key: JBIDE-21302
> URL: https://issues.jboss.org/browse/JBIDE-21302
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: common/jst/core
> Affects Versions: 4.3.1.Beta1
> Environment: JBDS 9.0.0.Beta1-v20151210-1836-B183
> Reporter: Radim Hopp
> Assignee: Rob Stryker
> Fix For: 4.3.1.CR1, 4.4.0.Alpha1
>
>
> Removing credentials (which are stored in secure storage) using
> CredentialPreferencePage without being authenticated to secure storage (see steps to reproduce on how to do that) seems to delete the credentials, but after eclipse restart, the credentials are still there. I would prefer message saying something like "Unable to delete credentials stored in secure storage without atuhenticating to secure storage".
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
10 years, 1 month