[JBoss JIRA] (JBIDE-12637) Hibernate Tools generates @SequenceGenerator with not unique name
by Koen Aers (JIRA)
[ https://issues.jboss.org/browse/JBIDE-12637?page=com.atlassian.jira.plugi... ]
Koen Aers updated JBIDE-12637:
------------------------------
Sprint: devex #115 May 2016
> Hibernate Tools generates @SequenceGenerator with not unique name
> -----------------------------------------------------------------
>
> Key: JBIDE-12637
> URL: https://issues.jboss.org/browse/JBIDE-12637
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: hibernate
> Reporter: Nicolas Bihan
> Assignee: Koen Aers
> Priority: Critical
> Labels: SequenceGenerator, hibenate, hibernate-tools, jpa
> Fix For: 4.4.0.Alpha3
>
>
> When generating entities with EJB3 annotations with a strategy set to "sequence", Hibernate tools generates POJOs with non unique javax.persistence.SequenceGenerator name "generator". But according to the Java documentation :
> bq. String name (Required) A unique generator name that can be referenced by one or more classes to be the generator for primary key values.
> See [javadoc|http://docs.oracle.com/javaee/5/api/javax/persistence/SequenceGen...]
> Exemple of generated code with 4.0.0 Alpha1:
> {code}
> @SequenceGenerator(name = "generator", sequenceName = "S_CLIENT")
> @Id
> @GeneratedValue(strategy = SEQUENCE, generator = "generator")
> @Column(name = "CLIENT_ID", unique = true, nullable = false, precision = 22, scale = 0)
> public long getClientId() {
> return this.clientId;
> }
> {code}
> [Source code|https://github.com/hibernate/hibernate-tools/blob/master/src/java/or...] can be seen here.
> So looks like the //TODO comment is right and it should generate a unique name atribute. sequencename+"generator" would be a good name.
> It would even be better if we could define this name in reveng.xml or/and in a DelegatingReverseEngineeringStrategy class.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 10 months
[JBoss JIRA] (JBIDE-22283) reveng *.java emitter does not escape java keyword 'return' as variable name
by Koen Aers (JIRA)
[ https://issues.jboss.org/browse/JBIDE-22283?page=com.atlassian.jira.plugi... ]
Koen Aers updated JBIDE-22283:
------------------------------
Sprint: devex #115 May 2016
> reveng *.java emitter does not escape java keyword 'return' as variable name
> ----------------------------------------------------------------------------
>
> Key: JBIDE-22283
> URL: https://issues.jboss.org/browse/JBIDE-22283
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: hibernate
> Affects Versions: 4.3.x
> Environment: Eclipse Mars
> Reporter: Darryl Miles
> Assignee: Koen Aers
> Fix For: 4.4.0.Alpha2
>
>
> reveng *.java emitter does not escape java keyword 'return' as variable name
> <table name="oc_return_history">
> <foreign-key constraint-name="FK_oc_return_history__return_id" foreign-table="oc_return">
> <column-ref local-column="return_id" foreign-column="return_id"/>
> <!-- this breaks the generator trying to name local variable as a java keyword -->
> <many-to-one property="return"/>
> </foreign-key>
> </table>
> The expected output would be:
> private Return _return;
> but actual output is:
> private Return return;
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 10 months