May 2016 - jbosstools-issues - Jboss List Archives

[JBoss JIRA] (JBIDE-22426) Connection: authorization strategy is always overwritten (in the client) upon #isConnected

by Andre Dietisheim (JIRA)

[ https://issues.jboss.org/browse/JBIDE-22426?page=com.atlassian.jira.plugi... ] Andre Dietisheim reassigned JBIDE-22426: ---------------------------------------- Assignee: Andre Dietisheim > Connection: authorization strategy is always overwritten (in the client) upon #isConnected > ------------------------------------------------------------------------------------------- > > Key: JBIDE-22426 > URL: https://issues.jboss.org/browse/JBIDE-22426 > Project: Tools (JBoss Tools) > Issue Type: Bug > Components: openshift > Affects Versions: 4.4.0.Alpha3 > Reporter: Andre Dietisheim > Assignee: Andre Dietisheim > Labels: connection, openshift_v3 > Fix For: 4.4.0.Alpha3 > > > The current implementation of Connection#isConnected() will always overwrite the authorization strategy in the client that it is using. This seems wrong given that #getResources, #createResource, #updateResource (and other methods) also set it but check if it already exists beforehand. Making sure that they dont overwrite an existing strategy. > {code:title=Connection#isConnected} > public boolean isConnected(IProgressMonitor monitor) { > client.setAuthorizationStrategy(getAuthorizationStrategy()); > try { > {code} > {code:title=Connection#createResource} > public <T extends IResource> T createResource(T resource) { > try { > if(client.getAuthorizationStrategy() == null) { > client.setAuthorizationStrategy(getAuthorizationStrategy()); > } > return client.create(resource); > {code} > A very likely side-effect of this is in Connection#ownsResource which compares clients (the one in the connection and the one attached to the given resource. The 2 clients are compared with the authorization strategy: > {code:title=com.openshift.internal.restclient.DefaultClient#equals} > @Override > public boolean equals(Object obj) { > ... > return ObjectUtils.equals(strategy, other.strategy); > {code} > the lookup for a connection for a given resource in ConnectionRegistryUtils#safeGetConnectionFor will therefore fail after a Connection#isConnected: > {code:title=ConnectionsRegistryUtil#safeGetConnectionFor(IResource)} > public static Connection safeGetConnectionFor(IResource resource) { > Collection<Connection> all = ConnectionsRegistrySingleton.getInstance().getAll(Connection.class); > for (Connection connection : all) { > if(connection.ownsResource(resource)) { > return connection; > } > } > return null; > } > {code} -- This message was sent by Atlassian JIRA (v6.4.11#64026)

9 years, 10 months

1
0
0 / 0

[JBoss JIRA] (ERT-146) Upgrade to Spotify client 3.6.4 [EBZ#492235]

by Xavier Coulon (JIRA)

[ https://issues.jboss.org/browse/ERT-146?page=com.atlassian.jira.plugin.sy... ] Xavier Coulon updated ERT-146: ------------------------------ Fix Version/s: Neon.1 (4.6) (was: Neon (4.6)) > Upgrade to Spotify client 3.6.4 [EBZ#492235] > -------------------------------------------- > > Key: ERT-146 > URL: https://issues.jboss.org/browse/ERT-146 > Project: Eclipse Release Train > Issue Type: Task > Components: Linux Tools > Reporter: Friendly Jira Robot > Labels: Docker, bzira > Fix For: Neon.1 (4.6) > > > CQ was approved http://dev.eclipse.org/ipzilla/show_bug.cgi?id=11108, but third-party dependencies need to be added/upgraded into Eclipse Orbit, too. -- This message was sent by Atlassian JIRA (v6.4.11#64026)

9 years, 10 months

1
0
0 / 0

[JBoss JIRA] (JBIDE-22383) Application Wizard: Selected project combo box is empty

by Andre Dietisheim (JIRA)

[ https://issues.jboss.org/browse/JBIDE-22383?page=com.atlassian.jira.plugi... ] Andre Dietisheim reassigned JBIDE-22383: ---------------------------------------- Assignee: Andre Dietisheim (was: Viacheslav Kabanovich) > Application Wizard: Selected project combo box is empty > ------------------------------------------------------- > > Key: JBIDE-22383 > URL: https://issues.jboss.org/browse/JBIDE-22383 > Project: Tools (JBoss Tools) > Issue Type: Enhancement > Components: openshift > Affects Versions: 4.4.0.Alpha2 > Reporter: Marián Labuda > Assignee: Andre Dietisheim > Labels: application_wizard, openshift_v3 > Fix For: 4.4.0.Alpha3 > > > Having a connection with several projects and a different than the first one project selected in OpenShift Explorer view, opening of a New OpenShift Application wizard via shell menu File - New - OpenShift Application leaves combo box for a project empty. If the first project is preselect in OpenShift Explorer view, its ok. Issues is only with selected project different than the first one. -- This message was sent by Atlassian JIRA (v6.4.11#64026)

9 years, 10 months

1
0
0 / 0

[JBoss JIRA] (ERT-165) Refactor the Connection Wizard [EBZ#492420]

by Xavier Coulon (JIRA)

[ https://issues.jboss.org/browse/ERT-165?page=com.atlassian.jira.plugin.sy... ] Xavier Coulon updated ERT-165: ------------------------------ Fix Version/s: Neon.1 (4.6) Oxygen (4.7) (was: Neon (4.6)) > Refactor the Connection Wizard [EBZ#492420] > ------------------------------------------- > > Key: ERT-165 > URL: https://issues.jboss.org/browse/ERT-165 > Project: Eclipse Release Train > Issue Type: Task > Components: Linux Tools > Reporter: Friendly Jira Robot > Assignee: Xavier Coulon > Labels: 5.0.0, Docker, bzira > Fix For: Neon.1 (4.6), Oxygen (4.7) > > > Refactor the connection wizard to provide: > - a table with all existing Docker instances (native, Docker for Mac/Windows and Docker Machine) > - a simplified form to specify custom settings, more directly based on the env variables that are used by the Docker CLI client (DOCKER_HOST, DOCKER_TLS_VERIFY and DOCKER_CERT_PATH) -- This message was sent by Atlassian JIRA (v6.4.11#64026)

9 years, 10 months

1
0
0 / 0

[JBoss JIRA] (JBIDE-22426) Connection: authorization strategy is always overwritten (in the client) upon #isConnected

by Andre Dietisheim (JIRA)

[ https://issues.jboss.org/browse/JBIDE-22426?page=com.atlassian.jira.plugi... ] Andre Dietisheim updated JBIDE-22426: ------------------------------------- Story Points: 2 Sprint: devex #115 May 2016 > Connection: authorization strategy is always overwritten (in the client) upon #isConnected > ------------------------------------------------------------------------------------------- > > Key: JBIDE-22426 > URL: https://issues.jboss.org/browse/JBIDE-22426 > Project: Tools (JBoss Tools) > Issue Type: Bug > Components: openshift > Affects Versions: 4.4.0.Alpha3 > Reporter: Andre Dietisheim > Labels: connection, openshift_v3 > Fix For: 4.4.0.Alpha3 > > > The current implementation of Connection#isConnected() will always overwrite the authorization strategy in the client that it is using. This seems wrong given that #getResources, #createResource, #updateResource (and other methods) also set it but check if it already exists beforehand. Making sure that they dont overwrite an existing strategy. > {code:title=Connection#isConnected} > public boolean isConnected(IProgressMonitor monitor) { > client.setAuthorizationStrategy(getAuthorizationStrategy()); > try { > {code} > {code:title=Connection#createResource} > public <T extends IResource> T createResource(T resource) { > try { > if(client.getAuthorizationStrategy() == null) { > client.setAuthorizationStrategy(getAuthorizationStrategy()); > } > return client.create(resource); > {code} > A very likely side-effect of this is in Connection#ownsResource which compares clients (the one in the connection and the one attached to the given resource. The 2 clients are compared with the authorization strategy: > {code:title=com.openshift.internal.restclient.DefaultClient#equals} > @Override > public boolean equals(Object obj) { > ... > return ObjectUtils.equals(strategy, other.strategy); > {code} > the lookup for a connection for a given resource in ConnectionRegistryUtils#safeGetConnectionFor will therefore fail after a Connection#isConnected: > {code:title=ConnectionsRegistryUtil#safeGetConnectionFor(IResource)} > public static Connection safeGetConnectionFor(IResource resource) { > Collection<Connection> all = ConnectionsRegistrySingleton.getInstance().getAll(Connection.class); > for (Connection connection : all) { > if(connection.ownsResource(resource)) { > return connection; > } > } > return null; > } > {code} -- This message was sent by Atlassian JIRA (v6.4.11#64026)

9 years, 10 months

1
0
0 / 0

[JBoss JIRA] (JBIDE-22380) New Application wizard: project is not preselected (nor can you select any) if launched from explorer

by Andre Dietisheim (JIRA)

[ https://issues.jboss.org/browse/JBIDE-22380?page=com.atlassian.jira.plugi... ] Andre Dietisheim reassigned JBIDE-22380: ---------------------------------------- Original Estimate: 8 minutes Remaining Estimate: 8 minutes Sprint: devex #115 May 2016 Assignee: Andre Dietisheim > New Application wizard: project is not preselected (nor can you select any) if launched from explorer > ----------------------------------------------------------------------------------------------------- > > Key: JBIDE-22380 > URL: https://issues.jboss.org/browse/JBIDE-22380 > Project: Tools (JBoss Tools) > Issue Type: Bug > Components: openshift > Affects Versions: 4.4.0.Alpha1 > Reporter: Andre Dietisheim > Assignee: Andre Dietisheim > Priority: Critical > Labels: application_wizard, openshift_v3 > Fix For: 4.4.0.Alpha3 > > Attachments: project-not-preselected.png > > Original Estimate: 8 minutes > Remaining Estimate: 8 minutes > -- This message was sent by Atlassian JIRA (v6.4.11#64026)

9 years, 10 months

1
0
0 / 0

[JBoss JIRA] (JBIDE-22383) Application Wizard: Selected project combo box is empty

by Andre Dietisheim (JIRA)

[ https://issues.jboss.org/browse/JBIDE-22383?page=com.atlassian.jira.plugi... ] Andre Dietisheim updated JBIDE-22383: ------------------------------------- Story Points: 2 (was: 8) > Application Wizard: Selected project combo box is empty > ------------------------------------------------------- > > Key: JBIDE-22383 > URL: https://issues.jboss.org/browse/JBIDE-22383 > Project: Tools (JBoss Tools) > Issue Type: Enhancement > Components: openshift > Affects Versions: 4.4.0.Alpha2 > Reporter: Marián Labuda > Assignee: Viacheslav Kabanovich > Labels: application_wizard, openshift_v3 > Fix For: 4.4.0.Alpha3 > > > Having a connection with several projects and a different than the first one project selected in OpenShift Explorer view, opening of a New OpenShift Application wizard via shell menu File - New - OpenShift Application leaves combo box for a project empty. If the first project is preselect in OpenShift Explorer view, its ok. Issues is only with selected project different than the first one. -- This message was sent by Atlassian JIRA (v6.4.11#64026)

9 years, 10 months

1
0
0 / 0

[JBoss JIRA] (ERT-204) Docker Machine lookup does not work on Windows machines [EBZ#494305]

by Fred Bricon (JIRA)

[ https://issues.jboss.org/browse/ERT-204?page=com.atlassian.jira.plugin.sy... ] Fred Bricon updated ERT-204: ---------------------------- Sprint: devex #115 May 2016 > Docker Machine lookup does not work on Windows machines [EBZ#494305] > -------------------------------------------------------------------- > > Key: ERT-204 > URL: https://issues.jboss.org/browse/ERT-204 > Project: Eclipse Release Train > Issue Type: Task > Components: Linux Tools > Reporter: Friendly Jira Robot > Labels: 5.0.0, Docker, bzira > Fix For: Neon (4.6) > > > When creating Docker connection, the docker-machine mechanism does not work on Window as it seems to find docker-machine and not docker-machine.exe -- This message was sent by Atlassian JIRA (v6.4.11#64026)

9 years, 10 months

1
0
0 / 0

[JBoss JIRA] (JBIDE-22383) Application Wizard: Selected project combo box is empty

by Andre Dietisheim (JIRA)

[ https://issues.jboss.org/browse/JBIDE-22383?page=com.atlassian.jira.plugi... ] Andre Dietisheim updated JBIDE-22383: ------------------------------------- Story Points: 8 Sprint: devex #115 May 2016 > Application Wizard: Selected project combo box is empty > ------------------------------------------------------- > > Key: JBIDE-22383 > URL: https://issues.jboss.org/browse/JBIDE-22383 > Project: Tools (JBoss Tools) > Issue Type: Enhancement > Components: openshift > Affects Versions: 4.4.0.Alpha2 > Reporter: Marián Labuda > Assignee: Viacheslav Kabanovich > Labels: application_wizard, openshift_v3 > Fix For: 4.4.0.Alpha3 > > > Having a connection with several projects and a different than the first one project selected in OpenShift Explorer view, opening of a New OpenShift Application wizard via shell menu File - New - OpenShift Application leaves combo box for a project empty. If the first project is preselect in OpenShift Explorer view, its ok. Issues is only with selected project different than the first one. -- This message was sent by Atlassian JIRA (v6.4.11#64026)

9 years, 10 months

1
0
0 / 0

[JBoss JIRA] (JBIDE-22283) reveng *.java emitter does not escape java keyword 'return' as variable name

by Koen Aers (JIRA)

[ https://issues.jboss.org/browse/JBIDE-22283?page=com.atlassian.jira.plugi... ] Koen Aers updated JBIDE-22283: ------------------------------ Story Points: 8 > reveng *.java emitter does not escape java keyword 'return' as variable name > ---------------------------------------------------------------------------- > > Key: JBIDE-22283 > URL: https://issues.jboss.org/browse/JBIDE-22283 > Project: Tools (JBoss Tools) > Issue Type: Bug > Components: hibernate > Affects Versions: 4.3.x > Environment: Eclipse Mars > Reporter: Darryl Miles > Assignee: Koen Aers > Fix For: 4.4.0.Alpha2 > > > reveng *.java emitter does not escape java keyword 'return' as variable name > <table name="oc_return_history"> > <foreign-key constraint-name="FK_oc_return_history__return_id" foreign-table="oc_return"> > <column-ref local-column="return_id" foreign-column="return_id"/> >  > <many-to-one property="return"/> > </foreign-key> > </table> > The expected output would be: > private Return _return; > but actual output is: > private Return return; -- This message was sent by Atlassian JIRA (v6.4.11#64026)

9 years, 10 months

1
0
0 / 0

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

jbosstools-issues May 2016