[JBoss JIRA] (JBIDE-22443) Add to TP build a check that produced TP can be installed in target Eclipse version
by Denis Golovin (JIRA)
[ https://issues.jboss.org/browse/JBIDE-22443?page=com.atlassian.jira.plugi... ]
Denis Golovin commented on JBIDE-22443:
---------------------------------------
[~maxandersen]Right, that would be a good check. I actually run this sometimes locally to verify PRs for TP. Full DevStudio build takes around 15 minutes + download time for new TP bits.
> Add to TP build a check that produced TP can be installed in target Eclipse version
> -----------------------------------------------------------------------------------
>
> Key: JBIDE-22443
> URL: https://issues.jboss.org/browse/JBIDE-22443
> Project: Tools (JBoss Tools)
> Issue Type: Enhancement
> Components: build, target-platform
> Reporter: Mickael Istria
>
> Recently, a change in TP (jetty 9.3.6) was introduced and everything built fine with it; until the very end of the build process: during install-tests.
> This issue would *probably* have occured if trying to install all content of the TP into the target Eclipse IDE (using install-grinder or p2director or whatever installation). So it would be good to have inside the TP build (as a "verify" plugin in pom.xml) something that would try to find whether target Eclipse version and our TP are already compatible.
> Technical notes:
> * Trying to install all IUs from the release train site + our TP seems easier to implement
> * We do not need to actually install the artifacts, just making the p2 request and getting whether the request managed to find a working plan without remediation seems enough.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 11 months
[JBoss JIRA] (JBIDE-22283) reveng *.java emitter does not escape java keyword 'return' as variable name
by Koen Aers (JIRA)
[ https://issues.jboss.org/browse/JBIDE-22283?page=com.atlassian.jira.plugi... ]
Koen Aers commented on JBIDE-22283:
-----------------------------------
[~dlmiles] Would it be possible to provide me with a test setup to reproduce this issue? Or in any case describe the steps to reproduce along with any relevant artifacts (i.e. *.hbm.xml and/or *.reveng.xml files)?
> reveng *.java emitter does not escape java keyword 'return' as variable name
> ----------------------------------------------------------------------------
>
> Key: JBIDE-22283
> URL: https://issues.jboss.org/browse/JBIDE-22283
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: hibernate
> Affects Versions: 4.3.x
> Environment: Eclipse Mars
> Reporter: Darryl Miles
> Assignee: Koen Aers
> Fix For: 4.4.0.Alpha3
>
>
> reveng *.java emitter does not escape java keyword 'return' as variable name
> <table name="oc_return_history">
> <foreign-key constraint-name="FK_oc_return_history__return_id" foreign-table="oc_return">
> <column-ref local-column="return_id" foreign-column="return_id"/>
> <!-- this breaks the generator trying to name local variable as a java keyword -->
> <many-to-one property="return"/>
> </foreign-key>
> </table>
> The expected output would be:
> private Return _return;
> but actual output is:
> private Return return;
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 11 months
[JBoss JIRA] (JBIDE-22443) Add to TP build a check that produced TP can be installed in target Eclipse version
by Max Rydahl Andersen (JIRA)
[ https://issues.jboss.org/browse/JBIDE-22443?page=com.atlassian.jira.plugi... ]
Max Rydahl Andersen commented on JBIDE-22443:
---------------------------------------------
[~dgolovin] wouldn't a simple compile only build based on your old proposal on having a jenkins job running on a git submodules repo of all components been an excellent way to check this ?
> Add to TP build a check that produced TP can be installed in target Eclipse version
> -----------------------------------------------------------------------------------
>
> Key: JBIDE-22443
> URL: https://issues.jboss.org/browse/JBIDE-22443
> Project: Tools (JBoss Tools)
> Issue Type: Enhancement
> Components: build, target-platform
> Reporter: Mickael Istria
>
> Recently, a change in TP (jetty 9.3.6) was introduced and everything built fine with it; until the very end of the build process: during install-tests.
> This issue would *probably* have occured if trying to install all content of the TP into the target Eclipse IDE (using install-grinder or p2director or whatever installation). So it would be good to have inside the TP build (as a "verify" plugin in pom.xml) something that would try to find whether target Eclipse version and our TP are already compatible.
> Technical notes:
> * Trying to install all IUs from the release train site + our TP seems easier to implement
> * We do not need to actually install the artifacts, just making the p2 request and getting whether the request managed to find a working plan without remediation seems enough.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 11 months
[JBoss JIRA] (JBIDE-22443) Add to TP build a check that produced TP can be installed in target Eclipse version
by Denis Golovin (JIRA)
[ https://issues.jboss.org/browse/JBIDE-22443?page=com.atlassian.jira.plugi... ]
Denis Golovin commented on JBIDE-22443:
---------------------------------------
If we wold have a build to verify PR's for jbosstools-target-platforms this check would be good to verify PR.
> Add to TP build a check that produced TP can be installed in target Eclipse version
> -----------------------------------------------------------------------------------
>
> Key: JBIDE-22443
> URL: https://issues.jboss.org/browse/JBIDE-22443
> Project: Tools (JBoss Tools)
> Issue Type: Enhancement
> Components: build, target-platform
> Reporter: Mickael Istria
>
> Recently, a change in TP (jetty 9.3.6) was introduced and everything built fine with it; until the very end of the build process: during install-tests.
> This issue would *probably* have occured if trying to install all content of the TP into the target Eclipse IDE (using install-grinder or p2director or whatever installation). So it would be good to have inside the TP build (as a "verify" plugin in pom.xml) something that would try to find whether target Eclipse version and our TP are already compatible.
> Technical notes:
> * Trying to install all IUs from the release train site + our TP seems easier to implement
> * We do not need to actually install the artifacts, just making the p2 request and getting whether the request managed to find a working plan without remediation seems enough.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 11 months
[JBoss JIRA] (JBIDE-22443) Add to TP build a check that produced TP can be installed in target Eclipse version
by Mickael Istria (JIRA)
Mickael Istria created JBIDE-22443:
--------------------------------------
Summary: Add to TP build a check that produced TP can be installed in target Eclipse version
Key: JBIDE-22443
URL: https://issues.jboss.org/browse/JBIDE-22443
Project: Tools (JBoss Tools)
Issue Type: Enhancement
Components: build, target-platform
Reporter: Mickael Istria
Recently, a change in TP (jetty 9.3.6) was introduced and everything built fine with it; until the very end of the build process: during install-tests.
This issue would *probably* have occured if trying to install all content of the TP into the target Eclipse IDE (using install-grinder or p2director or whatever installation). So it would be good to have inside the TP build (as a "verify" plugin in pom.xml) something that would try to find whether target Eclipse version and our TP are already compatible.
Technical notes:
* Trying to install all IUs from the release train site + our TP seems easier to implement
* We do not need to actually install the artifacts, just making the p2 request and getting whether the request managed to find a working plan without remediation seems enough.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 11 months
[JBoss JIRA] (JBDS-3666) Back off and retry if download fails
by Denis Golovin (JIRA)
[ https://issues.jboss.org/browse/JBDS-3666?page=com.atlassian.jira.plugin.... ]
Denis Golovin updated JBDS-3666:
--------------------------------
Labels: Havoc new_and_noteworthy user-docs (was: Havoc)
> Back off and retry if download fails
> ------------------------------------
>
> Key: JBDS-3666
> URL: https://issues.jboss.org/browse/JBDS-3666
> Project: Red Hat Developer Studio (DevStudio)
> Issue Type: Story
> Components: platform-installer
> Affects Versions: 10.0.0.Alpha1
> Reporter: Pete Muir
> Assignee: Denis Golovin
> Priority: Critical
> Labels: Havoc, new_and_noteworthy, user-docs
> Fix For: 10.0.0.Alpha2
>
> Attachments: download-again.png
>
>
> We should back off and retry downloads when they fail, automatically. We should also off a manual retry button.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 11 months
[JBoss JIRA] (JBDS-3787) Installer - Installation of each component should be optional
by Denis Golovin (JIRA)
[ https://issues.jboss.org/browse/JBDS-3787?page=com.atlassian.jira.plugin.... ]
Denis Golovin updated JBDS-3787:
--------------------------------
Labels: havoc new_and_notworthy user-docs (was: havoc user-docs)
> Installer - Installation of each component should be optional
> -------------------------------------------------------------
>
> Key: JBDS-3787
> URL: https://issues.jboss.org/browse/JBDS-3787
> Project: Red Hat Developer Studio (DevStudio)
> Issue Type: Feature Request
> Components: platform-installer
> Affects Versions: 9.1.0.GA
> Reporter: Len DiMaggio
> Assignee: Denis Golovin
> Labels: havoc, new_and_notworthy, user-docs
> Fix For: 10.0.0.Alpha3
>
> Attachments: components are optional v1.png, components are optional v2.png, screenshot-1.png
>
>
> Feature request - It would be ideal of the installer allowed to the user to select to install/not install any of the installer's components (JDK, CDK, etc.)
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 11 months
[JBoss JIRA] (JBDS-3787) Installer - Installation of each component should be optional
by Denis Golovin (JIRA)
[ https://issues.jboss.org/browse/JBDS-3787?page=com.atlassian.jira.plugin.... ]
Denis Golovin updated JBDS-3787:
--------------------------------
Labels: havoc user-docs (was: havoc)
> Installer - Installation of each component should be optional
> -------------------------------------------------------------
>
> Key: JBDS-3787
> URL: https://issues.jboss.org/browse/JBDS-3787
> Project: Red Hat Developer Studio (DevStudio)
> Issue Type: Feature Request
> Components: platform-installer
> Affects Versions: 9.1.0.GA
> Reporter: Len DiMaggio
> Assignee: Denis Golovin
> Labels: havoc, user-docs
> Fix For: 10.0.0.Alpha3
>
> Attachments: components are optional v1.png, components are optional v2.png, screenshot-1.png
>
>
> Feature request - It would be ideal of the installer allowed to the user to select to install/not install any of the installer's components (JDK, CDK, etc.)
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 11 months