[JBoss JIRA] (JBIDE-22426) Connection: authorization strategy is always overwritten (in the client) upon #isConnected
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-22426?page=com.atlassian.jira.plugi... ]
Andre Dietisheim updated JBIDE-22426:
-------------------------------------
Story Points: 4 (was: 2)
> Connection: authorization strategy is always overwritten (in the client) upon #isConnected
> -------------------------------------------------------------------------------------------
>
> Key: JBIDE-22426
> URL: https://issues.jboss.org/browse/JBIDE-22426
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Affects Versions: 4.4.0.Alpha3
> Reporter: Andre Dietisheim
> Assignee: Andre Dietisheim
> Labels: connection, openshift_v3
> Fix For: 4.4.0.Alpha3
>
>
> The current implementation of Connection#isConnected() will always overwrite the authorization strategy in the client that it is using. This seems wrong given that #getResources, #createResource, #updateResource (and other methods) also set it but check if it already exists beforehand. Making sure that they dont overwrite an existing strategy.
> {code:title=Connection#isConnected}
> public boolean isConnected(IProgressMonitor monitor) {
> client.setAuthorizationStrategy(getAuthorizationStrategy());
> try {
> {code}
> {code:title=Connection#createResource}
> public <T extends IResource> T createResource(T resource) {
> try {
> if(client.getAuthorizationStrategy() == null) {
> client.setAuthorizationStrategy(getAuthorizationStrategy());
> }
> return client.create(resource);
> {code}
> A very likely side-effect of this is in Connection#ownsResource which compares clients (the one in the connection and the one attached to the given resource. The 2 clients are compared with the authorization strategy:
> {code:title=com.openshift.internal.restclient.DefaultClient#equals}
> @Override
> public boolean equals(Object obj) {
> ...
> return ObjectUtils.equals(strategy, other.strategy);
> {code}
> the lookup for a connection for a given resource in ConnectionRegistryUtils#safeGetConnectionFor will therefore fail after a Connection#isConnected:
> {code:title=ConnectionsRegistryUtil#safeGetConnectionFor(IResource)}
> public static Connection safeGetConnectionFor(IResource resource) {
> Collection<Connection> all = ConnectionsRegistrySingleton.getInstance().getAll(Connection.class);
> for (Connection connection : all) {
> if(connection.ownsResource(resource)) {
> return connection;
> }
> }
> return null;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 10 months
[JBoss JIRA] (ERT-147) NoClassDefFoundError below DockerConnection.open (567) [EBZ#479760]
by Jeff Johnston (JIRA)
[ https://issues.jboss.org/browse/ERT-147?page=com.atlassian.jira.plugin.sy... ]
Jeff Johnston reassigned ERT-147:
---------------------------------
Assignee: Jeff Johnston
> NoClassDefFoundError below DockerConnection.open (567) [EBZ#479760]
> -------------------------------------------------------------------
>
> Key: ERT-147
> URL: https://issues.jboss.org/browse/ERT-147
> Project: Eclipse Release Train
> Issue Type: Task
> Components: Linux Tools
> Reporter: Friendly Jira Robot
> Assignee: Jeff Johnston
> Labels: Docker, bzira
> Fix For: Neon (4.6) RC3
>
>
> The following incident was reported via the automated error reporting:
> code: 0
> plugin: org.eclipse.ui_3.107.0.v20150507-1945
> message: Unhandled event loop exception
> fingerprint: d15f65f8
> exception class: java.lang.NoClassDefFoundError
> exception message: Could not initialize class com.spotify.docker.client.DefaultDockerClient
> number of children: 0
>
> java.lang.NoClassDefFoundError: Could not initialize class com.spotify.docker.client.DefaultDockerClient
> at org.eclipse.linuxtools.internal.docker.core.DockerConnection.open(DockerConnection.java:567)
> at org.eclipse.linuxtools.docker.core.DockerConnectionManager.addConnection(DockerConnectionManager.java:193)
> at org.eclipse.linuxtools.internal.docker.ui.wizards.NewDockerConnection.performFinish(NewDockerConnection.java:47)
> at org.eclipse.jface.wizard.WizardDialog.finishPressed(WizardDialog.java:799)
> at org.eclipse.jface.wizard.WizardDialog.buttonPressed(WizardDialog.java:429)
> at org.eclipse.jface.dialogs.Dialog$2.widgetSelected(Dialog.java:619)
> at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:248)
> at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
> at org.eclipse.swt.widgets.Display.sendEvent(Display.java:4362)
> at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1113)
> at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:4180)
> at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3769)
> at org.eclipse.jface.window.Window.runEventLoop(Window.java:827)
> at org.eclipse.jface.window.Window.open(Window.java:803)
> at org.eclipse.linuxtools.internal.docker.ui.views.DockerExplorerView$3.widgetSelected(DockerExplorerView.java:214)
> at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:248)
> at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
> at org.eclipse.swt.widgets.Display.sendEvent(Display.java:4362)
> at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1113)
> at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1137)
> at org.eclipse.swt.widgets.Widget.sendSelectionEvent(Widget.java:1154)
> at org.eclipse.swt.widgets.Link.wmNotifyChild(Link.java:1093)
> at org.eclipse.swt.widgets.Control.wmNotify(Control.java:5690)
> at org.eclipse.swt.widgets.Composite.wmNotify(Composite.java:1956)
> at org.eclipse.swt.widgets.Control.WM_NOTIFY(Control.java:5242)
> at org.eclipse.swt.widgets.Control.windowProc(Control.java:4718)
> at org.eclipse.swt.widgets.Display.windowProc(Display.java:5063)
> at org.eclipse.swt.internal.win32.OS.CallWindowProcW(OS.java:-2)
> at org.eclipse.swt.internal.win32.OS.CallWindowProc(OS.java:2443)
> at org.eclipse.swt.widgets.Link.callWindowProc(Link.java:172)
> at org.eclipse.swt.widgets.Widget.wmLButtonUp(Widget.java:2131)
> at org.eclipse.swt.widgets.Control.WM_LBUTTONUP(Control.java:5055)
> at org.eclipse.swt.widgets.Link.WM_LBUTTONUP(Link.java:929)
> at org.eclipse.swt.widgets.Control.windowProc(Control.java:4699)
> at org.eclipse.swt.widgets.Display.windowProc(Display.java:5050)
> at org.eclipse.swt.internal.win32.OS.DispatchMessageW(OS.java:-2)
> at org.eclipse.swt.internal.win32.OS.DispatchMessage(OS.java:2549)
> at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3767)
> at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$4.run(PartRenderingEngine.java:1127)
> at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:337)
> at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.run(PartRenderingEngine.java:1018)
> at org.eclipse.e4.ui.internal.workbench.E4Workbench.createAndRunUI(E4Workbench.java:156)
> at org.eclipse.ui.internal.Workbench$5.run(Workbench.java:654)
> at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:337)
> at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:598)
> at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:150)
> at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:139)
> at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
> at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:134)
> at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:104)
> at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:380)
> at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:235)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(null:-2)
> at sun.reflect.NativeMethodAccessorImpl.invoke(null:-1)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(null:-1)
> at java.lang.reflect.Method.invoke(null:-1)
> at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:669)
> at org.eclipse.equinox.launcher.Main.basicRun(Main.java:608)
> at org.eclipse.equinox.launcher.Main.run(Main.java:1515)
> at org.eclipse.equinox.launcher.Main.main(Main.java:1488)
>
>
> General Information:
> reported-by:
> anonymous-id: 5c584b3c-8ede-44f7-808a-27758ef9938a
> eclipse-build-id: 4.5.0.I20150603-2000
> eclipse-product: org.eclipse.epp.package.cpp.product
> operating system: Windows7 6.1.0 (x86_64) - win32
> jre-version: 1.8.0_60-b27
> The following plug-ins were present on the execution stack (*):
> 1. org.eclipse.core.databinding.observable_1.5.0.v20150422-0725
> 2. org.eclipse.core.databinding_1.5.0.v20150422-0725
> 3. org.eclipse.core.runtime_3.11.0.v20150405-1723
> 4. org.eclipse.e4.ui.workbench_1.3.0.v20150531-1948
> 5. org.eclipse.e4.ui.workbench.swt_0.13.0.v20150504-0621
> 6. org.eclipse.equinox.app_1.3.300.v20150423-1356
> 7. org.eclipse.equinox.launcher_1.3.100.v20150511-1540
> 8. org.eclipse.jface_3.11.0.v20150602-1400
> 9. org.eclipse.linuxtools.docker.core_1.1.0.201509302202
> 10. org.eclipse.linuxtools.docker.ui_1.1.0.201509302202
> 11. org.eclipse.swt_3.104.0.v20150528-0211
> 12. org.eclipse.ui_3.107.0.v20150507-1945
> 13. org.eclipse.ui.ide.application_1.1.0.v20150422-0725
> 14. org.eclipse.ui.ide_3.11.0.v20150510-1749
> Please note that:
> * Messages, stacktraces, and nested status objects may be shortened.
> * Bug fields like status, resolution, and whiteboard are sent
> back to reporters.
> * The list of present bundles and their respective versions was
> calculated by package naming heuristics. This may or may not reflect reality.
> Other Resources:
> * Report: https://dev.eclipse.org/recommenders/committers/confess/#/problems/560d26...
> * Manual: https://dev.eclipse.org/recommenders/community/confess/#/guide
> Thank you for your assistance.
> Your friendly error-reports-inbox.
> This bug was created on behalf of xcoulon@xxxxxxxxxxxx.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 10 months
[JBoss JIRA] (ERT-147) NoClassDefFoundError below DockerConnection.open (567) [EBZ#479760]
by Jeff Johnston (JIRA)
[ https://issues.jboss.org/browse/ERT-147?page=com.atlassian.jira.plugin.sy... ]
Jeff Johnston resolved ERT-147.
-------------------------------
Fix Version/s: Neon (4.6) RC3
Resolution: Done
> NoClassDefFoundError below DockerConnection.open (567) [EBZ#479760]
> -------------------------------------------------------------------
>
> Key: ERT-147
> URL: https://issues.jboss.org/browse/ERT-147
> Project: Eclipse Release Train
> Issue Type: Task
> Components: Linux Tools
> Reporter: Friendly Jira Robot
> Assignee: Jeff Johnston
> Labels: Docker, bzira
> Fix For: Neon (4.6) RC3
>
>
> The following incident was reported via the automated error reporting:
> code: 0
> plugin: org.eclipse.ui_3.107.0.v20150507-1945
> message: Unhandled event loop exception
> fingerprint: d15f65f8
> exception class: java.lang.NoClassDefFoundError
> exception message: Could not initialize class com.spotify.docker.client.DefaultDockerClient
> number of children: 0
>
> java.lang.NoClassDefFoundError: Could not initialize class com.spotify.docker.client.DefaultDockerClient
> at org.eclipse.linuxtools.internal.docker.core.DockerConnection.open(DockerConnection.java:567)
> at org.eclipse.linuxtools.docker.core.DockerConnectionManager.addConnection(DockerConnectionManager.java:193)
> at org.eclipse.linuxtools.internal.docker.ui.wizards.NewDockerConnection.performFinish(NewDockerConnection.java:47)
> at org.eclipse.jface.wizard.WizardDialog.finishPressed(WizardDialog.java:799)
> at org.eclipse.jface.wizard.WizardDialog.buttonPressed(WizardDialog.java:429)
> at org.eclipse.jface.dialogs.Dialog$2.widgetSelected(Dialog.java:619)
> at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:248)
> at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
> at org.eclipse.swt.widgets.Display.sendEvent(Display.java:4362)
> at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1113)
> at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:4180)
> at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3769)
> at org.eclipse.jface.window.Window.runEventLoop(Window.java:827)
> at org.eclipse.jface.window.Window.open(Window.java:803)
> at org.eclipse.linuxtools.internal.docker.ui.views.DockerExplorerView$3.widgetSelected(DockerExplorerView.java:214)
> at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:248)
> at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
> at org.eclipse.swt.widgets.Display.sendEvent(Display.java:4362)
> at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1113)
> at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1137)
> at org.eclipse.swt.widgets.Widget.sendSelectionEvent(Widget.java:1154)
> at org.eclipse.swt.widgets.Link.wmNotifyChild(Link.java:1093)
> at org.eclipse.swt.widgets.Control.wmNotify(Control.java:5690)
> at org.eclipse.swt.widgets.Composite.wmNotify(Composite.java:1956)
> at org.eclipse.swt.widgets.Control.WM_NOTIFY(Control.java:5242)
> at org.eclipse.swt.widgets.Control.windowProc(Control.java:4718)
> at org.eclipse.swt.widgets.Display.windowProc(Display.java:5063)
> at org.eclipse.swt.internal.win32.OS.CallWindowProcW(OS.java:-2)
> at org.eclipse.swt.internal.win32.OS.CallWindowProc(OS.java:2443)
> at org.eclipse.swt.widgets.Link.callWindowProc(Link.java:172)
> at org.eclipse.swt.widgets.Widget.wmLButtonUp(Widget.java:2131)
> at org.eclipse.swt.widgets.Control.WM_LBUTTONUP(Control.java:5055)
> at org.eclipse.swt.widgets.Link.WM_LBUTTONUP(Link.java:929)
> at org.eclipse.swt.widgets.Control.windowProc(Control.java:4699)
> at org.eclipse.swt.widgets.Display.windowProc(Display.java:5050)
> at org.eclipse.swt.internal.win32.OS.DispatchMessageW(OS.java:-2)
> at org.eclipse.swt.internal.win32.OS.DispatchMessage(OS.java:2549)
> at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3767)
> at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$4.run(PartRenderingEngine.java:1127)
> at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:337)
> at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.run(PartRenderingEngine.java:1018)
> at org.eclipse.e4.ui.internal.workbench.E4Workbench.createAndRunUI(E4Workbench.java:156)
> at org.eclipse.ui.internal.Workbench$5.run(Workbench.java:654)
> at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:337)
> at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:598)
> at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:150)
> at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:139)
> at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
> at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:134)
> at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:104)
> at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:380)
> at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:235)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(null:-2)
> at sun.reflect.NativeMethodAccessorImpl.invoke(null:-1)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(null:-1)
> at java.lang.reflect.Method.invoke(null:-1)
> at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:669)
> at org.eclipse.equinox.launcher.Main.basicRun(Main.java:608)
> at org.eclipse.equinox.launcher.Main.run(Main.java:1515)
> at org.eclipse.equinox.launcher.Main.main(Main.java:1488)
>
>
> General Information:
> reported-by:
> anonymous-id: 5c584b3c-8ede-44f7-808a-27758ef9938a
> eclipse-build-id: 4.5.0.I20150603-2000
> eclipse-product: org.eclipse.epp.package.cpp.product
> operating system: Windows7 6.1.0 (x86_64) - win32
> jre-version: 1.8.0_60-b27
> The following plug-ins were present on the execution stack (*):
> 1. org.eclipse.core.databinding.observable_1.5.0.v20150422-0725
> 2. org.eclipse.core.databinding_1.5.0.v20150422-0725
> 3. org.eclipse.core.runtime_3.11.0.v20150405-1723
> 4. org.eclipse.e4.ui.workbench_1.3.0.v20150531-1948
> 5. org.eclipse.e4.ui.workbench.swt_0.13.0.v20150504-0621
> 6. org.eclipse.equinox.app_1.3.300.v20150423-1356
> 7. org.eclipse.equinox.launcher_1.3.100.v20150511-1540
> 8. org.eclipse.jface_3.11.0.v20150602-1400
> 9. org.eclipse.linuxtools.docker.core_1.1.0.201509302202
> 10. org.eclipse.linuxtools.docker.ui_1.1.0.201509302202
> 11. org.eclipse.swt_3.104.0.v20150528-0211
> 12. org.eclipse.ui_3.107.0.v20150507-1945
> 13. org.eclipse.ui.ide.application_1.1.0.v20150422-0725
> 14. org.eclipse.ui.ide_3.11.0.v20150510-1749
> Please note that:
> * Messages, stacktraces, and nested status objects may be shortened.
> * Bug fields like status, resolution, and whiteboard are sent
> back to reporters.
> * The list of present bundles and their respective versions was
> calculated by package naming heuristics. This may or may not reflect reality.
> Other Resources:
> * Report: https://dev.eclipse.org/recommenders/committers/confess/#/problems/560d26...
> * Manual: https://dev.eclipse.org/recommenders/community/confess/#/guide
> Thank you for your assistance.
> Your friendly error-reports-inbox.
> This bug was created on behalf of xcoulon@xxxxxxxxxxxx.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 10 months
[JBoss JIRA] (ERT-147) NoClassDefFoundError below DockerConnection.open (567) [EBZ#479760]
by Jeff Johnston (JIRA)
[ https://issues.jboss.org/browse/ERT-147?page=com.atlassian.jira.plugin.sy... ]
Jeff Johnston updated ERT-147:
------------------------------
Sprint: devex #115 May 2016
> NoClassDefFoundError below DockerConnection.open (567) [EBZ#479760]
> -------------------------------------------------------------------
>
> Key: ERT-147
> URL: https://issues.jboss.org/browse/ERT-147
> Project: Eclipse Release Train
> Issue Type: Task
> Components: Linux Tools
> Reporter: Friendly Jira Robot
> Labels: Docker, bzira
>
> The following incident was reported via the automated error reporting:
> code: 0
> plugin: org.eclipse.ui_3.107.0.v20150507-1945
> message: Unhandled event loop exception
> fingerprint: d15f65f8
> exception class: java.lang.NoClassDefFoundError
> exception message: Could not initialize class com.spotify.docker.client.DefaultDockerClient
> number of children: 0
>
> java.lang.NoClassDefFoundError: Could not initialize class com.spotify.docker.client.DefaultDockerClient
> at org.eclipse.linuxtools.internal.docker.core.DockerConnection.open(DockerConnection.java:567)
> at org.eclipse.linuxtools.docker.core.DockerConnectionManager.addConnection(DockerConnectionManager.java:193)
> at org.eclipse.linuxtools.internal.docker.ui.wizards.NewDockerConnection.performFinish(NewDockerConnection.java:47)
> at org.eclipse.jface.wizard.WizardDialog.finishPressed(WizardDialog.java:799)
> at org.eclipse.jface.wizard.WizardDialog.buttonPressed(WizardDialog.java:429)
> at org.eclipse.jface.dialogs.Dialog$2.widgetSelected(Dialog.java:619)
> at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:248)
> at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
> at org.eclipse.swt.widgets.Display.sendEvent(Display.java:4362)
> at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1113)
> at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:4180)
> at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3769)
> at org.eclipse.jface.window.Window.runEventLoop(Window.java:827)
> at org.eclipse.jface.window.Window.open(Window.java:803)
> at org.eclipse.linuxtools.internal.docker.ui.views.DockerExplorerView$3.widgetSelected(DockerExplorerView.java:214)
> at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:248)
> at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
> at org.eclipse.swt.widgets.Display.sendEvent(Display.java:4362)
> at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1113)
> at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1137)
> at org.eclipse.swt.widgets.Widget.sendSelectionEvent(Widget.java:1154)
> at org.eclipse.swt.widgets.Link.wmNotifyChild(Link.java:1093)
> at org.eclipse.swt.widgets.Control.wmNotify(Control.java:5690)
> at org.eclipse.swt.widgets.Composite.wmNotify(Composite.java:1956)
> at org.eclipse.swt.widgets.Control.WM_NOTIFY(Control.java:5242)
> at org.eclipse.swt.widgets.Control.windowProc(Control.java:4718)
> at org.eclipse.swt.widgets.Display.windowProc(Display.java:5063)
> at org.eclipse.swt.internal.win32.OS.CallWindowProcW(OS.java:-2)
> at org.eclipse.swt.internal.win32.OS.CallWindowProc(OS.java:2443)
> at org.eclipse.swt.widgets.Link.callWindowProc(Link.java:172)
> at org.eclipse.swt.widgets.Widget.wmLButtonUp(Widget.java:2131)
> at org.eclipse.swt.widgets.Control.WM_LBUTTONUP(Control.java:5055)
> at org.eclipse.swt.widgets.Link.WM_LBUTTONUP(Link.java:929)
> at org.eclipse.swt.widgets.Control.windowProc(Control.java:4699)
> at org.eclipse.swt.widgets.Display.windowProc(Display.java:5050)
> at org.eclipse.swt.internal.win32.OS.DispatchMessageW(OS.java:-2)
> at org.eclipse.swt.internal.win32.OS.DispatchMessage(OS.java:2549)
> at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3767)
> at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$4.run(PartRenderingEngine.java:1127)
> at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:337)
> at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.run(PartRenderingEngine.java:1018)
> at org.eclipse.e4.ui.internal.workbench.E4Workbench.createAndRunUI(E4Workbench.java:156)
> at org.eclipse.ui.internal.Workbench$5.run(Workbench.java:654)
> at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:337)
> at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:598)
> at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:150)
> at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:139)
> at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
> at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:134)
> at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:104)
> at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:380)
> at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:235)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(null:-2)
> at sun.reflect.NativeMethodAccessorImpl.invoke(null:-1)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(null:-1)
> at java.lang.reflect.Method.invoke(null:-1)
> at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:669)
> at org.eclipse.equinox.launcher.Main.basicRun(Main.java:608)
> at org.eclipse.equinox.launcher.Main.run(Main.java:1515)
> at org.eclipse.equinox.launcher.Main.main(Main.java:1488)
>
>
> General Information:
> reported-by:
> anonymous-id: 5c584b3c-8ede-44f7-808a-27758ef9938a
> eclipse-build-id: 4.5.0.I20150603-2000
> eclipse-product: org.eclipse.epp.package.cpp.product
> operating system: Windows7 6.1.0 (x86_64) - win32
> jre-version: 1.8.0_60-b27
> The following plug-ins were present on the execution stack (*):
> 1. org.eclipse.core.databinding.observable_1.5.0.v20150422-0725
> 2. org.eclipse.core.databinding_1.5.0.v20150422-0725
> 3. org.eclipse.core.runtime_3.11.0.v20150405-1723
> 4. org.eclipse.e4.ui.workbench_1.3.0.v20150531-1948
> 5. org.eclipse.e4.ui.workbench.swt_0.13.0.v20150504-0621
> 6. org.eclipse.equinox.app_1.3.300.v20150423-1356
> 7. org.eclipse.equinox.launcher_1.3.100.v20150511-1540
> 8. org.eclipse.jface_3.11.0.v20150602-1400
> 9. org.eclipse.linuxtools.docker.core_1.1.0.201509302202
> 10. org.eclipse.linuxtools.docker.ui_1.1.0.201509302202
> 11. org.eclipse.swt_3.104.0.v20150528-0211
> 12. org.eclipse.ui_3.107.0.v20150507-1945
> 13. org.eclipse.ui.ide.application_1.1.0.v20150422-0725
> 14. org.eclipse.ui.ide_3.11.0.v20150510-1749
> Please note that:
> * Messages, stacktraces, and nested status objects may be shortened.
> * Bug fields like status, resolution, and whiteboard are sent
> back to reporters.
> * The list of present bundles and their respective versions was
> calculated by package naming heuristics. This may or may not reflect reality.
> Other Resources:
> * Report: https://dev.eclipse.org/recommenders/committers/confess/#/problems/560d26...
> * Manual: https://dev.eclipse.org/recommenders/community/confess/#/guide
> Thank you for your assistance.
> Your friendly error-reports-inbox.
> This bug was created on behalf of xcoulon@xxxxxxxxxxxx.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 10 months
[JBoss JIRA] (JBIDE-22426) Connection: authorization strategy is always overwritten (in the client) upon #isConnected
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-22426?page=com.atlassian.jira.plugi... ]
Andre Dietisheim commented on JBIDE-22426:
------------------------------------------
these are internal changes and added tests. Nothing for QE to verify.
> Connection: authorization strategy is always overwritten (in the client) upon #isConnected
> -------------------------------------------------------------------------------------------
>
> Key: JBIDE-22426
> URL: https://issues.jboss.org/browse/JBIDE-22426
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Affects Versions: 4.4.0.Alpha3
> Reporter: Andre Dietisheim
> Assignee: Andre Dietisheim
> Labels: connection, openshift_v3
> Fix For: 4.4.0.Alpha3
>
>
> The current implementation of Connection#isConnected() will always overwrite the authorization strategy in the client that it is using. This seems wrong given that #getResources, #createResource, #updateResource (and other methods) also set it but check if it already exists beforehand. Making sure that they dont overwrite an existing strategy.
> {code:title=Connection#isConnected}
> public boolean isConnected(IProgressMonitor monitor) {
> client.setAuthorizationStrategy(getAuthorizationStrategy());
> try {
> {code}
> {code:title=Connection#createResource}
> public <T extends IResource> T createResource(T resource) {
> try {
> if(client.getAuthorizationStrategy() == null) {
> client.setAuthorizationStrategy(getAuthorizationStrategy());
> }
> return client.create(resource);
> {code}
> A very likely side-effect of this is in Connection#ownsResource which compares clients (the one in the connection and the one attached to the given resource. The 2 clients are compared with the authorization strategy:
> {code:title=com.openshift.internal.restclient.DefaultClient#equals}
> @Override
> public boolean equals(Object obj) {
> ...
> return ObjectUtils.equals(strategy, other.strategy);
> {code}
> the lookup for a connection for a given resource in ConnectionRegistryUtils#safeGetConnectionFor will therefore fail after a Connection#isConnected:
> {code:title=ConnectionsRegistryUtil#safeGetConnectionFor(IResource)}
> public static Connection safeGetConnectionFor(IResource resource) {
> Collection<Connection> all = ConnectionsRegistrySingleton.getInstance().getAll(Connection.class);
> for (Connection connection : all) {
> if(connection.ownsResource(resource)) {
> return connection;
> }
> }
> return null;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 10 months
[JBoss JIRA] (JBIDE-22426) Connection: authorization strategy is always overwritten (in the client) upon #isConnected
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-22426?page=com.atlassian.jira.plugi... ]
Andre Dietisheim edited comment on JBIDE-22426 at 5/25/16 5:11 PM:
-------------------------------------------------------------------
these are internal changes and added tests. Nothing for QE to verify, closing
was (Author: adietish):
these are internal changes and added tests. Nothing for QE to verify.
> Connection: authorization strategy is always overwritten (in the client) upon #isConnected
> -------------------------------------------------------------------------------------------
>
> Key: JBIDE-22426
> URL: https://issues.jboss.org/browse/JBIDE-22426
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Affects Versions: 4.4.0.Alpha3
> Reporter: Andre Dietisheim
> Assignee: Andre Dietisheim
> Labels: connection, openshift_v3
> Fix For: 4.4.0.Alpha3
>
>
> The current implementation of Connection#isConnected() will always overwrite the authorization strategy in the client that it is using. This seems wrong given that #getResources, #createResource, #updateResource (and other methods) also set it but check if it already exists beforehand. Making sure that they dont overwrite an existing strategy.
> {code:title=Connection#isConnected}
> public boolean isConnected(IProgressMonitor monitor) {
> client.setAuthorizationStrategy(getAuthorizationStrategy());
> try {
> {code}
> {code:title=Connection#createResource}
> public <T extends IResource> T createResource(T resource) {
> try {
> if(client.getAuthorizationStrategy() == null) {
> client.setAuthorizationStrategy(getAuthorizationStrategy());
> }
> return client.create(resource);
> {code}
> A very likely side-effect of this is in Connection#ownsResource which compares clients (the one in the connection and the one attached to the given resource. The 2 clients are compared with the authorization strategy:
> {code:title=com.openshift.internal.restclient.DefaultClient#equals}
> @Override
> public boolean equals(Object obj) {
> ...
> return ObjectUtils.equals(strategy, other.strategy);
> {code}
> the lookup for a connection for a given resource in ConnectionRegistryUtils#safeGetConnectionFor will therefore fail after a Connection#isConnected:
> {code:title=ConnectionsRegistryUtil#safeGetConnectionFor(IResource)}
> public static Connection safeGetConnectionFor(IResource resource) {
> Collection<Connection> all = ConnectionsRegistrySingleton.getInstance().getAll(Connection.class);
> for (Connection connection : all) {
> if(connection.ownsResource(resource)) {
> return connection;
> }
> }
> return null;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 10 months
[JBoss JIRA] (JBIDE-22426) Connection: authorization strategy is always overwritten (in the client) upon #isConnected
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-22426?page=com.atlassian.jira.plugi... ]
Andre Dietisheim closed JBIDE-22426.
------------------------------------
> Connection: authorization strategy is always overwritten (in the client) upon #isConnected
> -------------------------------------------------------------------------------------------
>
> Key: JBIDE-22426
> URL: https://issues.jboss.org/browse/JBIDE-22426
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Affects Versions: 4.4.0.Alpha3
> Reporter: Andre Dietisheim
> Assignee: Andre Dietisheim
> Labels: connection, openshift_v3
> Fix For: 4.4.0.Alpha3
>
>
> The current implementation of Connection#isConnected() will always overwrite the authorization strategy in the client that it is using. This seems wrong given that #getResources, #createResource, #updateResource (and other methods) also set it but check if it already exists beforehand. Making sure that they dont overwrite an existing strategy.
> {code:title=Connection#isConnected}
> public boolean isConnected(IProgressMonitor monitor) {
> client.setAuthorizationStrategy(getAuthorizationStrategy());
> try {
> {code}
> {code:title=Connection#createResource}
> public <T extends IResource> T createResource(T resource) {
> try {
> if(client.getAuthorizationStrategy() == null) {
> client.setAuthorizationStrategy(getAuthorizationStrategy());
> }
> return client.create(resource);
> {code}
> A very likely side-effect of this is in Connection#ownsResource which compares clients (the one in the connection and the one attached to the given resource. The 2 clients are compared with the authorization strategy:
> {code:title=com.openshift.internal.restclient.DefaultClient#equals}
> @Override
> public boolean equals(Object obj) {
> ...
> return ObjectUtils.equals(strategy, other.strategy);
> {code}
> the lookup for a connection for a given resource in ConnectionRegistryUtils#safeGetConnectionFor will therefore fail after a Connection#isConnected:
> {code:title=ConnectionsRegistryUtil#safeGetConnectionFor(IResource)}
> public static Connection safeGetConnectionFor(IResource resource) {
> Collection<Connection> all = ConnectionsRegistrySingleton.getInstance().getAll(Connection.class);
> for (Connection connection : all) {
> if(connection.ownsResource(resource)) {
> return connection;
> }
> }
> return null;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 10 months
[JBoss JIRA] (JBIDE-22426) Connection: authorization strategy is always overwritten (in the client) upon #isConnected
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-22426?page=com.atlassian.jira.plugi... ]
Andre Dietisheim commented on JBIDE-22426:
------------------------------------------
merged into master.
> Connection: authorization strategy is always overwritten (in the client) upon #isConnected
> -------------------------------------------------------------------------------------------
>
> Key: JBIDE-22426
> URL: https://issues.jboss.org/browse/JBIDE-22426
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Affects Versions: 4.4.0.Alpha3
> Reporter: Andre Dietisheim
> Assignee: Andre Dietisheim
> Labels: connection, openshift_v3
> Fix For: 4.4.0.Alpha3
>
>
> The current implementation of Connection#isConnected() will always overwrite the authorization strategy in the client that it is using. This seems wrong given that #getResources, #createResource, #updateResource (and other methods) also set it but check if it already exists beforehand. Making sure that they dont overwrite an existing strategy.
> {code:title=Connection#isConnected}
> public boolean isConnected(IProgressMonitor monitor) {
> client.setAuthorizationStrategy(getAuthorizationStrategy());
> try {
> {code}
> {code:title=Connection#createResource}
> public <T extends IResource> T createResource(T resource) {
> try {
> if(client.getAuthorizationStrategy() == null) {
> client.setAuthorizationStrategy(getAuthorizationStrategy());
> }
> return client.create(resource);
> {code}
> A very likely side-effect of this is in Connection#ownsResource which compares clients (the one in the connection and the one attached to the given resource. The 2 clients are compared with the authorization strategy:
> {code:title=com.openshift.internal.restclient.DefaultClient#equals}
> @Override
> public boolean equals(Object obj) {
> ...
> return ObjectUtils.equals(strategy, other.strategy);
> {code}
> the lookup for a connection for a given resource in ConnectionRegistryUtils#safeGetConnectionFor will therefore fail after a Connection#isConnected:
> {code:title=ConnectionsRegistryUtil#safeGetConnectionFor(IResource)}
> public static Connection safeGetConnectionFor(IResource resource) {
> Collection<Connection> all = ConnectionsRegistrySingleton.getInstance().getAll(Connection.class);
> for (Connection connection : all) {
> if(connection.ownsResource(resource)) {
> return connection;
> }
> }
> return null;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 10 months