[JBoss JIRA] (JBIDE-22656) Related tag background becomes misplaced when typing
by Alexey Kazakov (JIRA)
[ https://issues.jboss.org/browse/JBIDE-22656?page=com.atlassian.jira.plugi... ]
Alexey Kazakov updated JBIDE-22656:
-----------------------------------
Fix Version/s: 4.4.x
> Related tag background becomes misplaced when typing
> ----------------------------------------------------
>
> Key: JBIDE-22656
> URL: https://issues.jboss.org/browse/JBIDE-22656
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: freemarker
> Reporter: Daniel Dekany
> Fix For: 4.4.x
>
>
> When you put the cursor inside an FTL tag, like {{<#if ...>}}, the background color of related tags, like {{<#else>}} and {{</#if>}}, is changed. The problem is that if now you start typing into a such background-colored tag, the offsets of the colored sections after it will become outdated, and so they start to drift left from under the tag. This is because the up to date offsets only become available after the reconciling thread has finished, but the background coloring logic is called directly in the keydown handler. I'm not familiar with plugin development, but I suspect this is architecturally wrong. Perhaps the reconciler should send some kind of event when it's done, and if the editor content is still in the state for which the reconciling was ran, only then should the old background coloring be removed and the new one is added.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 9 months
[JBoss JIRA] (JBIDE-22656) Related tag background becomes misplaced when typing
by Daniel Dekany (JIRA)
[ https://issues.jboss.org/browse/JBIDE-22656?page=com.atlassian.jira.plugi... ]
Daniel Dekany updated JBIDE-22656:
----------------------------------
Description: When you put the cursor inside an FTL tag, like {{<#if ...>}}, the background color of related tags, like {{<#else>}} and {{</#if>}}, is changed. The problem is that if now you start typing into a such background-colored tag, the offsets of the colored sections after it will become outdated, and so they start to drift left from under the tag. This is because the up to date offsets only become available after the reconciling thread has finished, but the background coloring logic is called directly in the keydown handler. I'm not familiar with plugin development, but I suspect this is architecturally wrong. Perhaps the reconciler should send some kind of event when it's done, and if the editor content is still in the state for which the reconciling was ran, only then should the old background coloring be removed and the new one is added. (was: When you put the cursor inside an FTL tag, like {{<#if ...>}}, the background color of related tags (like {{<#else>}} and {{</#if>}}) is changed. The problem is that if now you start typing into a such background-colored tag, the offsets of the sections after it will become stale, and so they start to drift left from under the tag. This is because the up to date offsets only become available after the reconciling thread has finished, but the background coloring logic is called directly in the keydown handler. I'm not familiar with plugin development, but I suspect this is architecturally wrong. Perhaps the reconciler should send some kind of event when it's done, and if the editor content is still in the state for which the reconciling was ran, only then should the old background coloring be removed and the new one is added.)
> Related tag background becomes misplaced when typing
> ----------------------------------------------------
>
> Key: JBIDE-22656
> URL: https://issues.jboss.org/browse/JBIDE-22656
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: freemarker
> Reporter: Daniel Dekany
>
> When you put the cursor inside an FTL tag, like {{<#if ...>}}, the background color of related tags, like {{<#else>}} and {{</#if>}}, is changed. The problem is that if now you start typing into a such background-colored tag, the offsets of the colored sections after it will become outdated, and so they start to drift left from under the tag. This is because the up to date offsets only become available after the reconciling thread has finished, but the background coloring logic is called directly in the keydown handler. I'm not familiar with plugin development, but I suspect this is architecturally wrong. Perhaps the reconciler should send some kind of event when it's done, and if the editor content is still in the state for which the reconciling was ran, only then should the old background coloring be removed and the new one is added.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 9 months
[JBoss JIRA] (JBIDE-22656) Related tag background becomes misplaced when typing
by Daniel Dekany (JIRA)
[ https://issues.jboss.org/browse/JBIDE-22656?page=com.atlassian.jira.plugi... ]
Daniel Dekany updated JBIDE-22656:
----------------------------------
Summary: Related tag background becomes misplaced when typing (was: Related tag background becomes to misplaced when typing)
> Related tag background becomes misplaced when typing
> ----------------------------------------------------
>
> Key: JBIDE-22656
> URL: https://issues.jboss.org/browse/JBIDE-22656
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: freemarker
> Environment: When you put the cursor inside an FTL tag, like {{<#if ...>}}, the background color of related tags (like {{<#else>}} and {{</#if>}}) is changed. The problem is that if now you start typing into a such background-colored tag, the offsets of the sections after it will become stale, and so they start to drift left from under the tag. This is because the up to date offsets only become available after the reconciling thread has finished, but the background coloring logic is called directly in the keydown handler. I'm not familiar with plugin development, but I suspect this is architecturally wrong. Perhaps the reconciler should send some kind of event when it's done, and if the editor content is still in the state for which the reconciling was ran, only then should the old background coloring be removed and the new one is added.
> Reporter: Daniel Dekany
>
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 9 months
[JBoss JIRA] (JBIDE-22656) Related tag background becomes misplaced when typing
by Daniel Dekany (JIRA)
[ https://issues.jboss.org/browse/JBIDE-22656?page=com.atlassian.jira.plugi... ]
Daniel Dekany updated JBIDE-22656:
----------------------------------
Environment: (was: When you put the cursor inside an FTL tag, like {{<#if ...>}}, the background color of related tags (like {{<#else>}} and {{</#if>}}) is changed. The problem is that if now you start typing into a such background-colored tag, the offsets of the sections after it will become stale, and so they start to drift left from under the tag. This is because the up to date offsets only become available after the reconciling thread has finished, but the background coloring logic is called directly in the keydown handler. I'm not familiar with plugin development, but I suspect this is architecturally wrong. Perhaps the reconciler should send some kind of event when it's done, and if the editor content is still in the state for which the reconciling was ran, only then should the old background coloring be removed and the new one is added.)
> Related tag background becomes misplaced when typing
> ----------------------------------------------------
>
> Key: JBIDE-22656
> URL: https://issues.jboss.org/browse/JBIDE-22656
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: freemarker
> Reporter: Daniel Dekany
>
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 9 months
[JBoss JIRA] (JBIDE-22656) Related tag background becomes misplaced when typing
by Daniel Dekany (JIRA)
[ https://issues.jboss.org/browse/JBIDE-22656?page=com.atlassian.jira.plugi... ]
Daniel Dekany updated JBIDE-22656:
----------------------------------
Description: When you put the cursor inside an FTL tag, like {{<#if ...>}}, the background color of related tags (like {{<#else>}} and {{</#if>}}) is changed. The problem is that if now you start typing into a such background-colored tag, the offsets of the sections after it will become stale, and so they start to drift left from under the tag. This is because the up to date offsets only become available after the reconciling thread has finished, but the background coloring logic is called directly in the keydown handler. I'm not familiar with plugin development, but I suspect this is architecturally wrong. Perhaps the reconciler should send some kind of event when it's done, and if the editor content is still in the state for which the reconciling was ran, only then should the old background coloring be removed and the new one is added.
> Related tag background becomes misplaced when typing
> ----------------------------------------------------
>
> Key: JBIDE-22656
> URL: https://issues.jboss.org/browse/JBIDE-22656
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: freemarker
> Reporter: Daniel Dekany
>
> When you put the cursor inside an FTL tag, like {{<#if ...>}}, the background color of related tags (like {{<#else>}} and {{</#if>}}) is changed. The problem is that if now you start typing into a such background-colored tag, the offsets of the sections after it will become stale, and so they start to drift left from under the tag. This is because the up to date offsets only become available after the reconciling thread has finished, but the background coloring logic is called directly in the keydown handler. I'm not familiar with plugin development, but I suspect this is architecturally wrong. Perhaps the reconciler should send some kind of event when it's done, and if the editor content is still in the state for which the reconciling was ran, only then should the old background coloring be removed and the new one is added.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 9 months
[JBoss JIRA] (JBIDE-22656) Related tag background becomes to misplaced when typing
by Daniel Dekany (JIRA)
Daniel Dekany created JBIDE-22656:
-------------------------------------
Summary: Related tag background becomes to misplaced when typing
Key: JBIDE-22656
URL: https://issues.jboss.org/browse/JBIDE-22656
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: freemarker
Environment: When you put the cursor inside an FTL tag, like {{<#if ...>}}, the background color of related tags (like {{<#else>}} and {{</#if>}}) is changed. The problem is that if now you start typing into a such background-colored tag, the offsets of the sections after it will become stale, and so they start to drift left from under the tag. This is because the up to date offsets only become available after the reconciling thread has finished, but the background coloring logic is called directly in the keydown handler. I'm not familiar with plugin development, but I suspect this is architecturally wrong. Perhaps the reconciler should send some kind of event when it's done, and if the editor content is still in the state for which the reconciling was ran, only then should the old background coloring be removed and the new one is added.
Reporter: Daniel Dekany
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 9 months
[JBoss JIRA] (JBIDE-22614) NPE in CDIProject.rebuildXML(CDIProject.java:1458)
by Alexey Kazakov (JIRA)
[ https://issues.jboss.org/browse/JBIDE-22614?page=com.atlassian.jira.plugi... ]
Alexey Kazakov updated JBIDE-22614:
-----------------------------------
Fix Version/s: 4.4.1.M1
(was: 4.4.x)
> NPE in CDIProject.rebuildXML(CDIProject.java:1458)
> --------------------------------------------------
>
> Key: JBIDE-22614
> URL: https://issues.jboss.org/browse/JBIDE-22614
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: cdi
> Reporter: Aurélien Pupier
> Assignee: Viacheslav Kabanovich
> Fix For: 4.4.1.M1
>
>
> I'm currently trying to write some integration tests and found this NPE in log.
> {noformat}
> !ENTRY org.eclipse.core.resources 4 2 2016-06-17 15:43:54.521
> !MESSAGE Problems occurred when invoking code from plug-in: "org.eclipse.core.resources".
> !STACK 0
> java.lang.NullPointerException
> at org.jboss.tools.cdi.internal.core.impl.CDIProject.rebuildXML(CDIProject.java:1458)
> at org.jboss.tools.cdi.internal.core.impl.CDIProject.update(CDIProject.java:1214)
> at org.jboss.tools.cdi.internal.core.impl.definition.DefinitionContext.applyWorkingCopy(DefinitionContext.java:442)
> at org.jboss.tools.cdi.core.CDICoreBuilder.build(CDICoreBuilder.java:267)
> at org.eclipse.core.internal.events.BuildManager$2.run(BuildManager.java:734)
> at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42)
> at org.eclipse.core.internal.events.BuildManager.basicBuild(BuildManager.java:205)
> at org.eclipse.core.internal.events.BuildManager.basicBuild(BuildManager.java:245)
> at org.eclipse.core.internal.events.BuildManager$1.run(BuildManager.java:300)
> at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42)
> at org.eclipse.core.internal.events.BuildManager.basicBuild(BuildManager.java:303)
> at org.eclipse.core.internal.events.BuildManager.basicBuildLoop(BuildManager.java:359)
> at org.eclipse.core.internal.events.BuildManager.build(BuildManager.java:382)
> at org.eclipse.core.internal.events.AutoBuildJob.doBuild(AutoBuildJob.java:144)
> at org.eclipse.core.internal.events.AutoBuildJob.run(AutoBuildJob.java:235)
> at org.eclipse.core.internal.jobs.Worker.run(Worker.java:55)
> {noformat}
> i'm not sure about the impact yet.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 9 months