August 2016 - jbosstools-issues - Jboss List Archives

[JBoss JIRA] (JBIDE-22756) Connection: varioius weirdness in token/password

by Andre Dietisheim (JIRA)

[ https://issues.jboss.org/browse/JBIDE-22756?page=com.atlassian.jira.plugi... ] Andre Dietisheim updated JBIDE-22756: ------------------------------------- Fix Version/s: 4.4.x (was: 4.4.1.AM3) > Connection: varioius weirdness in token/password > ------------------------------------------------- > > Key: JBIDE-22756 > URL: https://issues.jboss.org/browse/JBIDE-22756 > Project: Tools (JBoss Tools) > Issue Type: Task > Components: openshift > Affects Versions: 4.4.1.AM2 > Reporter: Andre Dietisheim > Labels: connection > Fix For: 4.4.x > > > The lifecycle of the token is rather weird and needs a consistent logic: > When connecting via wizard the token is set in the connection wizard: > {code:title=ConnectionWizardPageModel#connect} > ... > try { > IConnection connection = createConnection(connectionFactory, connectionAuthenticationProvider); > ... > {code} > {code:title=ConnectionWizardPageModel#createConnection} > ... > if (authProvider != null) { > authProvider.update(connection); // sets the token > } > ... > {code} > {code:title=BearTokenAuthenticationProvider#update} > ... > connection.setAuthScheme(IAuthorizationContext.AUTHSCHEME_OAUTH); > connection.setToken(tokenObservable.getValue()); > connection.setRememberToken(rememberTokenObservable.getValue()); > ... > {code} > {code:title=Connection#connect} > if(authorize()) { > ... > {code} > {code:title=Connection#authorized} > ... > if (context.isAuthorized()) { > String username = context.getUser().getName(); > String token = context.getToken(); > updateAuthorized(username, token); > } else { > ... > {code} > The token is then fetched from client and set to the connection > {code:title=Connection#updateAuthorized} > setToken(token); > ... > {code} > and the password is cleared > {code:Connectoin#savePasswordOrToken} > } else if (IAuthorizationContext.AUTHSCHEME_OAUTH.equals(getAuthScheme())){ > boolean success = saveOrClear(SECURE_STORAGE_TOKEN_KEY, this.token, isRememberToken()); > if(success) { > //Avoid second secure storage prompt. > //Token is stored, password should be cleared. > clearPassword(); > {code} > I suspect the aim here is to clear existing password in secure storage if the user is switching password->token based auth (and vice versa) > The opposite is then not fully congruent. The token is only cleared in secure storage, not in Connection instance var > {code:title=Connection#savePasswordOrToken} > if (IAuthorizationContext.AUTHSCHEME_BASIC.equals(getAuthScheme())) { > boolean success = saveOrClear(SECURE_STORAGE_PASSWORD_KEY, this.password, isRememberPassword()); > if (success) { > //Avoid second secure storage prompt. > // Password is stored, token should be cleared. > clearToken(); > } > {code:Connection#clearToken} > // dont clear the token instance var: JBIDE-22594 > setRememberToken(false); > saveOrClear(SECURE_STORAGE_TOKEN_KEY, null, false); > {code} > I suspect that we should only clear in secure storage, not in the Connection instance as we see in JBIDE-22594 (for the opposite case where we dont clear the token in the Connection instance). But then one has to keep in mind that all auth is token based. Even if you auth via password initially, the auth is then switched to token based once the authorization succeeded and we got a token: > {code:title=Connection#updateAuthorized} > setToken(token); > if (IAuthorizationContext.AUTHSCHEME_OAUTH.equalsIgnoreCase(getAuthScheme())) { > setUsername(username); > } > // force auth strategy to token if authorized > TokenAuthorizationStrategy tokenStrategy = new TokenAuthorizationStrategy(token, username); > client.setAuthorizationStrategy(tokenStrategy); > {code} > Another issue is that the connection and the auth schemeare both stored in different classes. The connection is stored via > {code:title=ConnectionPersistency#persist} > preferences.saveConnections(connections.keySet().toArray(new String[] {})); > ... > {code} > while the auth scheme is stored in Connection#saveAuthSchemePreference: > {code:title=Connection#connect} > saveAuthSchemePreference(); > {code} -- This message was sent by Atlassian JIRA (v6.4.11#64026)

9 years, 8 months

1
0
0 / 0

[JBoss JIRA] (JBIDE-22376) Enable JMX when entering Debug mode

by Andre Dietisheim (JIRA)

[ https://issues.jboss.org/browse/JBIDE-22376?page=com.atlassian.jira.plugi... ] Andre Dietisheim updated JBIDE-22376: ------------------------------------- Fix Version/s: 4.4.1.Final (was: 4.4.1.AM3) > Enable JMX when entering Debug mode > ----------------------------------- > > Key: JBIDE-22376 > URL: https://issues.jboss.org/browse/JBIDE-22376 > Project: Tools (JBoss Tools) > Issue Type: Enhancement > Components: openshift > Affects Versions: 4.1.1.Beta1 > Reporter: Thomas Mäder > Assignee: Fred Bricon > Fix For: 4.4.1.Final > > > We need to update the deployment configuration when entering debug mode. It is not entirely clear how to determine that an Openshift Pod has indeed a wildfly/EAP in it and can be reached with remoting-jmx -- This message was sent by Atlassian JIRA (v6.4.11#64026)

9 years, 8 months

1
0
0 / 0

[JBoss JIRA] (JBIDE-22727) Openshift resources managed by explorer and watcher are declared in both place leading to inconsistency

by Andre Dietisheim (JIRA)

[ https://issues.jboss.org/browse/JBIDE-22727?page=com.atlassian.jira.plugi... ] Andre Dietisheim updated JBIDE-22727: ------------------------------------- Sprint: devex #119 August 2016 (was: devex #118 July 2016) > Openshift resources managed by explorer and watcher are declared in both place leading to inconsistency > ------------------------------------------------------------------------------------------------------- > > Key: JBIDE-22727 > URL: https://issues.jboss.org/browse/JBIDE-22727 > Project: Tools (JBoss Tools) > Issue Type: Bug > Components: openshift > Affects Versions: 4.4.1.AM1 > Reporter: Jeff MAURY > Assignee: Dmitry Bocharov > Labels: explorer, openshift, openshift_v3 > Fix For: 4.4.1.Final > > > The kind of Openshift resources are declated in 2 different places: WatchManager and ConnectionWrapper. This increases the technical debt and may lead to resources displayed by the explorer but not refreshed by the watcher. > The task requires investigation about ResourceKind.IMAGE_STREAM_TAG, which is present in ConnectionWrapper, but there is no such element in WatchManager's array. See discussion [here|https://github.com/jbosstools/jbosstools-openshift/pull/1272#discuss...] -- This message was sent by Atlassian JIRA (v6.4.11#64026)

9 years, 8 months

1
0
0 / 0

[JBoss JIRA] (JBIDE-22727) Openshift resources managed by explorer and watcher are declared in both place leading to inconsistency

by Andre Dietisheim (JIRA)

[ https://issues.jboss.org/browse/JBIDE-22727?page=com.atlassian.jira.plugi... ] Andre Dietisheim updated JBIDE-22727: ------------------------------------- Fix Version/s: 4.4.1.Final (was: 4.4.1.AM3) > Openshift resources managed by explorer and watcher are declared in both place leading to inconsistency > ------------------------------------------------------------------------------------------------------- > > Key: JBIDE-22727 > URL: https://issues.jboss.org/browse/JBIDE-22727 > Project: Tools (JBoss Tools) > Issue Type: Bug > Components: openshift > Affects Versions: 4.4.1.AM1 > Reporter: Jeff MAURY > Assignee: Dmitry Bocharov > Labels: explorer, openshift, openshift_v3 > Fix For: 4.4.1.Final > > > The kind of Openshift resources are declated in 2 different places: WatchManager and ConnectionWrapper. This increases the technical debt and may lead to resources displayed by the explorer but not refreshed by the watcher. > The task requires investigation about ResourceKind.IMAGE_STREAM_TAG, which is present in ConnectionWrapper, but there is no such element in WatchManager's array. See discussion [here|https://github.com/jbosstools/jbosstools-openshift/pull/1272#discuss...] -- This message was sent by Atlassian JIRA (v6.4.11#64026)

9 years, 8 months

1
0
0 / 0

[JBoss JIRA] (JBIDE-22650) When starting an OS3 server adapter from scratch, error is reported although connection can be established

by Andre Dietisheim (JIRA)

[ https://issues.jboss.org/browse/JBIDE-22650?page=com.atlassian.jira.plugi... ] Andre Dietisheim edited comment on JBIDE-22650 at 8/12/16 11:42 AM: -------------------------------------------------------------------- tried again, cant reproduce it in current master either (4.4.1.AM3) Resolving as CANT_REPRODUCE was (Author: adietish): tried again, cant reproduce it in current master either (4.4.1.AM3) > When starting an OS3 server adapter from scratch, error is reported although connection can be established > ---------------------------------------------------------------------------------------------------------- > > Key: JBIDE-22650 > URL: https://issues.jboss.org/browse/JBIDE-22650 > Project: Tools (JBoss Tools) > Issue Type: Bug > Components: openshift, server > Affects Versions: 4.4.0.Final > Reporter: Jeff MAURY > Assignee: Andre Dietisheim > Fix For: 4.4.1.AM3 > > Attachments: screenshot-1.png > > > ASSERT: create an OS3 connection without password saved > ASSERT: create an OS3 server adapter > EXEC: restart Eclipse > EXEC: start the OS3 server adapter and give correct password > ASSERT: error is reported [^screenshot-1.png] -- This message was sent by Atlassian JIRA (v6.4.11#64026)

9 years, 8 months

1
0
0 / 0

[JBoss JIRA] (JBIDE-22650) When starting an OS3 server adapter from scratch, error is reported although connection can be established

by Andre Dietisheim (JIRA)

[ https://issues.jboss.org/browse/JBIDE-22650?page=com.atlassian.jira.plugi... ] Andre Dietisheim resolved JBIDE-22650. -------------------------------------- Resolution: Cannot Reproduce Bug > When starting an OS3 server adapter from scratch, error is reported although connection can be established > ---------------------------------------------------------------------------------------------------------- > > Key: JBIDE-22650 > URL: https://issues.jboss.org/browse/JBIDE-22650 > Project: Tools (JBoss Tools) > Issue Type: Bug > Components: openshift, server > Affects Versions: 4.4.0.Final > Reporter: Jeff MAURY > Assignee: Andre Dietisheim > Fix For: 4.4.1.AM3 > > Attachments: screenshot-1.png > > > ASSERT: create an OS3 connection without password saved > ASSERT: create an OS3 server adapter > EXEC: restart Eclipse > EXEC: start the OS3 server adapter and give correct password > ASSERT: error is reported [^screenshot-1.png] -- This message was sent by Atlassian JIRA (v6.4.11#64026)

9 years, 8 months

1
0
0 / 0

[JBoss JIRA] (JBIDE-22613) Connection wizard: When a connection is configured with a stored token, switching back with basic will fail if token is invalid

by Andre Dietisheim (JIRA)

[ https://issues.jboss.org/browse/JBIDE-22613?page=com.atlassian.jira.plugi... ] Andre Dietisheim updated JBIDE-22613: ------------------------------------- Fix Version/s: 4.4.1.Final (was: 4.4.1.AM3) > Connection wizard: When a connection is configured with a stored token, switching back with basic will fail if token is invalid > ------------------------------------------------------------------------------------------------------------------------------- > > Key: JBIDE-22613 > URL: https://issues.jboss.org/browse/JBIDE-22613 > Project: Tools (JBoss Tools) > Issue Type: Bug > Components: openshift > Affects Versions: 4.4.0.Final > Reporter: Jeff MAURY > Labels: connection, connection_wizard, openshift_v3 > Fix For: 4.4.1.Final > > > If an Openshift is configured with a OAuth and a stored token, if you want to switch back to basic, the connection will fail because the connection is still made using Oauth -- This message was sent by Atlassian JIRA (v6.4.11#64026)

9 years, 8 months

1
0
0 / 0

[JBoss JIRA] (ERT-240) Expose the ImagePushProgressHandler in the API packages [EBZ#495251]

by Jeff Johnston (JIRA)

[ https://issues.jboss.org/browse/ERT-240?page=com.atlassian.jira.plugin.sy... ] Jeff Johnston resolved ERT-240. ------------------------------- Fix Version/s: Neon.1 (4.6) Resolution: Done > Expose the ImagePushProgressHandler in the API packages [EBZ#495251] > -------------------------------------------------------------------- > > Key: ERT-240 > URL: https://issues.jboss.org/browse/ERT-240 > Project: Eclipse Release Train > Issue Type: Task > Components: Linux Tools > Reporter: Friendly Jira Robot > Assignee: Jeff Johnston > Labels: Docker, bzira > Fix For: Neon.1 (4.6) > > > So it can be used by the OpenShift tooling when using one of the IDockerConnection#push(...) methods -- This message was sent by Atlassian JIRA (v6.4.11#64026)

9 years, 8 months

1
0
0 / 0

[JBoss JIRA] (JBIDE-22650) When starting an OS3 server adapter from scratch, error is reported although connection can be established

by Andre Dietisheim (JIRA)

[ https://issues.jboss.org/browse/JBIDE-22650?page=com.atlassian.jira.plugi... ] Andre Dietisheim reassigned JBIDE-22650: ---------------------------------------- Assignee: Andre Dietisheim > When starting an OS3 server adapter from scratch, error is reported although connection can be established > ---------------------------------------------------------------------------------------------------------- > > Key: JBIDE-22650 > URL: https://issues.jboss.org/browse/JBIDE-22650 > Project: Tools (JBoss Tools) > Issue Type: Bug > Components: openshift, server > Affects Versions: 4.4.0.Final > Reporter: Jeff MAURY > Assignee: Andre Dietisheim > Fix For: 4.4.1.AM3 > > Attachments: screenshot-1.png > > > ASSERT: create an OS3 connection without password saved > ASSERT: create an OS3 server adapter > EXEC: restart Eclipse > EXEC: start the OS3 server adapter and give correct password > ASSERT: error is reported [^screenshot-1.png] -- This message was sent by Atlassian JIRA (v6.4.11#64026)

9 years, 8 months

1
0
0 / 0

[JBoss JIRA] (JBIDE-22650) When starting an OS3 server adapter from scratch, error is reported although connection can be established

by Andre Dietisheim (JIRA)

[ https://issues.jboss.org/browse/JBIDE-22650?page=com.atlassian.jira.plugi... ] Andre Dietisheim commented on JBIDE-22650: ------------------------------------------ tried again, cant reproduce it in current master either (4.4.1.AM3) > When starting an OS3 server adapter from scratch, error is reported although connection can be established > ---------------------------------------------------------------------------------------------------------- > > Key: JBIDE-22650 > URL: https://issues.jboss.org/browse/JBIDE-22650 > Project: Tools (JBoss Tools) > Issue Type: Bug > Components: openshift, server > Affects Versions: 4.4.0.Final > Reporter: Jeff MAURY > Assignee: Andre Dietisheim > Fix For: 4.4.1.AM3 > > Attachments: screenshot-1.png > > > ASSERT: create an OS3 connection without password saved > ASSERT: create an OS3 server adapter > EXEC: restart Eclipse > EXEC: start the OS3 server adapter and give correct password > ASSERT: error is reported [^screenshot-1.png] -- This message was sent by Atlassian JIRA (v6.4.11#64026)

9 years, 8 months

1
0
0 / 0

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

jbosstools-issues August 2016