[JBoss JIRA] (JBIDE-23040) NPE in ELReference when validating non-synchronized resources
by Viacheslav Kabanovich (JIRA)
[ https://issues.jboss.org/browse/JBIDE-23040?page=com.atlassian.jira.plugi... ]
Viacheslav Kabanovich updated JBIDE-23040:
------------------------------------------
Description:
Open in Eclipse workspace with a jsf project. Open one of page files in an external editor and modify it. Do not open the file in an editor inside Eclipse. Rebuild project.
{code}
org.jboss.tools.common.validation.JBTValidationException
at org.jboss.tools.common.validation.ValidatorManager.validate(ValidatorManager.java:147)
at org.jboss.tools.common.validation.ValidatorManager.validateInJob(ValidatorManager.java:81)
at org.eclipse.wst.validation.internal.core.ValidatorLauncher.start(ValidatorLauncher.java:77)
at org.eclipse.wst.validation.Validator$V1.validate(Validator.java:768)
at org.eclipse.wst.validation.Validator.validate(Validator.java:405)
at org.eclipse.wst.validation.internal.ValManager.validate(ValManager.java:704)
at org.eclipse.wst.validation.internal.ValManager$1.visit(ValManager.java:665)
at org.eclipse.wst.validation.internal.ValManager.accept(ValManager.java:810)
at org.eclipse.wst.validation.internal.ValManager.validate(ValManager.java:669)
at org.eclipse.wst.validation.internal.ValidationRunner.execute(ValidationRunner.java:134)
at org.eclipse.wst.validation.internal.ValidationRunner.validate(ValidationRunner.java:68)
at org.eclipse.wst.validation.ui.internal.ManualValidationRunner.runInWorkspace(ManualValidationRunner.java:83)
at org.eclipse.core.internal.resources.InternalWorkspaceJob.run(InternalWorkspaceJob.java:39)
at org.eclipse.core.internal.jobs.Worker.run(Worker.java:55)
Caused by: java.lang.NullPointerException
at org.jboss.tools.common.el.core.ELReference.getText(ELReference.java:175)
at org.jboss.tools.common.el.core.ELReference.getSourceText(ELReference.java:134)
at org.jboss.tools.common.el.core.ELReference.getEl(ELReference.java:164)
at org.jboss.tools.jst.web.kb.internal.validation.ELValidator.validateEL(ELValidator.java:336)
at org.jboss.tools.jst.web.kb.internal.validation.ELValidator.validate(ELValidator.java:209)
at org.jboss.tools.common.validation.ValidatorManager.validate(ValidatorManager.java:140)
... 13 more
{code}
If the file is open in editor in Eclipse, its content is stored in a buffer, and method FileUtil.getContentFromEditorOrFile(IFile) takes it from the buffer. When the file was not open in editor in Eclipse, the content is not buffered, and the method accesses the file but fails if it is not synchronized. However, clients of the method (e.g. search) may need the content even if the file is not synchronized in order to check its relevance and report synchronization problem only if the case is relevant. As it is, an error is logged now any time when user's resources are not synchronized. So, I suggest not only checking for null in ELReference but also returning in FileUtil.getContentFromEditorOrFile(IFile) content from the file on disk (if it exists) for not synchronized files.
> NPE in ELReference when validating non-synchronized resources
> -------------------------------------------------------------
>
> Key: JBIDE-23040
> URL: https://issues.jboss.org/browse/JBIDE-23040
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: common/jst/core
> Affects Versions: 4.4.1.AM3
> Reporter: Viacheslav Kabanovich
> Assignee: Viacheslav Kabanovich
>
> Open in Eclipse workspace with a jsf project. Open one of page files in an external editor and modify it. Do not open the file in an editor inside Eclipse. Rebuild project.
> {code}
> org.jboss.tools.common.validation.JBTValidationException
> at org.jboss.tools.common.validation.ValidatorManager.validate(ValidatorManager.java:147)
> at org.jboss.tools.common.validation.ValidatorManager.validateInJob(ValidatorManager.java:81)
> at org.eclipse.wst.validation.internal.core.ValidatorLauncher.start(ValidatorLauncher.java:77)
> at org.eclipse.wst.validation.Validator$V1.validate(Validator.java:768)
> at org.eclipse.wst.validation.Validator.validate(Validator.java:405)
> at org.eclipse.wst.validation.internal.ValManager.validate(ValManager.java:704)
> at org.eclipse.wst.validation.internal.ValManager$1.visit(ValManager.java:665)
> at org.eclipse.wst.validation.internal.ValManager.accept(ValManager.java:810)
> at org.eclipse.wst.validation.internal.ValManager.validate(ValManager.java:669)
> at org.eclipse.wst.validation.internal.ValidationRunner.execute(ValidationRunner.java:134)
> at org.eclipse.wst.validation.internal.ValidationRunner.validate(ValidationRunner.java:68)
> at org.eclipse.wst.validation.ui.internal.ManualValidationRunner.runInWorkspace(ManualValidationRunner.java:83)
> at org.eclipse.core.internal.resources.InternalWorkspaceJob.run(InternalWorkspaceJob.java:39)
> at org.eclipse.core.internal.jobs.Worker.run(Worker.java:55)
> Caused by: java.lang.NullPointerException
> at org.jboss.tools.common.el.core.ELReference.getText(ELReference.java:175)
> at org.jboss.tools.common.el.core.ELReference.getSourceText(ELReference.java:134)
> at org.jboss.tools.common.el.core.ELReference.getEl(ELReference.java:164)
> at org.jboss.tools.jst.web.kb.internal.validation.ELValidator.validateEL(ELValidator.java:336)
> at org.jboss.tools.jst.web.kb.internal.validation.ELValidator.validate(ELValidator.java:209)
> at org.jboss.tools.common.validation.ValidatorManager.validate(ValidatorManager.java:140)
> ... 13 more
> {code}
> If the file is open in editor in Eclipse, its content is stored in a buffer, and method FileUtil.getContentFromEditorOrFile(IFile) takes it from the buffer. When the file was not open in editor in Eclipse, the content is not buffered, and the method accesses the file but fails if it is not synchronized. However, clients of the method (e.g. search) may need the content even if the file is not synchronized in order to check its relevance and report synchronization problem only if the case is relevant. As it is, an error is logged now any time when user's resources are not synchronized. So, I suggest not only checking for null in ELReference but also returning in FileUtil.getContentFromEditorOrFile(IFile) content from the file on disk (if it exists) for not synchronized files.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 7 months
[JBoss JIRA] (JBDS-3981) Build a new feature that omits features available from RPM install
by Nick Boldt (JIRA)
[ https://issues.jboss.org/browse/JBDS-3981?page=com.atlassian.jira.plugin.... ]
Nick Boldt commented on JBDS-3981:
----------------------------------
Build successful on wonka, after some fancy footwork to get eclipse installed.
http://wonka.mw.lab.eng.bos.redhat.com/RHDS/10.0/snapshots/builds/2016082...
> Build a new feature that omits features available from RPM install
> ------------------------------------------------------------------
>
> Key: JBDS-3981
> URL: https://issues.jboss.org/browse/JBDS-3981
> Project: Red Hat JBoss Developer Studio (devstudio)
> Issue Type: Bug
> Components: build, updatesite
> Affects Versions: 10.1.0.AM2
> Reporter: Nick Boldt
> Assignee: Nick Boldt
> Fix For: 10.1.0.GA
>
> Attachments: IUs-removed-from-rh-eclipse46-devstudio.rpm.txt, IUs-removed-from-rh-eclipse46-devstudio.rpm_more.txt, rh-eclipse46-devstudio.provides.list.01, rh-eclipse46-devstudio.provides.list.02, simpler_install_foorprint_rh-eclipse46-devstudio.rpm.png, simpler_install_foorprint_rh-eclipse46-devstudio.rpm_2.png, simpler_install_foorprint_rh-eclipse46-devstudio.rpm_3.png
>
>
> What we DO need is a feature with fewer dependencies than com.jboss.devstudio.core.feature (eg., which omits pde, emf, xsd, egit...)
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 7 months
[JBoss JIRA] (JBDS-3981) Build a new feature that omits features available from RPM install
by Nick Boldt (JIRA)
[ https://issues.jboss.org/browse/JBDS-3981?page=com.atlassian.jira.plugin.... ]
Nick Boldt edited comment on JBDS-3981 at 8/24/16 9:45 PM:
-----------------------------------------------------------
Further removed IUs: [^IUs-removed-from-rh-eclipse46-devstudio.rpm_more.txt]
Result is an even smaller list of provided IUs: [^rh-eclipse46-devstudio.provides.list.02]
And now the mirror is only 480M, with the rpm compressed down to 302M.
Seems good enough to start doing more install/usage testing.
So, here's a taste of what the RPM looks like:
http://www.qa.jboss.com/binaries/RHDS/10.0/snapshots/builds/devstudio.rpm...
Now I need a place to build it other than my own machine :D
was (Author: nickboldt):
Here's a taste of what the RPM looks like:
http://www.qa.jboss.com/binaries/RHDS/10.0/snapshots/builds/devstudio.rpm...
Now I need a place to build it other than my own machine :D
> Build a new feature that omits features available from RPM install
> ------------------------------------------------------------------
>
> Key: JBDS-3981
> URL: https://issues.jboss.org/browse/JBDS-3981
> Project: Red Hat JBoss Developer Studio (devstudio)
> Issue Type: Bug
> Components: build, updatesite
> Affects Versions: 10.1.0.AM2
> Reporter: Nick Boldt
> Assignee: Nick Boldt
> Fix For: 10.1.0.GA
>
> Attachments: IUs-removed-from-rh-eclipse46-devstudio.rpm.txt, IUs-removed-from-rh-eclipse46-devstudio.rpm_more.txt, rh-eclipse46-devstudio.provides.list.01, rh-eclipse46-devstudio.provides.list.02, simpler_install_foorprint_rh-eclipse46-devstudio.rpm.png, simpler_install_foorprint_rh-eclipse46-devstudio.rpm_2.png, simpler_install_foorprint_rh-eclipse46-devstudio.rpm_3.png
>
>
> What we DO need is a feature with fewer dependencies than com.jboss.devstudio.core.feature (eg., which omits pde, emf, xsd, egit...)
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 7 months
[JBoss JIRA] (JBDS-3981) Build a new feature that omits features available from RPM install
by Nick Boldt (JIRA)
[ https://issues.jboss.org/browse/JBDS-3981?page=com.atlassian.jira.plugin.... ]
Nick Boldt commented on JBDS-3981:
----------------------------------
Here's a taste of what the RPM looks like:
http://www.qa.jboss.com/binaries/RHDS/10.0/snapshots/builds/devstudio.rpm...
Now I need a place to build it other than my own machine :D
> Build a new feature that omits features available from RPM install
> ------------------------------------------------------------------
>
> Key: JBDS-3981
> URL: https://issues.jboss.org/browse/JBDS-3981
> Project: Red Hat JBoss Developer Studio (devstudio)
> Issue Type: Bug
> Components: build, updatesite
> Affects Versions: 10.1.0.AM2
> Reporter: Nick Boldt
> Assignee: Nick Boldt
> Fix For: 10.1.0.GA
>
> Attachments: IUs-removed-from-rh-eclipse46-devstudio.rpm.txt, IUs-removed-from-rh-eclipse46-devstudio.rpm_more.txt, rh-eclipse46-devstudio.provides.list.01, rh-eclipse46-devstudio.provides.list.02, simpler_install_foorprint_rh-eclipse46-devstudio.rpm.png, simpler_install_foorprint_rh-eclipse46-devstudio.rpm_2.png, simpler_install_foorprint_rh-eclipse46-devstudio.rpm_3.png
>
>
> What we DO need is a feature with fewer dependencies than com.jboss.devstudio.core.feature (eg., which omits pde, emf, xsd, egit...)
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 7 months