[JBoss JIRA] (JBIDE-24671) [jbosstools-openshift] Block PRs for merge untill code is reviewed
by Dmitrii Bocharov (JIRA)
[ https://issues.jboss.org/browse/JBIDE-24671?page=com.atlassian.jira.plugi... ]
Dmitrii Bocharov commented on JBIDE-24671:
------------------------------------------
[~nickboldt] yes, i think we can give the bot admin access. But how will it work? Will we write a special comment to merge via the bot?
Also i created a separate JBIDE-25221 yesterday and linked it to the JBIDE-24439, as you told me in mattermost. Should we close it not?
> [jbosstools-openshift] Block PRs for merge untill code is reviewed
> ------------------------------------------------------------------
>
> Key: JBIDE-24671
> URL: https://issues.jboss.org/browse/JBIDE-24671
> Project: Tools (JBoss Tools)
> Issue Type: Sub-task
> Components: openshift
> Affects Versions: 4.5.1.AM1
> Reporter: Nick Boldt
> Assignee: Dmitrii Bocharov
> Fix For: 4.5.1.Final
>
> Attachments: bot-admin-openshift.png, protected-master-branch.png
>
>
> Nick asked:
> {quote}
> if we implement protected branches in github then no PRs can be merged w/o a PR review
> so for projects like Base or Server, this would slow Rob down as he'd be even more dependent on PR reviews
> for Openshift this would force Andre to break his PRs into smaller pieces so they could be more easily/quickly reviewed
> otherwise all forward dev would be halted
> so it's good from a "keep the code safe and clean" perspective
> but if we don't actually get buy-in / acceptance from the people who submit the PRs and review them, it will block progress{quote}
> Jeff replied:
> {quote}I think this make more sense for OpenShift as we are more in a collaborative way, I have the feeling that Rob is more or less alone in server. So let's start with OpenShift but I would see this after the GA{quote}
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
8 years, 5 months
[JBoss JIRA] (JBIDE-24671) [jbosstools-openshift] Block PRs for merge untill code is reviewed
by Nick Boldt (JIRA)
[ https://issues.jboss.org/browse/JBIDE-24671?page=com.atlassian.jira.plugi... ]
Nick Boldt updated JBIDE-24671:
-------------------------------
Summary: [jbosstools-openshift] Block PRs for merge untill code is reviewed (was: [jbosstools-openshift] Block PRs for merge untill the Jenkins build is successful)
> [jbosstools-openshift] Block PRs for merge untill code is reviewed
> ------------------------------------------------------------------
>
> Key: JBIDE-24671
> URL: https://issues.jboss.org/browse/JBIDE-24671
> Project: Tools (JBoss Tools)
> Issue Type: Sub-task
> Components: openshift
> Affects Versions: 4.5.1.AM1
> Reporter: Nick Boldt
> Assignee: Dmitrii Bocharov
> Fix For: 4.5.1.Final
>
> Attachments: bot-admin-openshift.png, protected-master-branch.png
>
>
> Nick asked:
> {quote}
> if we implement protected branches in github then no PRs can be merged w/o a PR review
> so for projects like Base or Server, this would slow Rob down as he'd be even more dependent on PR reviews
> for Openshift this would force Andre to break his PRs into smaller pieces so they could be more easily/quickly reviewed
> otherwise all forward dev would be halted
> so it's good from a "keep the code safe and clean" perspective
> but if we don't actually get buy-in / acceptance from the people who submit the PRs and review them, it will block progress{quote}
> Jeff replied:
> {quote}I think this make more sense for OpenShift as we are more in a collaborative way, I have the feeling that Rob is more or less alone in server. So let's start with OpenShift but I would see this after the GA{quote}
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
8 years, 6 months
[JBoss JIRA] (JBIDE-24671) [jbosstools-openshift] Block PRs for merge untill the Jenkins build is successful
by Nick Boldt (JIRA)
[ https://issues.jboss.org/browse/JBIDE-24671?page=com.atlassian.jira.plugi... ]
Nick Boldt edited comment on JBIDE-24671 at 10/12/17 10:31 AM:
---------------------------------------------------------------
Current protected branch settings for master:
!protected-master-branch.png|thumbnail!
In order to allow automated updates to the master branch's root pom via a jenkins job, we would have to give the bot admin access, but that's not currently required:
!bot-admin-openshift.png|thumbnail!
cc: [~dbocharov] [~adietish] [~jeffmaury]
was (Author: nickboldt):
Current protected branch settings for master:
!protected-master-branch.png|thumbnail!
In order to allow automated updates to the master branch's root pom, I've given the bot admin access:
!bot-admin-openshift.png|thumbnail!
cc: [~dbocharov] [~adietish] [~jeffmaury]
> [jbosstools-openshift] Block PRs for merge untill the Jenkins build is successful
> ---------------------------------------------------------------------------------
>
> Key: JBIDE-24671
> URL: https://issues.jboss.org/browse/JBIDE-24671
> Project: Tools (JBoss Tools)
> Issue Type: Sub-task
> Components: openshift
> Affects Versions: 4.5.1.AM1
> Reporter: Nick Boldt
> Assignee: Andre Dietisheim
> Fix For: 4.5.1.Final
>
> Attachments: bot-admin-openshift.png, protected-master-branch.png
>
>
> Nick asked:
> {quote}
> if we implement protected branches in github then no PRs can be merged w/o a PR review
> so for projects like Base or Server, this would slow Rob down as he'd be even more dependent on PR reviews
> for Openshift this would force Andre to break his PRs into smaller pieces so they could be more easily/quickly reviewed
> otherwise all forward dev would be halted
> so it's good from a "keep the code safe and clean" perspective
> but if we don't actually get buy-in / acceptance from the people who submit the PRs and review them, it will block progress{quote}
> Jeff replied:
> {quote}I think this make more sense for OpenShift as we are more in a collaborative way, I have the feeling that Rob is more or less alone in server. So let's start with OpenShift but I would see this after the GA{quote}
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
8 years, 6 months
[JBoss JIRA] (JBIDE-24671) [jbosstools-openshift] Block PRs for merge untill the Jenkins build is successful
by Nick Boldt (JIRA)
[ https://issues.jboss.org/browse/JBIDE-24671?page=com.atlassian.jira.plugi... ]
Nick Boldt resolved JBIDE-24671.
--------------------------------
Assignee: Dmitrii Bocharov (was: Andre Dietisheim)
Resolution: Done
> [jbosstools-openshift] Block PRs for merge untill the Jenkins build is successful
> ---------------------------------------------------------------------------------
>
> Key: JBIDE-24671
> URL: https://issues.jboss.org/browse/JBIDE-24671
> Project: Tools (JBoss Tools)
> Issue Type: Sub-task
> Components: openshift
> Affects Versions: 4.5.1.AM1
> Reporter: Nick Boldt
> Assignee: Dmitrii Bocharov
> Fix For: 4.5.1.Final
>
> Attachments: bot-admin-openshift.png, protected-master-branch.png
>
>
> Nick asked:
> {quote}
> if we implement protected branches in github then no PRs can be merged w/o a PR review
> so for projects like Base or Server, this would slow Rob down as he'd be even more dependent on PR reviews
> for Openshift this would force Andre to break his PRs into smaller pieces so they could be more easily/quickly reviewed
> otherwise all forward dev would be halted
> so it's good from a "keep the code safe and clean" perspective
> but if we don't actually get buy-in / acceptance from the people who submit the PRs and review them, it will block progress{quote}
> Jeff replied:
> {quote}I think this make more sense for OpenShift as we are more in a collaborative way, I have the feeling that Rob is more or less alone in server. So let's start with OpenShift but I would see this after the GA{quote}
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
8 years, 6 months
[JBoss JIRA] (JBIDE-24671) [jbosstools-openshift] Block PRs for merge untill the Jenkins build is successful
by Nick Boldt (JIRA)
[ https://issues.jboss.org/browse/JBIDE-24671?page=com.atlassian.jira.plugi... ]
Nick Boldt commented on JBIDE-24671:
------------------------------------
Current protected branch settings for master:
!protected-master-branch.png|thumbnail!
In order to allow automated updates to the master branch's root pom, I've given the bot admin access:
!bot-admin-openshift.png|thumbnail!
cc: [~dbocharov] [~adietish] [~jeffmaury]
> [jbosstools-openshift] Block PRs for merge untill the Jenkins build is successful
> ---------------------------------------------------------------------------------
>
> Key: JBIDE-24671
> URL: https://issues.jboss.org/browse/JBIDE-24671
> Project: Tools (JBoss Tools)
> Issue Type: Sub-task
> Components: openshift
> Affects Versions: 4.5.1.AM1
> Reporter: Nick Boldt
> Assignee: Andre Dietisheim
> Fix For: 4.5.1.Final
>
> Attachments: bot-admin-openshift.png, protected-master-branch.png
>
>
> Nick asked:
> {quote}
> if we implement protected branches in github then no PRs can be merged w/o a PR review
> so for projects like Base or Server, this would slow Rob down as he'd be even more dependent on PR reviews
> for Openshift this would force Andre to break his PRs into smaller pieces so they could be more easily/quickly reviewed
> otherwise all forward dev would be halted
> so it's good from a "keep the code safe and clean" perspective
> but if we don't actually get buy-in / acceptance from the people who submit the PRs and review them, it will block progress{quote}
> Jeff replied:
> {quote}I think this make more sense for OpenShift as we are more in a collaborative way, I have the feeling that Rob is more or less alone in server. So let's start with OpenShift but I would see this after the GA{quote}
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
8 years, 6 months
[JBoss JIRA] (JBIDE-24671) [jbosstools-openshift] Block PRs for merge untill the Jenkins build is successful
by Nick Boldt (JIRA)
[ https://issues.jboss.org/browse/JBIDE-24671?page=com.atlassian.jira.plugi... ]
Nick Boldt updated JBIDE-24671:
-------------------------------
Attachment: protected-master-branch.png
> [jbosstools-openshift] Block PRs for merge untill the Jenkins build is successful
> ---------------------------------------------------------------------------------
>
> Key: JBIDE-24671
> URL: https://issues.jboss.org/browse/JBIDE-24671
> Project: Tools (JBoss Tools)
> Issue Type: Sub-task
> Components: openshift
> Affects Versions: 4.5.1.AM1
> Reporter: Nick Boldt
> Assignee: Andre Dietisheim
> Fix For: 4.5.1.Final
>
> Attachments: bot-admin-openshift.png, protected-master-branch.png
>
>
> Nick asked:
> {quote}
> if we implement protected branches in github then no PRs can be merged w/o a PR review
> so for projects like Base or Server, this would slow Rob down as he'd be even more dependent on PR reviews
> for Openshift this would force Andre to break his PRs into smaller pieces so they could be more easily/quickly reviewed
> otherwise all forward dev would be halted
> so it's good from a "keep the code safe and clean" perspective
> but if we don't actually get buy-in / acceptance from the people who submit the PRs and review them, it will block progress{quote}
> Jeff replied:
> {quote}I think this make more sense for OpenShift as we are more in a collaborative way, I have the feeling that Rob is more or less alone in server. So let's start with OpenShift but I would see this after the GA{quote}
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
8 years, 6 months
[JBoss JIRA] (JBIDE-24671) [jbosstools-openshift] Block PRs for merge untill the Jenkins build is successful
by Nick Boldt (JIRA)
[ https://issues.jboss.org/browse/JBIDE-24671?page=com.atlassian.jira.plugi... ]
Nick Boldt updated JBIDE-24671:
-------------------------------
Attachment: bot-admin-openshift.png
> [jbosstools-openshift] Block PRs for merge untill the Jenkins build is successful
> ---------------------------------------------------------------------------------
>
> Key: JBIDE-24671
> URL: https://issues.jboss.org/browse/JBIDE-24671
> Project: Tools (JBoss Tools)
> Issue Type: Sub-task
> Components: openshift
> Affects Versions: 4.5.1.AM1
> Reporter: Nick Boldt
> Assignee: Andre Dietisheim
> Fix For: 4.5.1.Final
>
> Attachments: bot-admin-openshift.png, protected-master-branch.png
>
>
> Nick asked:
> {quote}
> if we implement protected branches in github then no PRs can be merged w/o a PR review
> so for projects like Base or Server, this would slow Rob down as he'd be even more dependent on PR reviews
> for Openshift this would force Andre to break his PRs into smaller pieces so they could be more easily/quickly reviewed
> otherwise all forward dev would be halted
> so it's good from a "keep the code safe and clean" perspective
> but if we don't actually get buy-in / acceptance from the people who submit the PRs and review them, it will block progress{quote}
> Jeff replied:
> {quote}I think this make more sense for OpenShift as we are more in a collaborative way, I have the feeling that Rob is more or less alone in server. So let's start with OpenShift but I would see this after the GA{quote}
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
8 years, 6 months
[JBoss JIRA] (JBIDE-24671) [jbosstools-openshift] Block PRs for merge untill the Jenkins build is successful
by Nick Boldt (JIRA)
[ https://issues.jboss.org/browse/JBIDE-24671?page=com.atlassian.jira.plugi... ]
Nick Boldt updated JBIDE-24671:
-------------------------------
Fix Version/s: 4.5.1.Final
(was: 4.5.1.AM2)
> [jbosstools-openshift] Block PRs for merge untill the Jenkins build is successful
> ---------------------------------------------------------------------------------
>
> Key: JBIDE-24671
> URL: https://issues.jboss.org/browse/JBIDE-24671
> Project: Tools (JBoss Tools)
> Issue Type: Sub-task
> Components: openshift
> Affects Versions: 4.5.1.AM1
> Reporter: Nick Boldt
> Assignee: Andre Dietisheim
> Fix For: 4.5.1.Final
>
>
> Nick asked:
> {quote}
> if we implement protected branches in github then no PRs can be merged w/o a PR review
> so for projects like Base or Server, this would slow Rob down as he'd be even more dependent on PR reviews
> for Openshift this would force Andre to break his PRs into smaller pieces so they could be more easily/quickly reviewed
> otherwise all forward dev would be halted
> so it's good from a "keep the code safe and clean" perspective
> but if we don't actually get buy-in / acceptance from the people who submit the PRs and review them, it will block progress{quote}
> Jeff replied:
> {quote}I think this make more sense for OpenShift as we are more in a collaborative way, I have the feeling that Rob is more or less alone in server. So let's start with OpenShift but I would see this after the GA{quote}
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
8 years, 6 months
[JBoss JIRA] (JBIDE-25139) migrate PR build jobs on fusesource jenkins to dev-platform
by Aurélien Pupier (JIRA)
[ https://issues.jboss.org/browse/JBIDE-25139?page=com.atlassian.jira.plugi... ]
Aurélien Pupier commented on JBIDE-25139:
-----------------------------------------
current status:
* master job is working
* PR job is working
* [Sonar job|https://fusesource-jenkins.rhev-ci-vms.eng.rdu2.redhat.com/view/Fuse%...] has not been migrated
* started work for job testing snapshots of Camel has not been migrated
* Build time makes dev platform not usable for now:
** 2h instead of 1h30 for PR job
** 3h instead of 1h05 for master job on a fresh slave node
** only one slave available instead of 5
TO DO:
* Investigate why it takes so much more time:
** too many entries in settings.xml of Maven used?
** hard disk performance?
** network performance?
* try with a slave of 8G RAM:
** we should be able to have at least 2 or 3 slaves if it is working
* is it possible to have more ressources for slaves?
* investigate why so much memory is required? (between 4G and 16G)
* migrate Sonar job
* migrate camel snapshots job
other actions to do?
> migrate PR build jobs on fusesource jenkins to dev-platform
> -----------------------------------------------------------
>
> Key: JBIDE-25139
> URL: https://issues.jboss.org/browse/JBIDE-25139
> Project: Tools (JBoss Tools)
> Issue Type: Sub-task
> Components: build, fusetools
> Reporter: Nick Boldt
> Assignee: Nick Boldt
> Fix For: 4.5.1.Final
>
> Attachments: all-three-PR-builders.png
>
>
> I believe the current PR build job is this one:
> https://fusesource-jenkins.rhev-ci-vms.eng.rdu2.redhat.com/view/Fuse%20To...
> [~lhein] [~aurelien.pupier] is that correct?
> Yes, it is correct
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
8 years, 6 months