[JBoss JIRA] (JBDS-4588) update installer to be able to use JDK 9
by Martin Malina (JIRA)
[ https://issues.jboss.org/browse/JBDS-4588?page=com.atlassian.jira.plugin.... ]
Martin Malina commented on JBDS-4588:
-------------------------------------
I tried to run the current devstudio installer [1] with java 9 on mac and it works just fine for me. The only caveat is that in Step 4 you won't be able to just use "Default Java VM" because that would point to java 9 and that will give you an error that it's not supported. So you need to manually point the installer to a java 8 installation.
So if no issues are found by others, it's possible that no fixes will be necessary at all for now.
[1] devstudio-11.1.0.GA-v20171012-0713-B1322-installer-standalone.jar
> update installer to be able to use JDK 9
> ----------------------------------------
>
> Key: JBDS-4588
> URL: https://issues.jboss.org/browse/JBDS-4588
> Project: Red Hat JBoss Developer Studio (devstudio)
> Issue Type: Bug
> Components: installer
> Affects Versions: 11.1.0.AM3
> Reporter: Nick Boldt
> Assignee: Nick Boldt
> Fix For: 11.1.0.GA
>
>
> Investigate what's needed to support running the installer w/ JDK 9.
> May also need to add this to the devstudio.ini, after *-vmargs*:
> {code}-Dosgi.requiredJavaVersion=1.8
> --add-modules=ALL-SYSTEM{code} -- https://wiki.eclipse.org/Configure_Eclipse_for_Java_9#Configure_Eclipse_f...
> cc: [~mmalina] [~jeffmaury] [~dgolovin]
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
8 years, 6 months
[JBoss JIRA] (JBIDE-24491) CDK Server adapter: allow users to look up the address of the docker registry
by Martin Malina (JIRA)
[ https://issues.jboss.org/browse/JBIDE-24491?page=com.atlassian.jira.plugi... ]
Martin Malina closed JBIDE-24491.
---------------------------------
I verified that now it's better - in both of the failing cases there is a nice error message:
1. When the tooling doesn't even have a minishift command to run (i.e. there is no cdk server adapter or a partly configured one)
2. When the cdk server is fully setup but cdk is stopped
> CDK Server adapter: allow users to look up the address of the docker registry
> -----------------------------------------------------------------------------
>
> Key: JBIDE-24491
> URL: https://issues.jboss.org/browse/JBIDE-24491
> Project: Tools (JBoss Tools)
> Issue Type: Feature Request
> Components: cdk
> Affects Versions: 4.4.4.Final
> Reporter: Andre Dietisheim
> Assignee: Rob Stryker
> Fix For: 4.5.1.Final
>
>
> if you want to push a docker image to the docker registry within OpenShift you need the address of the docker registry.
> When launching the cdk in Eclipse our tooling creates the OpenShift connection for the tooling filling out that address.
> Users that didnt launch the cdk via the server adapter or had their connection already defined when launching it, would have to look the address up manually. One does this on the command line via {code}./minishift openshift registry{code}
> It would be nice if the server adapter would offer a way to look it up so that the user does not have to go the command line.
> I dont know yet how to look it up for the OpenShift online variant though.
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
8 years, 6 months
[JBoss JIRA] (JBIDE-25167) CDK 3.2+ adapter is created automatically even if I have CDK 3.1.1 installed
by Martin Malina (JIRA)
[ https://issues.jboss.org/browse/JBIDE-25167?page=com.atlassian.jira.plugi... ]
Martin Malina closed JBIDE-25167.
---------------------------------
It works correctly now. When I have 3.1.1 in ~/.minishift, CDK 3 is created. And if I have 3.2.x installed, then CDK 3.2+ adapter is created. Verified in devstudio-11.1.0.GA-v20171012-0713-B1322-installer-standalone.jar . Closing.
> CDK 3.2+ adapter is created automatically even if I have CDK 3.1.1 installed
> ----------------------------------------------------------------------------
>
> Key: JBIDE-25167
> URL: https://issues.jboss.org/browse/JBIDE-25167
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: cdk
> Affects Versions: 4.5.1.AM3
> Reporter: Martin Malina
> Assignee: Rob Stryker
> Priority: Critical
> Fix For: 4.5.1.Final
>
>
> I installed devstudio 11.1.0.AM3 B1225 and when I launched it there was a cdk server adapter already set up. That's completely normal. But what's wrong is that it's the new 3.2+ adapter whereas what I have actually installed in ~/.minishift is version 3.1.1.
> The runtime detection should be able to detect the version in ~/.minishift/cdk and return a match only if the version is compatible with the given adapter.
> [~jkopriva] says cdk 3.1.1 cannot be launched with cdk 3.2+ adapter. I cannot really check that myself because my server adapter doesn't have minishift binary set up by default and you validate the version in the server editor, so I can't use 3.1.1 with the 3.2+ adapter.
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
8 years, 6 months
[JBoss JIRA] (JBIDE-25225) OSIO login: error when the login window is closed by the user
by Jeff MAURY (JIRA)
[ https://issues.jboss.org/browse/JBIDE-25225?page=com.atlassian.jira.plugi... ]
Jeff MAURY commented on JBIDE-25225:
------------------------------------
This was done that way because the base service that is exposed to third parties plugins (and the connect button is an example) just call getToken to get a token and if we need to login because there is no account or tokens are not valid, and if the user closes the login dialog then we report an exception and in that case the LoginException is raised to indicate why the getToken failed
> OSIO login: error when the login window is closed by the user
> -------------------------------------------------------------
>
> Key: JBIDE-25225
> URL: https://issues.jboss.org/browse/JBIDE-25225
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Affects Versions: 4.5.1.Final
> Reporter: Martin Malina
> Fix For: 4.5.1.Final
>
> Attachments: osio-error.png
>
>
> I tested the OSIO login feature and it works pretty well. But one thing should be fixed I think. When you click the icon and the login browser window is opened and then you change your mind and click Close on the window, you're given an error:
> Error login to cluster OpenShift.io
> !osio-error.png!
> I think in the case of the user closing the window there shouldn't be an error like this.
> I understand that we do need some form of indication if the username is correct (so the webpage accepts it), but the login in devstudio fails somehow. In this case it is correct to display an error.
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
8 years, 6 months
[JBoss JIRA] (JBIDE-25225) OSIO login: error when the login window is closed by the user
by Martin Malina (JIRA)
[ https://issues.jboss.org/browse/JBIDE-25225?page=com.atlassian.jira.plugi... ]
Martin Malina updated JBIDE-25225:
----------------------------------
Fix Version/s: 4.5.1.Final
> OSIO login: error when the login window is closed by the user
> -------------------------------------------------------------
>
> Key: JBIDE-25225
> URL: https://issues.jboss.org/browse/JBIDE-25225
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Affects Versions: 4.5.1.Final
> Reporter: Martin Malina
> Fix For: 4.5.1.Final
>
> Attachments: osio-error.png
>
>
> I tested the OSIO login feature and it works pretty well. But one thing should be fixed I think. When you click the icon and the login browser window is opened and then you change your mind and click Close on the window, you're given an error:
> Error login to cluster OpenShift.io
> !osio-error.png!
> I think in the case of the user closing the window there shouldn't be an error like this.
> I understand that we do need some form of indication if the username is correct (so the webpage accepts it), but the login in devstudio fails somehow. In this case it is correct to display an error.
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
8 years, 6 months
[JBoss JIRA] (JBIDE-24793) Add OpenShift.io login
by Martin Malina (JIRA)
[ https://issues.jboss.org/browse/JBIDE-24793?page=com.atlassian.jira.plugi... ]
Martin Malina closed JBIDE-24793.
---------------------------------
This works pretty well, but I reported two followup JIRAs:
JBIDE-25226 OSIO login: Use credentials stored in devstudio
JBIDE-25225 OSIO login: error when the login window is closed by the user
> Add OpenShift.io login
> ----------------------
>
> Key: JBIDE-24793
> URL: https://issues.jboss.org/browse/JBIDE-24793
> Project: Tools (JBoss Tools)
> Issue Type: Feature Request
> Components: openshift
> Affects Versions: 4.5.0.Final
> Reporter: Jeff MAURY
> Assignee: Jeff MAURY
> Fix For: 4.5.1.AM3
>
>
> Add an action to login to OpenShift.io based on stored credentials in the first class credential domain
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
8 years, 6 months
[JBoss JIRA] (JBIDE-25218) OSIO login exploratory testing
by Martin Malina (JIRA)
[ https://issues.jboss.org/browse/JBIDE-25218?page=com.atlassian.jira.plugi... ]
Martin Malina commented on JBIDE-25218:
---------------------------------------
Truth be told, it turns out there is not much to be tested at this point - the only thing you can do right now is check that the login works and returns a token. In preferences, you can see that you have a valid login.
When you try to login again, you will just get the same token immediately.
In preferences, you can remove the token. Then you can login again (requiring your password).
All of this works correctly for me.
The original PR is here:
https://github.com/jbosstools/jbosstools-openshift/pull/1577
The JIRA for initial implementation:
JBIDE-24951 and JBIDE-24793
I did report one issue though: JBIDE-25225 OSIO login: error when the login window is closed by the user
Also, the original JIRA says that the credentials stored in eclipse should be used, but that's not currently working that way, so I reported it here: JBIDE-25226
> OSIO login exploratory testing
> -------------------------------
>
> Key: JBIDE-25218
> URL: https://issues.jboss.org/browse/JBIDE-25218
> Project: Tools (JBoss Tools)
> Issue Type: Task
> Components: integration-tests
> Reporter: Pavol Srna
> Assignee: Martin Malina
> Fix For: 4.5.1.Final
>
>
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
8 years, 6 months
[JBoss JIRA] (JBIDE-25226) OSIO login: Use credentials stored in devstudio
by Martin Malina (JIRA)
Martin Malina created JBIDE-25226:
-------------------------------------
Summary: OSIO login: Use credentials stored in devstudio
Key: JBIDE-25226
URL: https://issues.jboss.org/browse/JBIDE-25226
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: openshift
Affects Versions: 4.5.1.Final
Reporter: Martin Malina
Assignee: Jeff MAURY
Fix For: 4.5.1.Final
According to the original JIRA for osio login implementation, the feature should use credentials stored in devstudio: JBIDE-24951
I'm not sure if that's still the plan or not. If not feel free to reject this JIRA.
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
8 years, 6 months
[JBoss JIRA] (JBIDE-25225) OSIO login: error when the login window is closed by the user
by Martin Malina (JIRA)
Martin Malina created JBIDE-25225:
-------------------------------------
Summary: OSIO login: error when the login window is closed by the user
Key: JBIDE-25225
URL: https://issues.jboss.org/browse/JBIDE-25225
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: openshift
Affects Versions: 4.5.1.Final
Reporter: Martin Malina
Attachments: osio-error.png
I tested the OSIO login feature and it works pretty well. But one thing should be fixed I think. When you click the icon and the login browser window is opened and then you change your mind and click Close on the window, you're given an error:
Error login to cluster OpenShift.io
I think in the case of the user closing the window there shouldn't be an error like this.
I understand that we do need some form of indication if the username is correct (so the webpage accepts it), but the login in devstudio fails somehow. In this case it is correct to display an error.
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
8 years, 6 months