[JBoss JIRA] (JBIDE-25380) 'Undo' of most editor actions fails to correctly undo
by Rob Stryker (JIRA)
[ https://issues.jboss.org/browse/JBIDE-25380?page=com.atlassian.jira.plugi... ]
Rob Stryker commented on JBIDE-25380:
-------------------------------------
PR added: https://github.com/jbosstools/jbosstools-openshift/pull/1611/commits
This PR also fixes https://issues.jboss.org/browse/JBIDE-25278 since the change is in the same file
> 'Undo' of most editor actions fails to correctly undo
> -----------------------------------------------------
>
> Key: JBIDE-25380
> URL: https://issues.jboss.org/browse/JBIDE-25380
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift, server
> Affects Versions: 4.5.2.AM1
> Reporter: Rob Stryker
>
> Many actions in the editor cannot be correctly undone. Using the ctrl+z shortcut often leaves the editor and model in conflicting states. I believe the root cause of this is that the dependence on databinding and a specific model type is confusing things. What's more, the specific model class being used is extended from teh wizard model. This seems completely inappropriate, because the server editor is really just backed by the server working copy, and doesn't need 80% of the fields that are in the wizard model.
> Also, since a good many actions like changing the connection or the source project, make no sense and almost never function correctly, many of these actions should really not be available. They only make it more likely for a user to break his environment.
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
8 years, 5 months
[JBoss JIRA] (JBIDE-25380) 'Undo' of most editor actions fails to correctly undo
by Rob Stryker (JIRA)
Rob Stryker created JBIDE-25380:
-----------------------------------
Summary: 'Undo' of most editor actions fails to correctly undo
Key: JBIDE-25380
URL: https://issues.jboss.org/browse/JBIDE-25380
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: openshift, server
Affects Versions: 4.5.2.AM1
Reporter: Rob Stryker
Many actions in the editor cannot be correctly undone. Using the ctrl+z shortcut often leaves the editor and model in conflicting states. I believe the root cause of this is that the dependence on databinding and a specific model type is confusing things. What's more, the specific model class being used is extended from teh wizard model. This seems completely inappropriate, because the server editor is really just backed by the server working copy, and doesn't need 80% of the fields that are in the wizard model.
Also, since a good many actions like changing the connection or the source project, make no sense and almost never function correctly, many of these actions should really not be available. They only make it more likely for a user to break his environment.
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
8 years, 5 months