[JBoss JIRA] (JBIDE-25121) Connection wizard: Image Registry URL is not decorated when not valid (and validation seems weird)
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-25121?page=com.atlassian.jira.plugi... ]
Andre Dietisheim updated JBIDE-25121:
-------------------------------------
Fix Version/s: 4.5.2.AM1
(was: 4.5.x)
> Connection wizard: Image Registry URL is not decorated when not valid (and validation seems weird)
> --------------------------------------------------------------------------------------------------
>
> Key: JBIDE-25121
> URL: https://issues.jboss.org/browse/JBIDE-25121
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Affects Versions: 4.5.1.AM2
> Reporter: Andre Dietisheim
> Assignee: Jeff MAURY
> Priority: Minor
> Fix For: 4.5.2.AM1
>
> Attachments: image-2017-09-27-22-59-33-548.png
>
>
> steps 1:
> # ASSERT: have a connection the cdk
> # EXEC: edit the connection and move to "Image Registry URL" text field
> # EXEC: provide some bogus URL (ex. bookaroo-banzai)
> Result:
> the url is validated and an error appears in the title are, "Finish" is disabled. GOOD.
> But the text field is not decorated.
> !image-2017-09-27-22-59-33-548.png!
> steps 2:
> # EXEC: provide the following URL: http:/bookaroo-banzai
> Result:
> It thinks that it's valid, there's no error in the title area, "Finish" is enabled
> Expected result:
> http:/bookaroo-banzai doesnt look valid to me, it should error and disable "Finish"
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
8 years, 5 months
[JBoss JIRA] (JBIDE-25121) Connection wizard: Image Registry URL is not decorated when not valid (and validation seems weird)
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-25121?page=com.atlassian.jira.plugi... ]
Andre Dietisheim commented on JBIDE-25121:
------------------------------------------
merged into master.
> Connection wizard: Image Registry URL is not decorated when not valid (and validation seems weird)
> --------------------------------------------------------------------------------------------------
>
> Key: JBIDE-25121
> URL: https://issues.jboss.org/browse/JBIDE-25121
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Affects Versions: 4.5.1.AM2
> Reporter: Andre Dietisheim
> Assignee: Jeff MAURY
> Priority: Minor
> Fix For: 4.5.2.AM1
>
> Attachments: image-2017-09-27-22-59-33-548.png
>
>
> steps 1:
> # ASSERT: have a connection the cdk
> # EXEC: edit the connection and move to "Image Registry URL" text field
> # EXEC: provide some bogus URL (ex. bookaroo-banzai)
> Result:
> the url is validated and an error appears in the title are, "Finish" is disabled. GOOD.
> But the text field is not decorated.
> !image-2017-09-27-22-59-33-548.png!
> steps 2:
> # EXEC: provide the following URL: http:/bookaroo-banzai
> Result:
> It thinks that it's valid, there's no error in the title area, "Finish" is enabled
> Expected result:
> http:/bookaroo-banzai doesnt look valid to me, it should error and disable "Finish"
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
8 years, 5 months
[JBoss JIRA] (JBIDE-25169) Deadlock when tokenProvider is invoked during start
by Josef Kopriva (JIRA)
[ https://issues.jboss.org/browse/JBIDE-25169?page=com.atlassian.jira.plugi... ]
Josef Kopriva closed JBIDE-25169.
---------------------------------
Closing: Browser is shown and I have not experienced any deadlock.
Verified in:
Red Hat JBoss Developer Studio
Version: 11.2.0.AM1
Build id: AM1-v20171106-0622-B1520
Build date: 20171106-0622
> Deadlock when tokenProvider is invoked during start
> ---------------------------------------------------
>
> Key: JBIDE-25169
> URL: https://issues.jboss.org/browse/JBIDE-25169
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Affects Versions: 4.5.1.AM3
> Reporter: Jeff MAURY
> Assignee: Jeff MAURY
> Labels: Openshift.io, openshift
> Fix For: 4.5.1.Final
>
>
> If a service call the tokenProvider during start, this may lead to a deadlock because the browser is displayed using syncExec. Replace by a UIJob which does call asyncExec
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
8 years, 5 months
[JBoss JIRA] (JBIDE-25260) Console view is broken after entering subscription username
by Gerard Braad (JIRA)
[ https://issues.jboss.org/browse/JBIDE-25260?page=com.atlassian.jira.plugi... ]
Gerard Braad edited comment on JBIDE-25260 at 11/6/17 8:50 AM:
---------------------------------------------------------------
[~mmalina]To provide a better user experience, wouldn't it be possible to verify the entered credentials? I understand that when entered they can still expire (for instance, changed) but verifying is just a simple POST or GET away... right?
But as mentioned, we implemented the interactive entering this way to prevent echoing to the console, but it seems that the console does not have PTY support, and even echoes the password when entered (before sending it to the application). Is this really what you want? Because we received complaints from customers that we showed the password even in a verbose output, or kept it in memory too long.
was (Author: gbraad):
[~mmalina]To provide a better user experience, wouldn't it be possible verify the entered credentials? I understand that when entered they can still expire (for instance, changed) but verifying is just a simple POST or GET away... right?
But as mentioned, we implemented the interactive entering this way to prevent echoing to the console, but it seems that the console does not support PTY support, and even echoes the password when entered (before sending it to the application). Is this really what you want? Because we received complaints from customers that we showed the password even in a verbose output, or kept it in memory too long.
> Console view is broken after entering subscription username
> -----------------------------------------------------------
>
> Key: JBIDE-25260
> URL: https://issues.jboss.org/browse/JBIDE-25260
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: cdk, server
> Affects Versions: 4.5.1.Final
> Reporter: Josef Kopriva
> Assignee: Rob Stryker
> Attachments: image-2017-10-17-10-38-53-270.png, with_devstudio_11.0.0.GA-0.PNG, with_devstudio_11.0.0.GA-1.PNG
>
>
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
8 years, 5 months
[JBoss JIRA] (JBIDE-25169) Deadlock when tokenProvider is invoked during start
by Josef Kopriva (JIRA)
[ https://issues.jboss.org/browse/JBIDE-25169?page=com.atlassian.jira.plugi... ]
Josef Kopriva updated JBIDE-25169:
----------------------------------
Steps to Reproduce:
(from [~jeffmaury])
1) make sure you have no OSIO account configured (Prefs -> JBoss Tools -> OpenShift.io -> Remove if there is an account
2) make sure you have the Fabric8 analytics plugin installed
3) open a pom.xml file from your workspace
The fabrics8 analytics plugin should start the LSP which will request a token -> a browser should be launched but a there is a contention on the display you shoud face a timeout instead of a deadlock
was:
1) make sure you have no OSIO account configured (Prefs -> JBoss Tools -> OpenShift.io -> Remove if there is an account
2) make sure you have the Fabric8 analytics plugin installed
3) open a pom.xml file from your workspace
The fabrics8 analytics plugin should start the LSP which will request a token -> a browser should be launched but a there is a contention on the display you shoud face a timeout instead of a deadlock
> Deadlock when tokenProvider is invoked during start
> ---------------------------------------------------
>
> Key: JBIDE-25169
> URL: https://issues.jboss.org/browse/JBIDE-25169
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Affects Versions: 4.5.1.AM3
> Reporter: Jeff MAURY
> Assignee: Jeff MAURY
> Labels: Openshift.io, openshift
> Fix For: 4.5.1.Final
>
>
> If a service call the tokenProvider during start, this may lead to a deadlock because the browser is displayed using syncExec. Replace by a UIJob which does call asyncExec
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
8 years, 5 months