[JBoss JIRA] (JBIDE-25374) Validate Red Hat credentials when entering them / setting up CDK adapter
by Martin Malina (JIRA)
Martin Malina created JBIDE-25374:
-------------------------------------
Summary: Validate Red Hat credentials when entering them / setting up CDK adapter
Key: JBIDE-25374
URL: https://issues.jboss.org/browse/JBIDE-25374
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: cdk
Affects Versions: 4.5.1.Final
Reporter: Martin Malina
Assignee: Rob Stryker
In JBIDE-25260 we were dealing with the issue that when the credentials are wrong when starting CDK in devstudio, the user will be asked to correct them in the Console view which brings problems.
Gerard Braad suggested that we should validate the credentials when setting them up. I think it's actually not a bad idea. We would need to figure out when/where to do this. Also, the credentials could still become invalid before starting CDK, but the risk would be much lower. So it's a good question if it's worth or a good idea to do something like this.
Cc: [~jeffmaury]
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
8 years, 5 months
[JBoss JIRA] (JBIDE-25260) Console view is broken after entering subscription username
by Ondrej Dockal (JIRA)
[ https://issues.jboss.org/browse/JBIDE-25260?page=com.atlassian.jira.plugi... ]
Ondrej Dockal commented on JBIDE-25260:
---------------------------------------
My 0.02 cents.
I would like to add that entering credentials via console in GUI application (eclipse IDE) is not good practice at all, even if there is not password echoed at all.
As [~mmalina] said, there was a change in the way we were showing output of starting CDK to user. First, there was terminal view, that had possibility to pass the credentials via terminal. Then we moved to use Console View.
> ... So under normal circumstances it doesn't come to entering credentials in the Console view. This only happens if you fail to set up your credentials properly in the cdk server adapter configuration.
Also, do not forget that this happens when one has unchecked the "Pass credentials to environment" checkbox in CDK server editor as is mentioned in Step to reproduce. Here I would advocate to remove the checkbox from server adapter as we already force the user to add the credentials via credentials dialog, we just need to check the credentials instead...
> ... To provide a better user experience, wouldn't it be possible verify the entered credentials? I understand that when entered they can still expire (for instance, changed) but verifying is just a simple POST or GET away... right?
+1. This would be a solution, wdyt [~rob.stryker] ? If we check credentials when they are entered in dialog it would be similar to what is happening in devsuite installer where user must enter proper credentials to developers.redhat.com with signed Terms and Conditions and we do not need to have user passing anything via console.
I would like to mention, that according to https://issues.jboss.org/browse/JBIDE-25295, we cannot use upstream minishift binary under CDK 3.x server adapter after new validation was introduce in 11.1.0GA -> One cannot create a CDK server adapter with underlying minishift (upstream minishift). AND even if it was possible to create the adapter with upstream minishift in devstudio 11.0.0.GA it was not possible to properly start it.
In case we want to provide user with option to use upstream minishift in devstudio (we should discuss it on mailing list, I believe) in future, we will be facing problem how to bypass requirement of having credentials checked against developers.redhat.com (and though, one must have an account there with signed TC) as upstream minishift does not require this (is not using rhel image) by default (but one can use flag --iso-url and then some credentials need to be passed into process - this is getting complicated). Or would we like to introduce new server adapter for upstream minishift? [~jeffmaury] [~mmalina] [~rob.stryker]?
> Console view is broken after entering subscription username
> -----------------------------------------------------------
>
> Key: JBIDE-25260
> URL: https://issues.jboss.org/browse/JBIDE-25260
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: cdk, server
> Affects Versions: 4.5.1.Final
> Reporter: Josef Kopriva
> Assignee: Rob Stryker
> Attachments: image-2017-10-17-10-38-53-270.png, with_devstudio_11.0.0.GA-0.PNG, with_devstudio_11.0.0.GA-1.PNG
>
>
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
8 years, 5 months
[JBoss JIRA] (JBIDE-25295) Cannot use minishift binary instead of CDK in CDK server adapter in IDE
by Ondrej Dockal (JIRA)
[ https://issues.jboss.org/browse/JBIDE-25295?page=com.atlassian.jira.plugi... ]
Ondrej Dockal commented on JBIDE-25295:
---------------------------------------
Also, I tested devstudio 11.0.0.GA where it was possible to add a CDK server adapter with upstream minishift, but it fails to start anyway, there is something missing in the process of OS connection creation (accepting the certificate maybe? ) and Error dialog appears resulting in server adapter became stopped instead of started. Even though that minishift is actually started and OS is running on given url.
> Cannot use minishift binary instead of CDK in CDK server adapter in IDE
> -----------------------------------------------------------------------
>
> Key: JBIDE-25295
> URL: https://issues.jboss.org/browse/JBIDE-25295
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: cdk
> Affects Versions: 4.5.1.Final
> Reporter: Ondrej Dockal
> Assignee: Rob Stryker
> Priority: Critical
> Attachments: Screenshot_20171025_134414.png
>
>
> I am curious what if user will want to use upstream minishift binary for CDK 3.x (3.2+) server adapter. It is not possible now.
> Is there a reason for not allowing user to use upstream minishift binary? Before we did not distinguish between CDK 3.1 and 3.2, it was possible in my opinion. We lost this option when new adapter was added and we started to check CDK v.3.x.x version string for two CDK 3.1 and CDK 3.2 binaries.
> [~rob.stryker] [~jeffmaury] [~mmalina] WDYT?
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
8 years, 5 months
[JBoss JIRA] (JBIDE-25166) Resource wizard: using invalid URL does not show error message
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-25166?page=com.atlassian.jira.plugi... ]
Andre Dietisheim commented on JBIDE-25166:
------------------------------------------
[~jkopriva] ok, grocked. So it's not the URL that's malformed, it's the actual location that it's pointing at (your URL is causing a 404). IMHO we should not validate URL-/file-contents as you type. Validation "as you type" is a task that may take serious time and thus shouldn't be done "as you type".
> Resource wizard: using invalid URL does not show error message
> --------------------------------------------------------------
>
> Key: JBIDE-25166
> URL: https://issues.jboss.org/browse/JBIDE-25166
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Affects Versions: 4.5.1.AM3
> Reporter: Josef Kopriva
> Labels: openshift_v3, resource_wizard
> Fix For: 4.5.x
>
> Attachments: image-2017-10-27-15-12-22-841.png, valid-url-no-errors.png
>
>
> Steps to reproduce:
> 1. Have project in OpenShift connection in OpenShift Explorer
> 2. Right click on project -> New -> Resource...
> 3. Enter invalid URL -> no error is shown, Finish button is enabled
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
8 years, 5 months
[JBoss JIRA] (JBIDE-25350) CDK server editor's launch configuration should not offers to edit some fields
by Ondrej Dockal (JIRA)
[ https://issues.jboss.org/browse/JBIDE-25350?page=com.atlassian.jira.plugi... ]
Ondrej Dockal updated JBIDE-25350:
----------------------------------
Fix Version/s: 4.5.x
> CDK server editor's launch configuration should not offers to edit some fields
> ------------------------------------------------------------------------------
>
> Key: JBIDE-25350
> URL: https://issues.jboss.org/browse/JBIDE-25350
> Project: Tools (JBoss Tools)
> Issue Type: Enhancement
> Components: cdk
> Affects Versions: 4.5.1.Final
> Reporter: Ondrej Dockal
> Priority: Critical
> Fix For: 4.5.x
>
>
> I noticed some inconsistent behavior in launch configuration dialog.
> 1. Server name change in server's editor do not result in changing of text "Name:" in launch configuration (should be, possibly a bug) and vice versa.
> 2. Change of Minishift Binary in editor results in change of "Location" in launch config, but not vice versa. This is not a bug, it is just confusing the user.
> I believe that it should not be possible to edit those two fields in launch configuration. First reason for this is that we already have a place where we can edit server's name and location (in cdk server editor) and other reason will be that if we will allow to edit those values, we must put validation in place. WDYT [~mmalina] [~rob.stryker] ?
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
8 years, 5 months
[JBoss JIRA] (JBIDE-25350) CDK server editor's launch configuration should not offers to edit some fields
by Ondrej Dockal (JIRA)
[ https://issues.jboss.org/browse/JBIDE-25350?page=com.atlassian.jira.plugi... ]
Ondrej Dockal reassigned JBIDE-25350:
-------------------------------------
Assignee: Rob Stryker
> CDK server editor's launch configuration should not offers to edit some fields
> ------------------------------------------------------------------------------
>
> Key: JBIDE-25350
> URL: https://issues.jboss.org/browse/JBIDE-25350
> Project: Tools (JBoss Tools)
> Issue Type: Enhancement
> Components: cdk
> Affects Versions: 4.5.1.Final
> Reporter: Ondrej Dockal
> Assignee: Rob Stryker
> Priority: Critical
> Fix For: 4.5.x
>
>
> I noticed some inconsistent behavior in launch configuration dialog.
> 1. Server name change in server's editor do not result in changing of text "Name:" in launch configuration (should be, possibly a bug) and vice versa.
> 2. Change of Minishift Binary in editor results in change of "Location" in launch config, but not vice versa. This is not a bug, it is just confusing the user.
> I believe that it should not be possible to edit those two fields in launch configuration. First reason for this is that we already have a place where we can edit server's name and location (in cdk server editor) and other reason will be that if we will allow to edit those values, we must put validation in place. WDYT [~mmalina] [~rob.stryker] ?
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
8 years, 5 months