[JBoss JIRA] (JBIDE-23867) OCBinary: is mixing platform independent with dependent code
by Rob Stryker (JIRA)
[ https://issues.jboss.org/browse/JBIDE-23867?page=com.atlassian.jira.plugi... ]
Rob Stryker resolved JBIDE-23867.
---------------------------------
Fix Version/s: 4.4.3.Final
Resolution: Done
> OCBinary: is mixing platform independent with dependent code
> ------------------------------------------------------------
>
> Key: JBIDE-23867
> URL: https://issues.jboss.org/browse/JBIDE-23867
> Project: Tools (JBoss Tools)
> Issue Type: Enhancement
> Components: openshift
> Affects Versions: 4.4.3.AM2
> Reporter: Andre Dietisheim
> Assignee: Rob Stryker
> Fix For: 4.4.3.Final
>
>
> OCBinary is suing enums for the different platform. The platform instance is chosen right when you get the instance that you want to work with:
> {code}
> OCBinary#getInstance
> {code}
> {code}
> public static OCBinary getInstance() {
> if (SystemUtils.IS_OS_WINDOWS) {
> return WINDOWS;
> } else {
> return OTHER;
> }
> }
> {code}
> But then, latter code (that was introduced later in #getSystemPathLocation ignoring it and start being platform independent again, even setting the default to be linux:
> {code}
> public String getSystemPathLocation() {
> if (locationBinary == null) {
> this.locationBinary = new CommandLocationBinary("oc");
> locationBinary.addPlatformLocation(Platform.OS_LINUX, OC_DEFAULTLOCATION_LINUX);
> locationBinary.setDefaultPlatform(Platform.OS_LINUX);
> }
> return locationBinary.findLocation();
> }
> {code}
> Even worse is that the above code hard-codes the oc binary to be "oc" while the enum for windows is defining it as "oc.exe"
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
9 years, 1 month
[JBoss JIRA] (JBIDE-23536) components.py should store the assigned user
by Nick Boldt (JIRA)
[ https://issues.jboss.org/browse/JBIDE-23536?page=com.atlassian.jira.plugi... ]
Nick Boldt reassigned JBIDE-23536:
----------------------------------
Assignee: Nick Boldt (was: Jeff MAURY)
> components.py should store the assigned user
> --------------------------------------------
>
> Key: JBIDE-23536
> URL: https://issues.jboss.org/browse/JBIDE-23536
> Project: Tools (JBoss Tools)
> Issue Type: Enhancement
> Components: build
> Affects Versions: 4.4.2.Final
> Reporter: Jeff MAURY
> Assignee: Nick Boldt
> Labels: build, release, release-eng
> Fix For: 4.4.3.Final
>
> Attachments: run.log
>
>
> The file components.py is used when created JIRAs during the release process. One JIRA is created per component. But those JIRAs are not initially assigned to a user, so the user of the scripts (createnewandnotworthy,....) must update all the created JIRAs. If the file stored as well the JIRA user id, then this could be done automatically
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
9 years, 1 month