February 2017 - jbosstools-issues

[JBoss JIRA] (JBIDE-23871) install-grinder failure: "The widget (of type 'Button' and with mnemonic 'Finish' and with style 'SWT.PUSH') was not enabled."

by Friendly Jira Robot (JIRA)

[ https://issues.jboss.org/browse/JBIDE-23871?page=com.atlassian.jira.plugi... ] Friendly Jira Robot commented on JBIDE-23871: --------------------------------------------- https://devstudio.jboss.com/10.0/snapshots/builds/jbosstools-discovery.ce... (as shown in the screenshot) DOES contain an composite update site. So... maybe the job fired while the /latest/ symlink was being recreated and the link 404'd temporarily. I guess we can kick it again and see. https://jenkins.mw.lab.eng.bos.redhat.com/hudson/job/jbosstools-install-g... >=7840 > install-grinder failure: "The widget (of type 'Button' and with mnemonic 'Finish' and with style 'SWT.PUSH') was not enabled." > ------------------------------------------------------------------------------------------------------------------------------ > > Key: JBIDE-23871 > URL: https://issues.jboss.org/browse/JBIDE-23871 > Project: Tools (JBoss Tools) > Issue Type: Bug > Components: install-tests > Affects Versions: 4.4.3.AM2 > Reporter: Nick Boldt > > {code} > 12:14:33 Caused by: org.eclipse.swtbot.swt.finder.widgets.TimeoutException: > Timeout after: 5000 ms.: > The widget (of type 'Button' and with mnemonic 'Finish' and with > style 'SWT.PUSH') was not enabled. > {code} > {code} > 12:14:33 Testcase: testInstall took 103.682 sec > 12:14:33 Caused an ERROR > 12:14:33 Internal error > 12:14:33 java.lang.RuntimeException: Internal error > 12:14:33 at org.jboss.tools.tests.installation.InstallTest.continueInstall(InstallTest.java:213) > 12:14:33 at org.jboss.tools.tests.installation.InstallTest.continueInstall(InstallTest.java:147) > 12:14:33 at org.jboss.tools.tests.installation.InstallTest.installFromSite(InstallTest.java:133) > 12:14:33 at org.jboss.tools.tests.installation.InstallTest.testInstall(InstallTest.java:78) > 12:14:33 at org.eclipse.swtbot.swt.finder.junit.internal.CapturingFrameworkMethod.invokeExplosively(CapturingFrameworkMethod.java:47) > 12:14:33 at org.eclipse.swtbot.swt.finder.junit.SWTBotJunit4ClassRunner.runChild(SWTBotJunit4ClassRunner.java:76) > 12:14:33 at org.eclipse.swtbot.swt.finder.junit.SWTBotJunit4ClassRunner.run(SWTBotJunit4ClassRunner.java:61) > 12:14:33 at org.eclipse.swtbot.eclipse.junit.headless.EclipseTestRunner.run(EclipseTestRunner.java:350) > 12:14:33 at org.eclipse.swtbot.eclipse.junit.headless.EclipseTestRunner.run(EclipseTestRunner.java:208) > 12:14:33 at org.eclipse.swtbot.eclipse.junit.headless.UITestApplication.runTests(UITestApplication.java:117) > 12:14:33 at org.eclipse.e4.ui.internal.workbench.swt.E4Testable$1.run(E4Testable.java:73) > 12:14:33 at java.lang.Thread.run(Thread.java:745) > 12:14:33 Caused by: org.eclipse.swtbot.swt.finder.widgets.TimeoutException: Timeout after: 5000 ms.: The widget (of type 'Button' and with mnemonic 'Finish' and with style 'SWT.PUSH') was not enabled. > 12:14:33 at org.eclipse.swtbot.swt.finder.SWTBotFactory.waitUntil(SWTBotFactory.java:522) > 12:14:33 at org.eclipse.swtbot.swt.finder.SWTBotFactory.waitUntil(SWTBotFactory.java:496) > 12:14:33 at org.eclipse.swtbot.swt.finder.SWTBotFactory.waitUntil(SWTBotFactory.java:484) > 12:14:33 at org.eclipse.swtbot.swt.finder.widgets.AbstractSWTBot.waitForEnabled(AbstractSWTBot.java:650) > 12:14:33 at org.eclipse.swtbot.swt.finder.widgets.SWTBotButton.click(SWTBotButton.java:65) > 12:14:33 at org.jboss.tools.tests.installation.InstallTest.continueInstall(InstallTest.java:154){code} > -- https://jenkins.mw.lab.eng.bos.redhat.com/hudson/job/jbosstools-install-g... -- This message was sent by Atlassian JIRA (v7.2.3#72005)

9 years, 1 month

1
0
0 / 0

[JBoss JIRA] (JBIDE-23875) For JBIDE 4.4.3.Final: Prepare for 4.4.3.Final / 10.3.0.GA [aerogear-hybrid]

by Friendly Jira Robot (JIRA)

Friendly Jira Robot created JBIDE-23875: ------------------------------------------- Summary: For JBIDE 4.4.3.Final: Prepare for 4.4.3.Final / 10.3.0.GA [aerogear-hybrid] Key: JBIDE-23875 URL: https://issues.jboss.org/browse/JBIDE-23875 Project: Tools (JBoss Tools) Issue Type: Task Components: aerogear-hybrid Reporter: Friendly Jira Robot Priority: Blocker Fix For: 4.4.3.Final For JBIDE 4.4.3.Final [aerogear-hybrid]: Please perform the following tasks: 1. Check out your existing *{color:orange}master{color}* branch: {code} git checkout master {code} 2. Update your *{color:orange}master branch{color}* root pom to use the latest parent pom version, *{color:orange}4.4.3.Final-SNAPSHOT{color}*: {code} <parent> <groupId>org.jboss.tools</groupId> <artifactId>parent</artifactId> <version>4.4.3.Final-SNAPSHOT</version> </parent> {code} Now, your root pom will use parent pom version: * *{color:orange}4.4.3.Final-SNAPSHOT{color}* in your *{color:orange}master{color}* branch 3. Ensure that component features/plugins have been [properly upversioned|http://wiki.eclipse.org/Version_Numbering#Overall_example], eg., from 1.0.0 to 1.0.1. {code} mvn -Dtycho.mode=maven org.eclipse.tycho:tycho-versions-plugin:0.26.0:set-version -DnewVersion=1.0.1-SNAPSHOT {code} 4a. Ensure you've *built your code* using the latest *minimum* target platform version 4.60.2.Final {code} mvn clean verify -Dtpc.version=4.60.2.Final {code} 4b. Ensure you've *run your tests* using the latest *maximum* target platform version 4.60.2.Final {code} mvn clean verify -Dtpc.version=4.60.2.Final {code} 5. Close (do not resolve) this JIRA when done. 6. If you have any outstanding [New + Noteworthy JIRAs|https://issues.jboss.org/issues/?jql=%28%28project%20%3D%20%22JBIDE...] to do, please complete them next. [Search for all task JIRA|https://issues.jboss.org/issues/?jql=%28%28project+in+%28JBDS%29+and...], or [Search for aerogear-hybrid task JIRA|https://issues.jboss.org/issues/?jql=%28%28project+in+%28JBDS%29+and...] -- This message was sent by Atlassian JIRA (v7.2.3#72005)

9 years, 1 month

1
0
0 / 0

[JBoss JIRA] (JBIDE-23876) For JBIDE 4.4.3.Final: Prepare for 4.4.3.Final / 10.3.0.GA [aerogear-hybrid]

by Friendly Jira Robot (JIRA)

Friendly Jira Robot created JBIDE-23876: ------------------------------------------- Summary: For JBIDE 4.4.3.Final: Prepare for 4.4.3.Final / 10.3.0.GA [aerogear-hybrid] Key: JBIDE-23876 URL: https://issues.jboss.org/browse/JBIDE-23876 Project: Tools (JBoss Tools) Issue Type: Task Components: aerogear-hybrid Reporter: Friendly Jira Robot Priority: Blocker Fix For: 4.4.3.Final For JBIDE 4.4.3.Final [aerogear-hybrid]: Please perform the following tasks: 1. Check out your existing *{color:orange}master{color}* branch: {code} git checkout master {code} 2. Update your *{color:orange}master branch{color}* root pom to use the latest parent pom version, *{color:orange}4.4.3.Final-SNAPSHOT{color}*: {code} <parent> <groupId>org.jboss.tools</groupId> <artifactId>parent</artifactId> <version>4.4.3.Final-SNAPSHOT</version> </parent> {code} Now, your root pom will use parent pom version: * *{color:orange}4.4.3.Final-SNAPSHOT{color}* in your *{color:orange}master{color}* branch 3. Ensure that component features/plugins have been [properly upversioned|http://wiki.eclipse.org/Version_Numbering#Overall_example], eg., from 1.0.0 to 1.0.1. {code} mvn -Dtycho.mode=maven org.eclipse.tycho:tycho-versions-plugin:0.26.0:set-version -DnewVersion=1.0.1-SNAPSHOT {code} 4a. Ensure you've *built your code* using the latest *minimum* target platform version 4.60.2.Final {code} mvn clean verify -Dtpc.version=4.60.2.Final {code} 4b. Ensure you've *run your tests* using the latest *maximum* target platform version 4.60.2.Final {code} mvn clean verify -Dtpc.version=4.60.2.Final {code} 5. Close (do not resolve) this JIRA when done. 6. If you have any outstanding [New + Noteworthy JIRAs|https://issues.jboss.org/issues/?jql=%28%28project%20%3D%20%22JBIDE...] to do, please complete them next. [Search for all task JIRA|https://issues.jboss.org/issues/?jql=%28%28project+in+%28JBDS%29+and...], or [Search for aerogear-hybrid task JIRA|https://issues.jboss.org/issues/?jql=%28%28project+in+%28JBDS%29+and...] -- This message was sent by Atlassian JIRA (v7.2.3#72005)

9 years, 1 month

1
0
0 / 0

[JBoss JIRA] (JBIDE-23867) OCBinary: is mixing platform independent with dependent code

by Andre Dietisheim (JIRA)

[ https://issues.jboss.org/browse/JBIDE-23867?page=com.atlassian.jira.plugi... ] Andre Dietisheim updated JBIDE-23867: ------------------------------------- Issue Type: Enhancement (was: Bug) > OCBinary: is mixing platform independent with dependent code > ------------------------------------------------------------ > > Key: JBIDE-23867 > URL: https://issues.jboss.org/browse/JBIDE-23867 > Project: Tools (JBoss Tools) > Issue Type: Enhancement > Components: openshift > Affects Versions: 4.4.3.AM2 > Reporter: Andre Dietisheim > Assignee: Rob Stryker > > OCBinary is suing enums for the different platform. The platform instance is chosen right when you get the instance that you want to work with: > {code} > OCBinary#getInstance > {code} > {code} > public static OCBinary getInstance() { > if (SystemUtils.IS_OS_WINDOWS) { > return WINDOWS; > } else { > return OTHER; > } > } > {code} > But then, latter code (that was introduced later in #getSystemPathLocation ignoring it and start being platform independent again, even setting the default to be linux: > {code} > public String getSystemPathLocation() { > if (locationBinary == null) { > this.locationBinary = new CommandLocationBinary("oc"); > locationBinary.addPlatformLocation(Platform.OS_LINUX, OC_DEFAULTLOCATION_LINUX); > locationBinary.setDefaultPlatform(Platform.OS_LINUX); > } > return locationBinary.findLocation(); > } > {code} > Even worse is that the above code hard-codes the oc binary to be "oc" while the enum for windows is defining it as "oc.exe" -- This message was sent by Atlassian JIRA (v7.2.3#72005)

9 years, 1 month

1
0
0 / 0

[JBoss JIRA] (JBIDE-23867) OCBinary: is mixing platform independent with dependent code

by Andre Dietisheim (JIRA)

[ https://issues.jboss.org/browse/JBIDE-23867?page=com.atlassian.jira.plugi... ] Andre Dietisheim edited comment on JBIDE-23867 at 2/6/17 2:53 PM: ------------------------------------------------------------------ [~rob.stryker] this is not a bug per se (changing the issue type accordingly). It's just something that one stumbles upon when reading code, something that one could do more cleanly for sure. But there clearly is no urgency. was (Author: adietish): [~rob.stryker] this is not a bug per se (changing the issue type accordingly). It's just something that one stumbles upon when reading code, something that one could do more cleanly for sure. > OCBinary: is mixing platform independent with dependent code > ------------------------------------------------------------ > > Key: JBIDE-23867 > URL: https://issues.jboss.org/browse/JBIDE-23867 > Project: Tools (JBoss Tools) > Issue Type: Enhancement > Components: openshift > Affects Versions: 4.4.3.AM2 > Reporter: Andre Dietisheim > Assignee: Rob Stryker > > OCBinary is suing enums for the different platform. The platform instance is chosen right when you get the instance that you want to work with: > {code} > OCBinary#getInstance > {code} > {code} > public static OCBinary getInstance() { > if (SystemUtils.IS_OS_WINDOWS) { > return WINDOWS; > } else { > return OTHER; > } > } > {code} > But then, latter code (that was introduced later in #getSystemPathLocation ignoring it and start being platform independent again, even setting the default to be linux: > {code} > public String getSystemPathLocation() { > if (locationBinary == null) { > this.locationBinary = new CommandLocationBinary("oc"); > locationBinary.addPlatformLocation(Platform.OS_LINUX, OC_DEFAULTLOCATION_LINUX); > locationBinary.setDefaultPlatform(Platform.OS_LINUX); > } > return locationBinary.findLocation(); > } > {code} > Even worse is that the above code hard-codes the oc binary to be "oc" while the enum for windows is defining it as "oc.exe" -- This message was sent by Atlassian JIRA (v7.2.3#72005)

9 years, 1 month

1
0
0 / 0

[JBoss JIRA] (JBIDE-23874) For JBIDE 4.4.3.Final: Prepare for 4.4.3.Final / 10.3.0.GA [aerogear-hybrid]

by Friendly Jira Robot (JIRA)

Friendly Jira Robot created JBIDE-23874: ------------------------------------------- Summary: For JBIDE 4.4.3.Final: Prepare for 4.4.3.Final / 10.3.0.GA [aerogear-hybrid] Key: JBIDE-23874 URL: https://issues.jboss.org/browse/JBIDE-23874 Project: Tools (JBoss Tools) Issue Type: Task Components: aerogear-hybrid Reporter: Friendly Jira Robot Priority: Blocker Fix For: 4.4.3.Final For JBIDE 4.4.3.Final [aerogear-hybrid]: Please perform the following tasks: 1. Check out your existing *{color:orange}master{color}* branch: {code} git checkout master {code} 2. Update your *{color:orange}master branch{color}* root pom to use the latest parent pom version, *{color:orange}4.4.3.Final-SNAPSHOT{color}*: {code} <parent> <groupId>org.jboss.tools</groupId> <artifactId>parent</artifactId> <version>4.4.3.Final-SNAPSHOT</version> </parent> {code} Now, your root pom will use parent pom version: * *{color:orange}4.4.3.Final-SNAPSHOT{color}* in your *{color:orange}master{color}* branch 3. Ensure that component features/plugins have been [properly upversioned|http://wiki.eclipse.org/Version_Numbering#Overall_example], eg., from 1.0.0 to 1.0.1. {code} mvn -Dtycho.mode=maven org.eclipse.tycho:tycho-versions-plugin:0.26.0:set-version -DnewVersion=1.0.1-SNAPSHOT {code} 4a. Ensure you've *built your code* using the latest *minimum* target platform version 4.60.2.Final {code} mvn clean verify -Dtpc.version=4.60.2.Final {code} 4b. Ensure you've *run your tests* using the latest *maximum* target platform version 4.60.2.Final {code} mvn clean verify -Dtpc.version=4.60.2.Final {code} 5. Close (do not resolve) this JIRA when done. 6. If you have any outstanding [New + Noteworthy JIRAs|https://issues.jboss.org/issues/?jql=%28%28project%20%3D%20%22JBIDE...] to do, please complete them next. [Search for all task JIRA|https://issues.jboss.org/issues/?jql=%28%28project+in+%28JBDS%29+and...], or [Search for aerogear-hybrid task JIRA|https://issues.jboss.org/issues/?jql=%28%28project+in+%28JBDS%29+and...] -- This message was sent by Atlassian JIRA (v7.2.3#72005)

9 years, 1 month

1
0
0 / 0

[JBoss JIRA] (JBIDE-23867) OCBinary: is mixing platform independent with dependent code

by Andre Dietisheim (JIRA)

[ https://issues.jboss.org/browse/JBIDE-23867?page=com.atlassian.jira.plugi... ] Andre Dietisheim commented on JBIDE-23867: ------------------------------------------ [~rob.stryker] this is not a bug per se (changing the issue type accordingly). It's just something that one stumbles upon when reading code, something that one could do more cleanly for sure. > OCBinary: is mixing platform independent with dependent code > ------------------------------------------------------------ > > Key: JBIDE-23867 > URL: https://issues.jboss.org/browse/JBIDE-23867 > Project: Tools (JBoss Tools) > Issue Type: Bug > Components: openshift > Affects Versions: 4.4.3.AM2 > Reporter: Andre Dietisheim > Assignee: Rob Stryker > > OCBinary is suing enums for the different platform. The platform instance is chosen right when you get the instance that you want to work with: > {code} > OCBinary#getInstance > {code} > {code} > public static OCBinary getInstance() { > if (SystemUtils.IS_OS_WINDOWS) { > return WINDOWS; > } else { > return OTHER; > } > } > {code} > But then, latter code (that was introduced later in #getSystemPathLocation ignoring it and start being platform independent again, even setting the default to be linux: > {code} > public String getSystemPathLocation() { > if (locationBinary == null) { > this.locationBinary = new CommandLocationBinary("oc"); > locationBinary.addPlatformLocation(Platform.OS_LINUX, OC_DEFAULTLOCATION_LINUX); > locationBinary.setDefaultPlatform(Platform.OS_LINUX); > } > return locationBinary.findLocation(); > } > {code} > Even worse is that the above code hard-codes the oc binary to be "oc" while the enum for windows is defining it as "oc.exe" -- This message was sent by Atlassian JIRA (v7.2.3#72005)

9 years, 1 month

1
0
0 / 0

[JBoss JIRA] (JBIDE-23871) install-grinder failure: "The widget (of type 'Button' and with mnemonic 'Finish' and with style 'SWT.PUSH') was not enabled."

by Mickael Istria (JIRA)

[ https://issues.jboss.org/browse/JBIDE-23871?page=com.atlassian.jira.plugi... ] Mickael Istria commented on JBIDE-23871: ---------------------------------------- The screenshot is helpful too https://jenkins.mw.lab.eng.bos.redhat.com/hudson/job/jbosstools-install-g... . It seems like there is no issue with install grinder itself, but that the provided URL doesn't contain a site. Either the job config is wrong, or the URL is actually missing contnet. > install-grinder failure: "The widget (of type 'Button' and with mnemonic 'Finish' and with style 'SWT.PUSH') was not enabled." > ------------------------------------------------------------------------------------------------------------------------------ > > Key: JBIDE-23871 > URL: https://issues.jboss.org/browse/JBIDE-23871 > Project: Tools (JBoss Tools) > Issue Type: Bug > Components: install-tests > Affects Versions: 4.4.3.AM2 > Reporter: Nick Boldt > > {code} > 12:14:33 Caused by: org.eclipse.swtbot.swt.finder.widgets.TimeoutException: > Timeout after: 5000 ms.: > The widget (of type 'Button' and with mnemonic 'Finish' and with > style 'SWT.PUSH') was not enabled. > {code} > {code} > 12:14:33 Testcase: testInstall took 103.682 sec > 12:14:33 Caused an ERROR > 12:14:33 Internal error > 12:14:33 java.lang.RuntimeException: Internal error > 12:14:33 at org.jboss.tools.tests.installation.InstallTest.continueInstall(InstallTest.java:213) > 12:14:33 at org.jboss.tools.tests.installation.InstallTest.continueInstall(InstallTest.java:147) > 12:14:33 at org.jboss.tools.tests.installation.InstallTest.installFromSite(InstallTest.java:133) > 12:14:33 at org.jboss.tools.tests.installation.InstallTest.testInstall(InstallTest.java:78) > 12:14:33 at org.eclipse.swtbot.swt.finder.junit.internal.CapturingFrameworkMethod.invokeExplosively(CapturingFrameworkMethod.java:47) > 12:14:33 at org.eclipse.swtbot.swt.finder.junit.SWTBotJunit4ClassRunner.runChild(SWTBotJunit4ClassRunner.java:76) > 12:14:33 at org.eclipse.swtbot.swt.finder.junit.SWTBotJunit4ClassRunner.run(SWTBotJunit4ClassRunner.java:61) > 12:14:33 at org.eclipse.swtbot.eclipse.junit.headless.EclipseTestRunner.run(EclipseTestRunner.java:350) > 12:14:33 at org.eclipse.swtbot.eclipse.junit.headless.EclipseTestRunner.run(EclipseTestRunner.java:208) > 12:14:33 at org.eclipse.swtbot.eclipse.junit.headless.UITestApplication.runTests(UITestApplication.java:117) > 12:14:33 at org.eclipse.e4.ui.internal.workbench.swt.E4Testable$1.run(E4Testable.java:73) > 12:14:33 at java.lang.Thread.run(Thread.java:745) > 12:14:33 Caused by: org.eclipse.swtbot.swt.finder.widgets.TimeoutException: Timeout after: 5000 ms.: The widget (of type 'Button' and with mnemonic 'Finish' and with style 'SWT.PUSH') was not enabled. > 12:14:33 at org.eclipse.swtbot.swt.finder.SWTBotFactory.waitUntil(SWTBotFactory.java:522) > 12:14:33 at org.eclipse.swtbot.swt.finder.SWTBotFactory.waitUntil(SWTBotFactory.java:496) > 12:14:33 at org.eclipse.swtbot.swt.finder.SWTBotFactory.waitUntil(SWTBotFactory.java:484) > 12:14:33 at org.eclipse.swtbot.swt.finder.widgets.AbstractSWTBot.waitForEnabled(AbstractSWTBot.java:650) > 12:14:33 at org.eclipse.swtbot.swt.finder.widgets.SWTBotButton.click(SWTBotButton.java:65) > 12:14:33 at org.jboss.tools.tests.installation.InstallTest.continueInstall(InstallTest.java:154){code} > -- https://jenkins.mw.lab.eng.bos.redhat.com/hudson/job/jbosstools-install-g... -- This message was sent by Atlassian JIRA (v7.2.3#72005)

9 years, 1 month

1
0
0 / 0

[JBoss JIRA] (JBIDE-23873) For JBIDE 4.4.3.Final: Prepare for 4.4.3.Final / 10.3.0.GA [aerogear-hybrid]

by Friendly Jira Robot (JIRA)

Friendly Jira Robot created JBIDE-23873: ------------------------------------------- Summary: For JBIDE 4.4.3.Final: Prepare for 4.4.3.Final / 10.3.0.GA [aerogear-hybrid] Key: JBIDE-23873 URL: https://issues.jboss.org/browse/JBIDE-23873 Project: Tools (JBoss Tools) Issue Type: Task Components: aerogear-hybrid Reporter: Friendly Jira Robot Priority: Blocker Fix For: 4.4.3.Final For JBIDE 4.4.3.Final [aerogear-hybrid]: Please perform the following tasks: 1. Check out your existing *{color:orange}master{color}* branch: {code} git checkout master {code} 2. Update your *{color:orange}master branch{color}* root pom to use the latest parent pom version, *{color:orange}4.4.3.Final-SNAPSHOT{color}*: {code} <parent> <groupId>org.jboss.tools</groupId> <artifactId>parent</artifactId> <version>4.4.3.Final-SNAPSHOT</version> </parent> {code} Now, your root pom will use parent pom version: * *{color:orange}4.4.3.Final-SNAPSHOT{color}* in your *{color:orange}master{color}* branch 3. Ensure that component features/plugins have been [properly upversioned|http://wiki.eclipse.org/Version_Numbering#Overall_example], eg., from 1.0.0 to 1.0.1. {code} mvn -Dtycho.mode=maven org.eclipse.tycho:tycho-versions-plugin:0.26.0:set-version -DnewVersion=1.0.1-SNAPSHOT {code} 4a. Ensure you've *built your code* using the latest *minimum* target platform version 4.60.2.Final {code} mvn clean verify -Dtpc.version=4.60.2.Final {code} 4b. Ensure you've *run your tests* using the latest *maximum* target platform version 4.60.2.Final {code} mvn clean verify -Dtpc.version=4.60.2.Final {code} 5. Close (do not resolve) this JIRA when done. 6. If you have any outstanding [New + Noteworthy JIRAs|https://issues.jboss.org/issues/?jql=%28%28project%20%3D%20%22JBIDE...] to do, please complete them next. [Search for all task JIRA|https://issues.jboss.org/issues/?jql=%28%28project+in+%28JBDS%29+and...], or [Search for aerogear-hybrid task JIRA|https://issues.jboss.org/issues/?jql=%28%28project+in+%28JBDS%29+and...] -- This message was sent by Atlassian JIRA (v7.2.3#72005)

9 years, 1 month

1
0
0 / 0

[JBoss JIRA] (JBIDE-23867) OCBinary: is mixing platform independent with dependent code

by Rob Stryker (JIRA)

[ https://issues.jboss.org/browse/JBIDE-23867?page=com.atlassian.jira.plugi... ] Rob Stryker commented on JBIDE-23867: ------------------------------------- [~adietish] Does this actually cause a problem? Seriously asking. The default platform is only used if the current platform (ie windows) cannot be found. CommandLocationBinary.findLocation(etc) will also make sure to pass in the current platform. Is there an **actual** bug here? Or are you complaining the style is hard to understand? Does any method call actually return the wrong thing?? > OCBinary: is mixing platform independent with dependent code > ------------------------------------------------------------ > > Key: JBIDE-23867 > URL: https://issues.jboss.org/browse/JBIDE-23867 > Project: Tools (JBoss Tools) > Issue Type: Bug > Components: openshift > Affects Versions: 4.4.3.AM2 > Reporter: Andre Dietisheim > Assignee: Rob Stryker > > OCBinary is suing enums for the different platform. The platform instance is chosen right when you get the instance that you want to work with: > {code} > OCBinary#getInstance > {code} > {code} > public static OCBinary getInstance() { > if (SystemUtils.IS_OS_WINDOWS) { > return WINDOWS; > } else { > return OTHER; > } > } > {code} > But then, latter code (that was introduced later in #getSystemPathLocation ignoring it and start being platform independent again, even setting the default to be linux: > {code} > public String getSystemPathLocation() { > if (locationBinary == null) { > this.locationBinary = new CommandLocationBinary("oc"); > locationBinary.addPlatformLocation(Platform.OS_LINUX, OC_DEFAULTLOCATION_LINUX); > locationBinary.setDefaultPlatform(Platform.OS_LINUX); > } > return locationBinary.findLocation(); > } > {code} > Even worse is that the above code hard-codes the oc binary to be "oc" while the enum for windows is defining it as "oc.exe" -- This message was sent by Atlassian JIRA (v7.2.3#72005)

9 years, 1 month

1
0
0 / 0

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

jbosstools-issues February 2017