[JBoss JIRA] (JBIDE-24114) [parent pom] do not skip baseline comparison check when -DskipTests=true
by Radim Hopp (JIRA)
[ https://issues.jboss.org/browse/JBIDE-24114?page=com.atlassian.jira.plugi... ]
Radim Hopp commented on JBIDE-24114:
------------------------------------
Sorry [~nickboldt], It's so easy to overlook the "I" in skipITests. At least openshift PR check job runs with skipITests (no skipTest as I claimed earlier). My mistake.
> [parent pom] do not skip baseline comparison check when -DskipTests=true
> ------------------------------------------------------------------------
>
> Key: JBIDE-24114
> URL: https://issues.jboss.org/browse/JBIDE-24114
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: build
> Affects Versions: 4.4.4.AM1, 4.5.0.AM1
> Reporter: Nick Boldt
> Assignee: Jeff MAURY
> Fix For: 4.4.4.AM2, 4.5.0.AM1
>
>
> Currently, when you build with -DskipTests, the baseline checks are also skipped. This means that if you make a change to a file in a plugin, and build it locally to see if anything breaks, but forget to bump the version of the plugin and its containing feature, you won't see the baseline check failure until it's built in Jenkins and someone like me complains about it to you directly.
> This happened recently in the 4.4.x branch for changes to openshift and base.
> So I propose this change in parent pom for 4.4.x and master branches:
> {code}
> - <skipBaselineComparison>${skipTestsOrITests}</skipBaselineComparison>
> + <skipBaselineComparison>false</skipBaselineComparison>
> {code}
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
9 years
[JBoss JIRA] (JBIDE-24114) [parent pom] do not skip baseline comparison check when -DskipTests=true
by Nick Boldt (JIRA)
[ https://issues.jboss.org/browse/JBIDE-24114?page=com.atlassian.jira.plugi... ]
Nick Boldt edited comment on JBIDE-24114 at 3/20/17 9:07 AM:
-------------------------------------------------------------
The PR jobs should be running unit tests, but skipping Integration Tests with -DskipITests=true.
[~rhopp] can you fix the PR jobs so they run the unit tests? Why was it decided to skip unit tests when running PR checks? Simply to verify compilation? Shouldn't people be doing THAT locally before pushing the PR to github for review? [~jeffmaury] WDYT?
was (Author: nickboldt):
The PR jobs should be running unit tests, but skipping Itegration Tests with skipITests=true.
[~rhopp] can you fix the PR jobs so they run the unit tests? Why was it decided to skip unit tests when running PR checks? Simply to verify compilation? Shouldn't people be doing THAT locally before pushing the PR to github for review? [~jeffmaury] WDYT?
> [parent pom] do not skip baseline comparison check when -DskipTests=true
> ------------------------------------------------------------------------
>
> Key: JBIDE-24114
> URL: https://issues.jboss.org/browse/JBIDE-24114
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: build
> Affects Versions: 4.4.4.AM1, 4.5.0.AM1
> Reporter: Nick Boldt
> Assignee: Jeff MAURY
> Fix For: 4.4.4.AM2, 4.5.0.AM1
>
>
> Currently, when you build with -DskipTests, the baseline checks are also skipped. This means that if you make a change to a file in a plugin, and build it locally to see if anything breaks, but forget to bump the version of the plugin and its containing feature, you won't see the baseline check failure until it's built in Jenkins and someone like me complains about it to you directly.
> This happened recently in the 4.4.x branch for changes to openshift and base.
> So I propose this change in parent pom for 4.4.x and master branches:
> {code}
> - <skipBaselineComparison>${skipTestsOrITests}</skipBaselineComparison>
> + <skipBaselineComparison>false</skipBaselineComparison>
> {code}
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
9 years
[JBoss JIRA] (JBIDE-24114) [parent pom] do not skip baseline comparison check when -DskipTests=true
by Nick Boldt (JIRA)
[ https://issues.jboss.org/browse/JBIDE-24114?page=com.atlassian.jira.plugi... ]
Nick Boldt commented on JBIDE-24114:
------------------------------------
The PR jobs should be running unit tests, but skipping Itegration Tests with skipITests=true.
[~rhopp] can you fix the PR jobs so they run the unit tests? Why was it decided to skip unit tests when running PR checks? Simply to verify compilation? Shouldn't people be doing THAT locally before pushing the PR to github for review? [~jeffmaury] WDYT?
> [parent pom] do not skip baseline comparison check when -DskipTests=true
> ------------------------------------------------------------------------
>
> Key: JBIDE-24114
> URL: https://issues.jboss.org/browse/JBIDE-24114
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: build
> Affects Versions: 4.4.4.AM1, 4.5.0.AM1
> Reporter: Nick Boldt
> Assignee: Jeff MAURY
> Fix For: 4.4.4.AM2, 4.5.0.AM1
>
>
> Currently, when you build with -DskipTests, the baseline checks are also skipped. This means that if you make a change to a file in a plugin, and build it locally to see if anything breaks, but forget to bump the version of the plugin and its containing feature, you won't see the baseline check failure until it's built in Jenkins and someone like me complains about it to you directly.
> This happened recently in the 4.4.x branch for changes to openshift and base.
> So I propose this change in parent pom for 4.4.x and master branches:
> {code}
> - <skipBaselineComparison>${skipTestsOrITests}</skipBaselineComparison>
> + <skipBaselineComparison>false</skipBaselineComparison>
> {code}
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
9 years
[JBoss JIRA] (ERT-496) Proxy doesn't work when global OS proxy is set with protocol in the beginning [EBZ#513655]
by Friendly Jira Robot (JIRA)
Friendly Jira Robot created ERT-496:
---------------------------------------
Summary: Proxy doesn't work when global OS proxy is set with protocol in the beginning [EBZ#513655]
Key: ERT-496
URL: https://issues.jboss.org/browse/ERT-496
Project: Eclipse Release Train
Issue Type: Task
Components: Platform
Reporter: Friendly Jira Robot
Created attachment 267256
Fedora proxy configured with protocol
EXEC: set global proxy with "http://" and "https://" in the beginning on Fedora - see an attached screenshot
ASSERT: internet is accessible from any external browser (Chrome for example)
ASSERT: internet is NOT accessible from Internal Browser in Eclipse
EXEC: remove protocols "http://" and "https://" from the beginning of proxy in Fedora settings.
ASSERT: internet is accessible from Internal Browser
Configuring proxy in Window -> Preferences -> General -> Network Connection doesn't influence the situation anyhow. Tried all active providers(Direct, Manual and Native). In both cases (with and without protocols specified) doesn't change the situation.
I think that proxy must work fine even if global proxy settings for OS is specified with schema in the beginning, as that do browsers, for example.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
9 years
[JBoss JIRA] (JBIDE-24118) NullPointerException in JaxRsConfigurator.canConfigure
by Dmitrii Bocharov (JIRA)
[ https://issues.jboss.org/browse/JBIDE-24118?page=com.atlassian.jira.plugi... ]
Dmitrii Bocharov reassigned JBIDE-24118:
----------------------------------------
Assignee: Dmitrii Bocharov
> NullPointerException in JaxRsConfigurator.canConfigure
> ------------------------------------------------------
>
> Key: JBIDE-24118
> URL: https://issues.jboss.org/browse/JBIDE-24118
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: webservices
> Reporter: Automated Error Reporting Bot
> Assignee: Dmitrii Bocharov
>
> The following problem was reported via the automated error reporting:
> Message:
> java.lang.NullPointerException: null
> at org.jboss.tools.ws.jaxrs.ui.internal.importer.JaxRsConfigurator.canConfigure(JaxRsConfigurator.java:66)
> at org.eclipse.ui.internal.wizards.datatransfer.SmartImportJob.importProjectAndChildrenRecursively(SmartImportJob.java:491)
> at org.eclipse.ui.internal.wizards.datatransfer.SmartImportJob.run(SmartImportJob.java:249)
> at org.eclipse.core.internal.jobs.Worker.run(Worker.java:55)
> Bundles:
> | org.eclipse.core.jobs | 3.8.0.v20160509-0411 | 3.8.0.v20161020-1522 |
> | org.eclipse.ui | 3.108.0.v20160518-1929 | 3.109.0.v20161017-1617 |
> | org.jboss.tools.ws.jaxrs.ui | 1.9.0.Final-v20160610-0003-B1 | 1.9.3.v20161214-2127 |
> Operating Systems:
> | Linux | 3.13.0 | 4.9.13.fc25 |
> | MacOSX | 10.11.6 | 10.12.3 |
> | Windows | 6.1.0 | 10.0.0 |
> The above information is a snapshot of the collected data. Visit https://aer.ctrlflow.com/redhat/reviewers/#!/problems/574315d3e4b0138d62f... for the latest data.
> Thank you for your assistance.
> Your friendly error-reports-inbox.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
9 years
[JBoss JIRA] (JBIDE-24118) NullPointerException in JaxRsConfigurator.canConfigure
by Automated Error Reporting Bot (JIRA)
Automated Error Reporting Bot created JBIDE-24118:
-----------------------------------------------------
Summary: NullPointerException in JaxRsConfigurator.canConfigure
Key: JBIDE-24118
URL: https://issues.jboss.org/browse/JBIDE-24118
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: webservices
Reporter: Automated Error Reporting Bot
The following problem was reported via the automated error reporting:
Message:
java.lang.NullPointerException: null
at org.jboss.tools.ws.jaxrs.ui.internal.importer.JaxRsConfigurator.canConfigure(JaxRsConfigurator.java:66)
at org.eclipse.ui.internal.wizards.datatransfer.SmartImportJob.importProjectAndChildrenRecursively(SmartImportJob.java:491)
at org.eclipse.ui.internal.wizards.datatransfer.SmartImportJob.run(SmartImportJob.java:249)
at org.eclipse.core.internal.jobs.Worker.run(Worker.java:55)
Bundles:
| org.eclipse.core.jobs | 3.8.0.v20160509-0411 | 3.8.0.v20161020-1522 |
| org.eclipse.ui | 3.108.0.v20160518-1929 | 3.109.0.v20161017-1617 |
| org.jboss.tools.ws.jaxrs.ui | 1.9.0.Final-v20160610-0003-B1 | 1.9.3.v20161214-2127 |
Operating Systems:
| Linux | 3.13.0 | 4.9.13.fc25 |
| MacOSX | 10.11.6 | 10.12.3 |
| Windows | 6.1.0 | 10.0.0 |
The above information is a snapshot of the collected data. Visit https://aer.ctrlflow.com/redhat/reviewers/#!/problems/574315d3e4b0138d62f... for the latest data.
Thank you for your assistance.
Your friendly error-reports-inbox.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
9 years