[JBoss JIRA] (JBIDE-24114) [parent pom] do not skip baseline comparison check when -DskipTests=true
by Radim Hopp (JIRA)
[ https://issues.jboss.org/browse/JBIDE-24114?page=com.atlassian.jira.plugi... ]
Radim Hopp commented on JBIDE-24114:
------------------------------------
I'm +1 for this, mainly because PR check jobs are run with skipTests=true. At least PR check job should catch the non-bumped plugins.
> [parent pom] do not skip baseline comparison check when -DskipTests=true
> ------------------------------------------------------------------------
>
> Key: JBIDE-24114
> URL: https://issues.jboss.org/browse/JBIDE-24114
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: build
> Affects Versions: 4.4.4.AM1, 4.5.0.AM1
> Reporter: Nick Boldt
> Assignee: Jeff MAURY
> Fix For: 4.4.4.AM2, 4.5.0.AM1
>
>
> Currently, when you build with -DskipTests, the baseline checks are also skipped. This means that if you make a change to a file in a plugin, and build it locally to see if anything breaks, but forget to bump the version of the plugin and its containing feature, you won't see the baseline check failure until it's built in Jenkins and someone like me complains about it to you directly.
> This happened recently in the 4.4.x branch for changes to openshift and base.
> So I propose this change in parent pom for 4.4.x and master branches:
> {code}
> - <skipBaselineComparison>${skipTestsOrITests}</skipBaselineComparison>
> + <skipBaselineComparison>false</skipBaselineComparison>
> {code}
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
9 years
[JBoss JIRA] (JBIDE-24114) [parent pom] do not skip baseline comparison check when -DskipTests=true
by Martin Malina (JIRA)
[ https://issues.jboss.org/browse/JBIDE-24114?page=com.atlassian.jira.plugi... ]
Martin Malina commented on JBIDE-24114:
---------------------------------------
Sounds reasonable. +1. Can you think of any downside?
> [parent pom] do not skip baseline comparison check when -DskipTests=true
> ------------------------------------------------------------------------
>
> Key: JBIDE-24114
> URL: https://issues.jboss.org/browse/JBIDE-24114
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: build
> Affects Versions: 4.4.4.AM1, 4.5.0.AM1
> Reporter: Nick Boldt
> Assignee: Jeff MAURY
> Fix For: 4.4.4.AM2, 4.5.0.AM1
>
>
> Currently, when you build with -DskipTests, the baseline checks are also skipped. This means that if you make a change to a file in a plugin, and build it locally to see if anything breaks, but forget to bump the version of the plugin and its containing feature, you won't see the baseline check failure until it's built in Jenkins and someone like me complains about it to you directly.
> This happened recently in the 4.4.x branch for changes to openshift and base.
> So I propose this change in parent pom for 4.4.x and master branches:
> {code}
> - <skipBaselineComparison>${skipTestsOrITests}</skipBaselineComparison>
> + <skipBaselineComparison>false</skipBaselineComparison>
> {code}
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
9 years
[JBoss JIRA] (JBIDE-23489) Find out how to run mvn clean verify -Dtest.installBase=path/to/devstudio/rpm
by Lukáš Valach (JIRA)
[ https://issues.jboss.org/browse/JBIDE-23489?page=com.atlassian.jira.plugi... ]
Lukáš Valach edited comment on JBIDE-23489 at 3/20/17 6:18 AM:
---------------------------------------------------------------
I have discused this problem with [~vkadlcik], he has test working against RPM. He doesn't use Tycho.
This way is less confortable, but I just letting you know about this option.
There is what he does:
# White SWTBot or Red Deer test and upload it to update site
# Install Devstudio RPM
# Install test as plugin
eclipse \
-application org.eclipse.equinox.p2.director \
-repository file://$UPDATE_SITE \
-i $FEATURE_WITH_OUR_PLUGIN
(Plugin will be installed in $HOME/.eclipse/)
# Start test
eclipse \
-application org.eclipse.swtbot.eclipse.junit.headless.swtbottestapplication \
-testPluginName $OUR_PLUGIN_ID \
-className $OUR_TEST_CLASS
Demo: http://pkgs.devel.redhat.com/cgit/tests/eclipse/tree/Demo/rhbz910369_by_s...
was (Author: lvalach):
I have discused this problem with [~vkadlcik], he has test working against RPM. He doesn't use Tycho.
This way is less confortable, but I just letting you know about this option.
There is what he does:
# White SWTBot or Red Deer test and upload it to update site
# Install Devstudio RPM
# Install test as plugin
eclipse \
-application org.eclipse.equinox.p2.director \
-repository file://$UPDATE_SITE \
-i $FEATURE_WITH_OUR_PLUGIN
(Plugin will be installed in $HOME/.eclipse/)
# Start test
eclipse \
-application org.eclipse.swtbot.eclipse.junit.headless.swtbottestapplication \
-testPluginName $OUR_PLUGIN_ID \
-className $OUR_TEST_CLASS
> Find out how to run mvn clean verify -Dtest.installBase=path/to/devstudio/rpm
> ------------------------------------------------------------------------------
>
> Key: JBIDE-23489
> URL: https://issues.jboss.org/browse/JBIDE-23489
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: build
> Affects Versions: 4.4.2.AM3
> Reporter: Pavol Srna
> Fix For: 4.4.x
>
> Attachments: FreeMarket_rhscl_enabled.log, Freemarker_testRuntime_p2Installed.log
>
>
> We need to find a way how to run automated tests agains devstudio rpm.
> I've tried the following paths:
> 1) (as root) mvn clean verify -Dtest.installBase=/opt/rh/rh-eclipse46/root/usr/shareclipse/droplets/devstudio/eclipse/
> 2) (as hudson) mvn clean verify -Dtest.installBase=~/.eclipse/org.eclipse.platform_283378046_linux_gtk_x86_64
> But none of the above works.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
9 years
[JBoss JIRA] (JBIDE-24116) NullPointerException in JSFPromptingProvider.getVariables
by Automated Error Reporting Bot (JIRA)
Automated Error Reporting Bot created JBIDE-24116:
-----------------------------------------------------
Summary: NullPointerException in JSFPromptingProvider.getVariables
Key: JBIDE-24116
URL: https://issues.jboss.org/browse/JBIDE-24116
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: jsf
Reporter: Automated Error Reporting Bot
The following problem was reported via the automated error reporting:
Message:
java.lang.NullPointerException: null
at org.jboss.tools.jsf.model.pv.JSFPromptingProvider.getVariables(JSFPromptingProvider.java:268)
at org.jboss.tools.jsf.model.JSFELCompletionEngine.resolveVariables(JSFELCompletionEngine.java:144)
at org.jboss.tools.jsf.model.JSFELCompletionEngine.resolveVariables(JSFELCompletionEngine.java:103)
at org.jboss.tools.jsf.model.JSFELCompletionEngine.resolveVariables(JSFELCompletionEngine.java:83)
at org.jboss.tools.common.el.core.ca.AbstractELCompletionEngine.resolveELOperand(AbstractELCompletionEngine.java:466)
at org.jboss.tools.common.el.core.ca.AbstractELCompletionEngine.resolveELOperand(AbstractELCompletionEngine.java:282)
at org.jboss.tools.common.el.core.ca.AbstractELCompletionEngine.resolve(AbstractELCompletionEngine.java:165)
at org.jboss.tools.jst.web.kb.internal.validation.ELValidator.validateElOperand(ELValidator.java:397)
at org.jboss.tools.jst.web.kb.internal.validation.ELValidator.validateELExpression(ELValidator.java:359)
at org.jboss.tools.jst.web.kb.internal.validation.ELValidator.validateEL(ELValidator.java:337)
at org.jboss.tools.jst.web.kb.internal.validation.ELValidator.validate(ELValidator.java:278)
at org.jboss.tools.common.validation.AsYouTypeValidatorManager.validate(AsYouTypeValidatorManager.java:183)
at org.jboss.tools.common.validation.AsYouTypeValidatorManager.validateString(AsYouTypeValidatorManager.java:205)
at org.jboss.tools.common.validation.AsYouTypeValidatorManager.validateString(AsYouTypeValidatorManager.java:200)
at org.jboss.tools.common.validation.AsYouTypeValidatorManager.validate(AsYouTypeValidatorManager.java:254)
at org.eclipse.wst.sse.ui.internal.reconcile.validator.ReconcileStepForValidator.validate(ReconcileStepForValidator.java:381)
at org.eclipse.wst.sse.ui.internal.reconcile.validator.ReconcileStepForValidator.reconcileModel(ReconcileStepForValidator.java:259)
at org.eclipse.jface.text.reconciler.AbstractReconcileStep.reconcile(AbstractReconcileStep.java:95)
at org.eclipse.wst.sse.ui.internal.reconcile.validator.ValidatorStrategy.reconcile(ValidatorStrategy.java:269)
at org.eclipse.wst.sse.ui.internal.reconcile.DocumentRegionProcessor.process(DocumentRegionProcessor.java:321)
at org.eclipse.wst.sse.ui.internal.reconcile.StructuredRegionProcessor.process(StructuredRegionProcessor.java:258)
at org.eclipse.wst.sse.ui.internal.reconcile.DirtyRegionProcessor$BackgroundThread.run(DirtyRegionProcessor.java:691)
Bundles:
| org.eclipse.core.jobs | 3.7.0.v20150330-2103 | 3.8.0.v20160509-0411 |
| org.eclipse.jface.text | 3.10.0.v20150603-1752 | 3.11.2.v20161113-1700 |
| org.eclipse.wst.sse.ui | 1.3.401.v201510130005 | 1.3.500.v201605120129 |
| org.eclipse.wst.validation | 1.2.700.v201508251749 | 1.2.700.v201508251749 |
| org.eclipse.wst.xml.ui | 1.1.501.v201501212057 | 1.1.700.v201604272318 |
| org.jboss.tools.common.el.core | 3.7.1.Final-v20160408-2358-B112 | 3.8.3.v20161213-1258 |
| org.jboss.tools.common.text.xml | 3.7.1.Final-v20160408-2358-B112 | 3.8.1.v20160607-2053 |
| org.jboss.tools.common.validation | 3.7.1.Final-v20160408-2358-B112 | 3.8.3.v20161213-1258 |
| org.jboss.tools.jsf | 3.7.1.Final-v20160330-2256-B84 | 3.8.3.v20161214-1452 |
| org.jboss.tools.jst.web.kb | 3.7.1.Final-v20160331-0256-B96 | 3.8.3.v20161214-1634 |
| org.jboss.tools.jst.web.ui | 3.7.1.Final-v20160331-0256-B96 | 3.8.1.v20160628-0959 |
Operating Systems:
| Linux | 4.7.10.fc23 | 4.8.8.fc24 |
| MacOSX | 10.11.6 | 10.11.6 |
| Windows | 6.1.0 | 10.0.0 |
The above information is a snapshot of the collected data. Visit https://aer.ctrlflow.com/redhat/reviewers/#!/problems/574e5d77e4b06056d20... for the latest data.
Thank you for your assistance.
Your friendly error-reports-inbox.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
9 years
[JBoss JIRA] (JBDS-2356) JEE project example generates warnings
by Denis Golovin (JIRA)
[ https://issues.jboss.org/browse/JBDS-2356?page=com.atlassian.jira.plugin.... ]
Denis Golovin updated JBDS-2356:
--------------------------------
Fix Version/s: 10.4.0.AM2
(was: 10.4.0.AM1)
> JEE project example generates warnings
> --------------------------------------
>
> Key: JBDS-2356
> URL: https://issues.jboss.org/browse/JBDS-2356
> Project: Red Hat JBoss Developer Studio (devstudio)
> Issue Type: Bug
> Components: central
> Affects Versions: 6.0.0.Alpha2
> Environment: Version: 6.0.0.Alpha2
> Build id: Alpha2-v20121004-2330-B40
> Build date: 20121004-2330
> Reporter: Len DiMaggio
> Assignee: Fred Bricon
> Labels: examplewarnings
> Fix For: 10.4.0.AM2
>
>
> The JEE project example generates these warnings:
> jboss-javaee6-multi-ejb
> No connection specified for project. No database-specific validation will be performed.
> The import javax.persistence.PersistenceContext is never used
> WebResources.java
> /jboss-javaee6-multi-web/src/main/java/org/jboss/tools/example/util
> line 10
> The import javax.enterprise.event.Event is never used
> MemberController.java
> /jboss-javaee6-multi-web/src/main/java/org/jboss/tools/example/controller
> line 6
> The import javax.persistence.EntityManager is never used
> WebResources.java
> /jboss-javaee6-multi-web/src/main/java/org/jboss/tools/example/util
> line 9
> The import java.util.logging.Logger is never used
> MemberController.java
> /jboss-javaee6-multi-web/src/main/java/org/jboss/tools/example/controller
> line 3
> The import javax.enterprise.inject.spi.InjectionPoint is never used
> WebResources.java
> /jboss-javaee6-multi-web/src/main/java/org/jboss/tools/example/util
> line 7
> The import java.util.logging.Logger is never used
> WebResources.java
> /jboss-javaee6-multi-web/src/main/java/org/jboss/tools/example/util
> line 3
> Unnecessary @SuppressWarnings("unused") Resources.java
> /jboss-javaee6-multi-ejb/src/main/java/org/jboss/tools/example/util
> line 24
> No connection specified for project. No database-specific validation will be performed.
> jboss-javaee6-multi-ejb
> The import javax.persistence.EntityManager is never used
> MemberController.java
> /jboss-javaee6-multi-web/src/main/java/org/jboss/tools/example/controller
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
9 years