[JBoss JIRA] (JBIDE-24114) [parent pom] do not skip baseline comparison check when -DskipTests=true
by Nick Boldt (JIRA)
[ https://issues.jboss.org/browse/JBIDE-24114?page=com.atlassian.jira.plugi... ]
Nick Boldt reassigned JBIDE-24114:
----------------------------------
Assignee: Nick Boldt
> [parent pom] do not skip baseline comparison check when -DskipTests=true
> ------------------------------------------------------------------------
>
> Key: JBIDE-24114
> URL: https://issues.jboss.org/browse/JBIDE-24114
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: build
> Affects Versions: 4.4.4.AM1, 4.5.0.AM1
> Reporter: Nick Boldt
> Assignee: Nick Boldt
> Fix For: 4.4.4.AM2, 4.5.0.AM1
>
>
> Currently, when you build with -DskipTests, the baseline checks are also skipped. This means that if you make a change to a file in a plugin, and build it locally to see if anything breaks, but forget to bump the version of the plugin and its containing feature, you won't see the baseline check failure until it's built in Jenkins and someone like me complains about it to you directly.
> This happened recently in the 4.4.x branch for changes to openshift and base.
> So I propose this change in parent pom for 4.4.x and master branches:
> {code}
> - <skipBaselineComparison>${skipTestsOrITests}</skipBaselineComparison>
> + <skipBaselineComparison>false</skipBaselineComparison>
> {code}
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
9 years
[JBoss JIRA] (JBIDE-24112) document pre-staging steps (including creation of N&N JIRAs) in devstudio release guide
by Nick Boldt (JIRA)
[ https://issues.jboss.org/browse/JBIDE-24112?page=com.atlassian.jira.plugi... ]
Nick Boldt commented on JBIDE-24112:
------------------------------------
[~jeffmaury] As curently set up, jiralint machine user can create but cannot assign issues to component leads.
So the new job I created simply creates an email, sends it to you, and you can then run the instructions to fetch the jbosstools-build-ci project, and run the createnewandnoteworth.py script with the correct settings passed to it, including YOUR username/password. Since it's run as YOU and you have assignment rights, the issues are created and assigned to the component leads automatically. (Issue assignment was added in JBIDE-23536 some time ago, per your request.)
This is the same setup for when it's time to update root poms and create branches -- generate an email with instructions, which you then run using your username/password for issues.jboss.org.
If we create NEW machine user which has assignment rights, we could further simplify this so that the bash/python scripts could be run from Jenkins via the new machine user, and there'd be no need to generate emails w/ instructions.
We have a machine user in github called *devstudio-release* used in Jenkins to push commits to the github repos that back up download.jboss.org and devstudio.redhat.com. I could create a similar one in issues.jboss.org that would then be granted create & assignment rights for JBDS and JBIDE projects.
[~maxandersen] thanks for the clarification. [~jeffmaury] should we create a new machine user?
> document pre-staging steps (including creation of N&N JIRAs) in devstudio release guide
> ---------------------------------------------------------------------------------------
>
> Key: JBIDE-24112
> URL: https://issues.jboss.org/browse/JBIDE-24112
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: build
> Reporter: Nick Boldt
> Assignee: Nick Boldt
> Fix For: 4.4.4.AM2
>
> Attachments: jiralint.user.no.perms.to.assign.txt
>
>
> Need to document pre-staging steps (including creation of N&N JIRAs) in devstudio release guide. Also can create a job in jenkins to wrap the creation of the N&N JIRAs so heir creation is less error-prone.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
9 years