[JBoss JIRA] (JBIDE-24796) Starting of CDK 3 Server Adapter with Minishift Home that differs from ~/.minishift prevents OS tooling to create proper connection and links it to default project
by Rob Stryker (JIRA)
[ https://issues.jboss.org/browse/JBIDE-24796?page=com.atlassian.jira.plugi... ]
Rob Stryker commented on JBIDE-24796:
-------------------------------------
Hey guys: Can we be a bit more clear here? I committed the first set of patches, but I'd like to find out what's still broken.
It seems that what remains here is that the default username is incorrect? Is that all that's left to fix?
> Starting of CDK 3 Server Adapter with Minishift Home that differs from ~/.minishift prevents OS tooling to create proper connection and links it to default project
> -------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: JBIDE-24796
> URL: https://issues.jboss.org/browse/JBIDE-24796
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: cdk, openshift
> Affects Versions: 4.5.0.Final
> Environment: Fedora
> Reporter: Ondrej Dockal
> Assignee: Rob Stryker
> Priority: Critical
> Attachments: cdk3_sa-manual_correct-mhome.png, cdk3_sa-manual_wrong-mhome2.png
>
>
> In the first case I would understand that if you change you minishift home (in server editor) and then you start server adapter, you will get some mess... Although, I would like to see a validation of minishift home here. We are checking minishit binary, why not to check minishift home (in this case for existence of the folder). See
> !cdk3_sa-manual_wrong-mhome2.png|thumbnail!
> In the second case comes the bug. Even if I have set MINISHIFT_HOME folder, called setup-cdk that configured everything in that folder and put this folder as Minishift Home, CDK3 Server Adapter is not respecting that location. Or it is maybe OS tooling, not sure here. Solution here would be a check that verifies minishift's home set in CDK server editor corresponds with the one that minishift binary uses, if it is possible (from the side of binary) - but that seems not to be an option here as minishift/cdk stored everything in config that resides in MINISHIFT_HOME or ~/.minishift folder. See
> !cdk3_sa-manual_correct-mhome.png|thumbnail!
> Cc: [~adietish] [~rob.stryker].
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 7 months
[JBoss JIRA] (JBIDE-24871) checkStagingURLs should verify children of composite*.xml are valid URLs
by Nick Boldt (JIRA)
Nick Boldt created JBIDE-24871:
----------------------------------
Summary: checkStagingURLs should verify children of composite*.xml are valid URLs
Key: JBIDE-24871
URL: https://issues.jboss.org/browse/JBIDE-24871
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: build
Affects Versions: 4.5.1.AM1
Reporter: Nick Boldt
Currently, checkStagingURLs.sh will verify that a given composite*.xml file EXISTS.
But it won't check if the contents of that site are VALID. So, we should parse these files and check that the <child location=""> are valid URLs too.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 7 months
[JBoss JIRA] (JBIDE-24831) Race condition between launching minishift and adding debug listener
by Rob Stryker (JIRA)
[ https://issues.jboss.org/browse/JBIDE-24831?page=com.atlassian.jira.plugi... ]
Rob Stryker resolved JBIDE-24831.
---------------------------------
Resolution: Done
pushed to master
> Race condition between launching minishift and adding debug listener
> --------------------------------------------------------------------
>
> Key: JBIDE-24831
> URL: https://issues.jboss.org/browse/JBIDE-24831
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: cdk
> Affects Versions: 4.5.0.Final
> Reporter: Rob Stryker
> Assignee: Rob Stryker
> Fix For: 4.5.1.AM1
>
>
> The current code does the following:
> 1) Launch the process
> 2) Then add the debugListener to o.e.debug
> This is problematic. If the process ends very quickly,. our listener will never get alerted that the process terminated, and so the server will be stuck at 'starting'.
> Solution is to add the debugListener BEFORE launching the process.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 7 months