[JBoss JIRA] (JBIDE-24771) Misaligned button in Edit OpenShift Connection dialog
by Martin Malina (JIRA)
[ https://issues.jboss.org/browse/JBIDE-24771?page=com.atlassian.jira.plugi... ]
Martin Malina updated JBIDE-24771:
----------------------------------
Fix Version/s: 4.5.0.Final
(was: 4.5.x)
> Misaligned button in Edit OpenShift Connection dialog
> -----------------------------------------------------
>
> Key: JBIDE-24771
> URL: https://issues.jboss.org/browse/JBIDE-24771
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Affects Versions: 4.5.0.AM2
> Reporter: Martin Malina
> Labels: connection_wizard, openshift_v3
> Fix For: 4.5.0.Final
>
> Attachments: browse-button-correctly-right aligned.png, browse-button.png
>
>
> While verifying the PR for JBIDE-24768, I noticed a new item under the Advanced section of the Edit OpenShift Connection dialog.
> At the bottom, there is a checkbox for Override 'oc' location:
> At the end of the line, there is a Browse button. It is not fully visible - it's cut on the right as if there was not enough space to contain it. This is on Mac.
> !browse-button.png!
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 7 months
[JBoss JIRA] (JBIDE-24771) Misaligned button in Edit OpenShift Connection dialog
by Martin Malina (JIRA)
[ https://issues.jboss.org/browse/JBIDE-24771?page=com.atlassian.jira.plugi... ]
Martin Malina resolved JBIDE-24771.
-----------------------------------
Assignee: Martin Malina
Resolution: Cannot Reproduce Bug
[~adietish], I can confirm that it's no longer reproducible in devstudio 11.0.0.GA.
> Misaligned button in Edit OpenShift Connection dialog
> -----------------------------------------------------
>
> Key: JBIDE-24771
> URL: https://issues.jboss.org/browse/JBIDE-24771
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Affects Versions: 4.5.0.AM2
> Reporter: Martin Malina
> Assignee: Martin Malina
> Labels: connection_wizard, openshift_v3
> Fix For: 4.5.0.Final
>
> Attachments: browse-button-correctly-right aligned.png, browse-button.png
>
>
> While verifying the PR for JBIDE-24768, I noticed a new item under the Advanced section of the Edit OpenShift Connection dialog.
> At the bottom, there is a checkbox for Override 'oc' location:
> At the end of the line, there is a Browse button. It is not fully visible - it's cut on the right as if there was not enough space to contain it. This is on Mac.
> !browse-button.png!
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 7 months
[JBoss JIRA] (JBIDE-24125) Import wizard: adapt ITs to changes introduced in JBIDE-24048
by Josef Kopriva (JIRA)
[ https://issues.jboss.org/browse/JBIDE-24125?page=com.atlassian.jira.plugi... ]
Josef Kopriva closed JBIDE-24125.
---------------------------------
Resolution: Done
PR is merged. Closing.
> Import wizard: adapt ITs to changes introduced in JBIDE-24048
> -------------------------------------------------------------
>
> Key: JBIDE-24125
> URL: https://issues.jboss.org/browse/JBIDE-24125
> Project: Tools (JBoss Tools)
> Issue Type: Enhancement
> Components: openshift
> Affects Versions: 4.4.4.AM2
> Reporter: Andre Dietisheim
> Assignee: Josef Kopriva
> Fix For: 4.5.1.AM1
>
>
> In JBIDE-24048 changes have been done to the import wizard. We should change the ITs to cover these changes.
> @rhopp @bdshadow can you please test this since it's a rather larger change and provides changes in how it behaves?
> * Validations were extended:
> ** is the existing clone destination a git repo?
> ** is the existing clone destination a clone of the source that is used in OpenShift?
> * We now also ask the user if he wants to checkout the correct branch (the one that's used in OpenShift) in the existing git repo
> * UI was slightly changed according to requests made in JBIDE-21935
> * We now also close the wizard dialog before executing the import. This should allow the user to continue working.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 7 months
[JBoss JIRA] (JBIDE-24783) Update default registry url for cdk 3
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-24783?page=com.atlassian.jira.plugi... ]
Andre Dietisheim edited comment on JBIDE-24783 at 8/11/17 6:17 AM:
-------------------------------------------------------------------
[~rob.stryker] 172.30.1.1:5000 is the usual value for the registry in cdk3/minishift. I'd not say that it's the default though, how reliable can such a default be if it's IP based? I'd rather not use a default at all since such a default is very unlikely to be reliable. I'd rather allow users to manually look it up as discussed in JBIDE-24491.
Btw. this seem like what I reported back in JBIDE-24482 but noone could reproduce it.
was (Author: adietish):
[~rob.stryker] 172.30.1.1:5000 is the usual value for the registry in cdk3/minishift. I'd not say that it's the default though, how reliable can such a default be if it's IP based? I'd rather not use a default at all.
Btw. this seem like what I reported back in JBIDE-24482 but noone could reproduce it.
> Update default registry url for cdk 3
> -------------------------------------
>
> Key: JBIDE-24783
> URL: https://issues.jboss.org/browse/JBIDE-24783
> Project: Tools (JBoss Tools)
> Issue Type: Feature Request
> Components: cdk, openshift
> Affects Versions: 4.5.0.AM2
> Reporter: Martin Malina
>
> Yesterday I started cdk 3 and it seemed to start ok, but was not really ok.
> The registry command didn't really work:
> {code}
> $ ./minishift openshift registry
> No information found for 'service/docker-registry'
> {code}
> The result is that the openshift connection details showed this under Image Registry URL:
> https://hub.openshift.rhel-cdk.10.1.2.2.xip.io
> This seems like the default value for cdk 3. I think we should update the default value for cdk 3. Or is this simply a default value for an openshift connection? In any case, this should use the cdk 3 value.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 7 months
[JBoss JIRA] (JBIDE-24783) Update default registry url for cdk 3
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-24783?page=com.atlassian.jira.plugi... ]
Andre Dietisheim edited comment on JBIDE-24783 at 8/11/17 6:14 AM:
-------------------------------------------------------------------
[~rob.stryker] 172.30.1.1:5000 is the usual value for the registry in cdk3/minishift. I'd not say that it's the default though, how reliable can such a default be if it's IP based? I'd rather not use a default at all.
Btw. this seem like what I reported back in JBIDE-24482 but noone could reproduce it.
was (Author: adietish):
[~rob.stryker] 172.30.1.1:5000 is the usual value for the registry in cdk3/minishift. I'd not say that it's the default though, how reliable can such a default be if it's IP based? I'd rather not use a default at all.
> Update default registry url for cdk 3
> -------------------------------------
>
> Key: JBIDE-24783
> URL: https://issues.jboss.org/browse/JBIDE-24783
> Project: Tools (JBoss Tools)
> Issue Type: Feature Request
> Components: cdk, openshift
> Affects Versions: 4.5.0.AM2
> Reporter: Martin Malina
>
> Yesterday I started cdk 3 and it seemed to start ok, but was not really ok.
> The registry command didn't really work:
> {code}
> $ ./minishift openshift registry
> No information found for 'service/docker-registry'
> {code}
> The result is that the openshift connection details showed this under Image Registry URL:
> https://hub.openshift.rhel-cdk.10.1.2.2.xip.io
> This seems like the default value for cdk 3. I think we should update the default value for cdk 3. Or is this simply a default value for an openshift connection? In any case, this should use the cdk 3 value.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 7 months
[JBoss JIRA] (JBIDE-24783) Update default registry url for cdk 3
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-24783?page=com.atlassian.jira.plugi... ]
Andre Dietisheim commented on JBIDE-24783:
------------------------------------------
[~rob.stryker] 172.30.1.1:5000 is the usual value for the registry in cdk3/minishift. I'd not say that it's the default though, how reliable can such a default be if it's IP based? I'd rather not use a default at all.
> Update default registry url for cdk 3
> -------------------------------------
>
> Key: JBIDE-24783
> URL: https://issues.jboss.org/browse/JBIDE-24783
> Project: Tools (JBoss Tools)
> Issue Type: Feature Request
> Components: cdk, openshift
> Affects Versions: 4.5.0.AM2
> Reporter: Martin Malina
>
> Yesterday I started cdk 3 and it seemed to start ok, but was not really ok.
> The registry command didn't really work:
> {code}
> $ ./minishift openshift registry
> No information found for 'service/docker-registry'
> {code}
> The result is that the openshift connection details showed this under Image Registry URL:
> https://hub.openshift.rhel-cdk.10.1.2.2.xip.io
> This seems like the default value for cdk 3. I think we should update the default value for cdk 3. Or is this simply a default value for an openshift connection? In any case, this should use the cdk 3 value.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 7 months
[JBoss JIRA] (JBIDE-24771) Misaligned button in Edit OpenShift Connection dialog
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-24771?page=com.atlassian.jira.plugi... ]
Andre Dietisheim edited comment on JBIDE-24771 at 8/11/17 6:10 AM:
-------------------------------------------------------------------
[~mmalina] I am running Mac, too and I cannot replicate this:
!browse-button-correctly-right aligned.png!
I assume that this was fixed with JBIDE-24790. Can you please confirm this?
was (Author: adietish):
[~mmalina] I am running Mac, too and I cannot replicate this:
!browse-button-correctly-right aligned.png!
> Misaligned button in Edit OpenShift Connection dialog
> -----------------------------------------------------
>
> Key: JBIDE-24771
> URL: https://issues.jboss.org/browse/JBIDE-24771
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Affects Versions: 4.5.0.AM2
> Reporter: Martin Malina
> Labels: connection_wizard, openshift_v3
> Fix For: 4.5.x
>
> Attachments: browse-button-correctly-right aligned.png, browse-button.png
>
>
> While verifying the PR for JBIDE-24768, I noticed a new item under the Advanced section of the Edit OpenShift Connection dialog.
> At the bottom, there is a checkbox for Override 'oc' location:
> At the end of the line, there is a Browse button. It is not fully visible - it's cut on the right as if there was not enough space to contain it. This is on Mac.
> !browse-button.png!
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 7 months
[JBoss JIRA] (JBIDE-24771) Misaligned button in Edit OpenShift Connection dialog
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-24771?page=com.atlassian.jira.plugi... ]
Andre Dietisheim updated JBIDE-24771:
-------------------------------------
Attachment: browse-button-correctly-right aligned.png
> Misaligned button in Edit OpenShift Connection dialog
> -----------------------------------------------------
>
> Key: JBIDE-24771
> URL: https://issues.jboss.org/browse/JBIDE-24771
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Affects Versions: 4.5.0.AM2
> Reporter: Martin Malina
> Labels: connection_wizard, openshift_v3
> Fix For: 4.5.x
>
> Attachments: browse-button-correctly-right aligned.png, browse-button.png
>
>
> While verifying the PR for JBIDE-24768, I noticed a new item under the Advanced section of the Edit OpenShift Connection dialog.
> At the bottom, there is a checkbox for Override 'oc' location:
> At the end of the line, there is a Browse button. It is not fully visible - it's cut on the right as if there was not enough space to contain it. This is on Mac.
> !browse-button.png!
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 7 months
[JBoss JIRA] (JBIDE-24771) Misaligned button in Edit OpenShift Connection dialog
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-24771?page=com.atlassian.jira.plugi... ]
Andre Dietisheim commented on JBIDE-24771:
------------------------------------------
[~mmalina] I am running Mac, too and I cannot replicate this:
!browse-button-correctly-right aligned.png!
> Misaligned button in Edit OpenShift Connection dialog
> -----------------------------------------------------
>
> Key: JBIDE-24771
> URL: https://issues.jboss.org/browse/JBIDE-24771
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Affects Versions: 4.5.0.AM2
> Reporter: Martin Malina
> Labels: connection_wizard, openshift_v3
> Fix For: 4.5.x
>
> Attachments: browse-button-correctly-right aligned.png, browse-button.png
>
>
> While verifying the PR for JBIDE-24768, I noticed a new item under the Advanced section of the Edit OpenShift Connection dialog.
> At the bottom, there is a checkbox for Override 'oc' location:
> At the end of the line, there is a Browse button. It is not fully visible - it's cut on the right as if there was not enough space to contain it. This is on Mac.
> !browse-button.png!
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 7 months