[JBoss JIRA] (JBTIS-1166) Use aggregated JBT IS TP for Teiid Des
by Paul Leacu (JIRA)
[ https://issues.jboss.org/browse/JBTIS-1166?page=com.atlassian.jira.plugin... ]
Paul Leacu updated JBTIS-1166:
------------------------------
Description:
Teiid Designer needs access to the aggregated JBT core. Use the aggregated IS TP for the JBTIS repo.
was:Teiid Designer needs org.jboss.ide.eclipse.as from JBT core. Add it to the IS TP direct dependencies so we don't need to add core to the TD update site composites.
> Use aggregated JBT IS TP for Teiid Des
> --------------------------------------
>
> Key: JBTIS-1166
> URL: https://issues.jboss.org/browse/JBTIS-1166
> Project: JBoss Tools Integration Stack
> Issue Type: Task
> Components: target-platform
> Affects Versions: 4.5.0.Final-TP
> Reporter: Paul Leacu
> Assignee: Paul Leacu
> Fix For: 4.5.1.Final-TP
>
>
> Teiid Designer needs access to the aggregated JBT core. Use the aggregated IS TP for the JBTIS repo.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 7 months
[JBoss JIRA] (JBTIS-1166) Use aggregated JBT IS TP for Teiid Des
by Paul Leacu (JIRA)
[ https://issues.jboss.org/browse/JBTIS-1166?page=com.atlassian.jira.plugin... ]
Paul Leacu updated JBTIS-1166:
------------------------------
Summary: Use aggregated JBT IS TP for Teiid Des (was: Add org.jboss.ide.eclipse.as to IS TP for Teiid Des)
> Use aggregated JBT IS TP for Teiid Des
> --------------------------------------
>
> Key: JBTIS-1166
> URL: https://issues.jboss.org/browse/JBTIS-1166
> Project: JBoss Tools Integration Stack
> Issue Type: Task
> Components: target-platform
> Affects Versions: 4.5.0.Final-TP
> Reporter: Paul Leacu
> Assignee: Paul Leacu
> Fix For: 4.5.1.Final-TP
>
>
> Teiid Designer needs org.jboss.ide.eclipse.as from JBT core. Add it to the IS TP direct dependencies so we don't need to add core to the TD update site composites.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 7 months
[JBoss JIRA] (JBIDE-25008) 2 Test Failure(s) in JBIDE 4.5.1.AM2 for jst component
by Nick Boldt (JIRA)
[ https://issues.jboss.org/browse/JBIDE-25008?page=com.atlassian.jira.plugi... ]
Nick Boldt updated JBIDE-25008:
-------------------------------
Fix Version/s: 4.5.1.AM2
> 2 Test Failure(s) in JBIDE 4.5.1.AM2 for jst component
> ------------------------------------------------------
>
> Key: JBIDE-25008
> URL: https://issues.jboss.org/browse/JBIDE-25008
> Project: Tools (JBoss Tools)
> Issue Type: Task
> Components: jst
> Affects Versions: 4.5.1.AM2
> Reporter: Nick Boldt
> Assignee: Jeff MAURY
> Priority: Critical
> Labels: testfailure
> Fix For: 4.5.1.AM2
>
>
> *2 Test Failure(s) in JBIDE 4.5.1.AM2 for jst component:*
> https://dev-platform-jenkins.rhev-ci-vms.eng.rdu2.redhat.com/job/jbosstoo...
> # [org.jboss.tools.jst.web.ui.openon.test.DatalistHyperlinkDetectorTest|http...] (failing for 143 builds)
> # [org.jboss.tools.jst.web.ui.openon.test.DatalistHyperlinkDetectorTest|http...] (failing for 143 builds)
> [Search for Test Failure JIRAs in JBIDE 4.5.1.AM2 for jst component|https://issues.jboss.org/issues/?jql=labels+IN+%28%22testfailur...]
> -----
> * {color:red}org.jboss.tools.jst.web.ui.openon.test.DatalistHyperlinkDetectorTest : testHyperlinksHTML{color} (failing for 143 builds)
>
> {code:title=https://dev-platform-jenkins.rhev-ci-vms.eng.rdu2.redhat.com/job/jbosstools-jst_master/706/testReport/org.jboss.tools.jst.web.ui.openon.test/DatalistHyperlinkDetectorTest/testHyperlinksHTML}
> <case>
> <age>143</age>
> <className>org.jboss.tools.jst.web.ui.openon.test.DatalistHyperlinkDetectorTest</className>
> <duration>0.202</duration>
> <errorDetails>Wrong detection for region - <browsers> 301 - 309 line - 16 position - 14 offset - 302 (line - 16 position - 15)</errorDetails>
> <errorStackTrace>junit.framework.AssertionFailedError: Wrong detection for region - <browsers> 301 - 309 line - 16 position - 14 offset - 302 (line - 16 position - 15)
> at junit.framework.Assert.fail(Assert.java:57)
> at junit.framework.TestCase.fail(TestCase.java:227)
> at org.jboss.tools.jst.jsp.test.openon.HyperlinkTestUtil.checkHyperlinksInTextEditor(HyperlinkTestUtil.java:203)
> at org.jboss.tools.jst.web.ui.openon.test.DatalistHyperlinkDetectorTest.checkHyperlinks(DatalistHyperlinkDetectorTest.java:64)
> at org.jboss.tools.jst.web.ui.openon.test.DatalistHyperlinkDetectorTest.testHyperlinksHTML(DatalistHyperlinkDetectorTest.java:57)
> </errorStackTrace>
> <failedSince>564</failedSince>
> <name>testHyperlinksHTML</name>
> <skipped>false</skipped>
> <status>FAILED</status>
> </case>
> {code}
> * {color:red}org.jboss.tools.jst.web.ui.openon.test.DatalistHyperlinkDetectorTest : testDetectorHTML{color} (failing for 143 builds)
>
> {code:title=https://dev-platform-jenkins.rhev-ci-vms.eng.rdu2.redhat.com/job/jbosstools-jst_master/706/testReport/org.jboss.tools.jst.web.ui.openon.test/DatalistHyperlinkDetectorTest/testDetectorHTML}
> <case>
> <age>143</age>
> <className>org.jboss.tools.jst.web.ui.openon.test.DatalistHyperlinkDetectorTest</className>
> <duration>0.277</duration>
> <errorDetails>Wrong detection for region - <browsers> 301 - 309 line - 16 position - 14 offset - 301 (line - 16 position - 14)</errorDetails>
> <errorStackTrace>junit.framework.AssertionFailedError: Wrong detection for region - <browsers> 301 - 309 line - 16 position - 14 offset - 301 (line - 16 position - 14)
> at junit.framework.Assert.fail(Assert.java:57)
> at junit.framework.TestCase.fail(TestCase.java:227)
> at org.jboss.tools.jst.jsp.test.openon.HyperlinkTestUtil.checkRegionsInTextEditor(HyperlinkTestUtil.java:546)
> at org.jboss.tools.jst.web.ui.openon.test.DatalistHyperlinkDetectorTest.checkHyperlinkDetector(DatalistHyperlinkDetectorTest.java:53)
> at org.jboss.tools.jst.web.ui.openon.test.DatalistHyperlinkDetectorTest.testDetectorHTML(DatalistHyperlinkDetectorTest.java:47)
> </errorStackTrace>
> <failedSince>564</failedSince>
> <name>testDetectorHTML</name>
> <skipped>false</skipped>
> <status>FAILED</status>
> </case>
> {code}
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 7 months
[JBoss JIRA] (JBIDE-25008) 2 Test Failure(s) in JBIDE 4.5.1.AM2 for jst component
by Nick Boldt (JIRA)
Nick Boldt created JBIDE-25008:
----------------------------------
Summary: 2 Test Failure(s) in JBIDE 4.5.1.AM2 for jst component
Key: JBIDE-25008
URL: https://issues.jboss.org/browse/JBIDE-25008
Project: Tools (JBoss Tools)
Issue Type: Task
Components: jst
Affects Versions: 4.5.1.AM2
Reporter: Nick Boldt
Priority: Critical
*2 Test Failure(s) in JBIDE 4.5.1.AM2 for jst component:*
https://dev-platform-jenkins.rhev-ci-vms.eng.rdu2.redhat.com/job/jbosstoo...
# [org.jboss.tools.jst.web.ui.openon.test.DatalistHyperlinkDetectorTest|http...] (failing for 143 builds)
# [org.jboss.tools.jst.web.ui.openon.test.DatalistHyperlinkDetectorTest|http...] (failing for 143 builds)
[Search for Test Failure JIRAs in JBIDE 4.5.1.AM2 for jst component|https://issues.jboss.org/issues/?jql=labels+IN+%28%22testfailur...]
-----
* {color:red}org.jboss.tools.jst.web.ui.openon.test.DatalistHyperlinkDetectorTest : testHyperlinksHTML{color} (failing for 143 builds)
{code:title=https://dev-platform-jenkins.rhev-ci-vms.eng.rdu2.redhat.com/job/jbosstools-jst_master/706/testReport/org.jboss.tools.jst.web.ui.openon.test/DatalistHyperlinkDetectorTest/testHyperlinksHTML}
<case>
<age>143</age>
<className>org.jboss.tools.jst.web.ui.openon.test.DatalistHyperlinkDetectorTest</className>
<duration>0.202</duration>
<errorDetails>Wrong detection for region - <browsers> 301 - 309 line - 16 position - 14 offset - 302 (line - 16 position - 15)</errorDetails>
<errorStackTrace>junit.framework.AssertionFailedError: Wrong detection for region - <browsers> 301 - 309 line - 16 position - 14 offset - 302 (line - 16 position - 15)
at junit.framework.Assert.fail(Assert.java:57)
at junit.framework.TestCase.fail(TestCase.java:227)
at org.jboss.tools.jst.jsp.test.openon.HyperlinkTestUtil.checkHyperlinksInTextEditor(HyperlinkTestUtil.java:203)
at org.jboss.tools.jst.web.ui.openon.test.DatalistHyperlinkDetectorTest.checkHyperlinks(DatalistHyperlinkDetectorTest.java:64)
at org.jboss.tools.jst.web.ui.openon.test.DatalistHyperlinkDetectorTest.testHyperlinksHTML(DatalistHyperlinkDetectorTest.java:57)
</errorStackTrace>
<failedSince>564</failedSince>
<name>testHyperlinksHTML</name>
<skipped>false</skipped>
<status>FAILED</status>
</case>
{code}
* {color:red}org.jboss.tools.jst.web.ui.openon.test.DatalistHyperlinkDetectorTest : testDetectorHTML{color} (failing for 143 builds)
{code:title=https://dev-platform-jenkins.rhev-ci-vms.eng.rdu2.redhat.com/job/jbosstools-jst_master/706/testReport/org.jboss.tools.jst.web.ui.openon.test/DatalistHyperlinkDetectorTest/testDetectorHTML}
<case>
<age>143</age>
<className>org.jboss.tools.jst.web.ui.openon.test.DatalistHyperlinkDetectorTest</className>
<duration>0.277</duration>
<errorDetails>Wrong detection for region - <browsers> 301 - 309 line - 16 position - 14 offset - 301 (line - 16 position - 14)</errorDetails>
<errorStackTrace>junit.framework.AssertionFailedError: Wrong detection for region - <browsers> 301 - 309 line - 16 position - 14 offset - 301 (line - 16 position - 14)
at junit.framework.Assert.fail(Assert.java:57)
at junit.framework.TestCase.fail(TestCase.java:227)
at org.jboss.tools.jst.jsp.test.openon.HyperlinkTestUtil.checkRegionsInTextEditor(HyperlinkTestUtil.java:546)
at org.jboss.tools.jst.web.ui.openon.test.DatalistHyperlinkDetectorTest.checkHyperlinkDetector(DatalistHyperlinkDetectorTest.java:53)
at org.jboss.tools.jst.web.ui.openon.test.DatalistHyperlinkDetectorTest.testDetectorHTML(DatalistHyperlinkDetectorTest.java:47)
</errorStackTrace>
<failedSince>564</failedSince>
<name>testDetectorHTML</name>
<skipped>false</skipped>
<status>FAILED</status>
</case>
{code}
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 7 months
[JBoss JIRA] (JBIDE-25008) 2 Test Failure(s) in JBIDE 4.5.1.AM2 for jst component
by Nick Boldt (JIRA)
[ https://issues.jboss.org/browse/JBIDE-25008?page=com.atlassian.jira.plugi... ]
Nick Boldt reassigned JBIDE-25008:
----------------------------------
Assignee: Jeff MAURY
> 2 Test Failure(s) in JBIDE 4.5.1.AM2 for jst component
> ------------------------------------------------------
>
> Key: JBIDE-25008
> URL: https://issues.jboss.org/browse/JBIDE-25008
> Project: Tools (JBoss Tools)
> Issue Type: Task
> Components: jst
> Affects Versions: 4.5.1.AM2
> Reporter: Nick Boldt
> Assignee: Jeff MAURY
> Priority: Critical
> Labels: testfailure
>
> *2 Test Failure(s) in JBIDE 4.5.1.AM2 for jst component:*
> https://dev-platform-jenkins.rhev-ci-vms.eng.rdu2.redhat.com/job/jbosstoo...
> # [org.jboss.tools.jst.web.ui.openon.test.DatalistHyperlinkDetectorTest|http...] (failing for 143 builds)
> # [org.jboss.tools.jst.web.ui.openon.test.DatalistHyperlinkDetectorTest|http...] (failing for 143 builds)
> [Search for Test Failure JIRAs in JBIDE 4.5.1.AM2 for jst component|https://issues.jboss.org/issues/?jql=labels+IN+%28%22testfailur...]
> -----
> * {color:red}org.jboss.tools.jst.web.ui.openon.test.DatalistHyperlinkDetectorTest : testHyperlinksHTML{color} (failing for 143 builds)
>
> {code:title=https://dev-platform-jenkins.rhev-ci-vms.eng.rdu2.redhat.com/job/jbosstools-jst_master/706/testReport/org.jboss.tools.jst.web.ui.openon.test/DatalistHyperlinkDetectorTest/testHyperlinksHTML}
> <case>
> <age>143</age>
> <className>org.jboss.tools.jst.web.ui.openon.test.DatalistHyperlinkDetectorTest</className>
> <duration>0.202</duration>
> <errorDetails>Wrong detection for region - <browsers> 301 - 309 line - 16 position - 14 offset - 302 (line - 16 position - 15)</errorDetails>
> <errorStackTrace>junit.framework.AssertionFailedError: Wrong detection for region - <browsers> 301 - 309 line - 16 position - 14 offset - 302 (line - 16 position - 15)
> at junit.framework.Assert.fail(Assert.java:57)
> at junit.framework.TestCase.fail(TestCase.java:227)
> at org.jboss.tools.jst.jsp.test.openon.HyperlinkTestUtil.checkHyperlinksInTextEditor(HyperlinkTestUtil.java:203)
> at org.jboss.tools.jst.web.ui.openon.test.DatalistHyperlinkDetectorTest.checkHyperlinks(DatalistHyperlinkDetectorTest.java:64)
> at org.jboss.tools.jst.web.ui.openon.test.DatalistHyperlinkDetectorTest.testHyperlinksHTML(DatalistHyperlinkDetectorTest.java:57)
> </errorStackTrace>
> <failedSince>564</failedSince>
> <name>testHyperlinksHTML</name>
> <skipped>false</skipped>
> <status>FAILED</status>
> </case>
> {code}
> * {color:red}org.jboss.tools.jst.web.ui.openon.test.DatalistHyperlinkDetectorTest : testDetectorHTML{color} (failing for 143 builds)
>
> {code:title=https://dev-platform-jenkins.rhev-ci-vms.eng.rdu2.redhat.com/job/jbosstools-jst_master/706/testReport/org.jboss.tools.jst.web.ui.openon.test/DatalistHyperlinkDetectorTest/testDetectorHTML}
> <case>
> <age>143</age>
> <className>org.jboss.tools.jst.web.ui.openon.test.DatalistHyperlinkDetectorTest</className>
> <duration>0.277</duration>
> <errorDetails>Wrong detection for region - <browsers> 301 - 309 line - 16 position - 14 offset - 301 (line - 16 position - 14)</errorDetails>
> <errorStackTrace>junit.framework.AssertionFailedError: Wrong detection for region - <browsers> 301 - 309 line - 16 position - 14 offset - 301 (line - 16 position - 14)
> at junit.framework.Assert.fail(Assert.java:57)
> at junit.framework.TestCase.fail(TestCase.java:227)
> at org.jboss.tools.jst.jsp.test.openon.HyperlinkTestUtil.checkRegionsInTextEditor(HyperlinkTestUtil.java:546)
> at org.jboss.tools.jst.web.ui.openon.test.DatalistHyperlinkDetectorTest.checkHyperlinkDetector(DatalistHyperlinkDetectorTest.java:53)
> at org.jboss.tools.jst.web.ui.openon.test.DatalistHyperlinkDetectorTest.testDetectorHTML(DatalistHyperlinkDetectorTest.java:47)
> </errorStackTrace>
> <failedSince>564</failedSince>
> <name>testDetectorHTML</name>
> <skipped>false</skipped>
> <status>FAILED</status>
> </case>
> {code}
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 7 months
[JBoss JIRA] (JBIDE-25006) ITests profile is active by default
by Martin Malina (JIRA)
[ https://issues.jboss.org/browse/JBIDE-25006?page=com.atlassian.jira.plugi... ]
Martin Malina closed JBIDE-25006.
---------------------------------
I verified that the profile is now active when expected, i.e.:
1. mvn verify - profile inactive
2. mvn verify -PITests - profile active
3. mvn verify -DskipITests=false - profile active
4. mvn verify -DskipITests=true - profile inactive
With respect to ensuring itests jobs have either 2. or 3. - this is actually pretty safe, because if tests did run now, they should continue to run. The only difference is that before this fix, sometimes you could have the ITests profile active unintentionally. But skipITests would still be set to true in parent pom, so tests wouldn't run. The only known consequence would be the TP set to MAXIMUM which was exactly our problem.
> ITests profile is active by default
> -----------------------------------
>
> Key: JBIDE-25006
> URL: https://issues.jboss.org/browse/JBIDE-25006
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: build
> Affects Versions: 4.5.1.AM2
> Reporter: Martin Malina
> Assignee: Martin Malina
> Fix For: 4.5.1.AM2
>
>
> The intention is that if you run a build of anything depending on the parent pom, by default ITests profile is not active. But this doesn't work and it's always active unless you set -DskipITests=true from command line.
> The parent pom sets <skipITests>true</skipITests> here:
> https://github.com/jbosstools/jbosstools-build/blob/master/parent/pom.xml...
> And the ITests profile is activated if the skipITests property is not set at all:
> https://github.com/jbosstools/jbosstools-build/blob/master/parent/pom.xml...
> {code}
> <activation>
> <property>
> <name>!skipITests</name>
> </property>
> </activation>
> {code}
> We assumed that this would work but it turns out it does not work because profile activation only works with system properties and not properties in a pom.
> Pavol suggests simply removing the activation clause for that profile.
> [~nickboldt], what do you think of that? It seems simple enough. But who knows if there's hidden consequences to jobs that are used to the current behavior.
> Context: Builds of different repos started failing for us. Target platform max contains new RedDeer 2.0 and plugins in master still require RedDeer 1.x which is in target platform min. But it turned out that tpc.version is always set to target platform max which is not expected. So when investigating, we found that once the ITests profile is activated, it will set the tpc.version to max.
> This build breakage will disappear once TARGET_PLATFORM_VERSION_MIN is updated to the same version as TARGET_PLATFORM_VERSION_MAX - which is needed after the reddeer upgrade to 2.0. This is discussed in [1]. But we should still fix this.
> [1] https://issues.jboss.org/browse/JBIDE-25003?focusedCommentId=13461627&pag...
> Cc: [~psrna]
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 7 months
[JBoss JIRA] (JBIDE-25006) ITests profile is active by default
by Martin Malina (JIRA)
[ https://issues.jboss.org/browse/JBIDE-25006?page=com.atlassian.jira.plugi... ]
Martin Malina edited comment on JBIDE-25006 at 9/11/17 10:54 AM:
-----------------------------------------------------------------
PR is merged, thanks [~nickboldt]!
was (Author: mmalina):
PR is merged.
> ITests profile is active by default
> -----------------------------------
>
> Key: JBIDE-25006
> URL: https://issues.jboss.org/browse/JBIDE-25006
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: build
> Affects Versions: 4.5.1.AM2
> Reporter: Martin Malina
> Assignee: Martin Malina
> Fix For: 4.5.1.AM2
>
>
> The intention is that if you run a build of anything depending on the parent pom, by default ITests profile is not active. But this doesn't work and it's always active unless you set -DskipITests=true from command line.
> The parent pom sets <skipITests>true</skipITests> here:
> https://github.com/jbosstools/jbosstools-build/blob/master/parent/pom.xml...
> And the ITests profile is activated if the skipITests property is not set at all:
> https://github.com/jbosstools/jbosstools-build/blob/master/parent/pom.xml...
> {code}
> <activation>
> <property>
> <name>!skipITests</name>
> </property>
> </activation>
> {code}
> We assumed that this would work but it turns out it does not work because profile activation only works with system properties and not properties in a pom.
> Pavol suggests simply removing the activation clause for that profile.
> [~nickboldt], what do you think of that? It seems simple enough. But who knows if there's hidden consequences to jobs that are used to the current behavior.
> Context: Builds of different repos started failing for us. Target platform max contains new RedDeer 2.0 and plugins in master still require RedDeer 1.x which is in target platform min. But it turned out that tpc.version is always set to target platform max which is not expected. So when investigating, we found that once the ITests profile is activated, it will set the tpc.version to max.
> This build breakage will disappear once TARGET_PLATFORM_VERSION_MIN is updated to the same version as TARGET_PLATFORM_VERSION_MAX - which is needed after the reddeer upgrade to 2.0. This is discussed in [1]. But we should still fix this.
> [1] https://issues.jboss.org/browse/JBIDE-25003?focusedCommentId=13461627&pag...
> Cc: [~psrna]
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 7 months