September 2017 - jbosstools-issues

[JBoss JIRA] (JBIDE-25006) ITests profile is active by default

by Martin Malina (JIRA)

[ https://issues.jboss.org/browse/JBIDE-25006?page=com.atlassian.jira.plugi... ] Martin Malina resolved JBIDE-25006. ----------------------------------- Resolution: Done PR is merged. > ITests profile is active by default > ----------------------------------- > > Key: JBIDE-25006 > URL: https://issues.jboss.org/browse/JBIDE-25006 > Project: Tools (JBoss Tools) > Issue Type: Bug > Components: build > Affects Versions: 4.5.1.AM2 > Reporter: Martin Malina > Assignee: Martin Malina > Fix For: 4.5.1.AM2 > > > The intention is that if you run a build of anything depending on the parent pom, by default ITests profile is not active. But this doesn't work and it's always active unless you set -DskipITests=true from command line. > The parent pom sets <skipITests>true</skipITests> here: > https://github.com/jbosstools/jbosstools-build/blob/master/parent/pom.xml... > And the ITests profile is activated if the skipITests property is not set at all: > https://github.com/jbosstools/jbosstools-build/blob/master/parent/pom.xml... > {code} > <activation> > <property> > <name>!skipITests</name> > </property> > </activation> > {code} > We assumed that this would work but it turns out it does not work because profile activation only works with system properties and not properties in a pom. > Pavol suggests simply removing the activation clause for that profile. > [~nickboldt], what do you think of that? It seems simple enough. But who knows if there's hidden consequences to jobs that are used to the current behavior. > Context: Builds of different repos started failing for us. Target platform max contains new RedDeer 2.0 and plugins in master still require RedDeer 1.x which is in target platform min. But it turned out that tpc.version is always set to target platform max which is not expected. So when investigating, we found that once the ITests profile is activated, it will set the tpc.version to max. > This build breakage will disappear once TARGET_PLATFORM_VERSION_MIN is updated to the same version as TARGET_PLATFORM_VERSION_MAX - which is needed after the reddeer upgrade to 2.0. This is discussed in [1]. But we should still fix this. > [1] https://issues.jboss.org/browse/JBIDE-25003?focusedCommentId=13461627&pag... > Cc: [~psrna] -- This message was sent by Atlassian JIRA (v7.2.3#72005)

8 years, 7 months

1
0
0 / 0

[JBoss JIRA] (JBIDE-25006) ITests profile is active by default

by Nick Boldt (JIRA)

[ https://issues.jboss.org/browse/JBIDE-25006?page=com.atlassian.jira.plugi... ] Nick Boldt reassigned JBIDE-25006: ---------------------------------- Assignee: Martin Malina (was: Nick Boldt) > ITests profile is active by default > ----------------------------------- > > Key: JBIDE-25006 > URL: https://issues.jboss.org/browse/JBIDE-25006 > Project: Tools (JBoss Tools) > Issue Type: Bug > Components: build > Affects Versions: 4.5.1.AM2 > Reporter: Martin Malina > Assignee: Martin Malina > Fix For: 4.5.1.AM2 > > > The intention is that if you run a build of anything depending on the parent pom, by default ITests profile is not active. But this doesn't work and it's always active unless you set -DskipITests=true from command line. > The parent pom sets <skipITests>true</skipITests> here: > https://github.com/jbosstools/jbosstools-build/blob/master/parent/pom.xml... > And the ITests profile is activated if the skipITests property is not set at all: > https://github.com/jbosstools/jbosstools-build/blob/master/parent/pom.xml... > {code} > <activation> > <property> > <name>!skipITests</name> > </property> > </activation> > {code} > We assumed that this would work but it turns out it does not work because profile activation only works with system properties and not properties in a pom. > Pavol suggests simply removing the activation clause for that profile. > [~nickboldt], what do you think of that? It seems simple enough. But who knows if there's hidden consequences to jobs that are used to the current behavior. > Context: Builds of different repos started failing for us. Target platform max contains new RedDeer 2.0 and plugins in master still require RedDeer 1.x which is in target platform min. But it turned out that tpc.version is always set to target platform max which is not expected. So when investigating, we found that once the ITests profile is activated, it will set the tpc.version to max. > This build breakage will disappear once TARGET_PLATFORM_VERSION_MIN is updated to the same version as TARGET_PLATFORM_VERSION_MAX - which is needed after the reddeer upgrade to 2.0. This is discussed in [1]. But we should still fix this. > [1] https://issues.jboss.org/browse/JBIDE-25003?focusedCommentId=13461627&pag... > Cc: [~psrna] -- This message was sent by Atlassian JIRA (v7.2.3#72005)

8 years, 7 months

1
0
0 / 0

[JBoss JIRA] (JBIDE-25006) ITests profile is active by default

by Nick Boldt (JIRA)

[ https://issues.jboss.org/browse/JBIDE-25006?page=com.atlassian.jira.plugi... ] Nick Boldt commented on JBIDE-25006: ------------------------------------ Jobs that enable ITests profile: https://dev-platform-jenkins.rhev-ci-vms.eng.rdu2.redhat.com/view/Devstud... https://dev-platform-jenkins.rhev-ci-vms.eng.rdu2.redhat.com/view/Devstud... https://dev-platform-jenkins.rhev-ci-vms.eng.rdu2.redhat.com/view/Devstud... https://dev-platform-jenkins.rhev-ci-vms.eng.rdu2.redhat.com/view/Devstud... https://dev-platform-jenkins.rhev-ci-vms.eng.rdu2.redhat.com/view/Devstud... https://dev-platform-jenkins.rhev-ci-vms.eng.rdu2.redhat.com/view/Devstud... https://dev-platform-jenkins.rhev-ci-vms.eng.rdu2.redhat.com/view/Devstud... https://dev-platform-jenkins.rhev-ci-vms.eng.rdu2.redhat.com/view/Devstud... https://dev-platform-jenkins.rhev-ci-vms.eng.rdu2.redhat.com/view/Devstud... https://dev-platform-jenkins.rhev-ci-vms.eng.rdu2.redhat.com/view/Devstud... https://dev-platform-jenkins.rhev-ci-vms.eng.rdu2.redhat.com/view/Devstud... https://dev-platform-jenkins.rhev-ci-vms.eng.rdu2.redhat.com/view/Devstud... https://dev-platform-jenkins.rhev-ci-vms.eng.rdu2.redhat.com/view/Devstud... https://dev-platform-jenkins.rhev-ci-vms.eng.rdu2.redhat.com/view/Devstud... https://dev-platform-jenkins.rhev-ci-vms.eng.rdu2.redhat.com/view/Devstud... https://dev-platform-jenkins.rhev-ci-vms.eng.rdu2.redhat.com/view/Devstud... Jobs that set -DskipITests=false : https://dev-platform-jenkins.rhev-ci-vms.eng.rdu2.redhat.com/view/Devstud... > ITests profile is active by default > ----------------------------------- > > Key: JBIDE-25006 > URL: https://issues.jboss.org/browse/JBIDE-25006 > Project: Tools (JBoss Tools) > Issue Type: Bug > Components: build > Affects Versions: 4.5.1.AM2 > Reporter: Martin Malina > Assignee: Nick Boldt > Fix For: 4.5.1.AM2 > > > The intention is that if you run a build of anything depending on the parent pom, by default ITests profile is not active. But this doesn't work and it's always active unless you set -DskipITests=true from command line. > The parent pom sets <skipITests>true</skipITests> here: > https://github.com/jbosstools/jbosstools-build/blob/master/parent/pom.xml... > And the ITests profile is activated if the skipITests property is not set at all: > https://github.com/jbosstools/jbosstools-build/blob/master/parent/pom.xml... > {code} > <activation> > <property> > <name>!skipITests</name> > </property> > </activation> > {code} > We assumed that this would work but it turns out it does not work because profile activation only works with system properties and not properties in a pom. > Pavol suggests simply removing the activation clause for that profile. > [~nickboldt], what do you think of that? It seems simple enough. But who knows if there's hidden consequences to jobs that are used to the current behavior. > Context: Builds of different repos started failing for us. Target platform max contains new RedDeer 2.0 and plugins in master still require RedDeer 1.x which is in target platform min. But it turned out that tpc.version is always set to target platform max which is not expected. So when investigating, we found that once the ITests profile is activated, it will set the tpc.version to max. > This build breakage will disappear once TARGET_PLATFORM_VERSION_MIN is updated to the same version as TARGET_PLATFORM_VERSION_MAX - which is needed after the reddeer upgrade to 2.0. This is discussed in [1]. But we should still fix this. > [1] https://issues.jboss.org/browse/JBIDE-25003?focusedCommentId=13461627&pag... > Cc: [~psrna] -- This message was sent by Atlassian JIRA (v7.2.3#72005)

8 years, 7 months

1
0
0 / 0

[JBoss JIRA] (JBDS-4543) Fix installation note to header and remove extra UI space

by Mohit Suman (JIRA)

[ https://issues.jboss.org/browse/JBDS-4543?page=com.atlassian.jira.plugin.... ] Mohit Suman commented on JBDS-4543: ----------------------------------- As discussed with [~crobson]. The UI alignment looks fine. Will change the text to: {noformat} "Select the components to install" --> "Select any additional components to install" {noformat} > Fix installation note to header and remove extra UI space > --------------------------------------------------------- > > Key: JBDS-4543 > URL: https://issues.jboss.org/browse/JBDS-4543 > Project: Red Hat JBoss Developer Studio (devstudio) > Issue Type: Enhancement > Components: platform-installer > Reporter: Mohit Suman > Assignee: Mohit Suman > Attachments: install-note-css.png > > -- This message was sent by Atlassian JIRA (v7.2.3#72005)

8 years, 7 months

1
0
0 / 0

[JBoss JIRA] (JBIDE-25006) ITests profile is active by default

by Nick Boldt (JIRA)

[ https://issues.jboss.org/browse/JBIDE-25006?page=com.atlassian.jira.plugi... ] Nick Boldt commented on JBIDE-25006: ------------------------------------ Merged. Now we need to ensure that all jobs that run ITests do one of two things: a) -PITests b) -DskipITests=false > ITests profile is active by default > ----------------------------------- > > Key: JBIDE-25006 > URL: https://issues.jboss.org/browse/JBIDE-25006 > Project: Tools (JBoss Tools) > Issue Type: Bug > Components: build > Affects Versions: 4.5.1.AM2 > Reporter: Martin Malina > Assignee: Nick Boldt > Fix For: 4.5.1.AM2 > > > The intention is that if you run a build of anything depending on the parent pom, by default ITests profile is not active. But this doesn't work and it's always active unless you set -DskipITests=true from command line. > The parent pom sets <skipITests>true</skipITests> here: > https://github.com/jbosstools/jbosstools-build/blob/master/parent/pom.xml... > And the ITests profile is activated if the skipITests property is not set at all: > https://github.com/jbosstools/jbosstools-build/blob/master/parent/pom.xml... > {code} > <activation> > <property> > <name>!skipITests</name> > </property> > </activation> > {code} > We assumed that this would work but it turns out it does not work because profile activation only works with system properties and not properties in a pom. > Pavol suggests simply removing the activation clause for that profile. > [~nickboldt], what do you think of that? It seems simple enough. But who knows if there's hidden consequences to jobs that are used to the current behavior. > Context: Builds of different repos started failing for us. Target platform max contains new RedDeer 2.0 and plugins in master still require RedDeer 1.x which is in target platform min. But it turned out that tpc.version is always set to target platform max which is not expected. So when investigating, we found that once the ITests profile is activated, it will set the tpc.version to max. > This build breakage will disappear once TARGET_PLATFORM_VERSION_MIN is updated to the same version as TARGET_PLATFORM_VERSION_MAX - which is needed after the reddeer upgrade to 2.0. This is discussed in [1]. But we should still fix this. > [1] https://issues.jboss.org/browse/JBIDE-25003?focusedCommentId=13461627&pag... > Cc: [~psrna] -- This message was sent by Atlassian JIRA (v7.2.3#72005)

8 years, 7 months

1
0
0 / 0

[JBoss JIRA] (JBDS-4543) Fix installation note to header and remove extra UI space

by Mohit Suman (JIRA)

[ https://issues.jboss.org/browse/JBDS-4543?page=com.atlassian.jira.plugin.... ] Mohit Suman updated JBDS-4543: ------------------------------ Attachment: install-note-css.png > Fix installation note to header and remove extra UI space > --------------------------------------------------------- > > Key: JBDS-4543 > URL: https://issues.jboss.org/browse/JBDS-4543 > Project: Red Hat JBoss Developer Studio (devstudio) > Issue Type: Enhancement > Components: platform-installer > Reporter: Mohit Suman > Assignee: Mohit Suman > Attachments: install-note-css.png > > -- This message was sent by Atlassian JIRA (v7.2.3#72005)

8 years, 7 months

1
0
0 / 0

[JBoss JIRA] (JBIDE-25006) ITests profile is active by default

by Martin Malina (JIRA)

[ https://issues.jboss.org/browse/JBIDE-25006?page=com.atlassian.jira.plugi... ] Martin Malina commented on JBIDE-25006: --------------------------------------- +1 to merge > ITests profile is active by default > ----------------------------------- > > Key: JBIDE-25006 > URL: https://issues.jboss.org/browse/JBIDE-25006 > Project: Tools (JBoss Tools) > Issue Type: Bug > Components: build > Affects Versions: 4.5.1.AM2 > Reporter: Martin Malina > Assignee: Nick Boldt > Fix For: 4.5.1.AM2 > > > The intention is that if you run a build of anything depending on the parent pom, by default ITests profile is not active. But this doesn't work and it's always active unless you set -DskipITests=true from command line. > The parent pom sets <skipITests>true</skipITests> here: > https://github.com/jbosstools/jbosstools-build/blob/master/parent/pom.xml... > And the ITests profile is activated if the skipITests property is not set at all: > https://github.com/jbosstools/jbosstools-build/blob/master/parent/pom.xml... > {code} > <activation> > <property> > <name>!skipITests</name> > </property> > </activation> > {code} > We assumed that this would work but it turns out it does not work because profile activation only works with system properties and not properties in a pom. > Pavol suggests simply removing the activation clause for that profile. > [~nickboldt], what do you think of that? It seems simple enough. But who knows if there's hidden consequences to jobs that are used to the current behavior. > Context: Builds of different repos started failing for us. Target platform max contains new RedDeer 2.0 and plugins in master still require RedDeer 1.x which is in target platform min. But it turned out that tpc.version is always set to target platform max which is not expected. So when investigating, we found that once the ITests profile is activated, it will set the tpc.version to max. > This build breakage will disappear once TARGET_PLATFORM_VERSION_MIN is updated to the same version as TARGET_PLATFORM_VERSION_MAX - which is needed after the reddeer upgrade to 2.0. This is discussed in [1]. But we should still fix this. > [1] https://issues.jboss.org/browse/JBIDE-25003?focusedCommentId=13461627&pag... > Cc: [~psrna] -- This message was sent by Atlassian JIRA (v7.2.3#72005)

8 years, 7 months

1
0
0 / 0

[JBoss JIRA] (JBDS-4543) Fix installation note to header and remove extra UI space

by Mohit Suman (JIRA)

[ https://issues.jboss.org/browse/JBDS-4543?page=com.atlassian.jira.plugin.... ] Mohit Suman reassigned JBDS-4543: --------------------------------- Assignee: Mohit Suman > Fix installation note to header and remove extra UI space > --------------------------------------------------------- > > Key: JBDS-4543 > URL: https://issues.jboss.org/browse/JBDS-4543 > Project: Red Hat JBoss Developer Studio (devstudio) > Issue Type: Enhancement > Components: platform-installer > Reporter: Mohit Suman > Assignee: Mohit Suman > -- This message was sent by Atlassian JIRA (v7.2.3#72005)

8 years, 7 months

1
0
0 / 0

[JBoss JIRA] (JBDS-4544) Fix installation note to header and remove extra UI space

by Mohit Suman (JIRA)

Mohit Suman created JBDS-4544: --------------------------------- Summary: Fix installation note to header and remove extra UI space Key: JBDS-4544 URL: https://issues.jboss.org/browse/JBDS-4544 Project: Red Hat JBoss Developer Studio (devstudio) Issue Type: Enhancement Components: platform-installer Reporter: Mohit Suman -- This message was sent by Atlassian JIRA (v7.2.3#72005)

8 years, 7 months

1
0
0 / 0

[JBoss JIRA] (JBDS-4544) Fix installation note to header and remove extra UI space

by Mohit Suman (JIRA)

[ https://issues.jboss.org/browse/JBDS-4544?page=com.atlassian.jira.plugin.... ] Mohit Suman closed JBDS-4544. ----------------------------- Resolution: Duplicate Issue > Fix installation note to header and remove extra UI space > --------------------------------------------------------- > > Key: JBDS-4544 > URL: https://issues.jboss.org/browse/JBDS-4544 > Project: Red Hat JBoss Developer Studio (devstudio) > Issue Type: Enhancement > Components: platform-installer > Reporter: Mohit Suman > -- This message was sent by Atlassian JIRA (v7.2.3#72005)

8 years, 7 months

1
0
0 / 0

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

jbosstools-issues September 2017