[JBoss JIRA] (JBIDE-24991) Improve server port offset detection by inspecting configured system properties
by Jeff MAURY (JIRA)
[ https://issues.jboss.org/browse/JBIDE-24991?page=com.atlassian.jira.plugi... ]
Jeff MAURY updated JBIDE-24991:
-------------------------------
Fix Version/s: 4.5.x
> Improve server port offset detection by inspecting configured system properties
> -------------------------------------------------------------------------------
>
> Key: JBIDE-24991
> URL: https://issues.jboss.org/browse/JBIDE-24991
> Project: Tools (JBoss Tools)
> Issue Type: Enhancement
> Affects Versions: 4.5.0.Final
> Environment: JBDS11, WF10
> Reporter: Vsevolod Golovanov
> Fix For: 4.5.x
>
>
> The default Wildfly standalone.xml config has port offset configured like this:
> {code}
> <socket-binding-group ... port-offset="${jboss.socket.binding.port-offset:0}">
> {code}
> With the way our configuration process is set up we don't change that. Instead we add a system property to the same config file:
> {code}
> <system-properties>
> <property name="jboss.socket.binding.port-offset" value="10"/>
> </system-properties>
> {code}
> The problem is JBoss Tools doesn't detect this currently. It could be improved to inspect the port-offset attribute and find the corresponding system property value.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 7 months
[JBoss JIRA] (JBIDE-24991) Improve server port offset detection by inspecting configured system properties
by Jeff MAURY (JIRA)
[ https://issues.jboss.org/browse/JBIDE-24991?page=com.atlassian.jira.plugi... ]
Jeff MAURY reassigned JBIDE-24991:
----------------------------------
Assignee: Rob Stryker
> Improve server port offset detection by inspecting configured system properties
> -------------------------------------------------------------------------------
>
> Key: JBIDE-24991
> URL: https://issues.jboss.org/browse/JBIDE-24991
> Project: Tools (JBoss Tools)
> Issue Type: Enhancement
> Affects Versions: 4.5.0.Final
> Environment: JBDS11, WF10
> Reporter: Vsevolod Golovanov
> Assignee: Rob Stryker
> Fix For: 4.5.x
>
>
> The default Wildfly standalone.xml config has port offset configured like this:
> {code}
> <socket-binding-group ... port-offset="${jboss.socket.binding.port-offset:0}">
> {code}
> With the way our configuration process is set up we don't change that. Instead we add a system property to the same config file:
> {code}
> <system-properties>
> <property name="jboss.socket.binding.port-offset" value="10"/>
> </system-properties>
> {code}
> The problem is JBoss Tools doesn't detect this currently. It could be improved to inspect the port-offset attribute and find the corresponding system property value.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 7 months
[JBoss JIRA] (JBIDE-24801) Remove no-cache header for xml schema files
by Rob Stryker (JIRA)
[ https://issues.jboss.org/browse/JBIDE-24801?page=com.atlassian.jira.plugi... ]
Rob Stryker resolved JBIDE-24801.
---------------------------------
Resolution: Won't Do
After discussion on a call, this won't be done. After updates from David Hladky about the number of people likely to be required to sign-off, and the existence of the workaround in preferences, AND the jbds setting the preference automatically, this issue cannot be justified to use the time required.
> Remove no-cache header for xml schema files
> -------------------------------------------
>
> Key: JBIDE-24801
> URL: https://issues.jboss.org/browse/JBIDE-24801
> Project: Tools (JBoss Tools)
> Issue Type: Feature Request
> Components: server, upstream
> Affects Versions: 4.5.0.Final
> Reporter: Martin Malina
> Assignee: Rob Stryker
> Fix For: 4.5.1.AM2
>
>
> This is a followup of JBIDE-20610 . In the past we were trying to figure out how to make validation in Eclipse faster. The problem is that xml schema files return no-cache header and so Eclipse needs to fetch them over and over again.
> We tried to solve this on Eclipse side - allow ignoring of the no-cache http header. But why not try to solve this properly on the server side at least where we have control over it? I think there is no reason why request to urls like http://jboss.org/j2ee/dtd/service-ref_4_0.dtd should return no-cache.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 7 months
[JBoss JIRA] (JBIDE-24801) Remove no-cache header for xml schema files
by Rob Stryker (JIRA)
[ https://issues.jboss.org/browse/JBIDE-24801?page=com.atlassian.jira.plugi... ]
Rob Stryker updated JBIDE-24801:
--------------------------------
Fix Version/s: 4.5.1.AM2
(was: 4.5.x)
> Remove no-cache header for xml schema files
> -------------------------------------------
>
> Key: JBIDE-24801
> URL: https://issues.jboss.org/browse/JBIDE-24801
> Project: Tools (JBoss Tools)
> Issue Type: Feature Request
> Components: server, upstream
> Affects Versions: 4.5.0.Final
> Reporter: Martin Malina
> Assignee: Rob Stryker
> Fix For: 4.5.1.AM2
>
>
> This is a followup of JBIDE-20610 . In the past we were trying to figure out how to make validation in Eclipse faster. The problem is that xml schema files return no-cache header and so Eclipse needs to fetch them over and over again.
> We tried to solve this on Eclipse side - allow ignoring of the no-cache http header. But why not try to solve this properly on the server side at least where we have control over it? I think there is no reason why request to urls like http://jboss.org/j2ee/dtd/service-ref_4_0.dtd should return no-cache.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 7 months
[JBoss JIRA] (JBIDE-24968) VersionProviderTest.testFallBackEmbeddedValues is failing
by Nick Boldt (JIRA)
[ https://issues.jboss.org/browse/JBIDE-24968?page=com.atlassian.jira.plugi... ]
Nick Boldt resolved JBIDE-24968.
--------------------------------
Resolution: Done
Booyeah, grean build.
https://dev-platform-jenkins.rhev-ci-vms.eng.rdu2.redhat.com/view/Devstud...
> VersionProviderTest.testFallBackEmbeddedValues is failing
> ---------------------------------------------------------
>
> Key: JBIDE-24968
> URL: https://issues.jboss.org/browse/JBIDE-24968
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: common
> Affects Versions: 4.5.1.AM1
> Reporter: Aurélien Pupier
> Assignee: Rob Stryker
> Priority: Critical
> Fix For: 4.5.1.AM2
>
>
> the test if failing since the beginning of August.
> It seems that the test was not played before, see [JBIDE-19081] so maybe it is that it has never worked
> {noformat}
> Error Message
> ide-config.properties can't be loaded from the org.jboss.tools.foundation.core plugin
> Stacktrace
> java.lang.RuntimeException: ide-config.properties can't be loaded from the org.jboss.tools.foundation.core plugin
> at java.util.Properties$LineReader.readLine(Properties.java:434)
> at java.util.Properties.load0(Properties.java:353)
> at java.util.Properties.load(Properties.java:341)
> at org.jboss.tools.foundation.core.properties.internal.VersionPropertiesProvider.getProperties(VersionPropertiesProvider.java:293)
> at org.jboss.tools.foundation.core.properties.internal.VersionPropertiesProvider.loadDefaultProperties(VersionPropertiesProvider.java:204)
> at org.jboss.tools.foundation.core.properties.internal.VersionPropertiesProvider.getValue(VersionPropertiesProvider.java:158)
> at org.jboss.tools.foundation.core.properties.internal.VersionPropertiesProvider.getValue(VersionPropertiesProvider.java:217)
> at org.jboss.tools.foundation.core.properties.internal.VersionProviderTest.testFallBackEmbeddedValues(VersionProviderTest.java:207)
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 7 months
[JBoss JIRA] (JBIDE-24968) VersionProviderTest.testFallBackEmbeddedValues is failing
by Nick Boldt (JIRA)
[ https://issues.jboss.org/browse/JBIDE-24968?page=com.atlassian.jira.plugi... ]
Nick Boldt commented on JBIDE-24968:
------------------------------------
Triggered:
https://dev-platform-jenkins.rhev-ci-vms.eng.rdu2.redhat.com/view/Devstud... >=752
> VersionProviderTest.testFallBackEmbeddedValues is failing
> ---------------------------------------------------------
>
> Key: JBIDE-24968
> URL: https://issues.jboss.org/browse/JBIDE-24968
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: common
> Affects Versions: 4.5.1.AM1
> Reporter: Aurélien Pupier
> Assignee: Rob Stryker
> Priority: Critical
> Fix For: 4.5.1.AM2
>
>
> the test if failing since the beginning of August.
> It seems that the test was not played before, see [JBIDE-19081] so maybe it is that it has never worked
> {noformat}
> Error Message
> ide-config.properties can't be loaded from the org.jboss.tools.foundation.core plugin
> Stacktrace
> java.lang.RuntimeException: ide-config.properties can't be loaded from the org.jboss.tools.foundation.core plugin
> at java.util.Properties$LineReader.readLine(Properties.java:434)
> at java.util.Properties.load0(Properties.java:353)
> at java.util.Properties.load(Properties.java:341)
> at org.jboss.tools.foundation.core.properties.internal.VersionPropertiesProvider.getProperties(VersionPropertiesProvider.java:293)
> at org.jboss.tools.foundation.core.properties.internal.VersionPropertiesProvider.loadDefaultProperties(VersionPropertiesProvider.java:204)
> at org.jboss.tools.foundation.core.properties.internal.VersionPropertiesProvider.getValue(VersionPropertiesProvider.java:158)
> at org.jboss.tools.foundation.core.properties.internal.VersionPropertiesProvider.getValue(VersionPropertiesProvider.java:217)
> at org.jboss.tools.foundation.core.properties.internal.VersionProviderTest.testFallBackEmbeddedValues(VersionProviderTest.java:207)
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 7 months
[JBoss JIRA] (JBIDE-24968) VersionProviderTest.testFallBackEmbeddedValues is failing
by Rob Stryker (JIRA)
[ https://issues.jboss.org/browse/JBIDE-24968?page=com.atlassian.jira.plugi... ]
Rob Stryker edited comment on JBIDE-24968 at 9/6/17 7:35 PM:
-------------------------------------------------------------
> Thanks to Rob for nagging me until -I- *we* dug into this
was (Author: rob.stryker):
> Thanks to Rob for nagging me until ~I~ *we* dug into this
> VersionProviderTest.testFallBackEmbeddedValues is failing
> ---------------------------------------------------------
>
> Key: JBIDE-24968
> URL: https://issues.jboss.org/browse/JBIDE-24968
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: common
> Affects Versions: 4.5.1.AM1
> Reporter: Aurélien Pupier
> Assignee: Rob Stryker
> Priority: Critical
> Fix For: 4.5.1.AM2
>
>
> the test if failing since the beginning of August.
> It seems that the test was not played before, see [JBIDE-19081] so maybe it is that it has never worked
> {noformat}
> Error Message
> ide-config.properties can't be loaded from the org.jboss.tools.foundation.core plugin
> Stacktrace
> java.lang.RuntimeException: ide-config.properties can't be loaded from the org.jboss.tools.foundation.core plugin
> at java.util.Properties$LineReader.readLine(Properties.java:434)
> at java.util.Properties.load0(Properties.java:353)
> at java.util.Properties.load(Properties.java:341)
> at org.jboss.tools.foundation.core.properties.internal.VersionPropertiesProvider.getProperties(VersionPropertiesProvider.java:293)
> at org.jboss.tools.foundation.core.properties.internal.VersionPropertiesProvider.loadDefaultProperties(VersionPropertiesProvider.java:204)
> at org.jboss.tools.foundation.core.properties.internal.VersionPropertiesProvider.getValue(VersionPropertiesProvider.java:158)
> at org.jboss.tools.foundation.core.properties.internal.VersionPropertiesProvider.getValue(VersionPropertiesProvider.java:217)
> at org.jboss.tools.foundation.core.properties.internal.VersionProviderTest.testFallBackEmbeddedValues(VersionProviderTest.java:207)
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 7 months
[JBoss JIRA] (JBIDE-24968) VersionProviderTest.testFallBackEmbeddedValues is failing
by Rob Stryker (JIRA)
[ https://issues.jboss.org/browse/JBIDE-24968?page=com.atlassian.jira.plugi... ]
Rob Stryker commented on JBIDE-24968:
-------------------------------------
> Thanks to Rob for nagging me until ~~I~~ *we* dug into this
> VersionProviderTest.testFallBackEmbeddedValues is failing
> ---------------------------------------------------------
>
> Key: JBIDE-24968
> URL: https://issues.jboss.org/browse/JBIDE-24968
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: common
> Affects Versions: 4.5.1.AM1
> Reporter: Aurélien Pupier
> Assignee: Rob Stryker
> Priority: Critical
> Fix For: 4.5.1.AM2
>
>
> the test if failing since the beginning of August.
> It seems that the test was not played before, see [JBIDE-19081] so maybe it is that it has never worked
> {noformat}
> Error Message
> ide-config.properties can't be loaded from the org.jboss.tools.foundation.core plugin
> Stacktrace
> java.lang.RuntimeException: ide-config.properties can't be loaded from the org.jboss.tools.foundation.core plugin
> at java.util.Properties$LineReader.readLine(Properties.java:434)
> at java.util.Properties.load0(Properties.java:353)
> at java.util.Properties.load(Properties.java:341)
> at org.jboss.tools.foundation.core.properties.internal.VersionPropertiesProvider.getProperties(VersionPropertiesProvider.java:293)
> at org.jboss.tools.foundation.core.properties.internal.VersionPropertiesProvider.loadDefaultProperties(VersionPropertiesProvider.java:204)
> at org.jboss.tools.foundation.core.properties.internal.VersionPropertiesProvider.getValue(VersionPropertiesProvider.java:158)
> at org.jboss.tools.foundation.core.properties.internal.VersionPropertiesProvider.getValue(VersionPropertiesProvider.java:217)
> at org.jboss.tools.foundation.core.properties.internal.VersionProviderTest.testFallBackEmbeddedValues(VersionProviderTest.java:207)
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 7 months
[JBoss JIRA] (JBIDE-24968) VersionProviderTest.testFallBackEmbeddedValues is failing
by Rob Stryker (JIRA)
[ https://issues.jboss.org/browse/JBIDE-24968?page=com.atlassian.jira.plugi... ]
Rob Stryker edited comment on JBIDE-24968 at 9/6/17 7:34 PM:
-------------------------------------------------------------
> Thanks to Rob for nagging me until ~I~ *we* dug into this
was (Author: rob.stryker):
> Thanks to Rob for nagging me until ~~I~~ *we* dug into this
> VersionProviderTest.testFallBackEmbeddedValues is failing
> ---------------------------------------------------------
>
> Key: JBIDE-24968
> URL: https://issues.jboss.org/browse/JBIDE-24968
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: common
> Affects Versions: 4.5.1.AM1
> Reporter: Aurélien Pupier
> Assignee: Rob Stryker
> Priority: Critical
> Fix For: 4.5.1.AM2
>
>
> the test if failing since the beginning of August.
> It seems that the test was not played before, see [JBIDE-19081] so maybe it is that it has never worked
> {noformat}
> Error Message
> ide-config.properties can't be loaded from the org.jboss.tools.foundation.core plugin
> Stacktrace
> java.lang.RuntimeException: ide-config.properties can't be loaded from the org.jboss.tools.foundation.core plugin
> at java.util.Properties$LineReader.readLine(Properties.java:434)
> at java.util.Properties.load0(Properties.java:353)
> at java.util.Properties.load(Properties.java:341)
> at org.jboss.tools.foundation.core.properties.internal.VersionPropertiesProvider.getProperties(VersionPropertiesProvider.java:293)
> at org.jboss.tools.foundation.core.properties.internal.VersionPropertiesProvider.loadDefaultProperties(VersionPropertiesProvider.java:204)
> at org.jboss.tools.foundation.core.properties.internal.VersionPropertiesProvider.getValue(VersionPropertiesProvider.java:158)
> at org.jboss.tools.foundation.core.properties.internal.VersionPropertiesProvider.getValue(VersionPropertiesProvider.java:217)
> at org.jboss.tools.foundation.core.properties.internal.VersionProviderTest.testFallBackEmbeddedValues(VersionProviderTest.java:207)
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 7 months
[JBoss JIRA] (JBIDE-24968) VersionProviderTest.testFallBackEmbeddedValues is failing
by Nick Boldt (JIRA)
[ https://issues.jboss.org/browse/JBIDE-24968?page=com.atlassian.jira.plugi... ]
Nick Boldt edited comment on JBIDE-24968 at 9/6/17 7:30 PM:
------------------------------------------------------------
Seems the root cause here is that we're assigning the value of *skipTests* (eg., true) to *skipRequirements* [0], and in the parent pom, *skipRequirements* is used to determine if maven-download-plugin:1.1 and download-maven-plugin:1.2+ are going to fire or be skipped [1].
[0] https://github.com/jbosstools/jbosstools-build/blob/master/parent/pom.xml...
[1] https://github.com/jbosstools/jbosstools-build/blob/master/parent/pom.xml...
So, in https://github.com/jbosstools/jbosstools-base/pull/592/files I've set the call to download-maven-plugin:1.3 to never be skipped, since it's not fetching a TEST REQUIREMENT (eg., server runtimes) but a bit of the foundation.core plugin's source code.
Thanks to Rob for nagging me until I dug into this. :)
was (Author: nickboldt):
Seems the root cause here is that we're assigning the value of *skipTests* (eg., true) to *skipRequirements*, and in the parent pom, *skipRequirements* is used to determine if maven-download-plugin:1.1 and download-maven-plugin:1.2+ are going to fire or be skipped.
So, in https://github.com/jbosstools/jbosstools-base/pull/592/files I've set the call to download-maven-plugin to never be skipped, since it's not fetching a REQUIREMENT but a bit of plugin source code.
Thanks to Rob for nagging me until I dug into this. :)
> VersionProviderTest.testFallBackEmbeddedValues is failing
> ---------------------------------------------------------
>
> Key: JBIDE-24968
> URL: https://issues.jboss.org/browse/JBIDE-24968
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: common
> Affects Versions: 4.5.1.AM1
> Reporter: Aurélien Pupier
> Assignee: Rob Stryker
> Priority: Critical
> Fix For: 4.5.1.AM2
>
>
> the test if failing since the beginning of August.
> It seems that the test was not played before, see [JBIDE-19081] so maybe it is that it has never worked
> {noformat}
> Error Message
> ide-config.properties can't be loaded from the org.jboss.tools.foundation.core plugin
> Stacktrace
> java.lang.RuntimeException: ide-config.properties can't be loaded from the org.jboss.tools.foundation.core plugin
> at java.util.Properties$LineReader.readLine(Properties.java:434)
> at java.util.Properties.load0(Properties.java:353)
> at java.util.Properties.load(Properties.java:341)
> at org.jboss.tools.foundation.core.properties.internal.VersionPropertiesProvider.getProperties(VersionPropertiesProvider.java:293)
> at org.jboss.tools.foundation.core.properties.internal.VersionPropertiesProvider.loadDefaultProperties(VersionPropertiesProvider.java:204)
> at org.jboss.tools.foundation.core.properties.internal.VersionPropertiesProvider.getValue(VersionPropertiesProvider.java:158)
> at org.jboss.tools.foundation.core.properties.internal.VersionPropertiesProvider.getValue(VersionPropertiesProvider.java:217)
> at org.jboss.tools.foundation.core.properties.internal.VersionProviderTest.testFallBackEmbeddedValues(VersionProviderTest.java:207)
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 7 months