[JBoss JIRA] (JBIDE-24968) VersionProviderTest.testFallBackEmbeddedValues is failing
by Nick Boldt (JIRA)
[ https://issues.jboss.org/browse/JBIDE-24968?page=com.atlassian.jira.plugi... ]
Nick Boldt commented on JBIDE-24968:
------------------------------------
Seems the root cause here is that we're assigning the value of *skipTests* (eg., true) to *skipRequirements*, and in the parent pom, *skipRequirements* is used to determine if maven-download-plugin:1.1 and download-maven-plugin:1.2+ are going to fire or be skipped.
So, in https://github.com/jbosstools/jbosstools-base/pull/592/files I've set the call to download-maven-plugin to never be skipped, since it's not fetching a REQUIREMENT but a bit of plugin source code.
Thanks to Rob for nagging me until I dug into this. :)
> VersionProviderTest.testFallBackEmbeddedValues is failing
> ---------------------------------------------------------
>
> Key: JBIDE-24968
> URL: https://issues.jboss.org/browse/JBIDE-24968
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: common
> Affects Versions: 4.5.1.AM1
> Reporter: Aurélien Pupier
> Assignee: Rob Stryker
> Priority: Critical
> Fix For: 4.5.1.AM2
>
>
> the test if failing since the beginning of August.
> It seems that the test was not played before, see [JBIDE-19081] so maybe it is that it has never worked
> {noformat}
> Error Message
> ide-config.properties can't be loaded from the org.jboss.tools.foundation.core plugin
> Stacktrace
> java.lang.RuntimeException: ide-config.properties can't be loaded from the org.jboss.tools.foundation.core plugin
> at java.util.Properties$LineReader.readLine(Properties.java:434)
> at java.util.Properties.load0(Properties.java:353)
> at java.util.Properties.load(Properties.java:341)
> at org.jboss.tools.foundation.core.properties.internal.VersionPropertiesProvider.getProperties(VersionPropertiesProvider.java:293)
> at org.jboss.tools.foundation.core.properties.internal.VersionPropertiesProvider.loadDefaultProperties(VersionPropertiesProvider.java:204)
> at org.jboss.tools.foundation.core.properties.internal.VersionPropertiesProvider.getValue(VersionPropertiesProvider.java:158)
> at org.jboss.tools.foundation.core.properties.internal.VersionPropertiesProvider.getValue(VersionPropertiesProvider.java:217)
> at org.jboss.tools.foundation.core.properties.internal.VersionProviderTest.testFallBackEmbeddedValues(VersionProviderTest.java:207)
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 7 months
[JBoss JIRA] (JBIDE-24968) VersionProviderTest.testFallBackEmbeddedValues is failing
by Nick Boldt (JIRA)
[ https://issues.jboss.org/browse/JBIDE-24968?page=com.atlassian.jira.plugi... ]
Nick Boldt updated JBIDE-24968:
-------------------------------
Fix Version/s: 4.5.1.AM2
> VersionProviderTest.testFallBackEmbeddedValues is failing
> ---------------------------------------------------------
>
> Key: JBIDE-24968
> URL: https://issues.jboss.org/browse/JBIDE-24968
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: common
> Affects Versions: 4.5.1.AM1
> Reporter: Aurélien Pupier
> Assignee: Rob Stryker
> Priority: Critical
> Fix For: 4.5.1.AM2
>
>
> the test if failing since the beginning of August.
> It seems that the test was not played before, see [JBIDE-19081] so maybe it is that it has never worked
> {noformat}
> Error Message
> ide-config.properties can't be loaded from the org.jboss.tools.foundation.core plugin
> Stacktrace
> java.lang.RuntimeException: ide-config.properties can't be loaded from the org.jboss.tools.foundation.core plugin
> at java.util.Properties$LineReader.readLine(Properties.java:434)
> at java.util.Properties.load0(Properties.java:353)
> at java.util.Properties.load(Properties.java:341)
> at org.jboss.tools.foundation.core.properties.internal.VersionPropertiesProvider.getProperties(VersionPropertiesProvider.java:293)
> at org.jboss.tools.foundation.core.properties.internal.VersionPropertiesProvider.loadDefaultProperties(VersionPropertiesProvider.java:204)
> at org.jboss.tools.foundation.core.properties.internal.VersionPropertiesProvider.getValue(VersionPropertiesProvider.java:158)
> at org.jboss.tools.foundation.core.properties.internal.VersionPropertiesProvider.getValue(VersionPropertiesProvider.java:217)
> at org.jboss.tools.foundation.core.properties.internal.VersionProviderTest.testFallBackEmbeddedValues(VersionProviderTest.java:207)
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 7 months
[JBoss JIRA] (JBIDE-24841) Remove findbugs plugin from Central
by Nick Boldt (JIRA)
[ https://issues.jboss.org/browse/JBIDE-24841?page=com.atlassian.jira.plugi... ]
Nick Boldt reassigned JBIDE-24841:
----------------------------------
Assignee: Jeff MAURY (was: Nick Boldt)
> Remove findbugs plugin from Central
> -----------------------------------
>
> Key: JBIDE-24841
> URL: https://issues.jboss.org/browse/JBIDE-24841
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: central-update, target-platform, updatesite, upstream
> Affects Versions: 4.5.0.Final
> Reporter: Martin Malina
> Assignee: Jeff MAURY
> Fix For: 4.5.1.AM2
>
>
> I suggest we remove FindBugs connector from Central. It seems it hasn't been developed for some time now. The version we have in central is:
> edu.umd.cs.findbugs.plugin.eclipse_3.0.1.20150306-5afe4d1
> And if you look at the project's update site, that's still the latest release there is:
> http://findbugs.cs.umd.edu/eclipse/
> Furthermore, it kind of broke for me now. I never tested it extensively. But I would create a project and then right-click -> Find Bugs -> Find Bugs. This would open a window showing progress as the project is searched for bugs. When I tried it now, no window appears. For a few seconds something shows up in the status bar. But I can't see the results anywhere.
> Since this is Central, we could do this right away - affecting devstudio 11 / jbosstools 4.5.0. But I guess we need PM approval first.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 7 months
[JBoss JIRA] (JBIDE-24841) Remove findbugs plugin from Central
by Nick Boldt (JIRA)
[ https://issues.jboss.org/browse/JBIDE-24841?page=com.atlassian.jira.plugi... ]
Nick Boldt commented on JBIDE-24841:
------------------------------------
Given this plugin is also on the Eclipse Marketplace, do we REALLY want it in Central?
https://marketplace.eclipse.org/content/spotbugs-eclipse-plugin
Or can we just expect that users will find it there? Asking because I'm not a customer or a findbugs/spotbugs user, so I don't know if any users/customers care about this.
Looking at GA data for the last 8 months, I see about 1000 installs via Central. That's 0.03% of all installs via Central for that period.
So... maybe we just want to remove FindBugs, not replace it?
[~mmalina] [~rpdavis] [~jeffmaury] WDYT?
> Remove findbugs plugin from Central
> -----------------------------------
>
> Key: JBIDE-24841
> URL: https://issues.jboss.org/browse/JBIDE-24841
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: central-update, target-platform, updatesite, upstream
> Affects Versions: 4.5.0.Final
> Reporter: Martin Malina
> Assignee: Nick Boldt
> Fix For: 4.5.1.AM2
>
>
> I suggest we remove FindBugs connector from Central. It seems it hasn't been developed for some time now. The version we have in central is:
> edu.umd.cs.findbugs.plugin.eclipse_3.0.1.20150306-5afe4d1
> And if you look at the project's update site, that's still the latest release there is:
> http://findbugs.cs.umd.edu/eclipse/
> Furthermore, it kind of broke for me now. I never tested it extensively. But I would create a project and then right-click -> Find Bugs -> Find Bugs. This would open a window showing progress as the project is searched for bugs. When I tried it now, no window appears. For a few seconds something shows up in the status bar. But I can't see the results anywhere.
> Since this is Central, we could do this right away - affecting devstudio 11 / jbosstools 4.5.0. But I guess we need PM approval first.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 7 months
[JBoss JIRA] (JBIDE-24966) linuxtools.reddeer should depend on eclipse.reddeer 2.0, not jboss.reddeer 1.2
by Nick Boldt (JIRA)
[ https://issues.jboss.org/browse/JBIDE-24966?page=com.atlassian.jira.plugi... ]
Nick Boldt commented on JBIDE-24966:
------------------------------------
Building: https://dev-platform-jenkins.rhev-ci-vms.eng.rdu2.redhat.com/view/Devstud... >=8
> linuxtools.reddeer should depend on eclipse.reddeer 2.0, not jboss.reddeer 1.2
> ------------------------------------------------------------------------------
>
> Key: JBIDE-24966
> URL: https://issues.jboss.org/browse/JBIDE-24966
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: build, docker, target-platform
> Affects Versions: 4.5.1.AM2
> Reporter: Nick Boldt
> Assignee: Nick Boldt
> Priority: Blocker
> Fix For: 4.5.1.AM2
>
>
> Turns out we have a blocker here.
> org.eclipse.linuxtools.docker.reddeer depends on the old namespace org.jboss.reddeer.* plugins, but the plan for JBoss Tools 4.5.1 is to move to Red Deer 2.0, which has migrated to the org.eclipse.reddeer namespace.
> Therefore this manifest needs to be changed, if we want to include Red Deer 2.0 in jbosstools 4.5.1.AM2 / devstudio 11.1.0.AM2:
> {code:title=org.eclipse.linuxtools.docker.reddeer_1.0.0.201708220400.jar/META-INF/MANIFEST.MF}
> Require-Bundle: org.junit,org.eclipse.swt,
> org.eclipse.ui,
> org.eclipse.osgi,org.eclipse.core.runtime,
> org.jboss.reddeer.eclipse;bundle-version="1.2.1", <<
> org.jboss.reddeer.common;bundle-version="1.2.1", <<
> org.jboss.reddeer.swt;bundle-version="1.2.1", <<
> org.jboss.reddeer.core;bundle-version="1.2.1", <<
> org.jboss.reddeer.workbench;bundle-version="1.2.1", <<
> org.apache.commons.lang;bundle-version="2.6.0",
> org.eclipse.linuxtools.docker.core,
> org.hamcrest.library;bundle-version="1.3.0",
> org.hamcrest.core;bundle-version="1.3.0"{code}
> Note that the target platform freeze for the upcoming AM2 milestone is next Tuesday, Sept 12. Ideally, this would be fixed a few days before, so that I can apply other changes in advance.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 7 months