July 2018 - jbosstools-issues - Jboss List Archives

[JBoss JIRA] (JBIDE-26173) Validation for 'oc executable location' in Preferences OpenShift 3 page does not allow to keep value empty

by Andre Dietisheim (JIRA)

[ https://issues.jboss.org/browse/JBIDE-26173?page=com.atlassian.jira.plugi... ] Andre Dietisheim edited comment on JBIDE-26173 at 7/9/18 12:25 PM: ------------------------------------------------------------------- [~odockal] I now turned all oc binary errors into warnings which then allows you to get off the oc preferences page without being bugged. !image-2018-07-09-18-24-08-509.png! This makes imho also sense in the connection wizard: why would we prevent creating a connection if there's a problem with the oc binary? !image-2018-07-09-18-21-13-711.png|thumbnail! The only exception is in the server adapter wizard where the oc is absolutely required. !image-2018-07-09-18-21-33-723.png|thumbnail! was (Author: adietish): [~odockal] I now turned all oc binary errors into warnings which then allows you to get off the oc preferences page without being bugged. !image-2018-07-09-18-24-08-509.png! This makes imho also sense in the connection wizard: why would we prevent creating a connection if there's a problem with the oc binary? !image-2018-07-09-18-21-13-711.png! The only exception is in the server adapter wizard where the oc is absolutely required. !image-2018-07-09-18-21-33-723.png! > Validation for 'oc executable location' in Preferences OpenShift 3 page does not allow to keep value empty > ---------------------------------------------------------------------------------------------------------- > > Key: JBIDE-26173 > URL: https://issues.jboss.org/browse/JBIDE-26173 > Project: Tools (JBoss Tools) > Issue Type: Bug > Components: openshift > Affects Versions: 4.6.0.Final > Reporter: Ondrej Dockal > Assignee: Andre Dietisheim > Fix For: 4.9.0.AM1 > > Attachments: image-2018-07-09-18-20-57-878.png, image-2018-07-09-18-21-13-711.png, image-2018-07-09-18-21-33-723.png, image-2018-07-09-18-24-08-509.png > > > When user chooses Preferences -> Jboss Tools -> OpenShift 3 and does nothing (ie. when one just clicked to wrong page), the page cannot be changed, 'Could not accept changes' dialog pops up and user must cancel Preferences dialog. > I suggest to not validate empty oc location. -- This message was sent by Atlassian JIRA (v7.5.0#75005)

7 years, 9 months

1
0
0 / 0

[JBoss JIRA] (JBIDE-26173) Validation for 'oc executable location' in Preferences OpenShift 3 page does not allow to keep value empty

by Andre Dietisheim (JIRA)

[ https://issues.jboss.org/browse/JBIDE-26173?page=com.atlassian.jira.plugi... ] Andre Dietisheim edited comment on JBIDE-26173 at 7/9/18 12:24 PM: ------------------------------------------------------------------- [~odockal] I now turned all oc binary errors into warnings which then allows you to get off the oc preferences page without being bugged. !image-2018-07-09-18-24-08-509.png! This makes imho also sense in the connection wizard: why would we prevent creating a connection if there's a problem with the oc binary? !image-2018-07-09-18-21-13-711.png! The only exception is in the server adapter wizard where the oc is absolutely required. !image-2018-07-09-18-21-33-723.png! was (Author: adietish): [~odockal] I now turned all oc binary errors into warnings which then allows you to get off the oc preferences page without being bugged. !image-2018-07-09-18-20-57-878.png! This makes imho also sense in the connection wizard: why would we prevent creating a connection if there's a problem with the oc binary? !image-2018-07-09-18-21-13-711.png! The only exception is in the server adapter wizard where the oc is absolutely required. !image-2018-07-09-18-21-33-723.png! > Validation for 'oc executable location' in Preferences OpenShift 3 page does not allow to keep value empty > ---------------------------------------------------------------------------------------------------------- > > Key: JBIDE-26173 > URL: https://issues.jboss.org/browse/JBIDE-26173 > Project: Tools (JBoss Tools) > Issue Type: Bug > Components: openshift > Affects Versions: 4.6.0.Final > Reporter: Ondrej Dockal > Assignee: Andre Dietisheim > Fix For: 4.9.0.AM1 > > Attachments: image-2018-07-09-18-20-57-878.png, image-2018-07-09-18-21-13-711.png, image-2018-07-09-18-21-33-723.png, image-2018-07-09-18-24-08-509.png > > > When user chooses Preferences -> Jboss Tools -> OpenShift 3 and does nothing (ie. when one just clicked to wrong page), the page cannot be changed, 'Could not accept changes' dialog pops up and user must cancel Preferences dialog. > I suggest to not validate empty oc location. -- This message was sent by Atlassian JIRA (v7.5.0#75005)

7 years, 9 months

1
0
0 / 0

[JBoss JIRA] (JBIDE-26173) Validation for 'oc executable location' in Preferences OpenShift 3 page does not allow to keep value empty

by Andre Dietisheim (JIRA)

[ https://issues.jboss.org/browse/JBIDE-26173?page=com.atlassian.jira.plugi... ] Andre Dietisheim updated JBIDE-26173: ------------------------------------- Story Points: 4 Sprint: devex #152 July 2018 > Validation for 'oc executable location' in Preferences OpenShift 3 page does not allow to keep value empty > ---------------------------------------------------------------------------------------------------------- > > Key: JBIDE-26173 > URL: https://issues.jboss.org/browse/JBIDE-26173 > Project: Tools (JBoss Tools) > Issue Type: Bug > Components: openshift > Affects Versions: 4.6.0.Final > Reporter: Ondrej Dockal > Assignee: Andre Dietisheim > Fix For: 4.9.0.AM1 > > Attachments: image-2018-07-09-18-20-57-878.png, image-2018-07-09-18-21-13-711.png, image-2018-07-09-18-21-33-723.png > > > When user chooses Preferences -> Jboss Tools -> OpenShift 3 and does nothing (ie. when one just clicked to wrong page), the page cannot be changed, 'Could not accept changes' dialog pops up and user must cancel Preferences dialog. > I suggest to not validate empty oc location. -- This message was sent by Atlassian JIRA (v7.5.0#75005)

7 years, 9 months

1
0
0 / 0

[JBoss JIRA] (JBIDE-26173) Validation for 'oc executable location' in Preferences OpenShift 3 page does not allow to keep value empty

by Andre Dietisheim (JIRA)

[ https://issues.jboss.org/browse/JBIDE-26173?page=com.atlassian.jira.plugi... ] Andre Dietisheim edited comment on JBIDE-26173 at 7/9/18 12:21 PM: ------------------------------------------------------------------- [~odockal] I now turned all oc binary errors into warnings which then allows you to get off the oc preferences page without being bugged. !image-2018-07-09-18-20-57-878.png! This makes imho also sense in the connection wizard: why would we prevent creating a connection if there's a problem with the oc binary? !image-2018-07-09-18-21-13-711.png! The only exception is in the server adapter wizard where the oc is absolutely required. !image-2018-07-09-18-21-33-723.png! was (Author: adietish): [~odockal] I now turned all oc binary errors into warnings which then allows you to get off the oc preferences page without being bugged. This makes imho also sense in the connection wizard: why would we prevent creating a connection if there's a problem with the oc binary? The only exception is in the server adapter wizard where the oc is absoultely required. > Validation for 'oc executable location' in Preferences OpenShift 3 page does not allow to keep value empty > ---------------------------------------------------------------------------------------------------------- > > Key: JBIDE-26173 > URL: https://issues.jboss.org/browse/JBIDE-26173 > Project: Tools (JBoss Tools) > Issue Type: Bug > Components: openshift > Affects Versions: 4.6.0.Final > Reporter: Ondrej Dockal > Assignee: Andre Dietisheim > Fix For: 4.9.0.AM1 > > Attachments: image-2018-07-09-18-20-57-878.png, image-2018-07-09-18-21-13-711.png, image-2018-07-09-18-21-33-723.png > > > When user chooses Preferences -> Jboss Tools -> OpenShift 3 and does nothing (ie. when one just clicked to wrong page), the page cannot be changed, 'Could not accept changes' dialog pops up and user must cancel Preferences dialog. > I suggest to not validate empty oc location. -- This message was sent by Atlassian JIRA (v7.5.0#75005)

7 years, 9 months

1
0
0 / 0

[JBoss JIRA] (JBIDE-26173) Validation for 'oc executable location' in Preferences OpenShift 3 page does not allow to keep value empty

by Andre Dietisheim (JIRA)

[ https://issues.jboss.org/browse/JBIDE-26173?page=com.atlassian.jira.plugi... ] Andre Dietisheim updated JBIDE-26173: ------------------------------------- Fix Version/s: 4.9.0.AM1 > Validation for 'oc executable location' in Preferences OpenShift 3 page does not allow to keep value empty > ---------------------------------------------------------------------------------------------------------- > > Key: JBIDE-26173 > URL: https://issues.jboss.org/browse/JBIDE-26173 > Project: Tools (JBoss Tools) > Issue Type: Bug > Components: openshift > Affects Versions: 4.6.0.Final > Reporter: Ondrej Dockal > Assignee: Andre Dietisheim > Fix For: 4.9.0.AM1 > > > When user chooses Preferences -> Jboss Tools -> OpenShift 3 and does nothing (ie. when one just clicked to wrong page), the page cannot be changed, 'Could not accept changes' dialog pops up and user must cancel Preferences dialog. > I suggest to not validate empty oc location. -- This message was sent by Atlassian JIRA (v7.5.0#75005)

7 years, 9 months

1
0
0 / 0

[JBoss JIRA] (JBIDE-26173) Validation for 'oc executable location' in Preferences OpenShift 3 page does not allow to keep value empty

by Ondrej Dockal (JIRA)

[ https://issues.jboss.org/browse/JBIDE-26173?page=com.atlassian.jira.plugi... ] Ondrej Dockal updated JBIDE-26173: ---------------------------------- Priority: Major (was: Critical) > Validation for 'oc executable location' in Preferences OpenShift 3 page does not allow to keep value empty > ---------------------------------------------------------------------------------------------------------- > > Key: JBIDE-26173 > URL: https://issues.jboss.org/browse/JBIDE-26173 > Project: Tools (JBoss Tools) > Issue Type: Bug > Components: openshift > Affects Versions: 4.6.0.Final > Reporter: Ondrej Dockal > Assignee: Andre Dietisheim > > When user chooses Preferences -> Jboss Tools -> OpenShift 3 and does nothing (ie. when one just clicked to wrong page), the page cannot be changed, 'Could not accept changes' dialog pops up and user must cancel Preferences dialog. > I suggest to not validate empty oc location. -- This message was sent by Atlassian JIRA (v7.5.0#75005)

7 years, 9 months

1
0
0 / 0

[JBoss JIRA] (JBIDE-26173) Validation for 'oc executable location' in Preferences OpenShift 3 page does not allow to keep value empty

by Andre Dietisheim (JIRA)

[ https://issues.jboss.org/browse/JBIDE-26173?page=com.atlassian.jira.plugi... ] Andre Dietisheim commented on JBIDE-26173: ------------------------------------------ [~odockal] I see your point. I see a similar approach being taken ex. in Preferences > Java EE > XDoclet where one can get out of the page even if it is invalid (while there are other pages where you can't). But then, afaics you cannot have both: you cannot have an invalid page and have "Apply" disabled while you can switch pages. Both are linked, you can only get out of the page if "Apply" is enabled. "Apply" being enabled while the page is invalid is odd, too but seems the minor annoyance. So what I can do is to display an error while you can get out of the page and "Apply" is still enabled. ps. I'm not sure if this really is critical. One can fix it by downloading and installing oc. > Validation for 'oc executable location' in Preferences OpenShift 3 page does not allow to keep value empty > ---------------------------------------------------------------------------------------------------------- > > Key: JBIDE-26173 > URL: https://issues.jboss.org/browse/JBIDE-26173 > Project: Tools (JBoss Tools) > Issue Type: Bug > Components: openshift > Affects Versions: 4.6.0.Final > Reporter: Ondrej Dockal > Assignee: Andre Dietisheim > Priority: Critical > > When user chooses Preferences -> Jboss Tools -> OpenShift 3 and does nothing (ie. when one just clicked to wrong page), the page cannot be changed, 'Could not accept changes' dialog pops up and user must cancel Preferences dialog. > I suggest to not validate empty oc location. -- This message was sent by Atlassian JIRA (v7.5.0#75005)

7 years, 9 months

1
0
0 / 0

[JBoss JIRA] (JBIDE-26173) Validation for 'oc executable location' in Preferences OpenShift 3 page does not allow to keep value empty

by Ondrej Dockal (JIRA)

[ https://issues.jboss.org/browse/JBIDE-26173?page=com.atlassian.jira.plugi... ] Ondrej Dockal commented on JBIDE-26173: --------------------------------------- I agree that one should have filled up proper oc path, but just after the moment when he/she start using openshift tooling somehow. On contrary, imho, I personally do not like idea that user accidentally (on purpose while exploring settings) ends up "locked" or let's say forced to download/set up oc, even if he/she does not want to, wdyt? > Validation for 'oc executable location' in Preferences OpenShift 3 page does not allow to keep value empty > ---------------------------------------------------------------------------------------------------------- > > Key: JBIDE-26173 > URL: https://issues.jboss.org/browse/JBIDE-26173 > Project: Tools (JBoss Tools) > Issue Type: Bug > Components: openshift > Affects Versions: 4.6.0.Final > Reporter: Ondrej Dockal > Assignee: Andre Dietisheim > Priority: Critical > > When user chooses Preferences -> Jboss Tools -> OpenShift 3 and does nothing (ie. when one just clicked to wrong page), the page cannot be changed, 'Could not accept changes' dialog pops up and user must cancel Preferences dialog. > I suggest to not validate empty oc location. -- This message was sent by Atlassian JIRA (v7.5.0#75005)

7 years, 9 months

1
0
0 / 0

[JBoss JIRA] (JBIDE-26173) Validation for 'oc executable location' in Preferences OpenShift 3 page does not allow to keep value empty

by Ondrej Dockal (JIRA)

[ https://issues.jboss.org/browse/JBIDE-26173?page=com.atlassian.jira.plugi... ] Ondrej Dockal commented on JBIDE-26173: --------------------------------------- It ended up the same way as I do not have oc on path and thus, hitting restore defaults button fills up empty string. Then the switching to another page throws error dialog. > Validation for 'oc executable location' in Preferences OpenShift 3 page does not allow to keep value empty > ---------------------------------------------------------------------------------------------------------- > > Key: JBIDE-26173 > URL: https://issues.jboss.org/browse/JBIDE-26173 > Project: Tools (JBoss Tools) > Issue Type: Bug > Components: openshift > Affects Versions: 4.6.0.Final > Reporter: Ondrej Dockal > Assignee: Andre Dietisheim > Priority: Critical > > When user chooses Preferences -> Jboss Tools -> OpenShift 3 and does nothing (ie. when one just clicked to wrong page), the page cannot be changed, 'Could not accept changes' dialog pops up and user must cancel Preferences dialog. > I suggest to not validate empty oc location. -- This message was sent by Atlassian JIRA (v7.5.0#75005)

7 years, 9 months

1
0
0 / 0

[JBoss JIRA] (JBIDE-26173) Validation for 'oc executable location' in Preferences OpenShift 3 page does not allow to keep value empty

by Andre Dietisheim (JIRA)

[ https://issues.jboss.org/browse/JBIDE-26173?page=com.atlassian.jira.plugi... ] Andre Dietisheim edited comment on JBIDE-26173 at 7/9/18 9:00 AM: ------------------------------------------------------------------ I would think that this is correct since the tooling wont work properly in many areas if you dont have an oc binary. I would agree though that one should be able to switch to other preferences though. I can fix this by hitting "Restore Default". OC then gets filled out by what is found on $PATH (if it exists). Doesn't this work for you? was (Author: adietish): I would think that this is correct since the tooling wont work properly in many areas if you dont have an oc binary. I can fix this by hitting "Restore Default". OC then gets filled out by what is found on $PATH (if it exists). Doesn't this work for you? > Validation for 'oc executable location' in Preferences OpenShift 3 page does not allow to keep value empty > ---------------------------------------------------------------------------------------------------------- > > Key: JBIDE-26173 > URL: https://issues.jboss.org/browse/JBIDE-26173 > Project: Tools (JBoss Tools) > Issue Type: Bug > Components: openshift > Affects Versions: 4.6.0.Final > Reporter: Ondrej Dockal > Assignee: Andre Dietisheim > Priority: Critical > > When user chooses Preferences -> Jboss Tools -> OpenShift 3 and does nothing (ie. when one just clicked to wrong page), the page cannot be changed, 'Could not accept changes' dialog pops up and user must cancel Preferences dialog. > I suggest to not validate empty oc location. -- This message was sent by Atlassian JIRA (v7.5.0#75005)

7 years, 9 months

1
0
0 / 0

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

jbosstools-issues July 2018