[JBoss JIRA] (JBIDE-26379) Launcher: should be moved from base to central
by Jeff MAURY (JIRA)
[ https://issues.jboss.org/browse/JBIDE-26379?page=com.atlassian.jira.plugi... ]
Jeff MAURY commented on JBIDE-26379:
------------------------------------
I just meant that if this is a simple move it can be done but if you start renaming bundles and features then you will probably rename the packages and then it's another story
> Launcher: should be moved from base to central
> ----------------------------------------------
>
> Key: JBIDE-26379
> URL: https://issues.jboss.org/browse/JBIDE-26379
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: central, common
> Affects Versions: 4.9.0.AM3
> Reporter: Andre Dietisheim
> Labels: launcher_wizard
>
> as discussed in https://github.com/jbosstools/jbosstools-base/pull/631#issuecomment-42109...
> {quote}
> This should all live in central, and it shouldn't really be added to the common.all feature if we intend to simply move it later.
> Give it it's own feature, add it to the master list of features added to the project, and then later move it to the central repo.
> I personally believe a rename-and-move is just fine even before a Final. Keeping it where it is through a final actually is what's harder to change. Then it becomes a sort of API that the common.all feature contains this launcher, and later it won't.
> {quote}
> we should move the launcher from jbosstools-base to jbosstools-central
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
7 years, 6 months
[JBoss JIRA] (JBIDE-26379) Launcher: should be moved from base to central
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-26379?page=com.atlassian.jira.plugi... ]
Andre Dietisheim commented on JBIDE-26379:
------------------------------------------
[~jeffmaury] so in your opinion there's nothing to be done before final, leaving the rename to after GA?
> Launcher: should be moved from base to central
> ----------------------------------------------
>
> Key: JBIDE-26379
> URL: https://issues.jboss.org/browse/JBIDE-26379
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: central, common
> Affects Versions: 4.9.0.AM3
> Reporter: Andre Dietisheim
> Labels: launcher_wizard
>
> as discussed in https://github.com/jbosstools/jbosstools-base/pull/631#issuecomment-42109...
> {quote}
> This should all live in central, and it shouldn't really be added to the common.all feature if we intend to simply move it later.
> Give it it's own feature, add it to the master list of features added to the project, and then later move it to the central repo.
> I personally believe a rename-and-move is just fine even before a Final. Keeping it where it is through a final actually is what's harder to change. Then it becomes a sort of API that the common.all feature contains this launcher, and later it won't.
> {quote}
> we should move the launcher from jbosstools-base to jbosstools-central
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
7 years, 6 months
[JBoss JIRA] (JBIDE-26379) Launcher: should be moved from base to central
by Jeff MAURY (JIRA)
[ https://issues.jboss.org/browse/JBIDE-26379?page=com.atlassian.jira.plugi... ]
Jeff MAURY commented on JBIDE-26379:
------------------------------------
Moving is another story unless you decide not to rename the plugins/features
> Launcher: should be moved from base to central
> ----------------------------------------------
>
> Key: JBIDE-26379
> URL: https://issues.jboss.org/browse/JBIDE-26379
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: central, common
> Affects Versions: 4.9.0.AM3
> Reporter: Andre Dietisheim
> Labels: launcher_wizard
>
> as discussed in https://github.com/jbosstools/jbosstools-base/pull/631#issuecomment-42109...
> {quote}
> This should all live in central, and it shouldn't really be added to the common.all feature if we intend to simply move it later.
> Give it it's own feature, add it to the master list of features added to the project, and then later move it to the central repo.
> I personally believe a rename-and-move is just fine even before a Final. Keeping it where it is through a final actually is what's harder to change. Then it becomes a sort of API that the common.all feature contains this launcher, and later it won't.
> {quote}
> we should move the launcher from jbosstools-base to jbosstools-central
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
7 years, 6 months
[JBoss JIRA] (JBIDE-26379) Launcher: should be moved from base to central
by Jeff MAURY (JIRA)
[ https://issues.jboss.org/browse/JBIDE-26379?page=com.atlassian.jira.plugi... ]
Jeff MAURY commented on JBIDE-26379:
------------------------------------
There's already a specific feature for those plugins. I added them to commons.all because I thought it would make them available to JBoss Tools update site and DeveloperStudio installer but it was false
> Launcher: should be moved from base to central
> ----------------------------------------------
>
> Key: JBIDE-26379
> URL: https://issues.jboss.org/browse/JBIDE-26379
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: central, common
> Affects Versions: 4.9.0.AM3
> Reporter: Andre Dietisheim
> Labels: launcher_wizard
>
> as discussed in https://github.com/jbosstools/jbosstools-base/pull/631#issuecomment-42109...
> {quote}
> This should all live in central, and it shouldn't really be added to the common.all feature if we intend to simply move it later.
> Give it it's own feature, add it to the master list of features added to the project, and then later move it to the central repo.
> I personally believe a rename-and-move is just fine even before a Final. Keeping it where it is through a final actually is what's harder to change. Then it becomes a sort of API that the common.all feature contains this launcher, and later it won't.
> {quote}
> we should move the launcher from jbosstools-base to jbosstools-central
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
7 years, 6 months
[JBoss JIRA] (JBIDE-26379) Launcher: should be moved from base to central
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-26379?page=com.atlassian.jira.plugi... ]
Andre Dietisheim commented on JBIDE-26379:
------------------------------------------
[~jeffmaury] I guess we should remove the plugins from the commons.all feature and add it to it's very own feature before 4.9.0.Final. Moving can then be done after GA. Agree?
> Launcher: should be moved from base to central
> ----------------------------------------------
>
> Key: JBIDE-26379
> URL: https://issues.jboss.org/browse/JBIDE-26379
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: central, common
> Affects Versions: 4.9.0.AM3
> Reporter: Andre Dietisheim
> Labels: launcher_wizard
>
> as discussed in https://github.com/jbosstools/jbosstools-base/pull/631#issuecomment-42109...
> {quote}
> This should all live in central, and it shouldn't really be added to the common.all feature if we intend to simply move it later.
> Give it it's own feature, add it to the master list of features added to the project, and then later move it to the central repo.
> I personally believe a rename-and-move is just fine even before a Final. Keeping it where it is through a final actually is what's harder to change. Then it becomes a sort of API that the common.all feature contains this launcher, and later it won't.
> {quote}
> we should move the launcher from jbosstools-base to jbosstools-central
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
7 years, 6 months
[JBoss JIRA] (JBIDE-26380) Pod log: does not work if oc is configured at the connection level
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-26380?page=com.atlassian.jira.plugi... ]
Andre Dietisheim updated JBIDE-26380:
-------------------------------------
Story Points: 3
> Pod log: does not work if oc is configured at the connection level
> ------------------------------------------------------------------
>
> Key: JBIDE-26380
> URL: https://issues.jboss.org/browse/JBIDE-26380
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Affects Versions: 4.9.0.AM3
> Reporter: Jeff MAURY
> Assignee: Andre Dietisheim
> Labels: connection, oc_binary, pod_log
> Fix For: 4.9.0.Final
>
> Attachments: screenshot-1.png
>
>
> ASSERT: no oc configured at the workspace level
> ASSERT: oc is configured at the connection level
> ASSERT: have a pod running
> ASSERT: execute the pod log command
> EXPECTED: pod log is shown
> Instead, a dialog is shown claiming there is an issue with the oc client
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
7 years, 6 months
[JBoss JIRA] (JBIDE-26380) Pod log: does not work if oc is configured at the connection level
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-26380?page=com.atlassian.jira.plugi... ]
Andre Dietisheim updated JBIDE-26380:
-------------------------------------
Summary: Pod log: does not work if oc is configured at the connection level (was: pod log command does not work if oc is configured at the connection level)
> Pod log: does not work if oc is configured at the connection level
> ------------------------------------------------------------------
>
> Key: JBIDE-26380
> URL: https://issues.jboss.org/browse/JBIDE-26380
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Affects Versions: 4.9.0.AM3
> Reporter: Jeff MAURY
> Assignee: Andre Dietisheim
> Labels: connection, oc_binary, pod_log
> Fix For: 4.9.0.Final
>
> Attachments: screenshot-1.png
>
>
> ASSERT: no oc configured at the workspace level
> ASSERT: oc is configured at the connection level
> ASSERT: have a pod running
> ASSERT: execute the pod log command
> EXPECTED: pod log is shown
> Instead, a dialog is shown claiming there is an issue with the oc client
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
7 years, 6 months
[JBoss JIRA] (JBIDE-26380) pod log command does not work if oc is configured at the connection level
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-26380?page=com.atlassian.jira.plugi... ]
Andre Dietisheim updated JBIDE-26380:
-------------------------------------
Labels: connection oc_binary pod_log (was: )
> pod log command does not work if oc is configured at the connection level
> -------------------------------------------------------------------------
>
> Key: JBIDE-26380
> URL: https://issues.jboss.org/browse/JBIDE-26380
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Affects Versions: 4.9.0.AM3
> Reporter: Jeff MAURY
> Assignee: Andre Dietisheim
> Labels: connection, oc_binary, pod_log
> Fix For: 4.9.0.Final
>
> Attachments: screenshot-1.png
>
>
> ASSERT: no oc configured at the workspace level
> ASSERT: oc is configured at the connection level
> ASSERT: have a pod running
> ASSERT: execute the pod log command
> EXPECTED: pod log is shown
> Instead, a dialog is shown claiming there is an issue with the oc client
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
7 years, 6 months
[JBoss JIRA] (JBIDE-26380) pod log command does not work if oc is configured at the connection level
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-26380?page=com.atlassian.jira.plugi... ]
Andre Dietisheim updated JBIDE-26380:
-------------------------------------
Sprint: devex #155 September 2018
> pod log command does not work if oc is configured at the connection level
> -------------------------------------------------------------------------
>
> Key: JBIDE-26380
> URL: https://issues.jboss.org/browse/JBIDE-26380
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Affects Versions: 4.9.0.AM3
> Reporter: Jeff MAURY
> Assignee: Andre Dietisheim
> Labels: connection, oc_binary, pod_log
> Fix For: 4.9.0.Final
>
> Attachments: screenshot-1.png
>
>
> ASSERT: no oc configured at the workspace level
> ASSERT: oc is configured at the connection level
> ASSERT: have a pod running
> ASSERT: execute the pod log command
> EXPECTED: pod log is shown
> Instead, a dialog is shown claiming there is an issue with the oc client
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
7 years, 6 months