[JBoss JIRA] (ERT-666) Improve JDT Indexer performance for method reference lookups
by Roland Grunberg (JIRA)
[ https://issues.jboss.org/browse/ERT-666?page=com.atlassian.jira.plugin.sy... ]
Roland Grunberg updated ERT-666:
--------------------------------
Description:
Based on discussions with Igor, various proposals were made to improve the method reference lookup times of the JDT Indexer.
One particular suggestion, which should be possible, with least amount of friction, would be to provide more information about the declaring type of a method in the indexer format.
The methodRef category table currently stores :
(symbol, number of arguments) -> document numbers (classfiles)
toString/0 -> [1, 4, 5, 25]
The proposal would change this to :
(symbol, symbol's classname, classname) -> document numbers (classfiles)
toString/0/java.lang.Object -> [1, 4, 5, 25]
Doing so should reduce the number of post-processing changes needed to verify that the declaring type of the first set of matches corresponds to the declaring type of the selected reference.
(/) Make the patch mostly correct
(?) Handle some more difficult corner cases (eg. detect references even to dead code)
(/) Basic performance test with just a JVM target platform, and lookup of java.lang.Object.toString()
(?) More complicated performance test against the Eclipse Platform itself for java.lang.Object.toString()
(?) A more thorough correctness test to identify any additional differences. (eg. test every single possible method reference, not just toString() )
was:
Based on discussions with Igor, various proposals were made to improve the method reference lookup times of the JDT Indexer.
One particular suggestion, which should be possible, with least amount of friction, would be to provide more information about the declaring type of a method in the indexer format.
The methodRef category table currently stores :
(symbol, number of arguments) -> document numbers (classfiles)
toString/0 -> [1, 4, 5, 25]
The proposal would change this to :
(symbol, symbol's classname, classname) -> document numbers (classfiles)
toString/0/java.lang.Object -> [1, 4, 5, 25]
Doing so should reduce the number of post-processing changes needed to verify that the declaring type of the first set of matches corresponds to the declaring type of the selected reference.
> Improve JDT Indexer performance for method reference lookups
> ------------------------------------------------------------
>
> Key: ERT-666
> URL: https://issues.jboss.org/browse/ERT-666
> Project: Eclipse Release Train
> Issue Type: Task
> Reporter: Roland Grunberg
> Assignee: Roland Grunberg
>
> Based on discussions with Igor, various proposals were made to improve the method reference lookup times of the JDT Indexer.
> One particular suggestion, which should be possible, with least amount of friction, would be to provide more information about the declaring type of a method in the indexer format.
> The methodRef category table currently stores :
> (symbol, number of arguments) -> document numbers (classfiles)
> toString/0 -> [1, 4, 5, 25]
> The proposal would change this to :
> (symbol, symbol's classname, classname) -> document numbers (classfiles)
> toString/0/java.lang.Object -> [1, 4, 5, 25]
> Doing so should reduce the number of post-processing changes needed to verify that the declaring type of the first set of matches corresponds to the declaring type of the selected reference.
> (/) Make the patch mostly correct
> (?) Handle some more difficult corner cases (eg. detect references even to dead code)
> (/) Basic performance test with just a JVM target platform, and lookup of java.lang.Object.toString()
> (?) More complicated performance test against the Eclipse Platform itself for java.lang.Object.toString()
> (?) A more thorough correctness test to identify any additional differences. (eg. test every single possible method reference, not just toString() )
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
7 years, 6 months
[JBoss JIRA] (JBIDE-26180) TP: create target platform based on Eclipse 4.9 (Simrel 2018-09)
by Nick Boldt (JIRA)
[ https://issues.jboss.org/browse/JBIDE-26180?page=com.atlassian.jira.plugi... ]
Nick Boldt updated JBIDE-26180:
-------------------------------
Sprint: devex #152 July 2018, devex #153 August 2018, devex #155 September 2018 (was: devex #152 July 2018, devex #153 August 2018, devex #154 September 2018)
> TP: create target platform based on Eclipse 4.9 (Simrel 2018-09)
> ----------------------------------------------------------------
>
> Key: JBIDE-26180
> URL: https://issues.jboss.org/browse/JBIDE-26180
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: target-platform, upstream
> Affects Versions: 4.9.0.AM1
> Reporter: Nick Boldt
> Assignee: Nick Boldt
> Labels: releasework
> Fix For: 4.9.0.AM3, 4.9.0.Final
>
> Attachments: am1-vs-am2.p2diff.txt, p2diff.am2.am3.all.ignoreVersions.txt, p2diff.am2.am3.all.txt
>
>
> In order to start Eclipse 4.9-based builds, we need an updated target platform.
> For sprint 152 / AM1: simrel M1
> For sprint 153 / AM2: simrel M2
> For sprint 154 / AM3: simrel M3
> For sprint 155 / GA: simrel RC2/GA
> Coming in the next update, some orbit changes:
> * batik, icu4j, platform, felix gogo, httpclient (due 27 Aug)
> Also:
> * reddeer 2.3
> * m2e http://download.eclipse.org/technology/m2e/milestones/1.9/1.9.1.20180829-...
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
7 years, 6 months
[JBoss JIRA] (ERT-666) Improve JDT Indexer performance for method reference lookups
by Roland Grunberg (JIRA)
[ https://issues.jboss.org/browse/ERT-666?page=com.atlassian.jira.plugin.sy... ]
Roland Grunberg commented on ERT-666:
-------------------------------------
The patch as it exists in current form seems to improve performance for method reference lookups significantly.
> Improve JDT Indexer performance for method reference lookups
> ------------------------------------------------------------
>
> Key: ERT-666
> URL: https://issues.jboss.org/browse/ERT-666
> Project: Eclipse Release Train
> Issue Type: Task
> Reporter: Roland Grunberg
> Assignee: Roland Grunberg
>
> Based on discussions with Igor, various proposals were made to improve the method reference lookup times of the JDT Indexer.
> One particular suggestion, which should be possible, with least amount of friction, would be to provide more information about the declaring type of a method in the indexer format.
> The methodRef category table currently stores :
> (symbol, number of arguments) -> document numbers (classfiles)
> toString/0 -> [1, 4, 5, 25]
> The proposal would change this to :
> (symbol, symbol's classname, classname) -> document numbers (classfiles)
> toString/0/java.lang.Object -> [1, 4, 5, 25]
> Doing so should reduce the number of post-processing changes needed to verify that the declaring type of the first set of matches corresponds to the declaring type of the selected reference.
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
7 years, 6 months
[JBoss JIRA] (JBIDE-26301) Reduce CVE issues in org.fusesource.ide bundles
by Nick Boldt (JIRA)
[ https://issues.jboss.org/browse/JBIDE-26301?page=com.atlassian.jira.plugi... ]
Nick Boldt updated JBIDE-26301:
-------------------------------
Fix Version/s: 4.9.0.Final
(was: 4.9.0.AM3)
> Reduce CVE issues in org.fusesource.ide bundles
> -----------------------------------------------
>
> Key: JBIDE-26301
> URL: https://issues.jboss.org/browse/JBIDE-26301
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: central-update
> Reporter: Nick Boldt
> Assignee: Nick Boldt
> Fix For: 4.9.0.Final
>
>
> Some CVE issues exist in fuse bundles:
> {code:title=unpacked/devstudio-12.9.0.AM2-v20180808-0721-B3149-updatesite-core/}
> org.fusesource.ide.camel.model.service.impl.v2151redhat621216_11.1.0.v20180723-1842.jar/libs
> org.fusesource.ide.camel.model.service.impl.v2151redhat621216_11.1.0.v20180723-1842.jar/libs/camel-core-2.15.1.redhat-621216.jar/META-INF/maven/org.apache.camel/camel-core
> org.fusesource.ide.camel.model.service.impl.v2170redhat630347_11.1.0.v20180725-0619.jar/libs
> org.fusesource.ide.camel.model.service.impl.v2170redhat630347_11.1.0.v20180725-0619.jar/libs/camel-core-2.17.0.redhat-630347.jar/META-INF/maven/org.apache.camel/camel-core
> org.fusesource.ide.camel.model.service.impl.v2181redhat000021_11.1.0.v20180723-1842.jar/libs
> org.fusesource.ide.camel.model.service.impl.v2181redhat000021_11.1.0.v20180723-1842.jar/libs/camel-core-2.18.1.redhat-000021.jar/META-INF/maven/org.apache.camel/camel-core
> org.fusesource.ide.camel.model.service.impl.v2181redhat000021_11.1.0.v20180723-1842.jar/libs/camel-core-2.18.1.redhat-000021.jar/META-INF/maven/org.apache.camel/spi-annotations
> org.fusesource.ide.camel.model.service.impl.v2203_11.1.0.v20180723-1842.jar/libs
> org.fusesource.ide.camel.model.service.impl.v2210fuse000077redhat1_11.1.0.v20180723-1842.jar/libs
> org.fusesource.ide.camel.model.service.impl_11.1.0.v20180801-0947.jar/libs
> org.fusesource.ide.jmx.activemq_11.1.0.v20180723-1842.jar/libs
> org.fusesource.ide.wsdl2rest_11.1.0.v20180807-1302.jar/libs{code}
> -- https://dev-platform-jenkins.rhev-ci-vms.eng.rdu2.redhat.com/view/Devstud...
> Verification: check if we have fewer CVEs after updating to newer version of fuse 11.1.x:
> https://dev-platform-jenkins.rhev-ci-vms.eng.rdu2.redhat.com/view/Devstud... vs. #103
> https://dev-platform-jenkins.rhev-ci-vms.eng.rdu2.redhat.com/view/Devstud... vs. build #87
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
7 years, 6 months