[jbosstools-issues] [JBoss JIRA] (JBDS-3187) enforce rule that JBDS com.jboss.* bits must have GA, not Final qualifier

[ https://issues.jboss.org/browse/JBDS-3187?page=com.atlassian.jira.plugin.... ] Nick Boldt edited comment on JBDS-3187 at 10/17/14 3:11 PM: ------------------------------------------------------------ Tests build of JBDS in master branch with different settings: *works for master branch with 4.3.0.Alpha1-SNAPSHOT parent pom* {code} mvn clean install -P hudson -Djbosstools-site-stream=master -Dtpc.version=4.41.0.Final-SNAPSHOT {code} *now fails (as expected) for master branch with this change to root pom to use 4.2.0.Final-SNAPSHOT* {code} $➔ gd pom.xml diff --git a/pom.xml b/pom.xml index fd3a6ae..ead19f7 100644 --- a/pom.xml +++ b/pom.xml @@ -6,7 +6,7 @@ <parent> <groupId>org.jboss.tools</groupId> <artifactId>parent</artifactId> - <version>4.3.0.Alpha1-SNAPSHOT</version> + <version>4.2.0.Final-SNAPSHOT</version> </parent> <groupId>com.jboss.devstudio</groupId> <artifactId>product</artifactId> mvn install -P hudson -Djbosstools-site-stream=4.2.luna -Dtpc.version=4.41.0.Final-SNAPSHOT [INFO] ParentPomVersionCheckRule ......................... SUCCESS [2.312s] [INFO] JBDS - Product, Installers ........................ FAILURE [0.209s] [WARNING] Rule 0: com.jboss.devstudio.enforcer.rule.ParentPomVersionCheckRule failed with message: ** Parent pom version (4.2.0.Final-SNAPSHOT) contains .Final; must set -DBUILD_ALIAS=GA ** [ERROR] Failed to execute goal org.apache.maven.plugins:maven-enforcer-plugin:1.0-beta-1:enforce (enforce) on project product: Some Enforcer rules have failed. Look above for specific messages explaining why the rule failed. -> [Help 1] {code} *works for master branch with the above same change to root pom to use 4.2.0.Final-SNAPSHOT, and -DBUILD_ALIAS=GA flag added on* {code} mvn install -P hudson -Djbosstools-site-stream=4.2.luna -Dtpc.version=4.41.0.Final-SNAPSHOT -DBUILD_ALIAS=GA [INFO] ParentPomVersionCheckRule ......................... SUCCESS [0.393s] [INFO] JBDS - Product, Installers ........................ SUCCESS [1.490s] [INFO] JBDS - Product - Build Rules ...................... SUCCESS [0.008s] [INFO] JBDS - Product Plugins - Core ..................... SUCCESS [0.007s] [INFO] com.jboss.devstudio.core .......................... SUCCESS [3.762s] [INFO] com.jboss.devstudio.core.project.examples ......... SUCCESS [0.228s] [INFO] com.jboss.devstudio.core.usage.branding ........... SUCCESS [0.265s] [INFO] com.jboss.devstudio.core.central .................. SUCCESS [1.122s] [INFO] JBDS - Product Features - Core .................... SUCCESS [0.027s] [INFO] com.jboss.devstudio.core.feature .................. SUCCESS [0.616s] [INFO] com.jboss.devstudio.core.feature.source ........... SUCCESS [0.446s] [INFO] com.jboss.devstudio.core.site ..................... SUCCESS [1:27.254s] [INFO] p2-director ....................................... SUCCESS [0.168s] [INFO] com.jboss.devstudio.core.p2.director .............. SUCCESS [0.920s] [INFO] p2-director ....................................... SUCCESS [21.242s] [INFO] installer ......................................... SUCCESS [10:45.227s] [INFO] JBoss Developer Studio Sources .................... SUCCESS [15.659s] [INFO] JBoss Developer Studio Build Results .............. SUCCESS [7.716s] [INFO] ------------------------------------------------------------------------ [INFO] BUILD SUCCESS {code} So, I've pushed the above PR to master. [~maxandersen] [~mickael_istria], if you want it pushed to 4.2.x, let me know. was (Author: nickboldt): Tests build of JBDS in master branch with different settings: *works for master branch with 4.3.0.Alpha1-SNAPSHOT parent pom* {code} mvn clean install -P hudson -Djbosstools-site-stream=master -Dtpc.version=4.41.0.Final-SNAPSHOT {code} * now fails (as expected) for master branch with this change to root pom to use 4.2.0.Final-SNAPSHOT* {code} $➔ gd pom.xml diff --git a/pom.xml b/pom.xml index fd3a6ae..ead19f7 100644 --- a/pom.xml +++ b/pom.xml @@ -6,7 +6,7 @@ <parent> <groupId>org.jboss.tools</groupId> <artifactId>parent</artifactId> - <version>4.3.0.Alpha1-SNAPSHOT</version> + <version>4.2.0.Final-SNAPSHOT</version> </parent> <groupId>com.jboss.devstudio</groupId> <artifactId>product</artifactId> mvn install -P hudson -Djbosstools-site-stream=4.2.luna -Dtpc.version=4.41.0.Final-SNAPSHOT [INFO] ParentPomVersionCheckRule ......................... SUCCESS [2.312s] [INFO] JBDS - Product, Installers ........................ FAILURE [0.209s] [WARNING] Rule 0: com.jboss.devstudio.enforcer.rule.ParentPomVersionCheckRule failed with message: ** Parent pom version (4.2.0.Final-SNAPSHOT) contains .Final; must set -DBUILD_ALIAS=GA ** [ERROR] Failed to execute goal org.apache.maven.plugins:maven-enforcer-plugin:1.0-beta-1:enforce (enforce) on project product: Some Enforcer rules have failed. Look above for specific messages explaining why the rule failed. -> [Help 1] {code} *works for master branch with the above same change to root pom to use 4.2.0.Final-SNAPSHOT, and -DBUILD_ALIAS=GA flag added on* {code} mvn install -P hudson -Djbosstools-site-stream=4.2.luna -Dtpc.version=4.41.0.Final-SNAPSHOT -DBUILD_ALIAS=GA [INFO] ParentPomVersionCheckRule ......................... SUCCESS [0.393s] [INFO] JBDS - Product, Installers ........................ SUCCESS [1.490s] [INFO] JBDS - Product - Build Rules ...................... SUCCESS [0.008s] [INFO] JBDS - Product Plugins - Core ..................... SUCCESS [0.007s] [INFO] com.jboss.devstudio.core .......................... SUCCESS [3.762s] [INFO] com.jboss.devstudio.core.project.examples ......... SUCCESS [0.228s] [INFO] com.jboss.devstudio.core.usage.branding ........... SUCCESS [0.265s] [INFO] com.jboss.devstudio.core.central .................. SUCCESS [1.122s] [INFO] JBDS - Product Features - Core .................... SUCCESS [0.027s] [INFO] com.jboss.devstudio.core.feature .................. SUCCESS [0.616s] [INFO] com.jboss.devstudio.core.feature.source ........... SUCCESS [0.446s] [INFO] com.jboss.devstudio.core.site ..................... SUCCESS [1:27.254s] [INFO] p2-director ....................................... SUCCESS [0.168s] [INFO] com.jboss.devstudio.core.p2.director .............. SUCCESS [0.920s] [INFO] p2-director ....................................... SUCCESS [21.242s] [INFO] installer ......................................... SUCCESS [10:45.227s] [INFO] JBoss Developer Studio Sources .................... SUCCESS [15.659s] [INFO] JBoss Developer Studio Build Results .............. SUCCESS [7.716s] [INFO] ------------------------------------------------------------------------ [INFO] BUILD SUCCESS {code} So, I've pushed the above PR to master. [~maxandersen] [~mickael_istria], if you want it pushed to 4.2.x, let me know. -- This message was sent by Atlassian JIRA (v6.3.1#6329)