[jbosstools-issues] [JBoss JIRA] (JBIDE-14448) Build doesn't detect cycle dependencies between JBossTools modules

[ https://issues.jboss.org/browse/JBIDE-14448?page=com.atlassian.jira.plugi... ] Mickael Istria edited comment on JBIDE-14448 at 5/17/13 6:09 AM: ----------------------------------------------------------------- This is a problem we've already discussed several time, but did not suffer enough from this issue to fix. Now we're going to more cleanness and more independence between components, it's probably the right time to have a think about it. [~maxandersen]: you suggestion is the only right approach I have in mind. About maintaining branch vs master, it's all about using a profile or a property to set it. This is now easier thanks to new URL pattern Nick set up some month ago. For example, let's take the case of Server which has a dependency on Common. * We create a property "branch" in parent pom, with default value "master" (set in pom) * server root pom references http://download.jboss.org/jbosstools/builds/staging/jbosstools-common_${b... So * Running build for master is just a "mvn clean install" * Running build for branch is just a "mvn clean install -Dbranch=4.1.kepler" However, I don't know how we could deduce the "branch" from the current state of the code, so property would be immediatly well set. Especially since Tycho resolution happens very early in the build, there is no way to create a mojo to hack it... was (Author: mickael_istria): This is a problem we've already discussed several time, but did not suffer enough from this issue to fix. Now we're going to more cleanness and more independence between components, it's probably the right time to have a think about it. [~maxandersen]: you suggestion is the only right approach I have in mind. About maintaining branch vs master, it's all about using a profile or a property to set it. This is now easier thanks to new URL pattern Nick set up some month ago. For example, let's take the case of Server which has a dependency on Common. * We create a property "branch" in parent pom, with default value "master" (set in pom) * server root pom references http://download.jboss.org/jbosstools/builds/staging/jbosstools-common_${b... So * Running build for master is just a "mvn clean install" * Running build for branch is just a "mvn clean install -Dbranch=4.1.kepler" However, I don't know how we could deduce the "branch" from the current state of the code, so property would be immediatly well set. Especially since Tycho resolution happens very early in the build, there is no way to create a mojo to hack it... -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira