[
https://issues.jboss.org/browse/JBIDE-19335?page=com.atlassian.jira.plugi...
]
Rob Stryker commented on JBIDE-19335:
-------------------------------------
new inconsistent property introduced
I commented that
the property does not seem inconsistent. All it does is suppress browser creation. I
don't see how it's "inconsistent" in any way. Inconsistent with what? It
seems to me to be a clearly internal detail / sysprop used for testing.
mixed in license text with generic browser packages.
Looking at the BrowserUtility in master, and in fact all files in
org.jboss.tools.foundation.ui.util, I do not see any reference to license at all. Not in
BrowserUtility, not in BrowserUtilityMessages.java, or .properties. I don't know what
you mean by this.
no tests
I'm honestly really not sure how to go about testing this API. Who are our experts
at testing UI API? I'm really not familiar with it at all. Should I be opening new
shells and custom dialog boxes in my test case?
org.jboss.tools.runtime.ui.internal.wizard.DownloadRuntimeLicenseFragment fails with
SWTError without browser available
-----------------------------------------------------------------------------------------------------------------------
Key: JBIDE-19335
URL:
https://issues.jboss.org/browse/JBIDE-19335
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: common/jst/core, runtime-detection
Affects Versions: 4.2.3.Beta1, 4.3.0.Alpha1
Environment: Linux
Reporter: Denis Golovin
Assignee: Rob Stryker
Fix For: 4.3.0.Beta2
DownloadRuntimeLicenseFragment should work even without browser widget available and
show html or text without html tags with <p> and <br> elements replaced with
'\n'.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)