[jbosstools-issues] [JBoss JIRA] (JBIDE-15830) openshift-java-client: incompatibility with OpenShift Enterprise and Origin when using the remote-user authentication plugin

[ https://issues.jboss.org/browse/JBIDE-15830?page=com.atlassian.jira.plugi... ] Andre Dietisheim edited comment on JBIDE-15830 at 11/14/13 11:32 AM: --------------------------------------------------------------------- I'm removing the erroneous check in RestServiceProperties that wont return the *useragent* from the properties file if the id is *null*. I'm just checking that we have a useragent pattern and replace eventual nulls in *clientId* and *version* by empty strings (so that an overriding useragent-pattern may eventually decide to not provide clientId and version. {code} if (!StringUtils.isEmpty(useragentPattern)) { userAgent = MessageFormat.format(useragentPattern, StringUtils.nullToEmptyString(version), StringUtils.nullToEmptyString(clientId)); } {code} Created a PR for the above change (with test): https://github.com/openshift/openshift-java-client/pull/107 was (Author: adietish): I'm removing the erroneous check in RestServiceProperties that wont return the *useragent* from the properties file if the id is *null*. I'm just checking that we have a useragent pattern and replace eventual nulls in *clientId* and *version* by empty strings (so that an overriding useragent-pattern may eventually decide to not provide clientId and version. {code} if (!StringUtils.isEmpty(useragentPattern)) { userAgent = MessageFormat.format(useragentPattern, StringUtils.nullToEmptyString(version), StringUtils.nullToEmptyString(clientId)); } {code} I'll push this change upstream today. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira