[jbosstools-issues] [JBoss JIRA] (JBIDE-19756) jbosstools-src.zip has incomplete/misleading version info in folder names/structure
[
https://issues.jboss.org/browse/JBIDE-19756?page=com.atlassian.jira.plugi...
]
Nick Boldt commented on JBIDE-19756:
------------------------------------
Adding json files will take more work as they're produced in a different mojo
(GenerateRepositoryFacadeMojo.java, not FetchSourcesFromManifests.java), and I'm a bit
hesitant to have one mojo depend on another.
Do you want that the FetchSourcesFromManifests will also
FetchJSONFromUpstreamLatestBuildsFolders (hoping that no respins have happened between the
start of the aggregate job and the time when the fetch starts) ? Or should I just include
target/fullSite/all/repo/buildinfo.json into target/fullSite/all/jbosstools-src.zip ?
It's already included in the generated update site + update site zip, so I don't
have a problem adding it to the src.zip too... except for the fact that we'll have
cross-mojo dependencies. This will mean that the aggregate builds (JBT & JBDS) will
depend on BOTH mojos, and that they can only be configured to run in a SPECIFIC order. Is
that acceptable?
jbosstools-src.zip has incomplete/misleading version info in folder
names/structure
-----------------------------------------------------------------------------------
Key: JBIDE-19756
URL: https://issues.jboss.org/browse/JBIDE-19756
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: build
Affects Versions: 4.3.0.Beta1
Reporter: Max Rydahl Andersen
Assignee: Nick Boldt
Fix For: 4.3.0.Beta1
Attachments: jbide19756.png
Downloading latest jbosstools-src.zip from
http://download.jboss.org/jbosstools/mars/snapshots/builds/jbosstools-bui...
I see multiple files in root named:
<componentname>_<buildqualifier>_<sha1>
example:
jbosstools-javaee_Beta1-v20150501-0413-B767_149f9a46d5c676fd7119515e8b6aa796859955ad
A few issues with this:
a) it would have been nice unzipping would not create multiple root level folders. Maybe
have a jbosstools-source folder as root ?
b) the buildqualifier is there but the version string for the component is not. Either
put the full version string for that component (not overall jbosstools version) or just
leave it as <component>-<sha> and have the root folder state the full version
of jbosstools. since non-indulged user would not know this one had to do with 4.3.0.Beta1
or 4.2.3.Beta1 (for example).
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)