[jbosstools-issues] [JBoss JIRA] (JBIDE-16393) Fix/recover for bad usage of submodules in VPE
[
https://issues.jboss.org/browse/JBIDE-16393?page=com.atlassian.jira.plugi...
]
Denis Golovin commented on JBIDE-16393:
---------------------------------------
{quote}A) These are pointing to personal repos
B) No tags used
C) readme.adoc not documenting it
D) not announced anywhere
E) git clone no longer sufficient{quote}
(A) is bad, since it can just disappear at some point. So I guess we have to fork/mirror
original repository and merge in Yahor changes, then submodule can reference commit in our
fork.
(B) is actually not absolutely correct. Submodule is referencing to commit SHA and when
vpe is tagged it means we have a tagged submodule as well.
(C) and (D) should be fixed ASAP
(E) readme.adoc should be updated to have git clone --recursive
Fix/recover for bad usage of submodules in VPE
----------------------------------------------
Key: JBIDE-16393
URL: https://issues.jboss.org/browse/JBIDE-16393
Project: Tools (JBoss Tools)
Issue Type: Task
Components: browsersim, visual-page-editor-core
Affects Versions: 4.1.1.Final, 4.2.0.Alpha1
Reporter: Max Rydahl Andersen
Assignee: Ilya Buziuk
Priority: Critical
Fix For: 4.1.2.Final, 4.2.0.Alpha2
both master and branch of vpe is using submodules
https://github.com/jbosstools/jbosstools-vpe/blob/master/.gitmodules
https://github.com/jbosstools/jbosstools-vpe/blob/jbosstools-4.1.x/.gitmo...
Things wrong:
A) These are pointing to personal repos
B) No tags used
C) readme.adoc not documenting it
D) not announced anywhere
E) git clone no longer sufficient
We need to get this fixed/cleaned up in both branch and master.
*jbosstools-4.1.1.Final* - e498c091f79c140 ( JBIDE-15814 CordovaSim: Adding
navigator.app.backHistory support )
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira