6:24 a.m.
[
https://jira.jboss.org/jira/browse/JBIDE-3874?page=com.atlassian.jira.plu...
]
Max Rydahl Andersen commented on JBIDE-3874:
--------------------------------------------
If the project contains the Seam facet, the user can choose a maven
version of Seam - 2.1.1.GA is the default for the Seam facet 2.1 and 2.0.2.SP1 for the
Seam facet 2.0.
What I do not understand is why this maven facet is tied to Seam - what if this were a
plain Ear, war, esb, jar, .. ?
Here it for me would make sense if Seam etc. projects were updated to use the library
framework in WTP to say "Use Maven" and then
as far as I understand we can make it so Maven will know to pick up the right seam version
(possibly add ui for more precise selection).
Similar setup could be used for ear, war, jsf, etc. ?
>The user can also decide whether to remove WTP classpath
containers (where the path starts with org.eclipse.jst)
Yes - again, how many are there of these which would go away if they use the library
provider stuff from above ?
I also guess the JBoss AS runtimes can cause havoc ?
> * Is packaging choices the right thing to have on the maven page
? If yes, we should have it in sync with the packaging chosen on the seam (and other
>possible names)
In case of a Seam project, packaging is related to a web project and
needs to be war - we can disable this field.
okey - which projects would it be relevant for ?
> * Why is Seam listed on the M2 capabilities page ? Should it care
at this point ?
The M2 facet recognizes that the project contains the Seam facet and
enables the user to choose a Seam version.
Okey - but shouldn't it be the other way around ? Seam facet detecting Maven (and
again here the library provider integration could provide the questions ?)
> * Couldn't we somehow let Seam use the library provider
mechanism JSF does and then delegate that to the M2ClasspathProvider and simply just have
ui
> show up that ask you for JSF and Seam artifact id's ?
As to JSF, I am planning to add an extension point that would use WTP
3.1 Library Framework and provide contributions that would add dependencies to
the M2 classpath container. Some facet would be able to use that extension point.
The Seam project wizard is specific and is not easy to contribute in the Seam facet. The
Seam facet doesn't use the WTP Library framework, but copies
libraries from a Seam distribution. I have changed the wizard so that libraries aren't
copied, but added to the M2 classpath container within the post install
delegate. Post install delegate because we need to know properties of the Seam facet and
JBoss Maven facet when adding these libraries to the M2
classpath container.
The current Seam wizard is minimally changed this way.
Understood - but now is the time to do bigger changes to allow things like Maven to
coexist better (the older behaviour should just still be possible)
Seam requires more than JSF and Seam artifacts: hibernate, drools,
richfaces, facelets ... we need versions of all of these artifacts.
Doesn't Seam provide that info via their pom.xml's ?
> * And yes, as Eugene asks....does this run from the command line
too ?
The project can be run from the command line using maven 2.0.9
(probably 2.0.10), but can't using Run As>Maven clean/Run As>Maven install.
The problem is that m2eclipse uses maven 2.1 that is not compatible with maven 2.0
Yeah, the dreaded maven backward incompabilities ;( hmm - doesn't m2eclipse support
specifying which maven to run with ?
btw. why won't we just generate Maven 2.1 compatible project or ?
<list of m2eclipse/maven/wtp integration problems>
How do we go around best getting these fixed ? Create jira's for them individually and
report them to m2eclipse/maven and then see if we can provide a patch or get m2eclipse
team to help fix them ? if not in jira, we won't be able to get others to chip in ;)
Maven integration
-----------------
Key: JBIDE-3874
URL: https://jira.jboss.org/jira/browse/JBIDE-3874
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: common
Affects Versions: 3.0.0.GA
Reporter: Max Rydahl Andersen
Assignee: Snjezana Peco
Priority: Critical
Fix For: 3.1.0.M2
It is time to make sure our stuff works well with Maven, at least to the extent that the
underline runtimes support it.
First shot would be to add an adapter that allows m2eclipse controlled projects to
activate the seam features.
That would allow us still to bundle JBoss Tools without any dependencies to m2eclipse
which still seem to drag in non-compatible plugins which we need to look into before tying
us to m2eclipse.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira