[jbosstools-issues] [JBoss JIRA] (JBIDE-16488) Address issues raised by Sonar report in WS code

Address issues raised by Sonar report in WS code ------------------------------------------------ Key: JBIDE-16488 URL: https://issues.jboss.org/browse/JBIDE-16488 Project: Tools (JBoss Tools) Issue Type: Enhancement Components: webservices Affects Versions: 4.1.x Reporter: Xavier Coulon Assignee: Brian Fitzpatrick Fix For: 4.3.x Received an e-mail from Mickael about this Sonar report and think we should definitely take a look. Many of the issues raised could mask problems down the line at the very least and this sort of automated report could be very useful to avoid bugs BEFORE they are reported. Here's the e-mail: "I don't know if you remember, but some month ago, I did push installation of Sonar on JBoss infrastructure and have used the JBT WS job as a playground. So you can see reports at http://sonar.mw.lab.eng.bos.redhat.com/sonar/drilldown/violations/org.jbo... The most important ones are the rules violation with severity "Critical". Some of them are potential bugs, some other can cause performance or security issues, some others might show up some useless piece of code. You could use it during this "Quiet period" before GA to make some improvements inside the code. If you like it, please tell a word to the JBT team (or JBoss in general). This approach using code inspection to find bugs before they hit market is something that has been measured as a great benefit for a project: http://www.benlinders.com/2013/the-economics-of-software-quality/" Xavier and I should take a look at this after GA to try and fix at least the critical ones if possible.