[ https://jira.jboss.org/jira/browse/JBIDE-4736?page=com.atlassian.jira.plu... ] Max Rydahl Andersen commented on JBIDE-4736: -------------------------------------------- Wonder why they deprecated explicit control over natures like in maven-eclipse-plugin ? it would be a good fallback until every plugin in the world gets around to add support ;) What we need to figure out is how/when we enable seam functionallity. Other project configurators looks for specific plugins to enable their magic, i.e. WTP war projects get setup when maven-war-plugin is used, similar for maven-compiler-plugin etc. What I've suggested to Snjezana is that we enable Seam nature on projects which depend on seam core jars. that will enable code completion, seam views, etc. But it won't enable wizards that require seam-gen to work. We somehow need to know which seam-gen users are using... -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-4736?page=com.atlassian.jira.plu... ] Chris Bredesen commented on JBIDE-4736: --------------------------------------- Snjezana, If you could comment here when this hits the nightly update site I'd be more than happy to test it and report feedback. Thanks! -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-4736?page=com.atlassian.jira.plu... ] Snjezana Peco updated JBIDE-4736: --------------------------------- Attachment: outputMaven209.txt -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-4736?page=com.atlassian.jira.plu... ] Chris Bredesen commented on JBIDE-4736: --------------------------------------- If you use that POM and remove all other dependencies, you should be able to make the plugin work. I don't think there's anything special about it, per se... Making that POM work is going to be a pain because the ticketing-service is not in any repository. What I'm saying is, don't worry about my POM in particular. Just let me know what you need me to do and I'll fix my POM. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-4736?page=com.atlassian.jira.plu... ] Max Rydahl Andersen commented on JBIDE-4736: -------------------------------------------- "I have tried to import your project and faced a few issues: - the project doesn't contain the jboss-seam dependency. There is only the jboss-seam-ui dependency. Max, do we need to add Seam capabilities for projects like this? " doesn't jboss-seam-ui transitively drag in jboss-seam core ? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-4736?page=com.atlassian.jira.plu... ] Snjezana Peco commented on JBIDE-4736: -------------------------------------- I have committed the initial version of the Seam Maven configurator. The configurator will add Seam nature, Seam facet, required facets (Web Module, Java, JSF...), JBoss Maven Integration facet if the Maven project contains a dependency with the org.jboss.seam groupId and an artifactId starting with 'jboss-seam'. Seam capabilities will be added to the EJB, EAR and WAR project. There is a preference in the JBoss Tools category - "JBoss Maven Integration" to suspend this configurator. The bug related to adding the JBoss Maven Integration facet to an existing project (JBIDE-4706) is fixed. There are minimal changes in the seam.core plugin. I have added two preferences to the Seam Facet model. They suspend adding the default Seam Runtime and copying files from the Seam distribution that are unnecessary when importing a Maven project. For now the user needs to configure some Seam properties using the Seam Settings property page after importing a Maven project. TODO: - EAR projects require more testing especially because there are some m2eclipse bugs that need to be fixed.I have sent the patches that, I hope, will be applied this weekend. I will test photoalbum from the richfaces distribution, portletbridge examples, seam booking application, but would be really helpful if someone knows some other mavenized Seam EAR applications. - configure Seam Runtime that matches the Seam version from the Maven project if it exists in the workspace. - configure the View folder, the Model and Action's Source folder and package, The m2eclipse EAR configurator doesn't create application.xml, JBoss datasource and jboss-app.xml no mater if they are specified in maven-ear-plugin. I think we need to create these files. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-4736?page=com.atlassian.jira.plu... ] Max Rydahl Andersen commented on JBIDE-4736: -------------------------------------------- This looks great! "EAR projects require more testing especially because there are some m2eclipse bugs that need to be fixed.I have sent the patches that, I hope, will be applied this weekend" Do you have a list of those issues so we can keep track ? "The m2eclipse EAR configurator doesn't create application.xml, JBoss datasource and jboss-app.xml no mater if they are specified in maven-ear-plugin. I think we need to create these files." ...but the project-configurators at the plugin level shouldn't be creating actual project artifacts should they ? I would reckon that to be a common "contract" that the actual maven mojo plugins do the actual artifact creation and the project-configurators just enables as much as possible as they can in the IDE. Otherwise running the maven build in the IDE will have sideeffects that won't happen when just running the maven build outside the IDE. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-4736?page=com.atlassian.jira.plu... ] Max Rydahl Andersen commented on JBIDE-4736: -------------------------------------------- I honestly don't know what is the best option at the current time - so many factors to take into account :( I've started a thread on user@m2eclipse to see if that can give some input. Your solution is a workaround - but maybe the better option is to tell users if they wish to have things working both in maven and in eclipse they should not use the maven mojo's for these files ? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-4736?page=com.atlassian.jira.plu... ] Chris Bredesen commented on JBIDE-4736: --------------------------------------- This is awesome news! One question... As I'm testing this stuff via the nightly update site ... what do I need to do to ensure I'm hitting the features? Remove Eclipse metadata & reimport project? Or is Maven > Update Project Configuration enough? Should I try both? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-4736?page=com.atlassian.jira.plu... ] Snjezana Peco commented on JBIDE-4736: -------------------------------------- If you import a Maven project, the Maven Seam configurator will configure Seam. You can control the Seam configuration using the JBoss Tools>Maven Seam Configurator. Maven > Update Project Configuration will also work until you change a Seam preference using the Seam Settings project preference. It doesn't mater if the project contains Eclipse metadata unless you have changed a Seam project preference. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-4736?page=com.atlassian.jira.plu... ] Max Rydahl Andersen commented on JBIDE-4736: -------------------------------------------- Seeing that Export works, but Deploy doesn't is something we bumped into more than once and all WTP servers were affected by it not just ours. Snjezana, could you extract this into a separate bug for "JBoss AS" so we can track this separately ? Have you tried it with the default Generic JBoss deployer ? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira