>>>> On Tue, 19 Oct 2010 19:47:01 -0700, Ed Burns
<edward.burns(a)oracle.com> said:
>>>> On Tue, 19 Oct 2010 09:30:01 -0700, Ed Burns
<edward.burns(a)oracle.com> said:
>>>> On Mon, 18 Oct 2010 17:02:32 -0700, Blake Sullivan
<blake.sullivan(a)oracle.com> said:
B> I definitely consider it a bug for the
reason you mention. All of the
B> Trinidad components do push and pop the EL context during
B> invokeOnComponent. I believe that tree visiting does establish the
B> context correctly, which also shows where the intent lies.
EB> I agree this is probably a bug. I have made the change and am
EB> re-running our automated test suite. If there are no errors, I'll take
EB> the liberty of modifying the spec and impl, attaching a patch, seeking
EB> review, and commiting it. I think this can reasonably be grandfathered
EB> in under existing JSF 2.1 changelog issue 868. [1]
EB> I have attached the diffs to the issue. I would appreciate a quick code
EB> review of attachment 310 on [1], but considering that it is a small
EB> change, I'll commit it ahead of the review.
EB> Note that I modified the automated tests as well.
EB> [1]
https://javaserverfaces-spec-public.dev.java.net/issues/show_bug.cgi?id=868
Phooey, found and fixed another test failure, related to copyright
nonsense. Attachment 311, but ignore the FacesContext changes. They
are not in this commit.
Ed
--
| edward.burns(a)oracle.com | office: +1 407 458 0017
| homepage: |
http://ridingthecrest.com/
| 16 work days until German Oracle User's Group Conference