Author: shawkins
Date: 2012-07-02 10:12:21 -0400 (Mon, 02 Jul 2012)
New Revision: 4217
Modified:
trunk/client/src/main/java/org/teiid/net/socket/Message.java
trunk/client/src/main/java/org/teiid/net/socket/ServiceInvocationStruct.java
trunk/engine/src/main/java/org/teiid/query/processor/relational/SortUtility.java
trunk/runtime/src/main/java/org/teiid/transport/SocketClientInstance.java
Log:
TEIID-2089 additional logging enhancements
Modified: trunk/client/src/main/java/org/teiid/net/socket/Message.java
===================================================================
--- trunk/client/src/main/java/org/teiid/net/socket/Message.java 2012-07-02 13:57:57 UTC
(rev 4216)
+++ trunk/client/src/main/java/org/teiid/net/socket/Message.java 2012-07-02 14:12:21 UTC
(rev 4217)
@@ -35,7 +35,7 @@
private Serializable messageKey;
public String toString() {
- return "MessageHolder: contents=" + contents; //$NON-NLS-1$
+ return "MessageHolder: key=" + messageKey + " contents=" +
contents; //$NON-NLS-1$ //$NON-NLS-2$
}
public void setContents(Object contents) {
Modified: trunk/client/src/main/java/org/teiid/net/socket/ServiceInvocationStruct.java
===================================================================
---
trunk/client/src/main/java/org/teiid/net/socket/ServiceInvocationStruct.java 2012-07-02
13:57:57 UTC (rev 4216)
+++
trunk/client/src/main/java/org/teiid/net/socket/ServiceInvocationStruct.java 2012-07-02
14:12:21 UTC (rev 4217)
@@ -65,4 +65,9 @@
out.writeObject(methodName);
ExternalizeUtil.writeArray(out, args);
}
+
+ @Override
+ public String toString() {
+ return "Invoke " + targetClass + "." + methodName; //$NON-NLS-1$
//$NON-NLS-2$
+ }
}
\ No newline at end of file
Modified:
trunk/engine/src/main/java/org/teiid/query/processor/relational/SortUtility.java
===================================================================
---
trunk/engine/src/main/java/org/teiid/query/processor/relational/SortUtility.java 2012-07-02
13:57:57 UTC (rev 4216)
+++
trunk/engine/src/main/java/org/teiid/query/processor/relational/SortUtility.java 2012-07-02
14:12:21 UTC (rev 4217)
@@ -40,6 +40,7 @@
import org.teiid.core.TeiidProcessingException;
import org.teiid.core.util.Assertion;
import org.teiid.language.SortSpecification.NullOrdering;
+import org.teiid.logging.LogConstants;
import org.teiid.logging.LogManager;
import org.teiid.logging.MessageLevel;
import org.teiid.query.sql.lang.OrderBy;
@@ -176,10 +177,6 @@
this(ts, new OrderBy(expressions, types).getOrderByItems(), mode, bufferManager,
connectionID, schema);
}
- public boolean isDone() {
- return this.doneReading && this.phase == DONE;
- }
-
public TupleBuffer sort()
throws TeiidComponentException, TeiidProcessingException {
@@ -203,11 +200,18 @@
initialSort();
}
+ for (TupleBuffer tb : activeTupleBuffers) {
+ tb.close();
+ }
+
return activeTupleBuffers;
}
private TupleBuffer createTupleBuffer() throws TeiidComponentException {
TupleBuffer tb = bufferManager.createTupleBuffer(this.schema, this.groupName,
TupleSourceType.PROCESSOR);
+ if (LogManager.isMessageToBeRecorded(LogConstants.CTX_DQP, MessageLevel.DETAIL)) {
+ LogManager.logDetail(LogConstants.CTX_DQP, "Created intermediate sort buffer
", tb.getId()); //$NON-NLS-1$
+ }
tb.setForwardOnly(true);
return tb;
}
Modified: trunk/runtime/src/main/java/org/teiid/transport/SocketClientInstance.java
===================================================================
--- trunk/runtime/src/main/java/org/teiid/transport/SocketClientInstance.java 2012-07-02
13:57:57 UTC (rev 4216)
+++ trunk/runtime/src/main/java/org/teiid/transport/SocketClientInstance.java 2012-07-02
14:12:21 UTC (rev 4217)
@@ -75,10 +75,10 @@
}
public void send(Message message, Serializable messageKey) {
+ message.setMessageKey(messageKey);
if (LogManager.isMessageToBeRecorded(LogConstants.CTX_TRANSPORT,
MessageLevel.DETAIL)) {
- LogManager.logDetail(LogConstants.CTX_TRANSPORT, " message: " +
message + " for message:" + messageKey); //$NON-NLS-1$ //$NON-NLS-2$
+ LogManager.logDetail(LogConstants.CTX_TRANSPORT, "send message: " +
message); //$NON-NLS-1$
}
- message.setMessageKey(messageKey);
objectSocket.write(message);
}
Show replies by thread