[JBoss JIRA] (TEIID-4238) Remove need for quotes around cursor name declarations/fetches
by Marc Shirley (JIRA)
[ https://issues.jboss.org/browse/TEIID-4238?page=com.atlassian.jira.plugin... ]
Marc Shirley commented on TEIID-4238:
-------------------------------------
This appears to be working towards supporting existing custom clients which do not currently quote cursor names.
> Remove need for quotes around cursor name declarations/fetches
> --------------------------------------------------------------
>
> Key: TEIID-4238
> URL: https://issues.jboss.org/browse/TEIID-4238
> Project: Teiid
> Issue Type: Bug
> Reporter: Marc Shirley
> Assignee: Steven Hawkins
>
> Attempting to declare a cursor without quotes results in an error similar to[1]. The quotes should be optional except in special cases, as this seems to match later standards (SQL2003). Performing fetch operations against the cursor have the same issue, where if the cursorname is not quoted, parsing errors occur.
> [1] Caused by: org.teiid.api.exception.query.QueryParserException: TEIID31100 Parsing error: Encountered "[*]DECLARE[*] cursorname CURSOR" at line 1, column 1.
> Was expecting: "alter" | "begin" | "call" | "create" | "delete" | "drop" | "exec" | "execute" | "insert" | "merge" ...
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
8 years, 6 months
[JBoss JIRA] (TEIID-4238) Remove need for quotes around cursor name declarations/fetches
by Steven Hawkins (JIRA)
[ https://issues.jboss.org/browse/TEIID-4238?page=com.atlassian.jira.plugin... ]
Steven Hawkins commented on TEIID-4238:
---------------------------------------
> The quotes should be optional
That is correct, but this is not a but in that the current code is based upon the pg odbc client, which always quotes. Is this to support a different client or just a general request?
> Remove need for quotes around cursor name declarations/fetches
> --------------------------------------------------------------
>
> Key: TEIID-4238
> URL: https://issues.jboss.org/browse/TEIID-4238
> Project: Teiid
> Issue Type: Bug
> Reporter: Marc Shirley
> Assignee: Steven Hawkins
>
> Attempting to declare a cursor without quotes results in an error similar to[1]. The quotes should be optional except in special cases, as this seems to match later standards (SQL2003). Performing fetch operations against the cursor have the same issue, where if the cursorname is not quoted, parsing errors occur.
> [1] Caused by: org.teiid.api.exception.query.QueryParserException: TEIID31100 Parsing error: Encountered "[*]DECLARE[*] cursorname CURSOR" at line 1, column 1.
> Was expecting: "alter" | "begin" | "call" | "create" | "delete" | "drop" | "exec" | "execute" | "insert" | "merge" ...
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
8 years, 6 months
[JBoss JIRA] (TEIID-4238) Remove need for quotes around cursor name declarations/fetches
by Marc Shirley (JIRA)
Marc Shirley created TEIID-4238:
-----------------------------------
Summary: Remove need for quotes around cursor name declarations/fetches
Key: TEIID-4238
URL: https://issues.jboss.org/browse/TEIID-4238
Project: Teiid
Issue Type: Bug
Reporter: Marc Shirley
Assignee: Steven Hawkins
Attempting to declare a cursor without quotes results in an error similar to[1]. The quotes should be optional except in special cases, as this seems to match later standards (SQL2003). Performing fetch operations against the cursor have the same issue, where if the cursorname is not quoted, parsing errors occur.
[1] Caused by: org.teiid.api.exception.query.QueryParserException: TEIID31100 Parsing error: Encountered "[*]DECLARE[*] cursorname CURSOR" at line 1, column 1.
Was expecting: "alter" | "begin" | "call" | "create" | "delete" | "drop" | "exec" | "execute" | "insert" | "merge" ...
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
8 years, 6 months
[JBoss JIRA] (TEIID-4237) INNER JOIN returns incorrect results
by RH Bugzilla Integration (JIRA)
[ https://issues.jboss.org/browse/TEIID-4237?page=com.atlassian.jira.plugin... ]
RH Bugzilla Integration updated TEIID-4237:
-------------------------------------------
Bugzilla References: https://bugzilla.redhat.com/show_bug.cgi?id=1341763
Bugzilla Update: Perform
> INNER JOIN returns incorrect results
> ------------------------------------
>
> Key: TEIID-4237
> URL: https://issues.jboss.org/browse/TEIID-4237
> Project: Teiid
> Issue Type: Bug
> Components: Query Engine
> Affects Versions: 8.12
> Environment: teiid-8.12-Beta1 on Red Hat JBoss Enterprise Application Platform - Version 6.3.0.GA
> Reporter: dalex dalex
> Assignee: Steven Hawkins
> Priority: Blocker
> Fix For: 9.0, 8.13.5
>
>
> Running the following query:
> {code:sql}
> select avg(t1.a) from
> (select 3 as a, 3 as b union all
> select 1 as a, 1 as b union all
> select 3 as a, 3 as b) as t1
> join (select 1 as a, 1 as b union all
> select 1 as a, 1 as b union all
> select 2 as a, 2 as b union all
> select 2 as a, 2 as b union all
> select 3 as a, 3 as b union all
> select 3 as a, 3 as b) as t2 on t1.a=t2.a
> {code}
> on teiid causes incorrect result: 2 in comparing with mysql which returns 2.333.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
8 years, 6 months
[JBoss JIRA] (TEIID-4237) INNER JOIN returns incorrect results
by dalex dalex (JIRA)
[ https://issues.jboss.org/browse/TEIID-4237?page=com.atlassian.jira.plugin... ]
dalex dalex edited comment on TEIID-4237 at 6/1/16 1:19 PM:
------------------------------------------------------------
[~shawkins] Cool! Thanks for the quick fix.
was (Author: dalex005):
Cool! Thanks for the quick fix.
> INNER JOIN returns incorrect results
> ------------------------------------
>
> Key: TEIID-4237
> URL: https://issues.jboss.org/browse/TEIID-4237
> Project: Teiid
> Issue Type: Bug
> Components: Query Engine
> Affects Versions: 8.12
> Environment: teiid-8.12-Beta1 on Red Hat JBoss Enterprise Application Platform - Version 6.3.0.GA
> Reporter: dalex dalex
> Assignee: Steven Hawkins
> Priority: Blocker
> Fix For: 9.0, 8.13.5
>
>
> Running the following query:
> {code:sql}
> select avg(t1.a) from
> (select 3 as a, 3 as b union all
> select 1 as a, 1 as b union all
> select 3 as a, 3 as b) as t1
> join (select 1 as a, 1 as b union all
> select 1 as a, 1 as b union all
> select 2 as a, 2 as b union all
> select 2 as a, 2 as b union all
> select 3 as a, 3 as b union all
> select 3 as a, 3 as b) as t2 on t1.a=t2.a
> {code}
> on teiid causes incorrect result: 2 in comparing with mysql which returns 2.333.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
8 years, 6 months
[JBoss JIRA] (TEIID-4237) INNER JOIN returns incorrect results
by dalex dalex (JIRA)
[ https://issues.jboss.org/browse/TEIID-4237?page=com.atlassian.jira.plugin... ]
dalex dalex commented on TEIID-4237:
------------------------------------
Cool! Thanks for the quick fix.
> INNER JOIN returns incorrect results
> ------------------------------------
>
> Key: TEIID-4237
> URL: https://issues.jboss.org/browse/TEIID-4237
> Project: Teiid
> Issue Type: Bug
> Components: Query Engine
> Affects Versions: 8.12
> Environment: teiid-8.12-Beta1 on Red Hat JBoss Enterprise Application Platform - Version 6.3.0.GA
> Reporter: dalex dalex
> Assignee: Steven Hawkins
> Priority: Blocker
> Fix For: 9.0, 8.13.5
>
>
> Running the following query:
> {code:sql}
> select avg(t1.a) from
> (select 3 as a, 3 as b union all
> select 1 as a, 1 as b union all
> select 3 as a, 3 as b) as t1
> join (select 1 as a, 1 as b union all
> select 1 as a, 1 as b union all
> select 2 as a, 2 as b union all
> select 2 as a, 2 as b union all
> select 3 as a, 3 as b union all
> select 3 as a, 3 as b) as t2 on t1.a=t2.a
> {code}
> on teiid causes incorrect result: 2 in comparing with mysql which returns 2.333.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
8 years, 6 months
[JBoss JIRA] (TEIID-4237) INNER JOIN returns incorrect results
by Steven Hawkins (JIRA)
[ https://issues.jboss.org/browse/TEIID-4237?page=com.atlassian.jira.plugin... ]
Steven Hawkins resolved TEIID-4237.
-----------------------------------
Fix Version/s: 9.0
8.13.5
Resolution: Done
Thanks for finding this. There was an errant check that the left hand side represented distinct values. This will be in 9.0 final as well as 8.13.5.
> INNER JOIN returns incorrect results
> ------------------------------------
>
> Key: TEIID-4237
> URL: https://issues.jboss.org/browse/TEIID-4237
> Project: Teiid
> Issue Type: Bug
> Components: Query Engine
> Affects Versions: 8.12
> Environment: teiid-8.12-Beta1 on Red Hat JBoss Enterprise Application Platform - Version 6.3.0.GA
> Reporter: dalex dalex
> Assignee: Steven Hawkins
> Priority: Blocker
> Fix For: 9.0, 8.13.5
>
>
> Running the following query:
> {code:sql}
> select avg(t1.a) from
> (select 3 as a, 3 as b union all
> select 1 as a, 1 as b union all
> select 3 as a, 3 as b) as t1
> join (select 1 as a, 1 as b union all
> select 1 as a, 1 as b union all
> select 2 as a, 2 as b union all
> select 2 as a, 2 as b union all
> select 3 as a, 3 as b union all
> select 3 as a, 3 as b) as t2 on t1.a=t2.a
> {code}
> on teiid causes incorrect result: 2 in comparing with mysql which returns 2.333.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
8 years, 6 months
[JBoss JIRA] (TEIID-4237) INNER JOIN returns incorrect results
by dalex dalex (JIRA)
[ https://issues.jboss.org/browse/TEIID-4237?page=com.atlassian.jira.plugin... ]
dalex dalex updated TEIID-4237:
-------------------------------
Steps to Reproduce:
Run the following query on teiid and mysql:
{code:sql}
select avg(t1.a) from
(select 3 as a, 3 as b union all
select 1 as a, 1 as b union all
select 3 as a, 3 as b) as t1
join (select 1 as a, 1 as b union all
select 1 as a, 1 as b union all
select 2 as a, 2 as b union all
select 2 as a, 2 as b union all
select 3 as a, 3 as b union all
select 3 as a, 3 as b) as t2 on t1.a=t2.a
{code}
and compare gotten results.
was:
Run the following query:
{code:sql}
select avg(t1.a) from
(select 3 as a, 3 as b union all
select 1 as a, 1 as b union all
select 3 as a, 3 as b) as t1
join (select 1 as a, 1 as b union all
select 1 as a, 1 as b union all
select 2 as a, 2 as b union all
select 2 as a, 2 as b union all
select 3 as a, 3 as b union all
select 3 as a, 3 as b) as t2 on t1.a=t2.a
{code}
on teiid and mysql and compare gotten results.
> INNER JOIN returns incorrect results
> ------------------------------------
>
> Key: TEIID-4237
> URL: https://issues.jboss.org/browse/TEIID-4237
> Project: Teiid
> Issue Type: Bug
> Components: Query Engine
> Affects Versions: 8.12
> Environment: teiid-8.12-Beta1 on Red Hat JBoss Enterprise Application Platform - Version 6.3.0.GA
> Reporter: dalex dalex
> Assignee: Steven Hawkins
> Priority: Blocker
>
> Running the following query:
> {code:sql}
> select avg(t1.a) from
> (select 3 as a, 3 as b union all
> select 1 as a, 1 as b union all
> select 3 as a, 3 as b) as t1
> join (select 1 as a, 1 as b union all
> select 1 as a, 1 as b union all
> select 2 as a, 2 as b union all
> select 2 as a, 2 as b union all
> select 3 as a, 3 as b union all
> select 3 as a, 3 as b) as t2 on t1.a=t2.a
> {code}
> on teiid causes incorrect result: 2 in comparing with mysql which returns 2.333.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
8 years, 6 months
[JBoss JIRA] (TEIID-4237) INNER JOIN returns incorrect results
by dalex dalex (JIRA)
dalex dalex created TEIID-4237:
----------------------------------
Summary: INNER JOIN returns incorrect results
Key: TEIID-4237
URL: https://issues.jboss.org/browse/TEIID-4237
Project: Teiid
Issue Type: Bug
Components: Query Engine
Affects Versions: 8.12
Environment: teiid-8.12-Beta1 on Red Hat JBoss Enterprise Application Platform - Version 6.3.0.GA
Reporter: dalex dalex
Assignee: Steven Hawkins
Priority: Blocker
Running the following query:
{code:sql}
select avg(t1.a) from
(select 3 as a, 3 as b union all
select 1 as a, 1 as b union all
select 3 as a, 3 as b) as t1
join (select 1 as a, 1 as b union all
select 1 as a, 1 as b union all
select 2 as a, 2 as b union all
select 2 as a, 2 as b union all
select 3 as a, 3 as b union all
select 3 as a, 3 as b) as t2 on t1.a=t2.a
{code}
on teiid causes incorrect result: 2 in comparing with mysql which returns 2.333.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
8 years, 6 months
[JBoss JIRA] (TEIID-3999) more aspects of materialization metadata should be validated
by Steven Hawkins (JIRA)
[ https://issues.jboss.org/browse/TEIID-3999?page=com.atlassian.jira.plugin... ]
Steven Hawkins commented on TEIID-3999:
---------------------------------------
> How to validate?
For updatablity there's a flag on the table Table.supportsUpdate()
> is there any good ways to validate the load scripts
We can try to parse / resolve / validate the statement - for commands that are mostly embedded in a native procedure call there's not much for us to validate, but it would ensure that the overall command is valid.
> more aspects of materialization metadata should be validated
> ------------------------------------------------------------
>
> Key: TEIID-3999
> URL: https://issues.jboss.org/browse/TEIID-3999
> Project: Teiid
> Issue Type: Quality Risk
> Components: Query Engine
> Reporter: Steven Hawkins
> Assignee: Kylin Soong
> Priority: Minor
> Fix For: 9.0
>
>
> * During metadata load we should check if the status table and the materialization scripts are valid, so there is at least a log of the issue rather than waiting for the exception to occur once the vdb is active.
> * According to TEIID-4203, add an initial validation that validate the status table definition matches the expectation.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
8 years, 6 months