[JBoss JIRA] (TEIID-3999) more aspects of materialization metadata should be validated
by Steven Hawkins (JIRA)
[ https://issues.jboss.org/browse/TEIID-3999?page=com.atlassian.jira.plugin... ]
Steven Hawkins commented on TEIID-3999:
---------------------------------------
I think we should alter our handling of the semi-colon delimited scripts - the tokenizing logic we use won't tolerate having a semi-colon in the actual query. We can either account for an escape mechanism or recommend using an anonymous procedure block for multiple statements.
> more aspects of materialization metadata should be validated
> ------------------------------------------------------------
>
> Key: TEIID-3999
> URL: https://issues.jboss.org/browse/TEIID-3999
> Project: Teiid
> Issue Type: Quality Risk
> Components: Query Engine
> Reporter: Steven Hawkins
> Assignee: Kylin Soong
> Priority: Minor
> Fix For: 9.0
>
>
> * During metadata load we should check if the status table and the materialization scripts are valid, so there is at least a log of the issue rather than waiting for the exception to occur once the vdb is active.
> * According to TEIID-4203, add an initial validation that validate the status table definition matches the expectation.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
8 years, 9 months
[JBoss JIRA] (TEIID-3999) more aspects of materialization metadata should be validated
by Kylin Soong (JIRA)
[ https://issues.jboss.org/browse/TEIID-3999?page=com.atlassian.jira.plugin... ]
Kylin Soong commented on TEIID-3999:
------------------------------------
I have add parse / resolve / validate for validating load scripts, so far tables, scripts all will be validate, we may leave the further validation in future once a user requested.
> more aspects of materialization metadata should be validated
> ------------------------------------------------------------
>
> Key: TEIID-3999
> URL: https://issues.jboss.org/browse/TEIID-3999
> Project: Teiid
> Issue Type: Quality Risk
> Components: Query Engine
> Reporter: Steven Hawkins
> Assignee: Kylin Soong
> Priority: Minor
> Fix For: 9.0
>
>
> * During metadata load we should check if the status table and the materialization scripts are valid, so there is at least a log of the issue rather than waiting for the exception to occur once the vdb is active.
> * According to TEIID-4203, add an initial validation that validate the status table definition matches the expectation.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
8 years, 9 months
[JBoss JIRA] (TEIID-4235) dynamic sql recursion check not valid after caught exception
by Steven Hawkins (JIRA)
[ https://issues.jboss.org/browse/TEIID-4235?page=com.atlassian.jira.plugin... ]
Steven Hawkins updated TEIID-4235:
----------------------------------
Fix Version/s: 8.12.5
> dynamic sql recursion check not valid after caught exception
> ------------------------------------------------------------
>
> Key: TEIID-4235
> URL: https://issues.jboss.org/browse/TEIID-4235
> Project: Teiid
> Issue Type: Bug
> Components: Query Engine
> Affects Versions: 8.7
> Reporter: Steven Hawkins
> Assignee: Steven Hawkins
> Fix For: 9.0, 8.12.5, 8.13.5
>
>
> With a procedure like:
> begin
> execute immediate
> exception e
> ...
> execute immediate ...
> An exception on the second execute immediate will be seen like:
> org.teiid.api.exception.query.QueryProcessingException: TEIID30168 Couldn't execute the dynamic SQL command "EXECUTE IMMEDIATE ..." due to: TEIID30347 There is a recursive invocation of group 'proc'. Please correct the SQL.
> Even when the dynamic sql does not re-invoke the proc. The issue is that when catching the initial exception thrown doesn't clear the entry from the recursion stack.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
8 years, 9 months
[JBoss JIRA] (TEIID-4237) INNER JOIN returns incorrect results
by Steven Hawkins (JIRA)
[ https://issues.jboss.org/browse/TEIID-4237?page=com.atlassian.jira.plugin... ]
Steven Hawkins updated TEIID-4237:
----------------------------------
Fix Version/s: 8.12.5
> INNER JOIN returns incorrect results
> ------------------------------------
>
> Key: TEIID-4237
> URL: https://issues.jboss.org/browse/TEIID-4237
> Project: Teiid
> Issue Type: Bug
> Components: Query Engine
> Affects Versions: 8.12
> Environment: teiid-8.12-Beta1 on Red Hat JBoss Enterprise Application Platform - Version 6.3.0.GA
> Reporter: dalex dalex
> Assignee: Steven Hawkins
> Priority: Blocker
> Fix For: 9.0, 8.12.5, 8.13.5
>
>
> Running the following query:
> {code:sql}
> select avg(t1.a) from
> (select 3 as a, 3 as b union all
> select 1 as a, 1 as b union all
> select 3 as a, 3 as b) as t1
> join (select 1 as a, 1 as b union all
> select 1 as a, 1 as b union all
> select 2 as a, 2 as b union all
> select 2 as a, 2 as b union all
> select 3 as a, 3 as b union all
> select 3 as a, 3 as b) as t2 on t1.a=t2.a
> {code}
> on teiid causes incorrect result: 2 in comparing with mysql which returns 2.333.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
8 years, 9 months
[JBoss JIRA] (TEIID-4238) Remove need for quotes around cursor name declarations/fetches
by Steven Hawkins (JIRA)
[ https://issues.jboss.org/browse/TEIID-4238?page=com.atlassian.jira.plugin... ]
Steven Hawkins edited comment on TEIID-4238 at 6/1/16 3:01 PM:
---------------------------------------------------------------
> The quotes should be optional
That is correct, but this is not a bug in that the current code is based upon the pg odbc client, which always quotes. Is this to support a different client or just a general request?
was (Author: shawkins):
> The quotes should be optional
That is correct, but this is not a but in that the current code is based upon the pg odbc client, which always quotes. Is this to support a different client or just a general request?
> Remove need for quotes around cursor name declarations/fetches
> --------------------------------------------------------------
>
> Key: TEIID-4238
> URL: https://issues.jboss.org/browse/TEIID-4238
> Project: Teiid
> Issue Type: Enhancement
> Components: ODBC
> Reporter: Marc Shirley
> Assignee: Steven Hawkins
> Fix For: 9.1
>
>
> Attempting to declare a cursor without quotes results in an error similar to[1]. The quotes should be optional except in special cases, as this seems to match later standards (SQL2003). Performing fetch operations against the cursor have the same issue, where if the cursorname is not quoted, parsing errors occur.
> [1] Caused by: org.teiid.api.exception.query.QueryParserException: TEIID31100 Parsing error: Encountered "[*]DECLARE[*] cursorname CURSOR" at line 1, column 1.
> Was expecting: "alter" | "begin" | "call" | "create" | "delete" | "drop" | "exec" | "execute" | "insert" | "merge" ...
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
8 years, 9 months
[JBoss JIRA] (TEIID-4238) Remove need for quotes around cursor name declarations/fetches
by Steven Hawkins (JIRA)
[ https://issues.jboss.org/browse/TEIID-4238?page=com.atlassian.jira.plugin... ]
Steven Hawkins updated TEIID-4238:
----------------------------------
Issue Type: Enhancement (was: Bug)
Component/s: ODBC
Fix Version/s: 9.1
Workaround Description: Use a quoted cursor name.
Workaround: Workaround Exists
> Remove need for quotes around cursor name declarations/fetches
> --------------------------------------------------------------
>
> Key: TEIID-4238
> URL: https://issues.jboss.org/browse/TEIID-4238
> Project: Teiid
> Issue Type: Enhancement
> Components: ODBC
> Reporter: Marc Shirley
> Assignee: Steven Hawkins
> Fix For: 9.1
>
>
> Attempting to declare a cursor without quotes results in an error similar to[1]. The quotes should be optional except in special cases, as this seems to match later standards (SQL2003). Performing fetch operations against the cursor have the same issue, where if the cursorname is not quoted, parsing errors occur.
> [1] Caused by: org.teiid.api.exception.query.QueryParserException: TEIID31100 Parsing error: Encountered "[*]DECLARE[*] cursorname CURSOR" at line 1, column 1.
> Was expecting: "alter" | "begin" | "call" | "create" | "delete" | "drop" | "exec" | "execute" | "insert" | "merge" ...
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
8 years, 9 months