[JBoss JIRA] (TEIID-5887) Issues with marhaller registration
by Steven Hawkins (Jira)
[ https://issues.redhat.com/browse/TEIID-5887?page=com.atlassian.jira.plugi... ]
Steven Hawkins resolved TEIID-5887.
-----------------------------------
Resolution: Done
Changed the marshalling logic so that it can be done lazily.
> Issues with marhaller registration
> ----------------------------------
>
> Key: TEIID-5887
> URL: https://issues.redhat.com/browse/TEIID-5887
> Project: Teiid
> Issue Type: Bug
> Components: Infinispan
> Reporter: Steven Hawkins
> Assignee: Steven Hawkins
> Priority: Major
> Fix For: 13.1
>
> Original Estimate: 6 hours
> Time Spent: 7 hours
> Remaining Estimate: 0 minutes
>
> Adding transactional logic to infinispan highlights several problems with marshaller registration. The first is that all connections are working off of a shared context and each registering a marshaller for the same class type - this is not thread safe.
> The other issue specific to transactions is that some operations are delayed or redone at commit time - which is called after the connection is closed potentially in a different thread and thus the marshaller provider has been removed. Given the interplay of threads using a thread local won't work.
> Potentially a transaction aware thread pool or the use of something like our execution context keep alive may be needed.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
4 years, 11 months
[JBoss JIRA] (TEIID-5887) Issues with marhaller registration
by Steven Hawkins (Jira)
[ https://issues.redhat.com/browse/TEIID-5887?focusedWorklogId=12449970&pag... ]
Steven Hawkins logged work on TEIID-5887:
-----------------------------------------
Author: Steven Hawkins
Created on: 27/Jan/20 2:27 PM
Start Date: 27/Jan/20 2:27 PM
Worklog Time Spent: 7 hours
Issue Time Tracking
-------------------
Remaining Estimate: 0 minutes (was: 6 hours)
Time Spent: 7 hours
Worklog Id: (was: 12449970)
> Issues with marhaller registration
> ----------------------------------
>
> Key: TEIID-5887
> URL: https://issues.redhat.com/browse/TEIID-5887
> Project: Teiid
> Issue Type: Bug
> Components: Infinispan
> Reporter: Steven Hawkins
> Assignee: Steven Hawkins
> Priority: Major
> Fix For: 13.1
>
> Original Estimate: 6 hours
> Time Spent: 7 hours
> Remaining Estimate: 0 minutes
>
> Adding transactional logic to infinispan highlights several problems with marshaller registration. The first is that all connections are working off of a shared context and each registering a marshaller for the same class type - this is not thread safe.
> The other issue specific to transactions is that some operations are delayed or redone at commit time - which is called after the connection is closed potentially in a different thread and thus the marshaller provider has been removed. Given the interplay of threads using a thread local won't work.
> Potentially a transaction aware thread pool or the use of something like our execution context keep alive may be needed.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
4 years, 11 months
[JBoss JIRA] (TEIID-5888) Infinispan translator returns wrong update count in some circumstances
by Steven Hawkins (Jira)
[ https://issues.redhat.com/browse/TEIID-5888?page=com.atlassian.jira.plugi... ]
Steven Hawkins commented on TEIID-5888:
---------------------------------------
There are issues with nested select scenarios as well. There was a bit of the filter logic not hit by the existing tests. A query such as:
SELECT g2.e1, g4.e1, g4.e2 FROM G2 g2 JOIN G4 g4 ON g2.e1 = g4.G2_e1 WHERE g4.e2 = 'two'
returns no results, when one is expected.
> Infinispan translator returns wrong update count in some circumstances
> ----------------------------------------------------------------------
>
> Key: TEIID-5888
> URL: https://issues.redhat.com/browse/TEIID-5888
> Project: Teiid
> Issue Type: Bug
> Components: Infinispan
> Reporter: Steven Hawkins
> Assignee: Ramesh Reddy
> Priority: Major
> Fix For: 13.1
>
>
> In some nested circumstances the wrong update count is returned. For example in TestHodrodExecution the update:
> UPDATE G4 SET e2 = 'two-2' WHERE e2 = 'two-two' OR e2 = 'one-one'
> should return 2, but instead returns 4. This happens both prior to and after the changes for TEIID-5887.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
4 years, 11 months
[JBoss JIRA] (TEIID-5888) Infinispan translator returns wrong update count in some circumstances
by Steven Hawkins (Jira)
Steven Hawkins created TEIID-5888:
-------------------------------------
Summary: Infinispan translator returns wrong update count in some circumstances
Key: TEIID-5888
URL: https://issues.redhat.com/browse/TEIID-5888
Project: Teiid
Issue Type: Bug
Components: Infinispan
Reporter: Steven Hawkins
Assignee: Ramesh Reddy
Fix For: 13.1
In some nested circumstances the wrong update count is returned. For example in TestHodrodExecution the update:
UPDATE G4 SET e2 = 'two-2' WHERE e2 = 'two-two' OR e2 = 'one-one'
should return 2, but instead returns 4. This happens both prior to and after the changes for TEIID-5887.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
4 years, 11 months
[JBoss JIRA] (TEIID-5886) parser does not allow non-reserved word as identifier for domain type name
by Steven Hawkins (Jira)
[ https://issues.redhat.com/browse/TEIID-5886?focusedWorklogId=12449965&pag... ]
Steven Hawkins logged work on TEIID-5886:
-----------------------------------------
Author: Steven Hawkins
Created on: 27/Jan/20 10:43 AM
Start Date: 27/Jan/20 10:43 AM
Worklog Time Spent: 3 hours
Issue Time Tracking
-------------------
Remaining Estimate: 1 hour (was: 4 hours)
Time Spent: 3 hours
Worklog Id: (was: 12449965)
> parser does not allow non-reserved word as identifier for domain type name
> --------------------------------------------------------------------------
>
> Key: TEIID-5886
> URL: https://issues.redhat.com/browse/TEIID-5886
> Project: Teiid
> Issue Type: Bug
> Components: Grammar
> Affects Versions: 13.0.1
> Reporter: Ken Geis
> Assignee: Steven Hawkins
> Priority: Major
> Fix For: 13.1, 13.0.2
>
> Original Estimate: 4 hours
> Time Spent: 3 hours
> Remaining Estimate: 1 hour
>
> I am trying to upgrade from 12.2.1 to 13.0.1. have a VDB where I aliased VARCHAR as TEXT (a non-reserved keyword, according to the docs) in order to improve PostgreSQL compatibility. The VDB works on 12.2.1 and fails to load on 13.0.1.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
4 years, 11 months
[JBoss JIRA] (TEIID-5886) parser does not allow non-reserved word as identifier for domain type name
by Steven Hawkins (Jira)
[ https://issues.redhat.com/browse/TEIID-5886?page=com.atlassian.jira.plugi... ]
Steven Hawkins resolved TEIID-5886.
-----------------------------------
Resolution: Done
Split the non reserved words so that most are eligible for domain names. Those that are still ineligible are: EXCEPTION, SERIAL, OBJECT, INDEX, JSON, GEOMETRY, GEOGRAPHY, DEFAULT
> parser does not allow non-reserved word as identifier for domain type name
> --------------------------------------------------------------------------
>
> Key: TEIID-5886
> URL: https://issues.redhat.com/browse/TEIID-5886
> Project: Teiid
> Issue Type: Bug
> Components: Grammar
> Affects Versions: 13.0.1
> Reporter: Ken Geis
> Assignee: Steven Hawkins
> Priority: Major
> Fix For: 13.1, 13.0.2
>
> Original Estimate: 4 hours
> Remaining Estimate: 4 hours
>
> I am trying to upgrade from 12.2.1 to 13.0.1. have a VDB where I aliased VARCHAR as TEXT (a non-reserved keyword, according to the docs) in order to improve PostgreSQL compatibility. The VDB works on 12.2.1 and fails to load on 13.0.1.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
4 years, 11 months
[JBoss JIRA] (TEIID-5887) Issues with marhaller registration
by Steven Hawkins (Jira)
[ https://issues.redhat.com/browse/TEIID-5887?page=com.atlassian.jira.plugi... ]
Work on TEIID-5887 started by Steven Hawkins.
---------------------------------------------
> Issues with marhaller registration
> ----------------------------------
>
> Key: TEIID-5887
> URL: https://issues.redhat.com/browse/TEIID-5887
> Project: Teiid
> Issue Type: Bug
> Components: Infinispan
> Reporter: Steven Hawkins
> Assignee: Steven Hawkins
> Priority: Major
> Fix For: 13.1
>
> Original Estimate: 6 hours
> Remaining Estimate: 6 hours
>
> Adding transactional logic to infinispan highlights several problems with marshaller registration. The first is that all connections are working off of a shared context and each registering a marshaller for the same class type - this is not thread safe.
> The other issue specific to transactions is that some operations are delayed or redone at commit time - which is called after the connection is closed potentially in a different thread and thus the marshaller provider has been removed. Given the interplay of threads using a thread local won't work.
> Potentially a transaction aware thread pool or the use of something like our execution context keep alive may be needed.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
4 years, 11 months