[JBoss JIRA] (TEIID-5886) parser does not allow non-reserved word as identifier for domain type name
by Steven Hawkins (Jira)
[ https://issues.redhat.com/browse/TEIID-5886?page=com.atlassian.jira.plugi... ]
Steven Hawkins updated TEIID-5886:
----------------------------------
Fix Version/s: 13.1
13.0.2
Original Estimate: 4 hours
Remaining Estimate: 4 hours
Story Points: 0.5
Sprint: DV Sprint 58
> parser does not allow non-reserved word as identifier for domain type name
> --------------------------------------------------------------------------
>
> Key: TEIID-5886
> URL: https://issues.redhat.com/browse/TEIID-5886
> Project: Teiid
> Issue Type: Bug
> Components: Grammar
> Affects Versions: 13.0.1
> Reporter: Ken Geis
> Assignee: Steven Hawkins
> Priority: Major
> Fix For: 13.1, 13.0.2
>
> Original Estimate: 4 hours
> Remaining Estimate: 4 hours
>
> I am trying to upgrade from 12.2.1 to 13.0.1. have a VDB where I aliased VARCHAR as TEXT (a non-reserved keyword, according to the docs) in order to improve PostgreSQL compatibility. The VDB works on 12.2.1 and fails to load on 13.0.1.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
4 years, 11 months
[JBoss JIRA] (TEIID-5887) Issues with marhaller registration
by Ramesh Reddy (Jira)
[ https://issues.redhat.com/browse/TEIID-5887?page=com.atlassian.jira.plugi... ]
Ramesh Reddy commented on TEIID-5887:
-------------------------------------
Looks good. We can make a request for Object level marshaling, but the initial one also took some time after I did above then a couple versions later they came with their own api.
> Issues with marhaller registration
> ----------------------------------
>
> Key: TEIID-5887
> URL: https://issues.redhat.com/browse/TEIID-5887
> Project: Teiid
> Issue Type: Bug
> Components: Infinispan
> Reporter: Steven Hawkins
> Priority: Major
> Fix For: 13.1
>
> Original Estimate: 6 hours
> Remaining Estimate: 6 hours
>
> Adding transactional logic to infinispan highlights several problems with marshaller registration. The first is that all connections are working off of a shared context and each registering a marshaller for the same class type - this is not thread safe.
> The other issue specific to transactions is that some operations are delayed or redone at commit time - which is called after the connection is closed potentially in a different thread and thus the marshaller provider has been removed. Given the interplay of threads using a thread local won't work.
> Potentially a transaction aware thread pool or the use of something like our execution context keep alive may be needed.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
4 years, 11 months
[JBoss JIRA] (TEIID-5887) Issues with marhaller registration
by Steven Hawkins (Jira)
[ https://issues.redhat.com/browse/TEIID-5887?page=com.atlassian.jira.plugi... ]
Steven Hawkins commented on TEIID-5887:
---------------------------------------
@rareddy Here's the WIP: https://github.com/teiid/teiid/compare/master...shawkins:TEIID-5887?expand=1
The strategy here is to create marshallers that don't need to be unregistered. For now I'm assuming a one to one relationship between a resource adapter and the translator and that the source table schemas aren't modifiable - changing those assumptions would mean changing the simplistic caching strategy. I'll need to have more test cases, but the basic idea is that our marshalling provider can have everything registered and we just need a little help when asked to find by class. It would be great if there were another method on their marshalling provider that asked by object.
>From there the effects of the filter are being moved to post serialization logic. I have that stubbed, but not wired in yet.
> Issues with marhaller registration
> ----------------------------------
>
> Key: TEIID-5887
> URL: https://issues.redhat.com/browse/TEIID-5887
> Project: Teiid
> Issue Type: Bug
> Components: Infinispan
> Reporter: Steven Hawkins
> Priority: Major
> Fix For: 13.1
>
> Original Estimate: 6 hours
> Remaining Estimate: 6 hours
>
> Adding transactional logic to infinispan highlights several problems with marshaller registration. The first is that all connections are working off of a shared context and each registering a marshaller for the same class type - this is not thread safe.
> The other issue specific to transactions is that some operations are delayed or redone at commit time - which is called after the connection is closed potentially in a different thread and thus the marshaller provider has been removed. Given the interplay of threads using a thread local won't work.
> Potentially a transaction aware thread pool or the use of something like our execution context keep alive may be needed.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
4 years, 11 months
[JBoss JIRA] (TEIID-5887) Issues with marhaller registration
by Steven Hawkins (Jira)
[ https://issues.redhat.com/browse/TEIID-5887?page=com.atlassian.jira.plugi... ]
Steven Hawkins moved TEIIDSB-164 to TEIID-5887:
-----------------------------------------------
Project: Teiid (was: Teiid Spring Boot)
Key: TEIID-5887 (was: TEIIDSB-164)
Component/s: Infinispan
(was: datasource)
Fix Version/s: 13.1
(was: 1.4.0)
(was: 1.3.1)
> Issues with marhaller registration
> ----------------------------------
>
> Key: TEIID-5887
> URL: https://issues.redhat.com/browse/TEIID-5887
> Project: Teiid
> Issue Type: Bug
> Components: Infinispan
> Reporter: Steven Hawkins
> Priority: Major
> Fix For: 13.1
>
> Original Estimate: 6 hours
> Remaining Estimate: 6 hours
>
> Adding transactional logic to infinispan highlights several problems with marshaller registration. The first is that all connections are working off of a shared context and each registering a marshaller for the same class type - this is not thread safe.
> The other issue specific to transactions is that some operations are delayed or redone at commit time - which is called after the connection is closed potentially in a different thread and thus the marshaller provider has been removed. Given the interplay of threads using a thread local won't work.
> Potentially a transaction aware thread pool or the use of something like our execution context keep alive may be needed.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
4 years, 11 months
[JBoss JIRA] (TEIIDSB-164) Issues with marhaller registration
by Steven Hawkins (Jira)
[ https://issues.redhat.com/browse/TEIIDSB-164?page=com.atlassian.jira.plug... ]
Steven Hawkins updated TEIIDSB-164:
-----------------------------------
Parent: (was: TEIIDSB-147)
Issue Type: Bug (was: Sub-task)
> Issues with marhaller registration
> ----------------------------------
>
> Key: TEIIDSB-164
> URL: https://issues.redhat.com/browse/TEIIDSB-164
> Project: Teiid Spring Boot
> Issue Type: Bug
> Components: datasource
> Reporter: Steven Hawkins
> Priority: Major
> Fix For: 13.1
>
> Original Estimate: 6 hours
> Remaining Estimate: 6 hours
>
> Adding transactional logic to infinispan highlights several problems with marshaller registration. The first is that all connections are working off of a shared context and each registering a marshaller for the same class type - this is not thread safe.
> The other issue specific to transactions is that some operations are delayed or redone at commit time - which is called after the connection is closed potentially in a different thread and thus the marshaller provider has been removed. Given the interplay of threads using a thread local won't work.
> Potentially a transaction aware thread pool or the use of something like our execution context keep alive may be needed.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
4 years, 11 months
[JBoss JIRA] (TEIID-5886) parser does not allow non-reserved word as identifier for domain type name
by Steven Hawkins (Jira)
[ https://issues.redhat.com/browse/TEIID-5886?page=com.atlassian.jira.plugi... ]
Steven Hawkins updated TEIID-5886:
----------------------------------
Summary: parser does not allow non-reserved word as identifier for domain type name (was: parser does not allow non-reserved word as identifier)
This was introduced with TEIID-5177 to align the parsing methods. The recent change was TEXT was introduced as non-reserved, which then made it ineligible as a domain type. I'll see if expanding domain type names to non-reserved will work.
> parser does not allow non-reserved word as identifier for domain type name
> --------------------------------------------------------------------------
>
> Key: TEIID-5886
> URL: https://issues.redhat.com/browse/TEIID-5886
> Project: Teiid
> Issue Type: Bug
> Components: Grammar
> Affects Versions: 13.0.1
> Reporter: Ken Geis
> Assignee: Steven Hawkins
> Priority: Major
>
> I am trying to upgrade from 12.2.1 to 13.0.1. have a VDB where I aliased VARCHAR as TEXT (a non-reserved keyword, according to the docs) in order to improve PostgreSQL compatibility. The VDB works on 12.2.1 and fails to load on 13.0.1.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
4 years, 11 months
[JBoss JIRA] (TEIID-5886) parser does not allow non-reserved word as identifier
by Ken Geis (Jira)
[ https://issues.redhat.com/browse/TEIID-5886?page=com.atlassian.jira.plugi... ]
Ken Geis updated TEIID-5886:
----------------------------
Description: I am trying to upgrade from 12.2.1 to 13.0.1. have a VDB where I aliased VARCHAR as TEXT (a non-reserved keyword, according to the docs) in order to improve PostgreSQL compatibility. The VDB works on 12.2.1 and fails to load on 13.0.1. (was: I am trying to upgrade from 12.3.1 to 13.0.1. have a VDB where I aliased VARCHAR as TEXT (a non-reserved keyword, according to the docs) in order to improve PostgreSQL compatibility. The VDB works on 12.3.1 and fails to load on 13.0.1.)
> parser does not allow non-reserved word as identifier
> -----------------------------------------------------
>
> Key: TEIID-5886
> URL: https://issues.redhat.com/browse/TEIID-5886
> Project: Teiid
> Issue Type: Bug
> Components: Grammar
> Affects Versions: 13.0.1
> Reporter: Ken Geis
> Assignee: Barry LaFond
> Priority: Major
>
> I am trying to upgrade from 12.2.1 to 13.0.1. have a VDB where I aliased VARCHAR as TEXT (a non-reserved keyword, according to the docs) in order to improve PostgreSQL compatibility. The VDB works on 12.2.1 and fails to load on 13.0.1.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
4 years, 11 months
[JBoss JIRA] (TEIID-5886) parser does not allow non-reserved word as identifier
by Ken Geis (Jira)
Ken Geis created TEIID-5886:
-------------------------------
Summary: parser does not allow non-reserved word as identifier
Key: TEIID-5886
URL: https://issues.redhat.com/browse/TEIID-5886
Project: Teiid
Issue Type: Bug
Components: Grammar
Affects Versions: 13.0.1
Reporter: Ken Geis
Assignee: Barry LaFond
I am trying to upgrade from 12.3.1 to 13.0.1. have a VDB where I aliased VARCHAR as TEXT (a non-reserved keyword, according to the docs) in order to improve PostgreSQL compatibility. The VDB works on 12.3.1 and fails to load on 13.0.1.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
4 years, 11 months
[JBoss JIRA] (TEIIDSB-155) Infinispan configuration should support a transactional cache
by Steven Hawkins (Jira)
[ https://issues.redhat.com/browse/TEIIDSB-155?page=com.atlassian.jira.plug... ]
Steven Hawkins updated TEIIDSB-155:
-----------------------------------
Fix Version/s: (was: 1.3.1)
> Infinispan configuration should support a transactional cache
> -------------------------------------------------------------
>
> Key: TEIIDSB-155
> URL: https://issues.redhat.com/browse/TEIIDSB-155
> Project: Teiid Spring Boot
> Issue Type: Enhancement
> Components: datasource
> Reporter: Steven Hawkins
> Assignee: Steven Hawkins
> Priority: Major
> Fix For: 1.4.0
>
> Original Estimate: 1 day, 4 hours
> Time Spent: 1 day, 4 hours
> Remaining Estimate: 0 minutes
>
> The configuration should allow for single phase commit and non-recoverable xa. This will need to change the transaction support on the translator, set the transaction config, and register a transactionManager lookup that can find the configured transaction manager.
> The infinispan operator does not provide a way to configure the transaction support of the cache, so this may not fully work yet - I'll test to see what happens both with the default cache and with trying to create one on demand.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
4 years, 11 months