[JBoss JIRA] (TEIID-2610) pg protocol issues
by Steven Hawkins (JIRA)
[ https://issues.jboss.org/browse/TEIID-2610?page=com.atlassian.jira.plugin... ]
Steven Hawkins edited comment on TEIID-2610 at 7/31/13 6:56 PM:
----------------------------------------------------------------
Other issues include:
- multiple portals can be opened against a single prepared statement at a time - which requires allowing the statement result to not be implicitly closed in our StatementImpl.
- possibly the wrong portal is being closed when the statement is closed
- max rows is being read incorrectly for the execute message and is not implemented correctly as max rows (it needs to be a forward only cursoring mechanism rather than just a limit)
- if multiple binds are issued against a single statement before an execute, the parameters are not associated correctly
Minor issues:
- the unnamed constant should be the empty string to not conflict with the actual name "UNNAMED"
- only the bind of the unnamed portal should remove the previous unnamed
- it's an error to reuse an explicitly named portal/statement if one already exists
- it's not an error to close a non-existent portal
We also need to consider adding transaction awareness so that portals are cleaned up as expected.
was (Author: shawkins):
Other issues include:
- multiple portals can be opened against a single prepared statement at a time - which requires allowing the statement result to not be implicitly closed in our StatementImpl.
- possibly the wrong portal is being closed when the statement is closed
Minor issues:
- the unnamed constant should be the empty string to not conflict with the actual name "UNNAMED"
- only the bind of the unnamed portal should remove the previous unnamed
- it's an error to reuse an explicitly named portal/statement if one already exists
- it's not an error to close a non-existent portal
We also need to consider adding transaction awareness so that portals are cleaned up as expected.
> pg protocol issues
> ------------------
>
> Key: TEIID-2610
> URL: https://issues.jboss.org/browse/TEIID-2610
> Project: Teiid
> Issue Type: Bug
> Components: ODBC
> Affects Versions: 7.7
> Reporter: Steven Hawkins
> Assignee: Steven Hawkins
> Priority: Critical
> Fix For: 8.4.1, 8.5
>
>
> The primary issue is that closing a portal is also closing the prepared plan, which is causing a protocol error.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
10 years, 11 months
[JBoss JIRA] (TEIID-2610) pg protocol issues
by Steven Hawkins (JIRA)
[ https://issues.jboss.org/browse/TEIID-2610?page=com.atlassian.jira.plugin... ]
Steven Hawkins commented on TEIID-2610:
---------------------------------------
Other issues include:
- multiple portals can be opened against a single prepared statement at a time - which requires allowing the statement result to not be implicitly closed in our StatementImpl.
- possibly the wrong portal is being closed when the statement is closed
Minor issues:
- the unnamed constant should be the empty string to not conflict with the actual name "UNNAMED"
- only the bind of the unnamed portal should remove the previous unnamed
- it's an error to reuse an explicitly named portal/statement if one already exists
- it's not an error to close a non-existent portal
We also need to consider adding transaction awareness so that portals are cleaned up as expected.
> pg protocol issues
> ------------------
>
> Key: TEIID-2610
> URL: https://issues.jboss.org/browse/TEIID-2610
> Project: Teiid
> Issue Type: Bug
> Components: ODBC
> Affects Versions: 7.7
> Reporter: Steven Hawkins
> Assignee: Steven Hawkins
> Priority: Critical
> Fix For: 8.4.1, 8.5
>
>
> The primary issue is that closing a portal is also closing the prepared plan, which is causing a protocol error.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
10 years, 11 months
[JBoss JIRA] (TEIID-2610) pg protocol issues
by Steven Hawkins (JIRA)
Steven Hawkins created TEIID-2610:
-------------------------------------
Summary: pg protocol issues
Key: TEIID-2610
URL: https://issues.jboss.org/browse/TEIID-2610
Project: Teiid
Issue Type: Bug
Components: ODBC
Affects Versions: 7.7
Reporter: Steven Hawkins
Assignee: Steven Hawkins
Priority: Critical
Fix For: 8.4.1, 8.5
The primary issue is that closing a portal is also closing the prepared plan, which is causing a protocol error.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
10 years, 11 months
[JBoss JIRA] (TEIID-2608) Increase pg odbc client compatibility
by Steven Hawkins (JIRA)
[ https://issues.jboss.org/browse/TEIID-2608?page=com.atlassian.jira.plugin... ]
Steven Hawkins commented on TEIID-2608:
---------------------------------------
Added support for the items in the description. The added column can change generated teiid ids, but that should not be considered a breaking change.
Cleaned up exception handling in CompletionListeners so that an unchecked exception is logged, but otherwise doesn't cause unexpected followup exceptions (such as attempting to send an error on ResultReceiver that has already sent its result).
A side issue that we have so far side stepped is that tools seem to expect to be able to use the table name as the alias name, which is problematic for names containing '.'. e.g. "vdb"."schema"."foo.bar" as "foo.bar" - is not allowed by Teiid. I don't know if we have a formal KI on this anywhere but the approach is generally to use unqualified teiid names during import. This may be an issue though at some point with name uniqueness, so we may have to offer an import option for "odbc safe" names that replace '.' with '_' in the Teiid name.
At some point we may also want to re-target some of the set handling to our session variable support, rather than just the client handling.
> Increase pg odbc client compatibility
> -------------------------------------
>
> Key: TEIID-2608
> URL: https://issues.jboss.org/browse/TEIID-2608
> Project: Teiid
> Issue Type: Quality Risk
> Components: ODBC
> Reporter: Steven Hawkins
> Assignee: Steven Hawkins
> Fix For: 8.5
>
>
> Using a 9.0 level odbc client we see errors with the following:
> set x TO y - since we don't expect TO
> 'foo'::regclass - which is shorthand for an oid lookup
> pg_index.indpred - is used by some metadata queries
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
10 years, 11 months
[JBoss JIRA] (TEIID-2602) Add clearer message that a VDB cannot be deployed without a JNDI name specified in the .vdb
by Steven Hawkins (JIRA)
[ https://issues.jboss.org/browse/TEIID-2602?page=com.atlassian.jira.plugin... ]
Steven Hawkins resolved TEIID-2602.
-----------------------------------
Fix Version/s: 8.4.1
8.5
Resolution: Done
Treating invalid jndi names (including "") as a non-hard error with a warning log that the specified name is invalid. For a loopback scenario this means that it will work regardless of what is given as the jndi name.
> Add clearer message that a VDB cannot be deployed without a JNDI name specified in the .vdb
> -------------------------------------------------------------------------------------------
>
> Key: TEIID-2602
> URL: https://issues.jboss.org/browse/TEIID-2602
> Project: Teiid
> Issue Type: Enhancement
> Components: Server
> Affects Versions: 8.4.1
> Reporter: Van Halbert
> Assignee: Steven Hawkins
> Priority: Minor
> Fix For: 8.4.1, 8.5
>
>
> Created a sample VDB in designer, for which the model is to use the loopback connector. Did not specify a JNDI reference, because it doesn't need one. However, the VDB can't be deployed from Designer because there's no connection info for this model. So I hand deployed, but the server doesn't like it that there's no JNDI specified (if I add the JNDI reference, it deploys fine). You get this error:
> 08:10:17,265 ERROR [org.jboss.msc.service.fail] (MSC service thread 1-8) MSC000001: Failed to start service jboss.deployment.unit."Sample.vdb".INSTALL: org.jboss.msc.service.StartException in service jboss.deployment.unit."Sample.vdb".INSTALL: JBAS018733: Failed to process phase INSTALL of deployment "Sample.vdb"
> at org.jboss.as.server.deployment.DeploymentUnitPhaseService.start(DeploymentUnitPhaseService.java:127) [jboss-as-server-7.2.0.Final-redhat-8.jar:7.2.0.Final-redhat-8]
> at org.jboss.msc.service.ServiceControllerImpl$StartTask.startService(ServiceControllerImpl.java:1811) [jboss-msc-1.0.4.GA-redhat-1.jar:1.0.4.GA-redhat-1]
> at org.jboss.msc.service.ServiceControllerImpl$StartTask.run(ServiceControllerImpl.java:1746) [jboss-msc-1.0.4.GA-redhat-1.jar:1.0.4.GA-redhat-1]
> at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145) [rt.jar:1.7.0_13]
> at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615) [rt.jar:1.7.0_13]
> at java.lang.Thread.run(Thread.java:722) [rt.jar:1.7.0_13]
> Caused by: java.lang.IllegalArgumentException: Empty name segment is not allowed for java
> at org.jboss.msc.service.ServiceName.of(ServiceName.java:85) [jboss-msc-1.0.4.GA-redhat-1.jar:1.0.4.GA-redhat-1]
> at org.jboss.msc.service.ServiceName.append(ServiceName.java:112) [jboss-msc-1.0.4.GA-redhat-1.jar:1.0.4.GA-redhat-1]
> at org.jboss.as.naming.deployment.ContextNames.buildServiceName(ContextNames.java:183)
> at org.jboss.as.naming.deployment.ContextNames$BindInfo.<init>(ContextNames.java:195)
> at org.jboss.as.naming.deployment.ContextNames$BindInfo.<init>(ContextNames.java:186)
> at org.jboss.as.naming.deployment.ContextNames.bindInfoFor(ContextNames.java:300)
> at org.teiid.jboss.VDBDeployer.addDataSourceListener(VDBDeployer.java:245)
> at org.teiid.jboss.VDBDeployer.dataSourceDependencies(VDBDeployer.java:267)
> at org.teiid.jboss.VDBDeployer.deploy(VDBDeployer.java:153)
> at org.jboss.as.server.deployment.DeploymentUnitPhaseService.start(DeploymentUnitPhaseService.java:120) [jboss-as-server-7.2.0.Final-redhat-8.jar:7.2.0.Final-redhat-8]
> ... 5 more
> Can Teiid preempt this and produce a clearer message that its because there's no JNDI specified?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
10 years, 11 months
[JBoss JIRA] (TEIID-2602) Add clearer message that a VDB cannot be deployed without a JNDI name specified in the .vdb
by Steven Hawkins (JIRA)
[ https://issues.jboss.org/browse/TEIID-2602?page=com.atlassian.jira.plugin... ]
Steven Hawkins commented on TEIID-2602:
---------------------------------------
Since it is an attribute nillable is implicit. I wouldn't bother going at this in the xsd as there are other invalid jndi strings from looking at the context/bindinfo logic. I'll just add an appropriate catch/warning and treat this as effectively the same as supplying a jndi name to a missing resource.
> Add clearer message that a VDB cannot be deployed without a JNDI name specified in the .vdb
> -------------------------------------------------------------------------------------------
>
> Key: TEIID-2602
> URL: https://issues.jboss.org/browse/TEIID-2602
> Project: Teiid
> Issue Type: Enhancement
> Components: Server
> Affects Versions: 8.4.1
> Reporter: Van Halbert
> Assignee: Steven Hawkins
> Priority: Minor
>
> Created a sample VDB in designer, for which the model is to use the loopback connector. Did not specify a JNDI reference, because it doesn't need one. However, the VDB can't be deployed from Designer because there's no connection info for this model. So I hand deployed, but the server doesn't like it that there's no JNDI specified (if I add the JNDI reference, it deploys fine). You get this error:
> 08:10:17,265 ERROR [org.jboss.msc.service.fail] (MSC service thread 1-8) MSC000001: Failed to start service jboss.deployment.unit."Sample.vdb".INSTALL: org.jboss.msc.service.StartException in service jboss.deployment.unit."Sample.vdb".INSTALL: JBAS018733: Failed to process phase INSTALL of deployment "Sample.vdb"
> at org.jboss.as.server.deployment.DeploymentUnitPhaseService.start(DeploymentUnitPhaseService.java:127) [jboss-as-server-7.2.0.Final-redhat-8.jar:7.2.0.Final-redhat-8]
> at org.jboss.msc.service.ServiceControllerImpl$StartTask.startService(ServiceControllerImpl.java:1811) [jboss-msc-1.0.4.GA-redhat-1.jar:1.0.4.GA-redhat-1]
> at org.jboss.msc.service.ServiceControllerImpl$StartTask.run(ServiceControllerImpl.java:1746) [jboss-msc-1.0.4.GA-redhat-1.jar:1.0.4.GA-redhat-1]
> at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145) [rt.jar:1.7.0_13]
> at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615) [rt.jar:1.7.0_13]
> at java.lang.Thread.run(Thread.java:722) [rt.jar:1.7.0_13]
> Caused by: java.lang.IllegalArgumentException: Empty name segment is not allowed for java
> at org.jboss.msc.service.ServiceName.of(ServiceName.java:85) [jboss-msc-1.0.4.GA-redhat-1.jar:1.0.4.GA-redhat-1]
> at org.jboss.msc.service.ServiceName.append(ServiceName.java:112) [jboss-msc-1.0.4.GA-redhat-1.jar:1.0.4.GA-redhat-1]
> at org.jboss.as.naming.deployment.ContextNames.buildServiceName(ContextNames.java:183)
> at org.jboss.as.naming.deployment.ContextNames$BindInfo.<init>(ContextNames.java:195)
> at org.jboss.as.naming.deployment.ContextNames$BindInfo.<init>(ContextNames.java:186)
> at org.jboss.as.naming.deployment.ContextNames.bindInfoFor(ContextNames.java:300)
> at org.teiid.jboss.VDBDeployer.addDataSourceListener(VDBDeployer.java:245)
> at org.teiid.jboss.VDBDeployer.dataSourceDependencies(VDBDeployer.java:267)
> at org.teiid.jboss.VDBDeployer.deploy(VDBDeployer.java:153)
> at org.jboss.as.server.deployment.DeploymentUnitPhaseService.start(DeploymentUnitPhaseService.java:120) [jboss-as-server-7.2.0.Final-redhat-8.jar:7.2.0.Final-redhat-8]
> ... 5 more
> Can Teiid preempt this and produce a clearer message that its because there's no JNDI specified?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
10 years, 11 months
[JBoss JIRA] (TEIID-2602) Add clearer message that a VDB cannot be deployed without a JNDI name specified in the .vdb
by Ramesh Reddy (JIRA)
[ https://issues.jboss.org/browse/TEIID-2602?page=com.atlassian.jira.plugin... ]
Ramesh Reddy commented on TEIID-2602:
-------------------------------------
All I am saying is even after we fix in Teiid, somehow Designer let the empty string in that field, that should not happen from tooling perspective either.
In the XSD we can define as nillable, but I do not know if there is way to say no empty strings, may be we can set length > 0?
> Add clearer message that a VDB cannot be deployed without a JNDI name specified in the .vdb
> -------------------------------------------------------------------------------------------
>
> Key: TEIID-2602
> URL: https://issues.jboss.org/browse/TEIID-2602
> Project: Teiid
> Issue Type: Enhancement
> Components: Server
> Affects Versions: 8.4.1
> Reporter: Van Halbert
> Assignee: Steven Hawkins
> Priority: Minor
>
> Created a sample VDB in designer, for which the model is to use the loopback connector. Did not specify a JNDI reference, because it doesn't need one. However, the VDB can't be deployed from Designer because there's no connection info for this model. So I hand deployed, but the server doesn't like it that there's no JNDI specified (if I add the JNDI reference, it deploys fine). You get this error:
> 08:10:17,265 ERROR [org.jboss.msc.service.fail] (MSC service thread 1-8) MSC000001: Failed to start service jboss.deployment.unit."Sample.vdb".INSTALL: org.jboss.msc.service.StartException in service jboss.deployment.unit."Sample.vdb".INSTALL: JBAS018733: Failed to process phase INSTALL of deployment "Sample.vdb"
> at org.jboss.as.server.deployment.DeploymentUnitPhaseService.start(DeploymentUnitPhaseService.java:127) [jboss-as-server-7.2.0.Final-redhat-8.jar:7.2.0.Final-redhat-8]
> at org.jboss.msc.service.ServiceControllerImpl$StartTask.startService(ServiceControllerImpl.java:1811) [jboss-msc-1.0.4.GA-redhat-1.jar:1.0.4.GA-redhat-1]
> at org.jboss.msc.service.ServiceControllerImpl$StartTask.run(ServiceControllerImpl.java:1746) [jboss-msc-1.0.4.GA-redhat-1.jar:1.0.4.GA-redhat-1]
> at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145) [rt.jar:1.7.0_13]
> at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615) [rt.jar:1.7.0_13]
> at java.lang.Thread.run(Thread.java:722) [rt.jar:1.7.0_13]
> Caused by: java.lang.IllegalArgumentException: Empty name segment is not allowed for java
> at org.jboss.msc.service.ServiceName.of(ServiceName.java:85) [jboss-msc-1.0.4.GA-redhat-1.jar:1.0.4.GA-redhat-1]
> at org.jboss.msc.service.ServiceName.append(ServiceName.java:112) [jboss-msc-1.0.4.GA-redhat-1.jar:1.0.4.GA-redhat-1]
> at org.jboss.as.naming.deployment.ContextNames.buildServiceName(ContextNames.java:183)
> at org.jboss.as.naming.deployment.ContextNames$BindInfo.<init>(ContextNames.java:195)
> at org.jboss.as.naming.deployment.ContextNames$BindInfo.<init>(ContextNames.java:186)
> at org.jboss.as.naming.deployment.ContextNames.bindInfoFor(ContextNames.java:300)
> at org.teiid.jboss.VDBDeployer.addDataSourceListener(VDBDeployer.java:245)
> at org.teiid.jboss.VDBDeployer.dataSourceDependencies(VDBDeployer.java:267)
> at org.teiid.jboss.VDBDeployer.deploy(VDBDeployer.java:153)
> at org.jboss.as.server.deployment.DeploymentUnitPhaseService.start(DeploymentUnitPhaseService.java:120) [jboss-as-server-7.2.0.Final-redhat-8.jar:7.2.0.Final-redhat-8]
> ... 5 more
> Can Teiid preempt this and produce a clearer message that its because there's no JNDI specified?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
10 years, 11 months