December 2018 - teiid-issues - Jboss List Archives

[JBoss JIRA] (TEIID-5577) Create clean dependencies / separate boms

by Van Halbert (Jira)

[ https://issues.jboss.org/browse/TEIID-5577?page=com.atlassian.jira.plugin... ] Van Halbert updated TEIID-5577: ------------------------------- Git Pull Request: https://github.com/teiid/teiid/pull/1111 > Create clean dependencies / separate boms > ----------------------------------------- > > Key: TEIID-5577 > URL: https://issues.jboss.org/browse/TEIID-5577 > Project: Teiid > Issue Type: Sub-task > Components: Build/Kits > Reporter: Steven Hawkins > Assignee: Van Halbert > Priority: Major > > The teiid-bom currently defines all of the non-overlapping dependencies with the wildfly bom. > We should introduce another bom that defines the overlapping dependencies used by the core project - this includes things like vfs, jboss-logging, the javax api jars, marshalling, infinispan, etc. We should also substitute usage of the jboss javax jars for whatever the vanilla replacements are. > We should then be able to cut ties with wildfly boms in the core project. > For connector development convenience we could also introduce a bom-wildfly which imports both the teiid-bom and the wildfly-parent. -- This message was sent by Atlassian Jira (v7.12.1#712002)

5 years, 4 months

1
0
0 / 0

[JBoss JIRA] (TEIID-5574) Clarify buffer manager property names

by Steven Hawkins (Jira)

[ https://issues.jboss.org/browse/TEIID-5574?page=com.atlassian.jira.plugin... ] Steven Hawkins commented on TEIID-5574: --------------------------------------- Or perhaps skip the cli entirely and let system / env properties supersede? > Clarify buffer manager property names > ------------------------------------- > > Key: TEIID-5574 > URL: https://issues.jboss.org/browse/TEIID-5574 > Project: Teiid > Issue Type: Quality Risk > Components: Query Engine, Server > Reporter: Steven Hawkins > Assignee: Steven Hawkins > Priority: Major > Fix For: 12.0 > > > Where possible the buffer manager properties should be better differentiated. Instead of max-buffer-space for example, we could have max-buffer-disk-space-mb. -- This message was sent by Atlassian Jira (v7.12.1#712002)

5 years, 4 months

1
0
0 / 0

[JBoss JIRA] (TEIID-5574) Clarify buffer manager property names

by Steven Hawkins (Jira)

[ https://issues.jboss.org/browse/TEIID-5574?page=com.atlassian.jira.plugin... ] Steven Hawkins commented on TEIID-5574: --------------------------------------- To expand on the last comment. old: {code} BUFFER_SERVICE_ELEMENT("buffer-service"), USE_DISK_ATTRIBUTE("use-disk", "buffer-service-use-disk"), PROCESSOR_BATCH_SIZE_ATTRIBUTE("processor-batch-size", "buffer-service-processor-batch-size"), MAX_PROCESSING_KB_ATTRIBUTE("max-processing-kb", "buffer-service-max-processing-kb"), MAX_RESERVED_KB_ATTRIBUTE("max-reserve-kb", "buffer-service-max-reserve-kb"), MAX_FILE_SIZE_ATTRIBUTE("max-file-size", "buffer-service-max-file-size"), MAX_BUFFER_SPACE_ATTRIBUTE("max-buffer-space", "buffer-service-max-buffer-space"), MAX_OPEN_FILES_ATTRIBUTE("max-open-files", "buffer-service-max-open-files"), MEMORY_BUFFER_SPACE_ATTRIBUTE("memory-buffer-space", "buffer-service-memory-buffer-space"), MEMORY_BUFFER_OFFHEAP_ATTRIBUTE("memory-buffer-off-heap", "buffer-service-memory-buffer-off-heap"), MAX_STORAGE_OBJECT_SIZE_ATTRIBUTE("max-storage-object-size", "buffer-service-max-storage-object-size"), INLINE_LOBS("inline-lobs", "buffer-service-inline-lobs"), ENCRYPT_FILES_ATTRIBUTE("encrypt-files", "buffer-service-encrypt-files"), {code} New: {code} BUFFER_SERVICE_ELEMENT("buffer-manager"), PROCESSOR_BATCH_SIZE_ATTRIBUTE("processor-batch-size", "buffer-manager-processor-batch-size"), INLINE_LOBS("inline-lobs", "buffer-manager-inline-lobs"), MAX_PROCESSING_KB_ATTRIBUTE("heap-max-processing-kb", "buffer-manager-heap-max-processing-kb"), MAX_RESERVED_KB_ATTRIBUTE("heap-max-reserve-kb", "buffer-manager-heap-max-reserve-kb"), USE_DISK_ATTRIBUTE("storage-enabled", "buffer-manager-storage-enabled"), MAX_STORAGE_OBJECT_SIZE_ATTRIBUTE("storage-max-object-size", "buffer-manager-storage-max-object-size"), MEMORY_BUFFER_SPACE_ATTRIBUTE("fixed-memory-space-mb", "buffer-manager-fixed-memory-space-mb"), MEMORY_BUFFER_OFFHEAP_ATTRIBUTE("fixed-memory-off-heap", "buffer-manager-fixed-memory-off-heap"), MAX_FILE_SIZE_ATTRIBUTE("disk-max-file-size", "buffer-manager-disk-max-file-size"), MAX_BUFFER_SPACE_ATTRIBUTE("disk-max-space-mb", "buffer-manager-disk-max-space-mb"), MAX_OPEN_FILES_ATTRIBUTE("disk-max-open-files", "buffer-manager-disk-max-open-files"), ENCRYPT_FILES_ATTRIBUTE("disk-encrypt-files", "buffer-manager-disk-encrypt-files"), {code} There's probably a fancy way to do this with versioned configurations, but it seems just as easy to just add handling for both and deprecate the old. There would be a corresponding change to EmbeddedConfiguration, and clarifications to the EngineStatisticsBean. > Clarify buffer manager property names > ------------------------------------- > > Key: TEIID-5574 > URL: https://issues.jboss.org/browse/TEIID-5574 > Project: Teiid > Issue Type: Quality Risk > Components: Query Engine, Server > Reporter: Steven Hawkins > Assignee: Steven Hawkins > Priority: Major > Fix For: 12.0 > > > Where possible the buffer manager properties should be better differentiated. Instead of max-buffer-space for example, we could have max-buffer-disk-space-mb. -- This message was sent by Atlassian Jira (v7.12.1#712002)

5 years, 4 months

1
0
0 / 0

[JBoss JIRA] (TEIID-5574) Clarify buffer manager property names

by Steven Hawkins (Jira)

[ https://issues.jboss.org/browse/TEIID-5574?page=com.atlassian.jira.plugin... ] Steven Hawkins commented on TEIID-5574: --------------------------------------- > No not really, as you say they are behind the EmbeddedConfiguration, does not really matter. Can you clarify that you currently map the spring config to the EmbeddedConfiguration so that is where we need the method names to line up with the expected convention? I'm assuming that below. > If all the properties are related to buffer manager exclusively then the below makes sense to me The user level proposal would be to have the EmbeddedConfiguration methods via the spring convention and the cli properties match - so that anything that any message that currently references a cli property can be generic to both? Cli properties are currently prefixed as buffer-service, but moving forward can all be buffer-manager along with any clarification, units, and reordering such that they are more logically grouped. > Clarify buffer manager property names > ------------------------------------- > > Key: TEIID-5574 > URL: https://issues.jboss.org/browse/TEIID-5574 > Project: Teiid > Issue Type: Quality Risk > Components: Query Engine, Server > Reporter: Steven Hawkins > Assignee: Steven Hawkins > Priority: Major > Fix For: 12.0 > > > Where possible the buffer manager properties should be better differentiated. Instead of max-buffer-space for example, we could have max-buffer-disk-space-mb. -- This message was sent by Atlassian Jira (v7.12.1#712002)

5 years, 4 months

1
0
0 / 0

[JBoss JIRA] (TEIID-5574) Clarify buffer manager property names

by Ramesh Reddy (Jira)

[ https://issues.jboss.org/browse/TEIID-5574?page=com.atlassian.jira.plugin... ] Ramesh Reddy edited comment on TEIID-5574 at 12/18/18 5:06 PM: --------------------------------------------------------------- >How are you proposing this will map to spring? No not really, as you say they are behind the EmbeddedConfiguration, does not really matter. >Perhaps the question is how will work from a user perspective. Yes, this is the angle I have been thinking. If all the properties are related to buffer manager exclusively then the below makes sense to me {code} bufferManagerHeapMemory[???] bufferManagerFixedMemory[???] bufferManagerDisk[???] {code} was (Author: rareddy): >How are you proposing this will map to spring? No not really, as you say they are behind the EmbeddedConfiguration, does not really matter. >Perhaps the question is how will work from a user perspective. Yes, this is the angle I have been thinking. If all the properties are related to buffer manager exclusively then the below makes sense to me bufferManagerHeapMemory{...} bufferManagerFixedMemory{...} bufferManagerDisk{...} > Clarify buffer manager property names > ------------------------------------- > > Key: TEIID-5574 > URL: https://issues.jboss.org/browse/TEIID-5574 > Project: Teiid > Issue Type: Quality Risk > Components: Query Engine, Server > Reporter: Steven Hawkins > Assignee: Steven Hawkins > Priority: Major > Fix For: 12.0 > > > Where possible the buffer manager properties should be better differentiated. Instead of max-buffer-space for example, we could have max-buffer-disk-space-mb. -- This message was sent by Atlassian Jira (v7.12.1#712002)

5 years, 4 months

1
0
0 / 0

[JBoss JIRA] (TEIID-5574) Clarify buffer manager property names

by Ramesh Reddy (Jira)

[ https://issues.jboss.org/browse/TEIID-5574?page=com.atlassian.jira.plugin... ] Ramesh Reddy commented on TEIID-5574: ------------------------------------- >How are you proposing this will map to spring? No not really, as you say they are behind the EmbeddedConfiguration, does not really matter. >Perhaps the question is how will work from a user perspective. Yes, this is the angle I have been thinking. If all the properties are related to buffer manager exclusively then the below makes sense to me bufferManagerHeapMemory{...} bufferManagerFixedMemory{...} bufferManagerDisk{...} > Clarify buffer manager property names > ------------------------------------- > > Key: TEIID-5574 > URL: https://issues.jboss.org/browse/TEIID-5574 > Project: Teiid > Issue Type: Quality Risk > Components: Query Engine, Server > Reporter: Steven Hawkins > Assignee: Steven Hawkins > Priority: Major > Fix For: 12.0 > > > Where possible the buffer manager properties should be better differentiated. Instead of max-buffer-space for example, we could have max-buffer-disk-space-mb. -- This message was sent by Atlassian Jira (v7.12.1#712002)

5 years, 4 months

1
0
0 / 0

[JBoss JIRA] (TEIID-5574) Clarify buffer manager property names

by Steven Hawkins (Jira)

[ https://issues.jboss.org/browse/TEIID-5574?page=com.atlassian.jira.plugin... ] Steven Hawkins commented on TEIID-5574: --------------------------------------- > maxReservedKb -> maxReservedHeapKb -> heapMemoryMaxReservedInKb (making the "heapMemory" word as prefix consistent across) That would be something like: heapBufferMaxReservedKb heapBufferReservedByActivePlansKb heapBufferInUseKb Part of the reason for the subtle difference is that max reserve is not a hard limit for what is actually in use (see above). > heapCacheMemoryInUseKB -> heapBufferInUseKb -> heapMemoryInUseKb (may be drop "buffer" every where?) The danger in that is that buffer differentiates these properties to buffer manager. diskMaxSpaceMb for example could apply to temp space as well. > This way it is easy and also works well in spring-boot with style "heap-memory-max-reserved-in-kb" format. Of course most of the other properties would need changed as well then. Perhaps the question is how will work from a user perspective. I was specifically starting with the bufferserivceimpl and renaming properties that were not sufficiently descriptive. How are you proposing this will map to spring? Are you reusing the EmbeddedConfiguration or are you expecting to directly set properties on the BufferServiceImpl bean. And do you expect any consistency with cli? In the cli we have existing properties like buffer-service-max-reserve-kb, which with this change that would become buffer-service-max-reserved-heap-mb or buffer-service-heap-max-reserved-mb if we redo the property keys to be more consistent with prefixing. > Clarify buffer manager property names > ------------------------------------- > > Key: TEIID-5574 > URL: https://issues.jboss.org/browse/TEIID-5574 > Project: Teiid > Issue Type: Quality Risk > Components: Query Engine, Server > Reporter: Steven Hawkins > Assignee: Steven Hawkins > Priority: Major > Fix For: 12.0 > > > Where possible the buffer manager properties should be better differentiated. Instead of max-buffer-space for example, we could have max-buffer-disk-space-mb. -- This message was sent by Atlassian Jira (v7.12.1#712002)

5 years, 4 months

1
0
0 / 0

[JBoss JIRA] (TEIID-5577) Create clean dependencies / separate boms

by Steven Hawkins (Jira)

[ https://issues.jboss.org/browse/TEIID-5577?page=com.atlassian.jira.plugin... ] Steven Hawkins commented on TEIID-5577: --------------------------------------- > IMO don't use "jboss" in Unfortunately we already set that precedent in other artifact names. > use the project name. If this is "wildfly" use "org.teiid:teiid-wildfly-bom". It's not quite wildfly - it's for the overlap of the dependencies that we and wildfly use, so its things across the jboss portfolio like netty, vfs, jboss-logging, infinispan, marshalling, staxmapper, etc.. Such that we can have a bom for the Teiid core maven modules that is free of the wild-parent and wildfly-core-parent poms. > Create clean dependencies / separate boms > ----------------------------------------- > > Key: TEIID-5577 > URL: https://issues.jboss.org/browse/TEIID-5577 > Project: Teiid > Issue Type: Sub-task > Components: Build/Kits > Reporter: Steven Hawkins > Assignee: Van Halbert > Priority: Major > > The teiid-bom currently defines all of the non-overlapping dependencies with the wildfly bom. > We should introduce another bom that defines the overlapping dependencies used by the core project - this includes things like vfs, jboss-logging, the javax api jars, marshalling, infinispan, etc. We should also substitute usage of the jboss javax jars for whatever the vanilla replacements are. > We should then be able to cut ties with wildfly boms in the core project. > For connector development convenience we could also introduce a bom-wildfly which imports both the teiid-bom and the wildfly-parent. -- This message was sent by Atlassian Jira (v7.12.1#712002)

5 years, 4 months

1
0
0 / 0

[JBoss JIRA] (TEIID-5577) Create clean dependencies / separate boms

by Ramesh Reddy (Jira)

[ https://issues.jboss.org/browse/TEIID-5577?page=com.atlassian.jira.plugin... ] Ramesh Reddy commented on TEIID-5577: ------------------------------------- [~van.halbert] , [~shawkins] IMO don't use "jboss" in org.teiid:teiid-jboss-bom use the project name. If this is "wildfly" use "org.teiid:teiid-wildfly-bom". > Create clean dependencies / separate boms > ----------------------------------------- > > Key: TEIID-5577 > URL: https://issues.jboss.org/browse/TEIID-5577 > Project: Teiid > Issue Type: Sub-task > Components: Build/Kits > Reporter: Steven Hawkins > Assignee: Van Halbert > Priority: Major > > The teiid-bom currently defines all of the non-overlapping dependencies with the wildfly bom. > We should introduce another bom that defines the overlapping dependencies used by the core project - this includes things like vfs, jboss-logging, the javax api jars, marshalling, infinispan, etc. We should also substitute usage of the jboss javax jars for whatever the vanilla replacements are. > We should then be able to cut ties with wildfly boms in the core project. > For connector development convenience we could also introduce a bom-wildfly which imports both the teiid-bom and the wildfly-parent. -- This message was sent by Atlassian Jira (v7.12.1#712002)

5 years, 4 months

1
0
0 / 0

[JBoss JIRA] (TEIID-5574) Clarify buffer manager property names

by Ramesh Reddy (Jira)

[ https://issues.jboss.org/browse/TEIID-5574?page=com.atlassian.jira.plugin... ] Ramesh Reddy commented on TEIID-5574: ------------------------------------- some suggestions to consider? maxReservedKb -> maxReservedHeapKb -> heapMemoryMaxReservedInKb (making the "heapMemory" word as prefix consistent across) heapCacheMemoryInUseKB -> heapBufferInUseKb -> heapMemoryInUseKb (may be drop "buffer" every where?) memoryBufferOffHeap -> fixedMemoryOffHeapIn?? memoryBufferSpace -> fixedMemorySpaceMb maxBufferSpace -> diskMaxSpaceMb This way it is easy and also works well in spring-boot with style "heap-memory-max-reserved-in-kb" format. > Clarify buffer manager property names > ------------------------------------- > > Key: TEIID-5574 > URL: https://issues.jboss.org/browse/TEIID-5574 > Project: Teiid > Issue Type: Quality Risk > Components: Query Engine, Server > Reporter: Steven Hawkins > Assignee: Steven Hawkins > Priority: Major > Fix For: 12.0 > > > Where possible the buffer manager properties should be better differentiated. Instead of max-buffer-space for example, we could have max-buffer-disk-space-mb. -- This message was sent by Atlassian Jira (v7.12.1#712002)

5 years, 4 months

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

teiid-issues December 2018