[JBoss JIRA] (TEIID-5577) Create clean dependencies / separate boms
by Steven Hawkins (Jira)
[ https://issues.jboss.org/browse/TEIID-5577?page=com.atlassian.jira.plugin... ]
Steven Hawkins commented on TEIID-5577:
---------------------------------------
> So my goal is to this first and assuming it goes smooth, should have a PR no later than tomorrow.
Sounds great.
> What would be your preference as to the folder structure:
> 1. rename build-configuration/bom to build-configuration/teiid-bom
I'm fine either way. For a lot of the sub modules we drop the teiid- prefix from the folder name.
> 2. create a new module like integration-bom/pom.xml with the versions properties put in the root pom.xml
Is the though there that the root teiid pom.xml would also be the teiid bom?
> Create clean dependencies / separate boms
> -----------------------------------------
>
> Key: TEIID-5577
> URL: https://issues.jboss.org/browse/TEIID-5577
> Project: Teiid
> Issue Type: Sub-task
> Components: Build/Kits
> Reporter: Steven Hawkins
> Assignee: Van Halbert
> Priority: Major
>
> The teiid-bom currently defines all of the non-overlapping dependencies with the wildfly bom.
> We should introduce another bom that defines the overlapping dependencies used by the core project - this includes things like vfs, jboss-logging, the javax api jars, marshalling, infinispan, etc. We should also substitute usage of the jboss javax jars for whatever the vanilla replacements are.
> We should then be able to cut ties with wildfly boms in the core project.
> For connector development convenience we could also introduce a bom-wildfly which imports both the teiid-bom and the wildfly-parent.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
6 years, 2 months
[JBoss JIRA] (TEIID-5577) Create clean dependencies / separate boms
by Van Halbert (Jira)
[ https://issues.jboss.org/browse/TEIID-5577?page=com.atlassian.jira.plugin... ]
Van Halbert commented on TEIID-5577:
------------------------------------
I was running into these type of dependency issues when working on TEIID-5563, so it makes sense to resolve this first so that teiid-5563 will be simplified. So my goal is to this first and assuming it goes smooth, should have a PR no later than tomorrow.
> Create clean dependencies / separate boms
> -----------------------------------------
>
> Key: TEIID-5577
> URL: https://issues.jboss.org/browse/TEIID-5577
> Project: Teiid
> Issue Type: Sub-task
> Components: Build/Kits
> Reporter: Steven Hawkins
> Assignee: Van Halbert
> Priority: Major
>
> The teiid-bom currently defines all of the non-overlapping dependencies with the wildfly bom.
> We should introduce another bom that defines the overlapping dependencies used by the core project - this includes things like vfs, jboss-logging, the javax api jars, marshalling, infinispan, etc. We should also substitute usage of the jboss javax jars for whatever the vanilla replacements are.
> We should then be able to cut ties with wildfly boms in the core project.
> For connector development convenience we could also introduce a bom-wildfly which imports both the teiid-bom and the wildfly-parent.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
6 years, 2 months
[JBoss JIRA] (TEIID-5577) Create clean dependencies / separate boms
by Steven Hawkins (Jira)
[ https://issues.jboss.org/browse/TEIID-5577?page=com.atlassian.jira.plugin... ]
Steven Hawkins commented on TEIID-5577:
---------------------------------------
This could also update the connector arche-type as it not references the jboss javax dependency.
Is this something you could get to this week?
> Create clean dependencies / separate boms
> -----------------------------------------
>
> Key: TEIID-5577
> URL: https://issues.jboss.org/browse/TEIID-5577
> Project: Teiid
> Issue Type: Sub-task
> Components: Build/Kits
> Reporter: Steven Hawkins
> Assignee: Van Halbert
> Priority: Major
>
> The teiid-bom currently defines all of the non-overlapping dependencies with the wildfly bom.
> We should introduce another bom that defines the overlapping dependencies used by the core project - this includes things like vfs, jboss-logging, the javax api jars, marshalling, infinispan, etc. We should also substitute usage of the jboss javax jars for whatever the vanilla replacements are.
> We should then be able to cut ties with wildfly boms in the core project.
> For connector development convenience we could also introduce a bom-wildfly which imports both the teiid-bom and the wildfly-parent.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
6 years, 2 months
[JBoss JIRA] (TEIID-5577) Create clean dependencies / separate boms
by Van Halbert (Jira)
[ https://issues.jboss.org/browse/TEIID-5577?page=com.atlassian.jira.plugin... ]
Van Halbert commented on TEIID-5577:
------------------------------------
What would be your preference as to the folder structure:
1. rename build-configuration/bom to build-configuration/teiid-bom
add build-configuration/integration-bom (or some other name)
2. create a new module like integration-bom/pom.xml with the versions properties put in the root pom.xml
3. other preference
> Create clean dependencies / separate boms
> -----------------------------------------
>
> Key: TEIID-5577
> URL: https://issues.jboss.org/browse/TEIID-5577
> Project: Teiid
> Issue Type: Sub-task
> Components: Build/Kits
> Reporter: Steven Hawkins
> Assignee: Van Halbert
> Priority: Major
>
> The teiid-bom currently defines all of the non-overlapping dependencies with the wildfly bom.
> We should introduce another bom that defines the overlapping dependencies used by the core project - this includes things like vfs, jboss-logging, the javax api jars, marshalling, infinispan, etc. We should also substitute usage of the jboss javax jars for whatever the vanilla replacements are.
> We should then be able to cut ties with wildfly boms in the core project.
> For connector development convenience we could also introduce a bom-wildfly which imports both the teiid-bom and the wildfly-parent.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
6 years, 2 months
[JBoss JIRA] (TEIID-5577) Create clean dependencies / separate boms
by Van Halbert (Jira)
[ https://issues.jboss.org/browse/TEIID-5577?page=com.atlassian.jira.plugin... ]
Van Halbert commented on TEIID-5577:
------------------------------------
I'll do this before splitting out the wildfly related modules.
> Create clean dependencies / separate boms
> -----------------------------------------
>
> Key: TEIID-5577
> URL: https://issues.jboss.org/browse/TEIID-5577
> Project: Teiid
> Issue Type: Sub-task
> Components: Build/Kits
> Reporter: Steven Hawkins
> Assignee: Van Halbert
> Priority: Major
>
> The teiid-bom currently defines all of the non-overlapping dependencies with the wildfly bom.
> We should introduce another bom that defines the overlapping dependencies used by the core project - this includes things like vfs, jboss-logging, the javax api jars, marshalling, infinispan, etc. We should also substitute usage of the jboss javax jars for whatever the vanilla replacements are.
> We should then be able to cut ties with wildfly boms in the core project.
> For connector development convenience we could also introduce a bom-wildfly which imports both the teiid-bom and the wildfly-parent.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
6 years, 2 months
[JBoss JIRA] (TEIID-5577) Create clean dependencies / separate boms
by Van Halbert (Jira)
[ https://issues.jboss.org/browse/TEIID-5577?page=com.atlassian.jira.plugin... ]
Work on TEIID-5577 started by Van Halbert.
------------------------------------------
> Create clean dependencies / separate boms
> -----------------------------------------
>
> Key: TEIID-5577
> URL: https://issues.jboss.org/browse/TEIID-5577
> Project: Teiid
> Issue Type: Sub-task
> Components: Build/Kits
> Reporter: Steven Hawkins
> Assignee: Van Halbert
> Priority: Major
>
> The teiid-bom currently defines all of the non-overlapping dependencies with the wildfly bom.
> We should introduce another bom that defines the overlapping dependencies used by the core project - this includes things like vfs, jboss-logging, the javax api jars, marshalling, infinispan, etc. We should also substitute usage of the jboss javax jars for whatever the vanilla replacements are.
> We should then be able to cut ties with wildfly boms in the core project.
> For connector development convenience we could also introduce a bom-wildfly which imports both the teiid-bom and the wildfly-parent.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
6 years, 2 months
[JBoss JIRA] (TEIID-5578) Issues if xa txn import fails
by Steven Hawkins (Jira)
[ https://issues.jboss.org/browse/TEIID-5578?page=com.atlassian.jira.plugin... ]
Steven Hawkins resolved TEIID-5578.
-----------------------------------
Resolution: Done
Changed the import to not set the type until after importing. Changed the client to rethrow the server exception.
> Issues if xa txn import fails
> -----------------------------
>
> Key: TEIID-5578
> URL: https://issues.jboss.org/browse/TEIID-5578
> Project: Teiid
> Issue Type: Bug
> Components: JDBC Driver, Server
> Reporter: Steven Hawkins
> Assignee: Steven Hawkins
> Priority: Major
> Fix For: 12.0, 11.2.2
>
>
> There are two issues if the import fails. The first is that the transaction type is already set on the context which will cause an npe later when the session is killed - as no txn will be set on the context as expected. The other issue is that the client does not rethrow the exception.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
6 years, 2 months